Re: [PATCH 1/3] stkagent: Add ConfirmCallSetup request.

Hi Andrew, On 08/25/2010 10:49 AM, Andrzej Zaborowski wrote: > --- > src/stkagent.c | 65 > > src/stkagent.h |5 > 2 files changed, 70 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis _

RE: [PATCH v2] Add CDMA extension tasks

Hi Jeevaka, I'd like remind you that please use plaint text and follow the mail rule of ofono. (I have ever make the same mistake several days ago :) ). > From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On > Behalf Of Jeevaka Prabu Badrappan > Sent: Wednesday, August 25, 2010 5:46

[PATCH 3/3] stk: Handle the Set Up Call proactive command.

--- src/stk.c | 198 + 1 files changed, 198 insertions(+), 0 deletions(-) diff --git a/src/stk.c b/src/stk.c index f391396..f0ca9b7 100644 --- a/src/stk.c +++ b/src/stk.c @@ -1399,6 +1399,198 @@ static gboolean handle_command_get_input(

[PATCH 1/3] stkagent: Add ConfirmCallSetup request.

--- src/stkagent.c | 65 src/stkagent.h |5 2 files changed, 70 insertions(+), 0 deletions(-) diff --git a/src/stkagent.c b/src/stkagent.c index e71436d..f62c2bd 100644 --- a/src/stkagent.c +++ b/src/stkagent.c @@ -789,3 +789,68

[PATCH 2/3][RfC] Add __ofono_voicecall_dial for other atoms to make calls.

The callback is only invoked when the call is CONNECTED (becomes active). Cancel ensures that the callback will not be called and does nothing more in this version, it's an open question if we want to release the call. --- src/ofono.h | 19 - src/voicecall.c | 247 +

RE: [PATCH v2] Add CDMA extension tasks

From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Jeevaka Prabu Badrappan Sent: Wednesday, August 25, 2010 5:46 PM To: ofono@ofono.org, Subject: Re: [PATCH v2] Add CDMA extension tasks Hi Caiwen, ---  TODO |   76 +++

Re: [PATCH 1/4] sim: read EFimg

Hi Kristen, On 08/25/2010 11:29 AM, Kristen Carlson Accardi wrote: > --- > src/sim.c | 49 + > 1 files changed, 49 insertions(+), 0 deletions(-) > > diff --git a/src/sim.c b/src/sim.c > index 04a708b..dc47901 100644 > --- a/src/sim.c > +++ b/src/

[PATCH 1/4] sim: read EFimg

--- src/sim.c | 49 + 1 files changed, 49 insertions(+), 0 deletions(-) diff --git a/src/sim.c b/src/sim.c index 04a708b..dc47901 100644 --- a/src/sim.c +++ b/src/sim.c @@ -88,6 +88,8 @@ struct ofono_sim { unsigned char efmsisdn_records;

Re: [PATCH 4/6] sim: read EFiidf

Hi Kristen, >> My initial feeling is that we should treat blocks just like we treat >> records today. We should not write them to separate files. >> >> Can we unify the two approaches somehow? Perhaps by storing a bitmap in >> the cache header, and update the bitmap every time we write the record

Re: [PATCH 4/6] sim: read EFiidf

On Wed, 25 Aug 2010 16:17:13 -0500 Denis Kenzior wrote: > From: Denis Kenzior > To: ofono@ofono.org > CC: Kristen Carlson Accardi , Andrzej Zaborowski > > Subject: Re: [PATCH 4/6] sim: read EFiidf > Date: Wed, 25 Aug 2010 16:17:13 -0500 > User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;

Re: [PATCH 4/6] sim: read EFiidf

Hi Kristen, On 08/25/2010 06:00 AM, Kristen Carlson Accardi wrote: > EFiidf can be larger than 256 bytes, so allow callers to read > portions of the EFiidf from a specified offset. Cache EFiidf > files as blocks of 256 bytes so that it's not necessary to > read the entire (potentially large) file

Re: New to OFONO

Hi Keith, On 08/25/2010 03:47 PM, Keith Collins wrote: > Hi, > > > > I am new to OFONO, but I have 11 years of experience in smartphone > telephony development. I have worked on both UMTS and CDMA product > designs for different mobile operators, handset manufacturers, chipset > vendors and o

Re: New to OFONO

Hi Keith, > I am new to OFONO, but I have 11 years of experience in smartphone > telephony development. I have worked on both UMTS and CDMA product > designs for different mobile operators, handset manufacturers, chipset > vendors and o/s vendors. I know the challenges of designing a > telephony

New to OFONO

Hi, I am new to OFONO, but I have 11 years of experience in smartphone telephony development. I have worked on both UMTS and CDMA product designs for different mobile operators, handset manufacturers, chipset vendors and o/s vendors. I know the challenges of designing a telephony subsystem th

Re: [RFC PATCH v2 2/4] smsutil: storing/loading sms status report over reboot

Hi Denis, and thanks for the comments. I'm changing the code according to your comments. So I'll change backup-file system to more like flat-system. Earlier messages were stored in address-based subdirectories, and now, if I understood correctly, those sub-directories shouldn't exist anymore. Bu

Re: [PATCH 3/6] sim: read EFimg

Hi Kristen, > +static void sim_efimg_read_cb(int ok, int length, int record, > + const unsigned char *data, > + int record_length, void *userdata) > +{ > + struct ofono_sim *sim = userdata; > + unsigned char *efimg; > + int num_re

Re: [PATCH 2/6] stkutil: change uint32_t to guint32

Hi Kristen, On 08/25/2010 06:00 AM, Kristen Carlson Accardi wrote: > This helps avoid needing to include any extra header files if > stkutil.h is included in sim.c > --- This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@

Re: [PATCH 1/6] simutil: add fileid for EFimg

Hi Kristen, On 08/25/2010 06:00 AM, Kristen Carlson Accardi wrote: > --- > src/simutil.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http:/

Re: [PATCH] mbm: add quirks for Dell D5530

Hi Denis, > > Dell D5530 is an OEM version of F3507g. It has an annoying habit of > > announcing itself to world with its own name. It also crashes upon > > processing received cbs messages. > > --- > > plugins/mbm.c | 55 > >

Re: [PATCH] mbm: add quirks for Dell D5530

Hi Marcel, On 08/25/2010 01:23 PM, Marcel Holtmann wrote: > Hi Denis, > > Dell D5530 is an OEM version of F3507g. It has an annoying habit of > announcing itself to world with its own name. It also crashes upon > processing received cbs messages. > --- > plugins/mbm.c | 55

[PATCH 2/2] atmodem: call sim_ready_notify when epev is received

--- drivers/atmodem/sim.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index 21bc933..44ecc1a 100644 --- a/drivers/atmodem/sim.c +++ b/drivers/atmodem/sim.c @@ -537,13 +537,16 @@ static gboolean at_epev_unregister

[PATCH 1/2] sim: add ofono_sim_ready_notify() support

--- include/sim.h |2 ++ src/sim.c | 25 +++-- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/include/sim.h b/include/sim.h index 36a99b9..9b7d52e 100644 --- a/include/sim.h +++ b/include/sim.h @@ -187,6 +187,8 @@ enum ofono_sim_state ofono_sim_get_st

[PATCH 0/2] ofono_sim_ready_notify

When entering a PIN, wait for the driver to notify us that the sim is ready before querying the password again and proceeding with the rest of sim initialization Kristen Carlson Accardi (2): sim: add ofono_sim_ready_notify() support atmodem: call sim_ready_notify when epev is received driver

Re: [PATCH] mbm: add quirks for Dell D5530

Hi Denis, > >>> Dell D5530 is an OEM version of F3507g. It has an annoying habit of > >>> announcing itself to world with its own name. It also crashes upon > >>> processing received cbs messages. > >>> --- > >>> plugins/mbm.c | 55 > >>> +--

Re: [PATCH] mbm: add quirks for Dell D5530

Hi Marcel, On 08/25/2010 01:05 PM, Marcel Holtmann wrote: > Hi Denis, > >>> Dell D5530 is an OEM version of F3507g. It has an annoying habit of >>> announcing itself to world with its own name. It also crashes upon >>> processing received cbs messages. >>> --- >>> plugins/mbm.c | 55 >>> +

Re: [PATCH] mbm: add quirks for Dell D5530

Hi Denis, > > Dell D5530 is an OEM version of F3507g. It has an annoying habit of > > announcing itself to world with its own name. It also crashes upon > > processing received cbs messages. > > --- > > plugins/mbm.c | 55 > > +-- > > 1 files

Re: [PATCH 3/6] sim: read EFimg

Hi Kristen, On 08/18/2010 06:25 AM, Kristen Carlson Accardi wrote: > Read EFimg when the sim is ready, and store it in memory. > --- > src/sim.c | 47 +++ > 1 files changed, 47 insertions(+), 0 deletions(-) > > diff --git a/src/sim.c b/src/sim.c > in

[PATCH 6/6] test: add get-icon script

--- test/get-icon | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) create mode 100755 test/get-icon diff --git a/test/get-icon b/test/get-icon new file mode 100755 index 000..680ae13 --- /dev/null +++ b/test/get-icon @@ -0,0 +1,25 @@ +#!/usr/bin/python + +i

[PATCH 5/6] sim: implement GetIcon

create an interface to allow a caller to request an icon by id via dbus. Convert iidf files to xpm format and cache. --- src/sim.c | 216 + 1 files changed, 216 insertions(+), 0 deletions(-) diff --git a/src/sim.c b/src/sim.c index a95

[PATCH 4/6] sim: read EFiidf

EFiidf can be larger than 256 bytes, so allow callers to read portions of the EFiidf from a specified offset. Cache EFiidf files as blocks of 256 bytes so that it's not necessary to read the entire (potentially large) file. --- src/sim.c | 201

[PATCH 3/6] sim: read EFimg

--- src/sim.c | 49 + 1 files changed, 49 insertions(+), 0 deletions(-) diff --git a/src/sim.c b/src/sim.c index 04a708b..b273bdb 100644 --- a/src/sim.c +++ b/src/sim.c @@ -88,6 +88,8 @@ struct ofono_sim { unsigned char efmsisdn_records;

[PATCH 2/6] stkutil: change uint32_t to guint32

This helps avoid needing to include any extra header files if stkutil.h is included in sim.c --- src/stkutil.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/stkutil.h b/src/stkutil.h index ea9294c..44d167a 100644 --- a/src/stkutil.h +++ b/src/stkutil.h @@ -852,7 +85

[PATCH 1/6] simutil: add fileid for EFimg

--- src/simutil.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index 4db950b..65e651a 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -22,6 +22,7 @@ enum sim_fileid { SIM_EFPL_FILEID = 0x2f05, SIM_EF_ICCID_FILEID = 0x2fe2

[PATCH v2 0/6] icon support patches

Changes from last version: * bugfix in patch 3, read EFimg, sim_efimg_read_cb. Don't calculate num_records without first checking for ok * bugfix in patch 5, implement GetIcon, ofono_sim_get_image When calling back with error, use 0 as error code, not -1 Kristen Carlson Accardi (

Re: [PATCH] simfilesystem: correct sw2 response for binary read

Hi Kristen, On 08/18/2010 06:14 AM, Kristen Carlson Accardi wrote: > according to spec, sw2 should be the number of bytes read, which > is just length. > --- Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://

Re: [PATCH] mbm: add quirks for Dell D5530

Hi Pekka, On 08/25/2010 12:13 PM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > Dell D5530 is an OEM version of F3507g. It has an annoying habit of > announcing itself to world with its own name. Another problem is some weird > +CGAP messages at the same time. It also crashes upon process

Re: [PATCH] sim: Read EFsst

Hi Yang, > -static void sim_efust_read_cb(int ok, int length, int record, > +static void sim_efsst_read_cb(int ok, int length, int record, > const unsigned char *data, > int record_length, void *userdata) > { > @@ -1057,6 +1059,27 @@ sta

[PATCH] mbm: add quirks for Dell D5530

From: Pekka Pessi Dell D5530 is an OEM version of F3507g. It has an annoying habit of announcing itself to world with its own name. Another problem is some weird +CGAP messages at the same time. It also crashes upon processing received CBS messages. --- plugins/mbm.c | 64 +

Re: [PATCH] mbm: add quirks for Dell D5530

2010/8/25 Denis Kenzior : > Should we really bother with this one? Or you're trying to be like > Marcel and waste some processing time with unused unsolicited > notifications? :) I'm trying to develop with this fine piece of hardware. First time it was funny when my IMSI was D5530. Or +GCAP: +CGSM

Re: [PATCH 2/2] test-monitor: monitor irregular signals

Hi Pekka, On 08/25/2010 06:57 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > test/monitor-ofono | 63 > > 1 files changed, 63 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis __

Re: [PATCH 1/2] monitor-ofono: deep pretty-print

Hi Pekka, On 08/25/2010 06:57 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > test/monitor-ofono | 60 +++ > 1 files changed, 46 insertions(+), 14 deletions(-) > Patch has been applied, thanks. Regards, -Denis _

Re: [PATCH] sim: check pins even if language checks fails

Hi Pekka, On 08/25/2010 08:44 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > src/sim.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/src/sim.c b/src/sim.c > index a450b30..be2793b 100644 > --- a/src/sim.c > +++ b/src/sim.c > @@ -1373,7 +1373,7

Re: [PATCH] mbm: add quirks for Dell D5530

Hi Pekka, On 08/25/2010 11:16 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > Dell D5530 is an OEM version of F3507g. It has an annoying habit of > announcing itself to world with its own name. It also crashes upon > processing received cbs messages. > --- > plugins/mbm.c | 55 ++

[PATCH] mbm: add quirks for Dell D5530

From: Pekka Pessi Dell D5530 is an OEM version of F3507g. It has an annoying habit of announcing itself to world with its own name. It also crashes upon processing received cbs messages. --- plugins/mbm.c | 55 +-- 1 files changed, 53 inserti

Re: Implementing support for a new modem- how to?

Hi Arun, > We are working with this type of modem, and would like to submit > patches to oFono. We found that we have to make few modifications to > some of the AT command responses and also may have to introduce to > support for a few new commands. > > We found that in network registration sms

RE: [PATCH] sim: Ensure to call sim_pin_check

Hi Denis, >-Original Message- >From: Denis Kenzior [mailto:denk...@gmail.com] >Sent: Wednesday, August 25, 2010 11:07 PM >To: ofono@ofono.org >Cc: Gu, Yang >Subject: Re: [PATCH] sim: Ensure to call sim_pin_check > >Hi Yang, > >> Your solution is better than mine, and might be Denis' inten

Re: [PATCH] sim: Ensure to call sim_pin_check

Hi Yang, > Your solution is better than mine, and might be Denis' intention of > modification. Honestly, I ever thought about the change like your proposal > (Actually it was the same as ppessi's patch), but I had a concern on current > code. Now we read EFli and EFpl in parallel. Is it guarant

RE: [PATCH] sim: Ensure to call sim_pin_check

Hi jeevaka, >> static void sim_iccid_read_cb(int ok, int length, int record, @@ >-1454,6 +1452,8 @@ static void sim_initialize(struct ofono_sim *sim) >> ofono_sim_read(sim, SIM_EFPL_FILEID, >> OFONO_SIM_FILE_STRUCTURE_TRANSPARENT, >> sim_efpl_read_c

Re: [PATCH] sim: Ensure to call sim_pin_check

2010/8/25 : > I believe the right place to call the sim_pin_check() will be > before the if condition(if (sim->language_prefs == NULL)) in > sim_efpl_read_cb(), like shown below > >      if (efpl) { >                g_slist_foreach(efpl, (GFunc)g_free, NULL); >              g_slist_free(efpl); >  

[PATCH] sim: check pins even if language checks fails

From: Pekka Pessi --- src/sim.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/sim.c b/src/sim.c index a450b30..be2793b 100644 --- a/src/sim.c +++ b/src/sim.c @@ -1373,7 +1373,7 @@ skip_efpl: } if (sim->language_prefs == NULL) - ret

Re: [PATCH 1/2] sim: add sim_ready_notify

Hi Kristen, 2010/8/24 Kristen Carlson Accardi : >  static void sim_pin_check(struct ofono_sim *sim) >  { > +       if (!(sim->status & SIM_STATUS_READY)) { > +               sim->status |= SIM_STATUS_WAITING_FOR_PIN; > +               return; > +       } > + > +       if (sim->status & SIM_STATUS_

RE: [PATCH] sim: Ensure to call sim_pin_check

Hi Yang Gu, > In current code, sim_pin_check() is called inside sim_efpl_read_cb(). > However, there may be a chance it would never be called, thus the modem won't be initialized correctly. > --- > src/sim.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > diff --git a/src/sim.

[PATCH 1/2] monitor-ofono: deep pretty-print

From: Pekka Pessi --- test/monitor-ofono | 60 +++ 1 files changed, 46 insertions(+), 14 deletions(-) diff --git a/test/monitor-ofono b/test/monitor-ofono index a441d5d..94febac 100755 --- a/test/monitor-ofono +++ b/test/monitor-ofono @@ -5,22 +

[PATCH 2/2] test-monitor: monitor irregular signals

From: Pekka Pessi --- test/monitor-ofono | 63 1 files changed, 63 insertions(+), 0 deletions(-) diff --git a/test/monitor-ofono b/test/monitor-ofono index 94febac..86239eb 100755 --- a/test/monitor-ofono +++ b/test/monitor-ofono @@ -54,6 +

[PATCH] sim: Read EFsst

--- src/sim.c | 31 +++- src/simutil.c | 18 src/simutil.h | 63 + 3 files changed, 111 insertions(+), 1 deletions(-) diff --git a/src/sim.c b/src/sim.c index 9bc9906..1491edd 100644 --- a/s

Implementing support for a new modem- how to?

Hi All, We are working with this type of modem, and would like to submit patches to oFono. We found that we have to make few modifications to some of the AT command responses and also may have to introduce to support for a few new commands. We found that in network registration sms, call meter

[PATCH] sim: Ensure to call sim_pin_check

In current code, sim_pin_check() is called inside sim_efpl_read_cb(). However, there may be a chance it would never be called, thus the modem won't be initialized correctly. --- src/sim.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sim.c b/src/sim.c index a450b3

Re: [PATCH v2] Add CDMA extension tasks

Hi Caiwen, --- > TODO | 76 > ++ > 1 files changed, 76 insertions(+), 0 deletions(-) > > diff --git a/TODO b/TODO > index a97f076..b159c07 100644 > --- a/TODO > +++ b/TODO > @@ -614,3 +614,79 @@ Miscellaneous > > Priority: Low >