RE: [PATCH] TODO: Add vCard export to SM/ME stores

2010-11-15 Thread Kiviluoto, Jaakko J
To support this feature then first we need to convert the current feature into returning a dict. And then have this feature using a dict as input. Is there already a specification/draft of the format of this dict? If not, I would be tempted to use the 27.007 +CPBR/W field names as

RE: [PATCH 0/4] Emergency Calls (3rd round)

2010-11-15 Thread Predon, Frederic
Hi Andras, Here is a new proposal for emergency calls handling. Steps in handling emergency calls: - subscribe to modem online notifications (add modem online watcher) - an emergency call detected (phone number is emergency number) - increment emergency mode - advertise EmergencyMode

[PATCH 0/5] Call Counters

2010-11-15 Thread Andras Domokos
Here a proposal for call counters implementation for keeping track of the total incoming and outgoing call duration counters. Each established call instance is contributing to either of the call duration counters. The 2 counters are updated periodically when there is an established call and the

[RFC PATCH 2/5] history: expand history API

2010-11-15 Thread Andras Domokos
--- src/history.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/src/history.c b/src/history.c index 0229cf5..31efadb 100644 --- a/src/history.c +++ b/src/history.c @@ -114,6 +114,30 @@ void __ofono_history_probe_drivers(struct ofono_modem

[RFC PATCH 1/5] history: expand history API include file

2010-11-15 Thread Andras Domokos
--- include/history.h |3 +++ src/ofono.h |4 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/history.h b/include/history.h index c1c4aa1..a2490f6 100644 --- a/include/history.h +++ b/include/history.h @@ -49,6 +49,9 @@ struct ofono_history_driver {

Re: [PATCH 0/4] Emergency Calls (3rd round)

2010-11-15 Thread Andras Domokos
Hi Frederic, I found a small issue in these patches, resulting into improper handling of the emergency calls for the non-SIM cases, but now that has been fixed and I am going to create a new set of patches. The answer to your question is yes, emergency calls will be also possible without a

[RFC PATCH 4/4] voicecall: add emergency call handling

2010-11-15 Thread Andras Domokos
--- src/voicecall.c | 111 ++- 1 files changed, 110 insertions(+), 1 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 3af614b..066cdb9 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -52,6 +52,7 @@ struct ofono_voicecall

[RFC PATCH 1/4] modem: add modem online-offline watch

2010-11-15 Thread Andras Domokos
From: Andras Domokos andras.domo...@nokia.com --- src/modem.c | 46 ++ src/ofono.h |8 2 files changed, 54 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index 3776461..f73cc1d 100644 --- a/src/modem.c +++

RE: [PATCH] TODO: Add vCard export to SM/ME stores

2010-11-15 Thread Bastian, Waldo
Marcel wrote: diff --git a/TODO b/TODO index bf2305b..9dcb43f 100644 --- a/TODO +++ b/TODO @@ -496,3 +496,14 @@ Miscellaneous Priority: Low Complexity: C4 + +- Enable exporting contact information from vCard data to SM and ME stores. + Need to implement a robust

Re: [PATCH 0/5] Call Counters

2010-11-15 Thread Marcel Holtmann
Hi Andras, Here a proposal for call counters implementation for keeping track of the total incoming and outgoing call duration counters. Each established call instance is contributing to either of the call duration counters. The 2 counters are updated periodically when there is an

Re: [RFC PATCH 5/5] Makefile: add call counters to the build

2010-11-15 Thread Marcel Holtmann
Hi Andras, Makefile.am |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makefile.am index f841b4c..a1c6097 100644 --- a/Makefile.am +++ b/Makefile.am @@ -295,6 +295,9 @@ builtin_modules += example_nettime builtin_sources += examples/nettime.c

RE: [PATCH] TODO: Add vCard export to SM/ME stores

2010-11-15 Thread Marcel Holtmann
Hi Waldo, To support this feature then first we need to convert the current feature into returning a dict. And then have this feature using a dict as input. Does this mean that support for writing to the phonebook is expected to be added to the phonebook modem API as part of ofono core

Re: [PATCH 0/4] Emergency Calls (3rd round)

2010-11-15 Thread Marcel Holtmann
Hi Andras, I found a small issue in these patches, resulting into improper handling of the emergency calls for the non-SIM cases, but now that has been fixed and I am going to create a new set of patches. The answer to your question is yes, emergency calls will be also possible without