RE: STK DisplayText changes proposal

2010-11-24 Thread Lucas, GuillaumeX
Hi Andrew, > > On 23 November 2010 18:08, Denis Kenzior wrote: > > On 11/23/2010 10:55 AM, Andrzej Zaborowski wrote: > >> As for the clear after delay flag, there's a check for it in > >> display_text_cb (line 1248).  As far as I can make out the only > >> difference is the response sent to the

Re: [PATCH 0/3] Long dial string support (2nd)

2010-11-24 Thread Andras Domokos
Hi Denis, On 11/24/2010 12:04 AM, ext Denis Kenzior wrote: Hi Andras, Even if we don't support FDN at this point, there is still a remaining related issue, who we are going to dial numbers like: 12345456p1234# I think the the dial string could still be passed to the voicecall driver

Re: [PATCH 0/3] Long dial string support (2nd)

2010-11-24 Thread Andras Domokos
Hi Rajesh, On 11/22/2010 10:58 PM, ext rajesh.naga...@elektrobit.com wrote: Hi Andras, Dial strings can now be as long as 120 digits (not counting '+'). This feature is going to be needed by the FDN feature. An FDN may consist of a phone number plus a DTMF string. In order to have the cal

Property signal fix for data and fax call forwarding

2010-11-24 Thread Jeevaka Badrappan
Hi, Data and Fax call forwarding is not supported in oFono. Currently, oFono triggers the property change only for voice call even when the Data/Fax call forwarding is active. In one particular case, the Data and Fax property change gets triggered. This patch handles that particular case as w

[PATCH] call-forwarding: skip property change data and fax

2010-11-24 Thread Jeevaka Badrappan
--- src/call-forwarding.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index 715ce02..ce03c40 100644 --- a/src/call-forwarding.c +++ b/src/call-forwarding.c @@ -285,6 +285,13 @@ static void set_new_cond_list(struct ofo

Fix issue in call forwarding erase response handling

2010-11-24 Thread Jeevaka Badrappan
Hi, Issue observed in call forwarding feature information list parsing. Due to this, isimodem reports Erase failure to the core even when the Erase request is successfully handled by the network. Considering the current logic, this is the fix that can be provided without changes to other parts o

[PATCH] isi: Fix issue in call forwarding erase response

2010-11-24 Thread Jeevaka Badrappan
--- drivers/isimodem/call-forwarding.c | 20 ++-- 1 files changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/isimodem/call-forwarding.c b/drivers/isimodem/call-forwarding.c index 1448451..c364bdf 100644 --- a/drivers/isimodem/call-forwarding.c +++ b/drivers/isimodem

[PATCH] TODO: Add a new task for CELL_DCH state indication

2010-11-24 Thread Aki Niemi
--- TODO | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index c484871..5806ef0 100644 --- a/TODO +++ b/TODO @@ -507,3 +507,13 @@ Miscellaneous Priority: Medium Complexity: C2 Owner: Sjur Br??ndeland + +- Add CELL_DCH state indication suppor

Re: [PATCH] isi: Fix issue in call forwarding erase response

2010-11-24 Thread Aki Niemi
Hi Jeevaka, 2010/11/24 Jeevaka Badrappan : > --- >  drivers/isimodem/call-forwarding.c |   20 ++-- >  1 files changed, 14 insertions(+), 6 deletions(-) > > diff --git a/drivers/isimodem/call-forwarding.c > b/drivers/isimodem/call-forwarding.c > index 1448451..c364bdf 100644 > ---

RE: [PATCH] isi: Fix issue in call forwarding erase response

2010-11-24 Thread Jeevaka.Badrappan
Hi Aki, > > I think the problem is that we try to decode the alpha tag > even when it is not present, i.e., when _numlen is zero. > > In fact, this has already been fixed in my current working > tree in a bit different way. Mostly due to the fact that I added a new > g_isi_sb_iter_get_struct

[PATCH] Doc Update voicecallmanager-api.txt

2010-11-24 Thread ext-arun . 1 . ravindran
From: Arun Ravindran --- doc/voicecallmanager-api.txt |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/doc/voicecallmanager-api.txt b/doc/voicecallmanager-api.txt index d960f3c..a4048d2 100644 --- a/doc/voicecallmanager-api.txt +++ b/doc/voicecallmanager-api.txt @

[PATCH] Add voice call boolean property for MO/MT distinction

2010-11-24 Thread Rémi Denis-Courmont
--- doc/voicecall-api.txt |5 + src/voicecall.c |6 +- 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt index f0ba316..f3cad7c 100644 --- a/doc/voicecall-api.txt +++ b/doc/voicecall-api.txt @@ -87,6 +87,11 @@ Proper

Re: [PATCH v2 5/7] text-telephony: add documentation

2010-11-24 Thread Denis Kenzior
Hi Lucas, > +Properties boolean Powered [readwrite] > + > + This property will enable or disable the text > + telephony feature in the modem. > + > + Text telephony (TTY), also known as TDD, is a feature > + present

Re: [PATCH v2 2/7] text-telephony: define new dbus interface

2010-11-24 Thread Denis Kenzior
Hi Lucas, On 11/23/2010 12:04 PM, Lucas De Marchi wrote: > --- > include/dbus.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.o

Re: [PATCH v2 3/7] text-telephony: add new interface to feature map

2010-11-24 Thread Denis Kenzior
Hi Lucas, On 11/23/2010 12:04 PM, Lucas De Marchi wrote: > --- > src/modem.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/

Re: [PATCH v2 1/7] text-telephony: add public header

2010-11-24 Thread Denis Kenzior
Hi Lucas, On 11/23/2010 12:04 PM, Lucas De Marchi wrote: > --- > Makefile.am |3 +- > include/text-telephony.h | 71 > ++ So I'd like to name this file include/ctm.h, looks nicer and is shorter to type. > 2 files changed, 73 insert

Re: [RFC PATCH 2/4] modem: add EmergencyMode property

2010-11-24 Thread Andras Domokos
Hi Denis, On 11/23/2010 10:46 AM, ext Denis Kenzior wrote: Hi Andras, On 11/15/2010 10:57 AM, Andras Domokos wrote: From: Andras Domokos --- src/modem.c | 134 +++ src/ofono.h |4 ++ 2 files changed, 138 insertions(+), 0 del

Re: [PATCH v2 4/7] text-telephony: implement interface/atom

2010-11-24 Thread Denis Kenzior
Hi Lucas, On 11/23/2010 12:04 PM, Lucas De Marchi wrote: > --- > Makefile.am |2 +- > src/ofono.h |2 + > src/text-telephony.c | 341 > ++ > 3 files changed, 344 insertions(+), 1 deletions(-) > create mode 100644 src/tex

Re: [RFC PATCH 4/4] voicecall: add emergency call handling

2010-11-24 Thread Andras Domokos
Hi Denis, On 11/23/2010 11:00 AM, ext Denis Kenzior wrote: Hi Andras, On 11/15/2010 10:58 AM, Andras Domokos wrote: --- src/voicecall.c | 111 ++- 1 files changed, 110 insertions(+), 1 deletions(-) diff --git a/src/voicecall.c b/src/

[RFC PATCH 2/4] modem: add EmergencyMode property

2010-11-24 Thread Andras Domokos
--- src/dbus.c |7 +++ src/modem.c | 137 +++ src/ofono.h |5 ++ 3 files changed, 149 insertions(+), 0 deletions(-) diff --git a/src/dbus.c b/src/dbus.c index ad29241..0b4fc06 100644 --- a/src/dbus.c +++ b/src/dbus.c @@ -348,6 +348

[RFC PATCH 4/4] voicecall: add emergency call handling

2010-11-24 Thread Andras Domokos
--- src/voicecall.c | 112 ++- 1 files changed, 111 insertions(+), 1 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 3307db0..882d94f 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -52,6 +52,7 @@ struct ofono_voicecall

Re: [PATCH v2 4/7] text-telephony: implement interface/atom

2010-11-24 Thread Lucas De Marchi
Hi Denis, On Wed, Nov 24, 2010 at 1:58 PM, Denis Kenzior wrote: > Hi Lucas, > > On 11/23/2010 12:04 PM, Lucas De Marchi wrote: >> --- >>  Makefile.am          |    2 +- >>  src/ofono.h          |    2 + >>  src/text-telephony.c |  341 >> ++ >>  3 f

Re: [PATCH v2 4/7] text-telephony: implement interface/atom

2010-11-24 Thread Denis Kenzior
Hi Lucas, >>> + tt_set_powered(tt, enable); >>> + tt_send_properties_reply(tt); >> >> The oFono convention is to reply to the pending D-Bus method call and >> then signal the property changed signals. >> > > The examples I found for query methods use exactly the opposite. See, > cw_ss_que

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-24 Thread Denis Kenzior
Hi Rémi, > + boolean Originated [readonly] > + > + Indicates whether the call was mobile-originated > + (true) or mobile-terminated (false). > + What use case are you trying to enable with this API? I don't see how this could be useful for the

Re: [PATCH] Doc Update voicecallmanager-api.txt

2010-11-24 Thread Denis Kenzior
Hi Arun, On 11/24/2010 08:56 AM, ext-arun.1.ravind...@nokia.com wrote: > From: Arun Ravindran > > --- > doc/voicecallmanager-api.txt |9 - > 1 files changed, 8 insertions(+), 1 deletions(-) > Patch has been applied, thanks. Regards, -Denis

Re: [PATCH] call-forwarding: skip property change data and fax

2010-11-24 Thread Denis Kenzior
Hi Jeevaka, On 11/24/2010 03:57 AM, Jeevaka Badrappan wrote: > --- > src/call-forwarding.c |7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > Good catch, patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@

[PATCH 0/3] Persist TX SMS messages

2010-11-24 Thread Kristen Carlson Accardi
This patch series implements a method of persisting pending outgoing sms messages on disk. Once an sms message has been submitted to the transmit queue, each pdu in the message is stored on disk until the driver indicates that it has been sent. Each tx_queue_entry is given an id number that repre

[PATCH 1/3] sms: store pending tx pdus on disk

2010-11-24 Thread Kristen Carlson Accardi
--- src/sms.c | 17 + src/smsutil.c | 26 ++ src/smsutil.h |3 +++ 3 files changed, 46 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index 12988c8..6eab0fa 100644 --- a/src/sms.c +++ b/src/sms.c @@ -52,6 +52,8 @@ static gboole

[PATCH 2/3] sms: delete sent sms messages from backup

2010-11-24 Thread Kristen Carlson Accardi
--- src/sms.c |9 + src/smsutil.c | 38 ++ src/smsutil.h |4 3 files changed, 51 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index 6eab0fa..f987946 100644 --- a/src/sms.c +++ b/src/sms.c @@ -769,6 +769,10 @@ stati

[PATCH 3/3] sms: restore pending tx messages from backup

2010-11-24 Thread Kristen Carlson Accardi
--- src/ofono.h |1 + src/sms.c | 38 +++ src/smsutil.c | 116 + src/smsutil.h |6 +++ 4 files changed, 161 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index d1a4bdc..4777f70 100644 -

How to get the OMA DRM right object file coming from WAP Push?

2010-11-24 Thread Lin, Mengdong
OMA DRM 1.0 use WAP Push to send a right object file to the device. The Push Application ID is - URN: x-wap-application:drm.ua - Number: 0x08 How can I get the right object file from oFono? Many thanks! Amanda ___ ofono mailing list ofono@ofono.org htt

RE: How to get the OMA DRM right object file coming from WAP Push?

2010-11-24 Thread Lin, Mengdong
I found two methods: Methods void RegisterAgent(object path) Registers an agent which will be called whenever a new Smart Messaging based SMS arrives. Methods void ReceiveNotification(array{byte} notification, dict info

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-24 Thread Rémi Denis-Courmont
On Wednesday 24 November 2010 23:31:43 ext Denis Kenzior, you wrote: > Hi Rémi, > > > + boolean Originated [readonly] > > + > > + Indicates whether the call was mobile-originated > > + (true) or mobile-terminated (false). > > + > > What use case are y

Re: [RERESEND] [PATCH 2/2] Update the network documentation

2010-11-24 Thread Rémi Denis-Courmont
On Tuesday 23 November 2010 23:45:07 ext Denis Kenzior, you wrote: > On 11/23/2010 01:20 PM, Aki Niemi wrote: > > Hi, > > > > 2010/11/23 Denis Kenzior : > >> In fact we were planning to report the current bearer on the > >> ConnectionManager interface once we figured out the vendor commands that >