Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context

Hi Tonny, Tonny Tzeng tonny.tz...@gmail.com writes: --- plugins/huawei.c |8 1 files changed, 4 insertions(+), 4 deletions(-) Your commit log is empty. The most important part of the commit log is to answer the question Why? and this patch really would need that answer. What's

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

Hi Remi, where is this timed running? I prefer the plugin just send a D-Bus message to the timed directly instead of a Get/Changed API kind of thing. AFAIK, Get/Changed is the simplest functional way to avoid races, where say oFono would receive the time before timed can

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

Hi Rémi, 2010/12/6 Rémi Denis-Courmont remi.denis-courm...@nokia.com: +static struct tm *refresh_nw_time(struct tm *nw_time, + time_t received) +{ + time_t now, new_nw_time; + + now = get_monotonic_time(); + new_nw_time = timegm(nw_time) +

Re: [PATCH] Mark ofono/*.h symbolink links as built sources

Hi Remi, This forces automake/make to build them first if needed (as before). But it avoids marking every single header as a dependency of every single object. Thus we do not need a bogus full rebuild of the tree everytime a header is added. --- Makefile.am |6 +++--- 1 files changed,

Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context

Hi Tonny, plugins/huawei.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 25dfaca..32cf70d 100644 --- a/plugins/huawei.c +++ b/plugins/huawei.c @@ -454,7 +454,7 @@ static void huawei_disconnect(gpointer user_data)

[PATCH] stkutil: fix crash issue cause by null length of text string

From: Guillaume Lucas guillaumex.lu...@intel.com According to 3GPP TS 31.124 a null length for the text string should be allowed. An empty string must be returned to the user in this case. --- src/stkutil.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

Hi Marcel, I have seen a bunch of devices where we have not a proper clock value to begin with. And in that case there is nothing really useful we can do with it, except just set the system clock right away. We are not using any absolute time value from any clock, but instead we use relative

Re: [PATCH 4/4] TODO: Marking the Barred Dialing task as done

Hi Denis/Pessi, On Mon, Dec 6, 2010 at 9:18 PM, jeevaka.badrap...@elektrobit.com wrote: Hi Sankar, Then as per your email, the support provided in Ofono seems to be limited. If there is no enable or disable is allowed, I am not sure, how we can we have a card in which FDN enabled, which

[PATCH] voicecall: Add emergency property

--- doc/voicecall-api.txt |5 + src/voicecall.c | 37 + 2 files changed, 42 insertions(+), 0 deletions(-) diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt index f0ba316..95a43a6 100644 --- a/doc/voicecall-api.txt +++

Re: [PATCH 0/5] Call Counters (2nd)

Hi Andras, 2010/11/22 Andras Domokos andras.domo...@nokia.com: Here a proposal for call counters implementation for keeping track of the total incoming and outgoing call duration counters. Each established call instance is contributing to either of the call duration counters. The 2 counters

Re: [PATCH 1/3] sms: store pending tx pdus on disk

Hi Kristen, 2010/11/25 Kristen Carlson Accardi kris...@linux.intel.com: @@ -1923,6 +1928,8 @@ int __ofono_sms_txq_submit(struct ofono_sms *sms, GSList *list,                        sms-ref = sms-ref + 1;        } +       entry-id = tx_counter++; +        g_queue_push_tail(sms-txq,

RE: [PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff

Hi Denis, + ofono_bool_t online; Why do you need to track this variable? Can't you simply call ofono_modem_get_online()? This way calling of ofono_modem_get_online for each get or set request can be avoided. Regards, Jeevaka ___ ofono

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

On Tuesday 07 December 2010 10:58:37 ext Marcel Holtmann, you wrote: I have seen a bunch of devices where we have not a proper clock value to begin with. And in that case there is nothing really useful we can do with it, except just set the system clock right away. Are you kidding me? You

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

On Tuesday 07 December 2010 09:51:57 ext Aki Niemi, you wrote: Passing the time over D-Bus may cause extra drift/imprecision than we already have. I wonder if it would make sense to provide not just the current time but both: - the current time for trivial programs, and - the system boot

What should happen after losing and retrieving gsm signal ?

Hi, I'm trying to re-establish a 3G connection after a gsm signal loss and I'm getting some pretty strange results. So first, some short and general questions : What should happen after going off gsm coverage and back again ? In particular, is ofono taking care of the network registration or

Re: What should happen after losing and retrieving gsm signal ?

On Tuesday 07 December 2010 19:00:49 ext Benoît Monin, you wrote: So first, some short and general questions : What should happen after going off gsm coverage and back again ? The modem should periodically try to register again. When that happens oFono will go back online. In particular, is

Re: [PATCH 2/3] sms: delete sent sms messages from backup

Hi Kristen, On 11/24/2010 04:53 PM, Kristen Carlson Accardi wrote: --- src/sms.c |9 + src/smsutil.c | 38 ++ src/smsutil.h |4 3 files changed, 51 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index

Re: [PATCH 1/3] sms: store pending tx pdus on disk

Hi Kristen, On 11/24/2010 04:53 PM, Kristen Carlson Accardi wrote: --- src/sms.c | 17 + src/smsutil.c | 26 ++ src/smsutil.h |3 +++ 3 files changed, 46 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index

Re: [PATCH 3/3] sms: restore pending tx messages from backup

Hi Kristen, On 11/24/2010 04:53 PM, Kristen Carlson Accardi wrote: --- src/ofono.h |1 + src/sms.c | 38 +++ src/smsutil.c | 116 + src/smsutil.h |6 +++ 4 files changed, 161 insertions(+), 0

Re: [PATCH] gatchat: fix canceling in progress commands

Hi Vinicius, On 12/02/2010 02:13 PM, Vinicius Costa Gomes wrote: As g_queue_peek_head() returns the node data field, we have to compare it against the actual command, not against the pointer to the queue node. --- gatchat/gatchat.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [PATCH] TODO: add owner to 'SIM PIN retry counter' task

Hi Lucas, On 12/02/2010 06:46 AM, Lucas De Marchi wrote: --- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index a421a99..878b0ab 100644 --- a/TODO +++ b/TODO @@ -114,6 +114,7 @@ SIM / SIM File system Priority: Low Complexity: C2 +

Re: [PATCH] voicecall: Add EmergencyCall property.

Hi John, On 12/03/2010 02:00 AM, john.mat...@elektrobit.com wrote: Hi Marcel, This was a question open for discussion. What would be the appropriate property name? As per my understanding, this property is only to provide the Emergency call indication to the application side, so that

Re: [PATCH -v3 2/5] modem: add ofono_modem_reset() to modem.h

Hi Gustavo, On 12/03/2010 12:52 PM, Gustavo F. Padovan wrote: --- include/modem.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH -v3 3/5] Add ofono_modem_reset()

Hi Gustavo, On 12/03/2010 12:52 PM, Gustavo F. Padovan wrote: Some modems can screw up everything and then we will need to do a silent reset of the modem. This patch take the modem back to the OFFLINE state. --- src/modem.c | 20 1 files changed, 20 insertions(+), 0

Re: [PATCH -v3 4/5] phonesim: Add modem reset trigger

Hi Gustavo, On 12/03/2010 12:52 PM, Gustavo F. Padovan wrote: --- plugins/phonesim.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list

Re: [PATCH 2/5] cdma-voicecall: Add CDMA MO Call Support

Hi Rajesh, On 12/03/2010 03:34 PM, rajesh.naga...@elektrobit.com wrote: Hi Dara, -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Dara Spieker-Doyle Sent: 03 December 2010 13:21 +enum cdma_call_status { +

Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context

Hi Tonny, On 12/03/2010 09:22 AM, Tonny Tzeng wrote: --- plugins/huawei.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 25dfaca..32cf70d 100644 --- a/plugins/huawei.c +++ b/plugins/huawei.c @@ -454,7 +454,7 @@

Re: [PATCH -v3 5/5] modem: add support to restore state when resetting the modem

Hi Gustavo, @@ -488,16 +465,22 @@ static void online_cb(const struct ofono_error *error, void *data) DBusMessage *reply; if (error-type == OFONO_ERROR_TYPE_NO_ERROR - modem-modem_state == MODEM_STATE_OFFLINE) + modem-modem_state ==

Re: [PATCH 1/3] smsutil: Change the range of time zone

Hi Yang, On 11/30/2010 04:44 AM, Yang Gu wrote: --- src/smsutil.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] Simulate provide local info command in sim app

Hi Yang, On 11/30/2010 04:43 AM, Yang Gu wrote: --- src/simapplication.cpp | 68 src/simapplication.h |2 + 2 files changed, 70 insertions(+), 0 deletions(-) Patch looks good, but could you please rebase and resubmit? Thanks,

[PATCH] modem: add support to restore state when resetting the modem

--- src/modem.c | 60 +++--- 1 files changed, 36 insertions(+), 24 deletions(-) diff --git a/src/modem.c b/src/modem.c index 2f9387c..816443e 100644 --- a/src/modem.c +++ b/src/modem.c @@ -70,6 +70,7 @@ struct ofono_modem { guint

[PATCH 1/2] Add CNAP support

With CNAP phonesim can tell the Caller Name within the RING comand --- src/callmanager.cpp | 16 +--- src/callmanager.h |5 +++-- src/control.cpp |4 ++-- src/control.h |2 +- src/controlbase.ui| 16

[PATCH 2/2] Add support to CNAP ss command

--- src/simapplication.cpp | 80 src/simapplication.h |2 + 2 files changed, 82 insertions(+), 0 deletions(-) diff --git a/src/simapplication.cpp b/src/simapplication.cpp index 62bbe9d..bd650a4 100644 --- a/src/simapplication.cpp +++

Re: [PATCH 0/5] Call Counters (2nd)

Hi Aki, On 12/07/2010 06:57 AM, Aki Niemi wrote: Hi Andras, 2010/11/22 Andras Domokos andras.domo...@nokia.com: Here a proposal for call counters implementation for keeping track of the total incoming and outgoing call duration counters. Each established call instance is contributing to

Re: [PATCH 2/5] cdma-voicecall: Add CDMA MO Call Support

Hi Denis On Tue, 2010-12-07 at 04:16 +0100, ext Denis Kenzior wrote: Hi Rajesh, On 12/03/2010 03:34 PM, rajesh.naga...@elektrobit.com wrote: Hi Dara, -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Dara Spieker-Doyle

Re: [PATCH] stkutil: fix crash issue cause by null length of text string

Hi Guillaume, On 7 December 2010 11:58, Lucas, GuillaumeX guillaumex.lu...@intel.com wrote: From: Guillaume Lucas guillaumex.lu...@intel.com According to 3GPP TS 31.124 a null length for the text string should be allowed. An empty string must be returned to the user in this case. Can you

Read/Write EFcfis/EFcphs-cff files

Hi, This patch reads and writes the call forwarding unconditional status from and to the SIM depending on the SIM file availability. New property needs to be added due to the fact that number won't be available from the cphs-cff file. Incase of SIM, EFcphs-cff file holds call forwarding status

[PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff

--- src/call-forwarding.c | 242 - 1 files changed, 241 insertions(+), 1 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index bb8aa37..aafb1ce 100644 --- a/src/call-forwarding.c +++ b/src/call-forwarding.c @@ -34,6 +34,7

[PATCH 3/7] isigen: Move call forwarding to post sim

--- plugins/isigen.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/isigen.c b/plugins/isigen.c index 028f1b2..b7b7ab5 100644 --- a/plugins/isigen.c +++ b/plugins/isigen.c @@ -402,6 +402,7 @@ static void isigen_post_sim(struct ofono_modem *modem)

[PATCH 6/7] doc: Add new property to call forwarding

--- doc/call-forwarding-api.txt |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/doc/call-forwarding-api.txt b/doc/call-forwarding-api.txt index 067531a..e8b4b9f 100644 --- a/doc/call-forwarding-api.txt +++ b/doc/call-forwarding-api.txt @@ -57,3 +57,8 @@ Properties

[PATCH 5/7] phonesim: Move call forwarding to post sim

--- plugins/phonesim.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/plugins/phonesim.c b/plugins/phonesim.c index c7ef0d7..b4795f2 100644 --- a/plugins/phonesim.c +++ b/plugins/phonesim.c @@ -635,6 +635,8 @@ static void phonesim_post_sim(struct ofono_modem *modem)

[PATCH 7/7] TODO: Marking the Read/Write EFcfis task as done

--- TODO |9 - doc/features.txt |5 + 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/TODO b/TODO index 5d0a9f9..d74ab50 100644 --- a/TODO +++ b/TODO @@ -92,15 +92,6 @@ SMS SIM / SIM File system = -- Read / Write EFcfis. Call

RE: [PATCH] stkutil: fix crash issue cause by null length of text string

Hi Guillaume, According to 3GPP TS 31.124 a null length for the text string should be allowed. An empty string must be returned to the user in this case. --- src/stkutil.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) Agree. As per the 3GPP TS 31.124 null text

Re: [PATCH] stkutil: fix crash issue cause by null length of text string

On 7 December 2010 22:55, jeevaka.badrap...@elektrobit.com wrote: Hi Guillaume, According to 3GPP TS 31.124 a null length for the text string should be allowed. An empty string must be returned to the user in this case. ---  src/stkutil.c |    6 --  1 files changed, 4 insertions(+),

Re: [PATCH 1/3] sms: store pending tx pdus on disk

On Mon, 06 Dec 2010 20:38:58 -0600 Denis Kenzior denk...@gmail.com wrote: snip + /* +* file name is: imsi/order in tx_queue-uuid/order of pdus +*/ + if (write_file(buf, len, SMS_BACKUP_MODE, + SMS_TX_BACKUP_PATH_FILE, imsi, id, uuid, +

[PATCH] Simulate provide local info command in sim app

--- src/simapplication.cpp | 68 src/simapplication.h |2 + 2 files changed, 70 insertions(+), 0 deletions(-) diff --git a/src/simapplication.cpp b/src/simapplication.cpp index 62bbe9d..388b2ce 100644 --- a/src/simapplication.cpp +++