[RFC PATCH 0/5 v2] Atom for Neighbour Cell Info

This series of patches implements an interface for client application to fetch the ECID information of neighbouring cells using DBUS. ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[RFC PATCH 2/5 v2] cell-info: Header file for cell-info atom

--- include/cell-info.h | 133 +++ 1 files changed, 133 insertions(+), 0 deletions(-) create mode 100644 include/cell-info.h diff --git a/include/cell-info.h b/include/cell-info.h new file mode 100644 index 000..3941e69 --- /dev/null +++ b/inc

[RFC PATCH 4/5 v2] cell-info: New files included for compilation

--- Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 4a919ab..e433861 100644 --- a/Makefile.am +++ b/Makefile.am @@ -14,7 +14,7 @@ include_HEADERS = include/log.h include/plugin.h include/history.h \ in

[RFC PATCH 1/5 v2] cell-info: Atom for ECID info of neighb cells

--- src/cell-info.c | 484 +++ 1 files changed, 484 insertions(+), 0 deletions(-) create mode 100644 src/cell-info.c diff --git a/src/cell-info.c b/src/cell-info.c new file mode 100644 index 000..2289ce1 --- /dev/null +++ b/src/cell-info.c

[RFC PATCH 5/5 v2] cell-info: Documentation

--- doc/cell-info.txt | 110 + 1 files changed, 110 insertions(+), 0 deletions(-) create mode 100644 doc/cell-info.txt diff --git a/doc/cell-info.txt b/doc/cell-info.txt new file mode 100644 index 000..9144eb7 --- /dev/null +++ b/doc/cell-

[RFC PATCH 3/5 v2] cell-info: Interface declarations

--- include/dbus.h |1 + src/ofono.h|1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/dbus.h b/include/dbus.h index c527515..98839cc 100644 --- a/include/dbus.h +++ b/include/dbus.h @@ -45,6 +45,7 @@ extern "C" { #define OFONO_MESSAGE_WAITING_INTERFACE "org.

Re: [RFC PATCH 0/4] Automatic provisioning of GPRS context settings

Hi On 21/12/10 16:11, ext Marcel Holtmann wrote: Settings database is CSV (comma separated values) formatted file(s) with fields for: (type=INTERNET|MMS protocol=ipv4|ipv6) MCC,MNC,SPN,type,UI name, APN, username, password, protocol, proxy IP address, proxy port, MMS server URL e.g. file /etc/

Discussion on CTM enhancement

Hi, As we are currently implementing the CTM modem driver for ifxmodem, I would like to bring a couple of things in the discussion. Today, patches for our modem driver are ready by before submitting them on the mailing list, I have 2 items to discuss: 1) First, it might a good proposal to merge

[PATCHv2 0/3] Support for Cinterion TC65

This is a second try on the matter, with corrections suggested by Denis. Oskari Timperi (3): Add a plugin for Cinterion TC65 modem Add TC65 to Makefile.am udev initialization for TC65 Makefile.am|3 + plugins/tc65.c | 263 p

[PATCHv2 1/3] Add a plugin for Cinterion TC65 modem

--- plugins/tc65.c | 263 1 files changed, 263 insertions(+), 0 deletions(-) create mode 100644 plugins/tc65.c diff --git a/plugins/tc65.c b/plugins/tc65.c new file mode 100644 index 000..4d1386b --- /dev/null +++ b/plugins/tc65.c @@

[PATCHv2 2/3] Add TC65 to Makefile.am

--- Makefile.am |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makefile.am index 4a919ab..1670de9 100644 --- a/Makefile.am +++ b/Makefile.am @@ -287,6 +287,9 @@ builtin_sources += plugins/ste.c builtin_modules += caif builtin_sources += plugins/caif.c +

[PATCHv2 3/3] udev initialization for TC65

--- plugins/udev.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index 3ca6af0..e384583 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -462,6 +462,19 @@ static void add_calypso(struct ofono_modem *modem, ofono_m

Re: PATCH: Enable udev-based autodetection of calypso modem on Freerunner

Hi Neil, > >>> Then I didn't look far back enough (or I'm simply blind). But I still > >>> prefer this to be inside the driver or HACKING.calypso for easier access. > >> > >> I am with you that this needs to be documented better than GIT commit > >> logs. > >> > >> However I do prefer doc/calyp

Re: [PATCH v2, 7/7] cdmaphonesim: Add CDMA SMS Support

Hi Lei, > Makefile.am | 10 ++ > plugins/cdmaphonesim.c| 328 > + > plugins/cdmaphonesim.conf | 14 ++ > 3 files changed, 352 insertions(+), 0 deletions(-) > create mode 100644 plugins/cdmaphonesim.c > create mode 100644 plugin

Re: [RFC] Refactoring ISI modem support

Hi All, 2010/11/15 Aki Niemi : > I've been working on improving the ISI modem support in oFono, mostly > concentrating on the gisi library, but also on tweaking the drivers > and plugins. You can follow the progress of this 'gisi' branch here: This branch has now been rebased and pushed to master

Re: [PATCH v2, 7/7] cdmaphonesim: Add CDMA SMS Support

Hi Marcel, On 12/22/2010 05:41 AM, ext Marcel Holtmann wrote: Hi Lei, Makefile.am | 10 ++ plugins/cdmaphonesim.c| 328 + plugins/cdmaphonesim.conf | 14 ++ 3 files changed, 352 insertions(+), 0 deletions(-) create mode

Re: [PATCH v2, 7/7] cdmaphonesim: Add CDMA SMS Support

Hi Lei, > >> Makefile.am | 10 ++ > >> plugins/cdmaphonesim.c| 328 > >> + > >> plugins/cdmaphonesim.conf | 14 ++ > >> 3 files changed, 352 insertions(+), 0 deletions(-) > >> create mode 100644 plugins/cdmaphonesim.c > >>

Re: [PATCH v2, 7/7] cdmaphonesim: Add CDMA SMS Support

Hi Marcel, On 12/22/2010 08:09 AM, ext Marcel Holtmann wrote: Hi Lei, Makefile.am | 10 ++ plugins/cdmaphonesim.c| 328 + plugins/cdmaphonesim.conf | 14 ++ 3 files changed, 352 insertions(+), 0 deletions(-) create

Re: [PATCH 1/2] modem: add Lockdown property to Modem interface

Hi Denis, * Denis Kenzior [2010-12-17 18:57:45 -0600]: > Hi Gustavo, > > On 12/03/2010 03:59 PM, Gustavo F. Padovan wrote: > > Setting Lockdown to TRUE means power down the modem and hold a lock that > > only permits the lock's owner power up the modem back. When released > > it restores the la

Re: [RFC PATCH 1/5 v2] cell-info: Atom for ECID info of neighb cells

Hi Antti, On Wed, 2010-12-22 at 11:35 +0200, ext Antti Paila wrote: > --- > src/cell-info.c | 484 > +++ > 1 files changed, 484 insertions(+), 0 deletions(-) > create mode 100644 src/cell-info.c > > diff --git a/src/cell-info.c b/src/cell-in

Re: [RFC PATCH 2/5 v2] cell-info: Header file for cell-info atom

Hi Antti, On Wed, 2010-12-22 at 11:35 +0200, ext Antti Paila wrote: > --- > include/cell-info.h | 133 > +++ > 1 files changed, 133 insertions(+), 0 deletions(-) > create mode 100644 include/cell-info.h > > diff --git a/include/cell-info.h b/inc

Re: [RFC PATCH 5/5 v2] cell-info: Documentation

Hi Antti, On Wed, 2010-12-22 at 11:35 +0200, ext Antti Paila wrote: > --- > doc/cell-info.txt | 110 > + > 1 files changed, 110 insertions(+), 0 deletions(-) > create mode 100644 doc/cell-info.txt > > diff --git a/doc/cell-info.txt b/doc/cel

[PATCH 2/3] doc: add Lockdown property to Modem

--- doc/modem-api.txt |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/doc/modem-api.txt b/doc/modem-api.txt index b92e53c..45043b0 100644 --- a/doc/modem-api.txt +++ b/doc/modem-api.txt @@ -37,6 +37,15 @@ Properties boolean Powered [readwrite]

[PATCH 3/3] modem: Add test script for the Lockdown property

--- Makefile.am |1 + test/lockdown-modem | 25 + 2 files changed, 26 insertions(+), 0 deletions(-) create mode 100755 test/lockdown-modem diff --git a/Makefile.am b/Makefile.am index 252b5da..94d5c09 100644 --- a/Makefile.am +++ b/Makefile.am @@ -428,6 +428

[PATCH 1/3] modem: add Lockdown property to Modem interface

Setting Lockdown to TRUE means power down the modem and hold a lock that only permits the lock's owner power up the modem back. When released it restores the last state of the modem before holding the lock. --- src/modem.c | 135 +++ 1 files

Re: [PATCH 3/4] doc: detail PinRetries property

Hi, On Tue, Dec 21, 2010 at 5:48 AM, Sankar wrote: >> +               byte PinRetries [readonly] >> + >> +                       Contains the retry counter for the current >> required >> +                       pin. This counter is tipically decremented >> whenever a >> +                       ca

[PATCH] TODO: add owner to the DUN server task

--- TODO |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/TODO b/TODO index ee32e34..39f3af8 100644 --- a/TODO +++ b/TODO @@ -132,10 +132,11 @@ Modem Emulator Complexity: C1 - Support DUN emulator. Implement the Bluetooth DUN profile with only mandatory - AT comman

[PATCH] TODO: Mark silent modem reset task as done

--- TODO |7 --- doc/features.txt |7 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/TODO b/TODO index 39f3af8..3c2ff15 100644 --- a/TODO +++ b/TODO @@ -408,13 +408,6 @@ Miscellaneous Complexity: C8 Owner: Jukka Saunamäki -- Support for mode

Re: [PATCH 1/3] modem: add Lockdown property to Modem interface

Hi Gustavo, On 12/22/2010 12:51 PM, Gustavo F. Padovan wrote: > Setting Lockdown to TRUE means power down the modem and hold a lock that > only permits the lock's owner power up the modem back. When released > it restores the last state of the modem before holding the lock. > --- > src/modem.c |

Re: [PATCH] TODO: Mark silent modem reset task as done

Hi Gustavo, On 12/22/2010 01:06 PM, Gustavo F. Padovan wrote: > --- > TODO |7 --- > doc/features.txt |7 +++ > 2 files changed, 7 insertions(+), 7 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono m

Re: [PATCH] TODO: add owner to the DUN server task

Hi Gustavo, On 12/22/2010 01:06 PM, Gustavo F. Padovan wrote: > --- > TODO |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/

[PATCH] TODO: Add CDMA network and voicecall tasks

Also updates the task ownership fields to be consistent with the tasks that are actually currently active. --- TODO | 66 +++--- 1 files changed, 63 insertions(+), 3 deletions(-) diff --git a/TODO b/TODO index ee32e34..a644fde 100644 -

Re: [PATCHv2 1/3] Add a plugin for Cinterion TC65 modem

Hi Oskari, On 12/22/2010 05:13 AM, Oskari Timperi wrote: > --- > plugins/tc65.c | 263 > > 1 files changed, 263 insertions(+), 0 deletions(-) > create mode 100644 plugins/tc65.c > > diff --git a/plugins/tc65.c b/plugins/tc65.c > new fil

Re: [PATCHv2 2/3] Add TC65 to Makefile.am

Hi Oskari, On 12/22/2010 05:13 AM, Oskari Timperi wrote: > --- > Makefile.am |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > Please squash this patch into Patch 1. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.o

[PATCH] TODO: Mark Lockdown task as done

--- TODO | 12 doc/features.txt |4 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/TODO b/TODO index 3c2ff15..a772e24 100644 --- a/TODO +++ b/TODO @@ -408,18 +408,6 @@ Miscellaneous Complexity: C8 Owner: Jukka Saunamäki -- Add support f

[PATCH v3 4/7] cdma-sms: Add CDMA SMS Support

--- Makefile.am|2 +- src/cdma-sms.c | 347 src/ofono.h|3 + 3 files changed, 351 insertions(+), 1 deletions(-) create mode 100644 src/cdma-sms.c diff --git a/Makefile.am b/Makefile.am index e85f522..61168ed 100644 --- a/M

[PATCH v3 7/7] cdmaphonesim: Add CDMA SMS Support

--- Makefile.am| 10 ++ plugins/cdmaphonesim.c | 328 plugins/phonesim.conf |4 + 3 files changed, 342 insertions(+), 0 deletions(-) create mode 100644 plugins/cdmaphonesim.c diff --git a/Makefile.am b/Makefile.am index 771f57d

Re: [PATCH v2, 4/7] cdma-sms: Add CDMA SMS Support

Hi All, On 12/21/2010 04:02 PM, Lei Yu wrote: --- Makefile.am|2 +- src/cdma-sms.c | 335 src/ofono.h|3 + 3 files changed, 339 insertions(+), 1 deletions(-) create mode 100644 src/cdma-sms.c diff --git a/Makefile.

Re: [PATCH v2, 7/7] cdmaphonesim: Add CDMA SMS Support

Hi, Marcel and all, On 12/22/2010 08:23 AM, ext Lei Yu wrote: Hi Marcel, On 12/22/2010 08:09 AM, ext Marcel Holtmann wrote: Hi Lei, Makefile.am | 10 ++ plugins/cdmaphonesim.c | 328 + plugins/cdmaphonesim.conf | 14 ++ 3 files changed, 352 insertions

Re: [PATCH 1/8] gps: define new dbus interface

Hi Rafael, On 12/16/2010 02:30 PM, Rafael Ignacio Zurita wrote: > --- > include/dbus.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/dbus.h b/include/dbus.h > index 9e29afb..48e8ac4 100644 > --- a/include/dbus.h > +++ b/include/dbus.h > @@ -54,6 +54,7 @@ e

Re: [PATCH 3/8] gps: add public header

Hi Rafael, > +struct ofono_gps_driver { > + const char *name; > + int (*probe)(struct ofono_gps *gps, unsigned int vendor, void *data); > + void (*remove)(struct ofono_gps *gps); > + void (*set_gps)(struct ofono_gps *gps, ofono_bool_t enable, > + ofono

Re: [PATCH 6/8] plugins: add gps atom to mbm

Hi Rafael, > > - if (modem_dev == NULL || data_dev == NULL) > + if (modem_dev == NULL || data_dev == NULL || gps_dev == NULL) > return -EINVAL; I don't think that failing because the gps device isn't set is such a good idea. There might be mbm cards without a gps node. L

Re: [PATCH 8/8] gps: add documentation

Hi Rafael, On 12/16/2010 02:30 PM, Rafael Ignacio Zurita wrote: > --- > Makefile.am |3 ++- > doc/gps-api.txt | 41 + > 2 files changed, 43 insertions(+), 1 deletions(-) > create mode 100644 doc/gps-api.txt > > diff --git a/Makefile.am b/Makefil

Re: [PATCH 3/4] doc: detail PinRetries property

Hi Lucas, On 12/22/2010 12:54 PM, Lucas De Marchi wrote: > Hi, > > On Tue, Dec 21, 2010 at 5:48 AM, Sankar wrote: >>> + byte PinRetries [readonly] >>> + >>> + Contains the retry counter for the current >>> required >>> + pin. This counter

Re: [PATCH] TODO: Mark Lockdown task as done

Hi Gustavo, On 12/22/2010 02:18 PM, Gustavo F. Padovan wrote: > --- > TODO | 12 > doc/features.txt |4 > 2 files changed, 4 insertions(+), 12 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofon

Re: [PATCH] TODO: Add CDMA network and voicecall tasks

Hi Dara, On 12/22/2010 02:12 PM, Dara Spieker-Doyle wrote: > Also updates the task ownership fields to be consistent > with the tasks that are actually currently active. > --- > TODO | 66 > +++--- > 1 files changed, 63 insertions(+),

Re: [PATCH v3, Part1, 4/5] cdmamodem: Add CDMA voicecall driver support for MO Call

Hi Dara, > + > +struct voicecall_driver { > + struct ofono_cdma_voicecall *vc; > + unsigned int local_release; What is the use of these two variables? > + GAtChat *chat; > + unsigned int vendor; > +}; > + > +struct change_state_req { > + struct ofono_cdma_voicecall *vc; > +

Re: [PATCH v3, Part1, 5/5] test: Add CDMA MO Call Support

Hi Dara, On 12/20/2010 07:36 PM, Dara Spieker-Doyle wrote: > --- > Makefile.am |5 - > test/cdma-dial-number | 24 > test/cdma-hangup | 20 > test/cdma-list-call | 30 ++ > 4 files changed, 78

Re: [PATCH v3, Part1, 1/5] cdma-voicecall: Add CDMA MO Call Support

On 12/20/2010 07:36 PM, Dara Spieker-Doyle wrote: > --- > Makefile.am |2 +- > include/cdma-voicecall.h | 89 > ++ > 2 files changed, 90 insertions(+), 1 deletions(-) > create mode 100644 include/cdma-voicecall.h > Patch has been a

Re: [PATCH v3, Part1, 2/5] cdma-voicecall: Add CDMA MO Call Support

Hi Dara, On 12/20/2010 07:36 PM, Dara Spieker-Doyle wrote: > --- > Makefile.am |3 +- > src/cdma-voicecall.c | 430 > ++ > src/common.c | 41 + > src/common.h |6 + > src/ofono.h |3 + > 5 files

Re: [PATCH v3, Part1, 3/5] cdmamodem: Add cdmamodem stubs

Hi Dara, On 12/20/2010 07:36 PM, Dara Spieker-Doyle wrote: > --- > Makefile.am |6 + > configure.ac |5 > drivers/cdmamodem/cdmamodem.c | 45 > + > drivers/cdmamodem/cdmamodem.h | 22 +

Re: [PATCH v3, Part2, 3/3] udev: Add nokiacdma device

Hi Dara, On 12/21/2010 01:23 PM, Dara Spieker-Doyle wrote: > --- > plugins/udev.c | 21 + > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/plugins/udev.c b/plugins/udev.c > index 255755e..9447e5c 100644 > --- a/plugins/udev.c > +++ b/plugins/udev.c > @@

Re: [PATCH v3, Part2, 1/3] nokiacdma: Add plugin and CDMA MO Call Support

Hi Dara, > +struct nokiacdma_data { > + GAtChat *chat; > + ofono_bool_t online; > + ofono_bool_t registration_status; What is the purpose of the above two variables? > +static void nokiacdma_disconnect(gpointer user_data) > +{ > + struct ofono_modem *modem = user_data; > +

Re: [PATCH 1/2] simutil: Minor style fixes and indentation

Hi Jessica, On 12/21/2010 03:34 AM, Jessica Nilsson wrote: > --- > src/simutil.h | 110 > 1 files changed, 55 insertions(+), 55 deletions(-) > > @@ -319,24 +319,24 @@ gboolean comprehension_tlv_iter_next(struct > comprehension_tlv_ite

Re: [PATCH 2/2] simutil: sim_fileid sorted in numerical order

Hi Jessica, On 12/21/2010 03:34 AM, Jessica Nilsson wrote: > --- > src/simutil.h | 10 +- > 1 files changed, 5 insertions(+), 5 deletions(-) > Looks good to me, please resubmit with the revised patch 1. Regards, -Denis ___ ofono mailing lis

Re: [PATCH 0/4 v2] Network Time plugin

Hi Aki, > There is no problem. If you still think there is a problem, you need > to continue the previous thread on this subject and prove your point. > > > And in case timed is not running it should just > > set the current time directly. > > You're welcome to write such a plugin -- this is why

Re: [PATCHv2] plugin: Add ste modem initd integration

Hi Sjur, > >> > This is a bad D-Bus API btw. Using a D-Bus method to trigger signal > >> > sending. You will wake up any listener for that signal. What is wrong > >> > with just having a GetState? > >> > >> My problem is that I need to get the path, or modem serial-number if > >> you like, to the

Re: [PATCH] TODO: Add onwer to 'Long phone numbers' task

Hi Rafael, On 12/21/2010 06:49 AM, Rafael Ignacio Zurita wrote: > --- > TODO |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > Thanks for taking up this task, patch has been applied. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 1/5] simfs: Cache flushing functions.

Hi Andrew, > diff --git a/src/simfs.h b/src/simfs.h > index ef962db..ace25bf 100644 > --- a/src/simfs.h > +++ b/src/simfs.h > @@ -47,4 +47,6 @@ char *sim_fs_get_cached_image(struct sim_fs *fs, int id); > > void sim_fs_cache_image(struct sim_fs *fs, const char *image, int id); > > +void sim_

Re: [RFC PATCH 2/5 v2] cell-info: Header file for cell-info atom

On Wed, 2010-12-22 at 20:45 +0200, ext Aki Niemi wrote: > Hi Antti, > > On Wed, 2010-12-22 at 11:35 +0200, ext Antti Paila wrote: > > --- > > include/cell-info.h | 133 > > +++ > > 1 files changed, 133 insertions(+), 0 deletions(-) > > create mod

RE: [RFC PATCH 2/5 v2] cell-info: Header file for cell-info atom

Hi Antti, On Wed, 2010-12-22 at 11:35 +0200, ext Antti Paila wrote: > --- > include/cell-info.h | 133 > +++ > 1 files changed, 133 insertions(+), 0 deletions(-) create mode > 100644 include/cell-info.h > > diff --git a/include/cell-info.h b/in

Re: [RFC PATCH 5/5 v2] cell-info: Documentation

Hi Aki, On Wed, 2010-12-22 at 20:46 +0200, ext Aki Niemi wrote: > Hi Antti, > > On Wed, 2010-12-22 at 11:35 +0200, ext Antti Paila wrote: > > --- > > doc/cell-info.txt | 110 > > + > > 1 files changed, 110 insertions(+), 0 deletions(-) > > c

RE: [RFC PATCH 2/5 v2] cell-info: Header file for cell-info atom

Hi Jun, On Thu, 2010-12-23 at 14:31 +0800, ext Wei, Jun wrote: > Hi Antti, > > On Wed, 2010-12-22 at 11:35 +0200, ext Antti Paila wrote: > > --- > > include/cell-info.h | 133 > > +++ > > 1 files changed, 133 insertions(+), 0 deletions(-) create