Hi Rajesh,
On 01/05/2011 02:34 PM, ext rajesh.naga...@elektrobit.com wrote:
HI Lei,
My comments inline
+
+/* 3GPP2 C.S0015-B v2.0, Table 3.4-1 */ enum cdma_sms_tp_msg_type {
+ CDMA_SMS_P2P = 0,
+ CDMA_SMS_BCAST =1,
+ CDMA_SMS_ACK = 2
+};
1.Coding style
Hi Rémi,
On 01/07/2011 02:52 AM, Rémi Denis-Courmont wrote:
> On Thursday 06 January 2011 02:17:09 ext Denis Kenzior, you wrote:
If such context is not found create a new one with "Internet" type.
>>>
>>> I don't really agree that we should create a context if no match is
>>> found. I think t
Hi Antti,
> > > > > But then it is far simpler to have a D-Bus getter and a D-Bus signal
> > > > > by any
> > > > > sane measure of complexity.
> > > >
> > > > So you did consider the complexity on both sides, ofonod and timed? And
> > > > not just looked at one side of picture?
> > >
> > > Ti
Hi Fred,
>>> The collision can only occur if the +CGDCONT (or +CGDSCONT) command from
>>> Ofono is sent at the same time as PDP >>context activation URC from the
>>> modem, and both use the same CID.
>>>
>>> But in that case, the modem should not reply "OK" to the PDP context
>>> configuration
Hi Rafael,
> Makefile.am |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 09dc9ad..679e4bf 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -436,7 +436,7 @@ test_scripts = test/backtrace \
> test/send-vcard \
>
Hi Sjur,
>-Original Message-
>From: Sjur Brændeland [mailto:sjurb...@gmail.com]
>Sent: Friday, January 07, 2011 4:39 PM
>To: ofono@ofono.org; Joly, Frederic
>Subject: Re: [RFC PATCH] gprs: add function to handle activated context
>
>Hi Fred,
>
>Frederic wrote:
>>The collision can only occ
Hi Rémi,
On 01/07/2011 10:02 AM, Rémi Denis-Courmont wrote:
> ---
> drivers/atmodem/gprs.c | 50
>
> 1 files changed, 50 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
> index a38c6b4..1d4a8bf 100
Hi Rémi,
On 01/07/2011 10:02 AM, Rémi Denis-Courmont wrote:
> ---
> include/gprs.h |2 ++
> src/gprs.c | 32
> 2 files changed, 34 insertions(+), 0 deletions(-)
>
please see the 'Submitting patches' section in HACKING
> diff --git a/include/gprs.h b/i
Hi Rémi,
On 01/07/2011 10:02 AM, Rémi Denis-Courmont wrote:
> ---
> src/common.c | 14 ++
> src/common.h | 13 +
> 2 files changed, 27 insertions(+), 0 deletions(-)
>
> diff --git a/src/common.c b/src/common.c
> index d4e567b..6664007 100644
> --- a/src/common.c
> +++
Hi Rémi,
On 01/07/2011 10:02 AM, Rémi Denis-Courmont wrote:
> ---
> doc/connman-api.txt | 10 ++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/doc/connman-api.txt b/doc/connman-api.txt
> index b13efd1..18185d7 100644
> --- a/doc/connman-api.txt
> +++ b/doc/connma
---
drivers/atmodem/gprs.c | 50
1 files changed, 50 insertions(+), 0 deletions(-)
diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
index a38c6b4..1d4a8bf 100644
--- a/drivers/atmodem/gprs.c
+++ b/drivers/atmodem/gprs.c
@@ -200,6 +200
---
doc/connman-api.txt | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/doc/connman-api.txt b/doc/connman-api.txt
index b13efd1..18185d7 100644
--- a/doc/connman-api.txt
+++ b/doc/connman-api.txt
@@ -150,6 +150,16 @@ Properties boolean Active [readwrite]
---
include/gprs.h |2 ++
src/gprs.c | 32
2 files changed, 34 insertions(+), 0 deletions(-)
diff --git a/include/gprs.h b/include/gprs.h
index 1c1d116..cd62f2f 100644
--- a/include/gprs.h
+++ b/include/gprs.h
@@ -59,6 +59,8 @@ void ofono_gprs_status_not
---
src/common.c | 14 ++
src/common.h | 13 +
2 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/src/common.c b/src/common.c
index d4e567b..6664007 100644
--- a/src/common.c
+++ b/src/common.c
@@ -714,6 +714,20 @@ const char *registration_tech_to_string(in
-Original Message-
From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of
Rémi Denis-Courmont
Sent: Friday, January 07, 2011 9:52 AM
To: ofono@ofono.org
Subject: Re: [RFC PATCH] gprs: add function to handle activated context
On Thursday 06 January 2011 02:17:09 ext
Hi Fred,
Frederic wrote:
> The collision can only occur if the +CGDCONT (or +CGDSCONT) command from
> Ofono is sent at the same time as PDP context activation URC from the modem,
> and both use the same CID.
>
> But in that case, the modem should not reply "OK" to the PDP context
> configurati
Hi,
My two cents on context activation race: the collision between a network
initiated context activation and UE initiated context activation. There is a
potential issue if the modem and ofono try to assign the same CID at the same
time
Basically the sequence of AT commands looks like the foll
---
Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 09dc9ad..679e4bf 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -436,7 +436,7 @@ test_scripts = test/backtrace \
test/send-vcard \
test/set-tty \
Hi,
2011/1/7 Rémi Denis-Courmont :
> On Thursday 06 January 2011 02:12:01 ext Marcel Holtmann, you wrote:
>> > If such context is not found create a new one with "Internet" type.
>>
>> I don't really agree that we should create a context if no match is
>> found. I think the better sensible strateg
Hi Marcel,
On Tue, 2011-01-04 at 13:49 -0800, ext Marcel Holtmann wrote:
> Hi Aki,
>
> > > > But then it is far simpler to have a D-Bus getter and a D-Bus signal by
> > > > any
> > > > sane measure of complexity.
> > >
> > > So you did consider the complexity on both sides, ofonod and timed? A
On Thursday 06 January 2011 02:17:09 ext Denis Kenzior, you wrote:
> >> If such context is not found create a new one with "Internet" type.
> >
> > I don't really agree that we should create a context if no match is
> > found. I think the better sensible strategy is to hold this information
> > in
On Thursday 06 January 2011 02:12:01 ext Marcel Holtmann, you wrote:
> > If such context is not found create a new one with "Internet" type.
>
> I don't really agree that we should create a context if no match is
> found. I think the better sensible strategy is to hold this information
> internall
22 matches
Mail list logo
