Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

2011-02-02 Thread Aki Niemi
On Wed, 2011-02-02 at 10:03 +0100, ext Andreas WESTIN wrote: On 2011-02-01 20:32, Aki Niemi wrote: Like I replied earlier, I don't see the need for this. Also, it will not work well with the isiusb plugin, which has the potential to work with any ISI modem. I'm not willing to break that

RE: Selecting multiple radio access technologies in oFono

2011-02-02 Thread Kjetil ASDAL
Hi Lucas, Lucas wrote: I don't know about LTE, but I can effectively disable umts in my huawei modem just by choosing a frequency not available in my country. Then, when going online the modem is forced to use one of the GSM ones. That may very well be so, but I still think this is at

[PATCH 1/2] include: fix comment on dst value

2011-02-02 Thread Jeevaka Badrappan
--- include/types.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/types.h b/include/types.h index 31f2682..d25f409 100644 --- a/include/types.h +++ b/include/types.h @@ -105,7 +105,7 @@ struct ofono_network_time { int mday; /* Day of month

Re: [PATCH 2/2] voicecall: try harder to avoid Dial mismatches

2011-02-02 Thread Pekka Pessi
Hi Denis, 2011/2/2 Denis Kenzior denk...@gmail.com: On 02/01/2011 04:22 PM, pekka.pe...@nokia.com wrote: From: Pekka Pessi pekka.pe...@nokia.com There were some cases where Dial returned an incorrect call object, e.g., after oFono crash and recover. ---  src/voicecall.c |   15

[PATCH] ifx: remove setting to offline during modem enable

2011-02-02 Thread Jeevaka Badrappan
--- plugins/ifx.c | 21 ++--- 1 files changed, 2 insertions(+), 19 deletions(-) diff --git a/plugins/ifx.c b/plugins/ifx.c index 411c012..ae53193 100644 --- a/plugins/ifx.c +++ b/plugins/ifx.c @@ -345,23 +345,6 @@ error: ofono_modem_set_powered(modem, FALSE); }

RE: [PATCH] ifx: remove setting to offline during modem enable

2011-02-02 Thread Predon, Frederic
Hi Marcel, plugins/ifx.c | 21 ++--- 1 files changed, 2 insertions(+), 19 deletions(-) diff --git a/plugins/ifx.c b/plugins/ifx.c index 411c012..ae53193 100644 --- a/plugins/ifx.c +++ b/plugins/ifx.c @@ -345,23 +345,6 @@ error:

RE: [PATCH v8] ifx: Adding modem selftest for Infineon modem

2011-02-02 Thread Ramakrishna, AnandX
Hi Marcel, I am replying to this email behalf of Robertino. I appreciate if you can review my comments/proposed solution before I submit the next patch. -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Marcel Holtmann Sent: Tuesday,

RE: [PATCH] ifx: remove setting to offline during modem enable

2011-02-02 Thread Marcel Holtmann
Hi Fred, plugins/ifx.c | 21 ++--- 1 files changed, 2 insertions(+), 19 deletions(-) diff --git a/plugins/ifx.c b/plugins/ifx.c index 411c012..ae53193 100644 --- a/plugins/ifx.c +++ b/plugins/ifx.c @@ -345,23 +345,6 @@ error:

[RFC] voicecall API changes (proposal 2)

2011-02-02 Thread Andras Domokos
--- doc/call-barring-api.txt | 10 -- doc/voicecall-api.txt| 17 + doc/voicecallmanager-api.txt | 28 3 files changed, 45 insertions(+), 10 deletions(-) diff --git a/doc/call-barring-api.txt b/doc/call-barring-api.txt index

RE: [PATCH] ifx: remove setting to offline during modem enable

2011-02-02 Thread Predon, Frederic
Hi Marcel, I toughth we talked about CFUN=4 in ifx_disable on IRC. This one is needed to bring the modem up in offline mode. I'd rather not remove this one. In a ideal world, the CFUN=4 in the dlc_setup will not be needed because the modem remembers is last state and will remain

Re: [PATCH 1/8] bluetooth: add server support

2011-02-02 Thread Gustavo F. Padovan
Hi Frederic, * Frederic Danis frederic.da...@linux.intel.com [2011-02-01 15:17:56 +0100]: Hello Gustavo, Le 31/01/2011 21:51, Gustavo F. Padovan a écrit : Initial code to have support to listen over a RFCOMM socket for incoming connections. --- Makefile.am |1 +

RE: [PATCH v8] ifx: Adding modem selftest for Infineon modem

2011-02-02 Thread Ramakrishna, AnandX
Hi Marcel, I am resending this email as MS outlook was fast before I could format the message. Sorry for that. -Original Message- From: Ramakrishna, AnandX Sent: Wednesday, February 02, 2011 10:08 AM To: ofono@ofono.org Subject: RE: [PATCH v8] ifx: Adding modem selftest for Infineon

[PATCH] smart-messaging: set agent to NULL after free

2011-02-02 Thread Lucas De Marchi
If agent is not set to NULL after it's freed, the following situation would not work: smart_messaging_register_agent() smart_messaging_unregister_agent() smart_messaging_register_agent() And this one could potentially crash oFono: smart_messaging_register_agent()

Re: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Denis Kenzior
Hi Mikhail, Am I right in assuming that the SMS history roundtrip is not performed before acking the constituent TPDUs to the network? If it is, we have problems even regardless of D-Bus method call timeouts. This has been discussed to death a bazillion times. So lets recap very

Re: [PATCH] smart-messaging: set agent to NULL after free

2011-02-02 Thread Denis Kenzior
Hi Lucas, On 02/02/2011 12:53 PM, Lucas De Marchi wrote: If agent is not set to NULL after it's freed, the following situation would not work: smart_messaging_register_agent() smart_messaging_unregister_agent() smart_messaging_register_agent() And this one could potentially crash oFono:

Re: [RFC] voicecall API changes (proposal 2)

2011-02-02 Thread Denis Kenzior
Hi Andras, + + boolean ForwardedCall + + Contains the indication whether the incoming voice call + is a redirected call due to a call forwarding operation + or not. Please drop the Call suffix, you are already on the

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Kai.Vehmanen
Hello Marcel, On 02 Feb 2011, Marcel Holtmann wrote: - This relates to another TODO - persistant storage of RX-TPDUs for incomplete messages. If we've acked a TPDU to network, we must have stored it to persistant storage. Where are we not doing this. We do store the

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Kai.Vehmanen
Hi Denis, On 02 Feb 2011, Denis Kenzior wrote: Another fun fact about CMT delivery is that if you do not ack in a 'reasonable' amount of time, the modem _silently_ turns off SMS delivery. So putting acks over D-Bus is simply a bad idea. ack, very much agreed. And now that I realized RX

RE: [RFC 2/2] doc: Add description for history agent interface

2011-02-02 Thread Marcel Holtmann
Hi Kai, So yes, there might be conditions where you crash before fsync really completes and you lose the SMS. However, there's nothing in the world you can do about this case anyway, since both the write and the fsync succeeded. I think this is perfectly reasonable. Even if some