[PATCH] common: '+' is not valid phone number anymore

2011-02-24 Thread Paavo Leinonen
Reject phone number if it contains only plus sign. --- Hi, Originally this issue was found while testing Call Forwarding. If user would set call fowarding to number '+', oFono actually erased existing CF settings. Fix was made to common.c as I don't think plus should be considered as a valid

Re: [PATCH] atmodem: CEREG support for LTE network status reporting in AT modem

2011-02-24 Thread Arun Ravindran
Hi Denis, -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Denis Kenzior Sent: Wednesday, February 23, 2011 5:50 PM To: ofono@ofono.org Cc: tomasz.grego...@gmail.com Subject: Re: [PATCH] atmodem: CEREG support for LTE network status reporting

Re: [PATCH 1/2] emulator: add CMER support

2011-02-24 Thread Frederic Danis
Hi Denis Le 23/02/2011 21:13, Denis Kenzior a écrit : Hi Frédéric, On 02/23/2011 01:00 PM, Frédéric Danis wrote: --- src/emulator.c | 107 ++- 1 files changed, 105 insertions(+), 2 deletions(-) I applied this patch, but one comment

Re: [RFC PATCH 2/3] ssn: add code and call id to notifications

2011-02-24 Thread Andras Domokos
Hi Denis and Sankar, The call SS notification handling patches hasn't been (fully) applied, I think we need to do something about it. Regards, Andras On 02/22/2011 02:07 PM, ext Sankar wrote: Hi Denis/Andras, Is this patch applied and available in the GIT? Regards, Sankar. On Thu, Feb

Re: [RFC PATCH 2/3] ssn: add code and call id to notifications

2011-02-24 Thread Denis Kenzior
Hi Andras, Please no top posting on this mailing list. You should know this by now. On 02/24/2011 05:43 AM, Andras Domokos wrote: Hi Denis and Sankar, The call SS notification handling patches hasn't been (fully) applied, I think we need to do something about it. I'd still like a

[PATCH 0/2] add support of void parameters in CMER

2011-02-24 Thread Frédéric Danis
following commands are supported : AT+CMER=3,0,0,1,0 OK AT+CMER=3,0,0,1 OK AT+CMER=3,,,1 OK AT+CMER=3,,,1, OK AT+CMER=,,0,1, OK AT+CMER=3, ,,1 OK AT+CMER=3,a,0,1 ERROR AT+CMER=3,a,0,1 ERROR AT+CMER=3, OK AT+CMER=3 OK Frédéric Danis (2): gatchat: add

[PATCH 2/2] emulator: add support of void parameters in CMER

2011-02-24 Thread Frédéric Danis
--- src/emulator.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index 4896ae1..c4bc505 100644 --- a/src/emulator.c +++ b/src/emulator.c @@ -312,23 +312,23 @@ static void cmer_cb(GAtServer *server,

[PATCH 1/2] gatchat: add g_at_result_iter_next_number_or_void API

2011-02-24 Thread Frédéric Danis
--- gatchat/gatresult.c | 25 + gatchat/gatresult.h |2 ++ 2 files changed, 27 insertions(+), 0 deletions(-) diff --git a/gatchat/gatresult.c b/gatchat/gatresult.c index 8a6dfae..0003f0b 100644 --- a/gatchat/gatresult.c +++ b/gatchat/gatresult.c @@ -292,6 +292,31 @@

Re: [PATCH] common: '+' is not valid phone number anymore

2011-02-24 Thread Denis Kenzior
Hi Paavo, On 02/24/2011 02:33 AM, Paavo Leinonen wrote: Reject phone number if it contains only plus sign. --- Hi, Originally this issue was found while testing Call Forwarding. If user would set call fowarding to number '+', oFono actually erased existing CF settings. Fix was made to

Re: [PATCH 1/2] gatchat: add g_at_result_iter_next_number_or_void API

2011-02-24 Thread Marcel Holtmann
Hi Fred, gatchat/gatresult.c | 25 + gatchat/gatresult.h |2 ++ 2 files changed, 27 insertions(+), 0 deletions(-) diff --git a/gatchat/gatresult.c b/gatchat/gatresult.c index 8a6dfae..0003f0b 100644 --- a/gatchat/gatresult.c +++ b/gatchat/gatresult.c @@

Re: [RFC PATCH 2/3] ssn: add code and call id to notifications

2011-02-24 Thread Andras Domokos
Hi, On 02/24/2011 05:43 PM, ext Denis Kenzior wrote: Hi Andras, Please no top posting on this mailing list. You should know this by now. I am terribly sorry, I know I should have not done that. On 02/24/2011 05:43 AM, Andras Domokos wrote: Hi Denis and Sankar, The call SS notification

Re: [PATCH] atmodem: CEREG support for LTE network status reporting in AT modem

2011-02-24 Thread Denis Kenzior
Hi Arun, On 02/24/2011 04:34 AM, Arun Ravindran wrote: Hi Denis, -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Denis Kenzior Sent: Wednesday, February 23, 2011 5:50 PM To: ofono@ofono.org Cc: tomasz.grego...@gmail.com Subject: Re:

Re: [RFC PATCH 2/3] ssn: add code and call id to notifications

2011-02-24 Thread Denis Kenzior
Hi Andras, The call SS notification handling patches hasn't been (fully) applied, I think we need to do something about it. I'd still like a version with the SSN atom removed. OK, I am going to remove the SSN atom, not a big deal, but do you have any other issues at this point? Not right

Re: [RFC PATCH 2/3] ssn: add code and call id to notifications

2011-02-24 Thread Andras Domokos
Hi Denis, On 02/24/2011 06:14 PM, ext Denis Kenzior wrote: Hi Andras, The call SS notification handling patches hasn't been (fully) applied, I think we need to do something about it. I'd still like a version with the SSN atom removed. OK, I am going to remove the SSN atom, not a big deal,

[PATCH 2/2] emulator: add support of void parameters in CMER

2011-02-24 Thread Frédéric Danis
--- src/emulator.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/emulator.c b/src/emulator.c index 9cd3252..20a575f 100644 --- a/src/emulator.c +++ b/src/emulator.c @@ -312,7 +312,7 @@ static void cmer_cb(GAtServer *server,

[PATCH v2 0/2] add support of void parameters in CMER

2011-02-24 Thread Frédéric Danis
following commands are supported : AT+CMER=3,0,0,1,0 OK AT+CMER=3,0,0,1 OK AT+CMER=3,,,1 OK AT+CMER=3,,,1, OK AT+CMER=,,0,1, OK AT+CMER=3, ,,1 OK AT+CMER=3,a,0,1 ERROR AT+CMER=3,a,0,1 ERROR AT+CMER=3, OK AT+CMER=3 OK Frédéric Danis (2): gatchat: add

Re: ofono crash (setting offline while connected)

2011-02-24 Thread Denis Kenzior
Hi Amit, On 02/23/2011 11:07 PM, Amit Mendapara wrote: Hi, While testing the Linktop driver I observed that ofono is crashing if I try to set modem offline while it is connected (using test/offline-modem.py script). After some debugging, I found that `linktop_disconnect` function is being

Re: [PATCH v2 0/2] add support of void parameters in CMER

2011-02-24 Thread Denis Kenzior
Hi Frédéric, On 02/24/2011 11:16 AM, Frédéric Danis wrote: following commands are supported : AT+CMER=3,0,0,1,0 OK AT+CMER=3,0,0,1 OK AT+CMER=3,,,1 OK AT+CMER=3,,,1, OK AT+CMER=,,0,1, OK AT+CMER=3, ,,1 OK AT+CMER=3,a,0,1 ERROR AT+CMER=3,a,0,1 ERROR AT+CMER=3,

Re: [PATCH] sim: showing lock state with call meter

2011-02-24 Thread Denis Kenzior
Hi Jussi, On 02/23/2011 09:24 AM, Jussi Kangas wrote: Hi, On Wed, 2011-02-23 at 08:15 +0200, Denis Kenzior wrote: - if (pin_type != OFONO_SIM_PASSWORD_NONE - sim-state == OFONO_SIM_STATE_READY) { + if ((pin_type != OFONO_SIM_PASSWORD_NONE +