Re: [PATCH] gemalto: Add more details in setup_gemalto comment

Hi Bassem, On 03/16/2018 12:21 PM, Bassem Boubaker wrote: ALS3, PLS8-E and PLS8-X have same vid/pid with same enumeration process --- plugins/udevng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Regards, -Denis

[PATCH] gemalto: Add more details in setup_gemalto comment

ALS3, PLS8-E and PLS8-X have same vid/pid with same enumeration process --- plugins/udevng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/udevng.c b/plugins/udevng.c index 6b5b015..ff5d41a 100644 --- a/plugins/udevng.c +++ b/plugins/udevng.c @@ -1146,7

Re: [PATCH 2/6] gemalto: support ALS3 in gemalto's plugin

Hi Gabriel, @@ -300,29 +322,24 @@ static int gemalto_hardware_monitor_enable(struct ofono_modem *modem) return 0; } -static int gemalto_enable(struct ofono_modem *modem) +static void gemalto_initialize(struct ofono_modem *modem) { struct gemalto_data *data =

[PATCH 2/6] gemalto: support ALS3 in gemalto's plugin

Force serial port opening options Wait for modem to be ready to start initializing it Handle LTE --- plugins/gemalto.c | 107 -- 1 file changed, 95 insertions(+), 12 deletions(-) diff --git a/plugins/gemalto.c b/plugins/gemalto.c index

[PATCH 2/6] gemalto: support ALS3 in gemalto's plugin

Force serial port opening options Wait for modem to be ready to start initializing it Handle LTE --- plugins/gemalto.c | 106 +++--- 1 file changed, 94 insertions(+), 12 deletions(-) diff --git a/plugins/gemalto.c b/plugins/gemalto.c index

[PATCH 2/6] gemalto: support ALS3 in gemalto's plugin

Force serial port opening options Wait for modem to be ready to start initializing it Handle LTE --- plugins/gemalto.c | 106 +++--- 1 file changed, 94 insertions(+), 12 deletions(-) diff --git a/plugins/gemalto.c b/plugins/gemalto.c index

Re: [PATCH 3/6] gemalto: acquire the network technology

Thanks Denis. My apologies for the unused variable. On 2018-03-16 15:27, Denis Kenzior wrote: Hi Gabriel, Mariem, On 03/16/2018 07:59 AM, Gabriel Lucas wrote: From: Mariem Cherif --- drivers/atmodem/network-registration.c | 45 ++

Re: [PATCH] Fix bug with "PropertyChanged" signals not being emmitted by ofono for org.ofono.cdma.NetworkRegistration

Hi Bassem, On 03/16/2018 10:24 AM, Bassem Boubaker wrote: Signed-off-by: Bassem Boubaker We don't use Signed-off-by, so please update your configuration not to include this. I've removed this manually and ... --- src/cdma-netreg.c | 2 ++ 1 file changed, 2

[PATCH] Fix bug with "PropertyChanged" signals not being emmitted by ofono for org.ofono.cdma.NetworkRegistration

Signed-off-by: Bassem Boubaker --- src/cdma-netreg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cdma-netreg.c b/src/cdma-netreg.c index ba9ee23..23616d9 100644 --- a/src/cdma-netreg.c +++ b/src/cdma-netreg.c @@ -115,6 +115,8 @@ static const

Re: [PATCH 3/6] gemalto: acquire the network technology

Hi Gabriel, Mariem, On 03/16/2018 07:59 AM, Gabriel Lucas wrote: From: Mariem Cherif --- drivers/atmodem/network-registration.c | 45 ++ 1 file changed, 45 insertions(+) When applying this patch I got: CC

Re: [PATCH 2/6] gemalto: support ALS3 in gemalto's plugin

Hi Gabriel,   { >>>   struct gemalto_data *data = ofono_modem_get_data(modem);   const char *app, *mdm;   -    DBG("%p", modem); +    /* Close devices */ +    g_at_chat_unref(data->mdm); +    g_at_chat_unref(data->app); + Why would you close both devices?  It is unnecessary,

Re: [PATCH 4/6] gemalto: handle sim is inserted or removed URCs

Hi Gabriel, On 03/16/2018 08:28 AM, Gabriel Lucas wrote: Hi Denis, On 15/03/2018 18:26, Denis Kenzior wrote: Hi Gabriel, On 03/15/2018 07:49 AM, Gabriel Lucas wrote: From: Mariem Cherif +    g_at_result_iter_init(, result); + +    if (!g_at_result_iter_next(,

Re: [PATCH 6/6] gemalto: fix sim reinsertion issue

Hi Denis, On 15/03/2018 18:29, Denis Kenzior wrote: Hi Gabriel, Why don't you just use at_util_sim_state_query_new here? Well, because I didn't know it existed :). Thanks, I going to use it. Best regards, Gabriel ___ ofono mailing list

Re: [PATCH 4/6] gemalto: handle sim is inserted or removed URCs

Hi Denis, On 15/03/2018 18:26, Denis Kenzior wrote: Hi Gabriel, On 03/15/2018 07:49 AM, Gabriel Lucas wrote: From: Mariem Cherif +    g_at_result_iter_init(, result); + +    if (!g_at_result_iter_next(, "+CIEV:")) +    return; + So generally +CIEV

[PATCH 3/6] gemalto: acquire the network technology

From: Mariem Cherif --- drivers/atmodem/network-registration.c | 45 ++ 1 file changed, 45 insertions(+) diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c index a5e2af3..80f6291 100644 ---

Re: [PATCH 3/6] gemalto: acquire the network technology

Hi Denis, Really sorry, this patch is from Mariem and I haven't reviewed it. the cinterion_parse_tech function really needs to be rework. I'll resend you a cleaner version today. On 15/03/2018 18:19, Denis Kenzior wrote: Hi Gabriel, On 03/15/2018 07:49 AM, Gabriel Lucas wrote: From: Mariem

Re: [PATCH 2/6] gemalto: support ALS3 in gemalto's plugin

Hi Denis, On 15/03/2018 18:11, Denis Kenzior wrote: No // please, use /* */.  This is C code ;) Fixed. I've just learned it was not ANSI C :). You leak options here in case channel == NULL.  The typical pattern is to call g_hash_table_destroy(options) right after g_at_tty_open.  See other