Re: [PATCH] test: make all files executable

Hi David, On 11/17/19 4:03 PM, David Lechner wrote: This sets the executable bit on the only two files in the test directory that do not already have it set. --- test/set-sms-alphabet | 0 test/test-serving-cell-info | 0 2 files changed, 0 insertions(+), 0 deletions(-) mode change 1

Re: [PATCH phonesim 12/13] Annotate overriding functions with override

Hi Jonah, On 11/12/19 3:37 PM, Jonah Brüchert wrote: * Allows us to notice when a function becomes source incompatible in a Qt major release, and our implementation stops overriding. --- src/aidapplication.cpp | 3 ++- src/aidapplication.h| 4 ++-- src/callmanager.h

Re: [PATCH phonesim 13/13] Use bool literals

Hi Jonah, On 11/12/19 3:37 PM, Jonah Brüchert wrote: Done using the modernize-use-bool-literals of clang-tidy --- src/qsmsmessage.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Regards, -Denis ___ ofono mailing list -

Re: [PATCH phonesim 11/13] Use dynamic_cast where appropriate

Hi Jonah, On 11/12/19 3:37 PM, Jonah Brüchert wrote: Done using the cppcoreguidelines-pro-type-cstyle-cast check of clang-tidy --- src/aidapplication.cpp | 2 +- src/phonesim.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) Applied, thanks. Regards, -Denis ___

Re: [PATCH phonesim 10/13] Port from c-style casts to static_cast<>()

Hi Jonah, On 11/12/19 3:37 PM, Jonah Brüchert wrote: Done using the google-readability-casting check of clang-tidy --- src/callmanager.cpp | 6 +- src/hardwaremanipulator.cpp | 12 +- src/phonesim.cpp | 62 +++--- src/qatresult.cpp| 10 +- src/qatresu

Re: [PATCH phonesim 04/13] Replace QtScript with QtQml

Hi Jonah, On 11/12/19 3:37 PM, Jonah Brüchert wrote: --- configure.ac| 2 +- src/control.cpp | 18 +- src/control.h | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) Patches 4-9 applied, thanks. Regards, -Denis _

Re: [PATCH phonesim 03/13] Port old-style connects

Hi Jonah, On 11/12/19 3:37 PM, Jonah Brüchert wrote: * Update CXX Standard to 14 to be able to use qOverload() --- configure.ac| 4 +-- src/callmanager.cpp | 22 ++--- src/control.cpp | 77 + src/phonesim.cpp| 56 +

Re: [PATCH phonesim 01/13] Use nullptrs

Hi Jonah, On 11/12/19 3:37 PM, Jonah Brüchert wrote: Done using the modernize-use-nullptr check of clang-tidy --- src/aidapplication.h | 2 +- src/callmanager.h | 2 +- src/conformancesimapplication.cpp | 2 +- src/control.cpp | 2 +- src/