Re: [Meego-handset] ofono-qt - anything to add/improve?

2011-07-05 Thread Antoine Reversat
Also from what I've heard the dialer is going to use ofono-qt at some point. It would probably be good to have the insight of Shane or Tom on what's missing, what needs to be improved, etc. Unfortunately I think Shane is on vacation. 2011/7/5 jukka.ekl...@nokia.com: Right, so CE specifically

[PATCH] Add CNAP support for isimodem

2011-02-25 Thread Antoine Reversat
--- drivers/isimodem/voicecall.c | 50 + src/voicecall.c |5 ++- 2 files changed, 48 insertions(+), 7 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index 0a32f27..37b0eb3 100644 ---

Re: [PATCH] Add CNAP support for isimodem

2011-02-25 Thread Antoine Reversat
This one should be clean. Sorry it created a new email. I specified a message-id but it don't see it as a reply to my mail in gmail here. On Fri, Feb 25, 2011 at 11:28 AM, Antoine Reversat a.rever...@gmail.com wrote: ---  drivers/isimodem/voicecall.c |   50

Re: [PATCH] Add CNAP support for isimodem

2011-02-25 Thread Antoine Reversat
Should I have made a second patch for the code cleanup to isi_call_any_address_sb_proc ? On Fri, Feb 25, 2011 at 11:33 AM, Antoine Reversat a.rever...@gmail.com wrote: This one should be clean. Sorry it created a new email. I specified a message-id but it don't see it as a reply to my mail

Re: [PATCH] Add CNAP support for isimodem

2011-02-25 Thread Antoine Reversat
On Fri, Feb 25, 2011 at 11:53 AM, Gustavo F. Padovan pado...@profusion.mobi wrote: Hy Antoine, Top posting is not allowed on this mailing list. Please stop using it. Sorry about that. A separate patch for this change. Will do. -- Gustavo F. Padovan http://profusion.mobi

[PATCH 1/2] Clean up isi_call_any_address_sb_proc

2011-02-25 Thread Antoine Reversat
--- drivers/isimodem/voicecall.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index 0a32f27..0ad4dfb 100644 --- a/drivers/isimodem/voicecall.c +++ b/drivers/isimodem/voicecall.c @@ -210,10 +210,13 @@

[PATCH 2/2] Add CNAP support for isimodem

2011-02-25 Thread Antoine Reversat
--- drivers/isimodem/voicecall.c | 39 ++- src/voicecall.c |5 +++-- 2 files changed, 41 insertions(+), 3 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index 0ad4dfb..37b0eb3 100644 ---

[PATCH 1/3] Clean up isi_call_any_address_sb_proc

2011-02-25 Thread Antoine Reversat
--- drivers/isimodem/voicecall.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index 0a32f27..0f9753b 100644 --- a/drivers/isimodem/voicecall.c +++ b/drivers/isimodem/voicecall.c @@ -210,10

[PATCH 2/3] Add CNAP support for isimodem

2011-02-25 Thread Antoine Reversat
--- drivers/isimodem/voicecall.c | 42 +- 1 files changed, 41 insertions(+), 1 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index 0f9753b..0870556 100644 --- a/drivers/isimodem/voicecall.c +++

[PATCH 3/3] Add CNAP debugging ofono voicecall

2011-02-25 Thread Antoine Reversat
--- src/voicecall.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index d6e8539..ec001c0 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -1951,8 +1951,9 @@ void ofono_voicecall_notify(struct ofono_voicecall *vc, struct

Re: [PATCH] Add CNAP to isimodem driver

2011-02-22 Thread Antoine Reversat
Has anyone have time to review this patch ? On Sat, Feb 19, 2011 at 6:58 PM, Antoine Reversat a.rever...@gmail.com wrote: This patch adds CNAP support to the isimodem driver. Sorry if it's ugly or wrong, it's my first patch to this project. I have tested it and it works though (I get

[PATCH] Add CNAP support (callerid name presentation) to isimodem

2011-02-22 Thread Antoine Reversat
--- drivers/isimodem/voicecall.c | 39 ++- src/voicecall.c |4 ++-- 2 files changed, 40 insertions(+), 3 deletions(-) diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/voicecall.c index 0a32f27..e778f23 100644 ---

Re: [PATCH] Add CNAP support (callerid name presentation) to isimodem

2011-02-22 Thread Antoine Reversat
On Tue, Feb 22, 2011 at 4:22 PM, Gustavo F. Padovan pado...@profusion.mobi wrote: Hi Antoine, Hi +     if (!g_isi_sb_iter_get_byte(sb, pres, 2) || +                     !g_isi_sb_iter_get_byte(sb, id, 6) || +                     !g_isi_sb_iter_get_byte(sb, len, 7) || +                    

[PATCH] Add CNAP to isimodem driver

2011-02-19 Thread Antoine Reversat
This patch adds CNAP support to the isimodem driver. Sorry if it's ugly or wrong, it's my first patch to this project. I have tested it and it works though (I get the callerid name as the Name property of an incoming voicecall). diff --git a/drivers/isimodem/voicecall.c

Modem reboots when trying to activate a ConnectionContext

2011-02-18 Thread Antoine Reversat
This is on an N900 running nitdroid gingerbread with a 2.6.35.9 kernel and ofono 0.42 When I do this : dbus-send --system --print-reply --dest=org.ofono /isimodem/context2 org.ofono.ConnectionContext.SetProperty string:Active variant:boolean:true I get back : Error org.ofono.Error.Failed:

Re: Modem reboots when trying to activate a ConnectionContext

2011-02-18 Thread Antoine Reversat
? It is also the case for GPDS_CONTEXT_AUTH_REQ. On Fri, Feb 18, 2011 at 11:55 AM, Antoine Reversat a.rever...@gmail.com wrote: This is on an N900 running nitdroid gingerbread with a 2.6.35.9 kernel and ofono 0.42 When I do this : dbus-send --system --print-reply --dest=org.ofono /isimodem/context2

Re: Modem reboots when trying to activate a ConnectionContext

2011-02-18 Thread Antoine Reversat
. Is this right or am I missing something ? It is also the case for GPDS_CONTEXT_AUTH_REQ. On Fri, Feb 18, 2011 at 11:55 AM, Antoine Reversat a.rever...@gmail.com wrote: This is on an N900 running nitdroid gingerbread with a 2.6.35.9 kernel and ofono 0.42 When I do this : dbus-send --system --print