Re: [PATCHv5 1/4] sim-auth: implementation of core sim-auth atom

Hi James, On 10/12/2017 11:28 AM, James Prestwood wrote: The sim-auth module atom can now be used for SIM application discovery and authentication. The atom will automatically discover SIM applications available on the SIM and register a new DBus object under the modem, whos name is the AID

Re: [PATCHv4 4/6] phonesim: Added sim-auth to phonesim plugin

On 10/11/2017 06:22 PM, James Prestwood wrote: --- plugins/phonesim.c | 4 1 file changed, 4 insertions(+) diff --git a/plugins/phonesim.c b/plugins/phonesim.c index 16bccd5..345c41e 100644 --- a/plugins/phonesim.c +++ b/plugins/phonesim.c @@ -61,6 +61,7 @@ #include #include

Re: [PATCHv4 3/6] xmm7xxx: add sim-auth driver to xmm7xxx plugin

Hi James, On 10/11/2017 06:22 PM, James Prestwood wrote: --- plugins/xmm7xxx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/xmm7xxx.c b/plugins/xmm7xxx.c index 5cb843b..ff0cb4c 100644 --- a/plugins/xmm7xxx.c +++ b/plugins/xmm7xxx.c @@ -49,6 +49,7 @@ #include #include

Re: [PATCHv4 5/6] test: added tests for GSM/UMTS auth algorithms

Hi James, On 10/11/2017 06:22 PM, James Prestwood wrote: --- test/run-isim-umts-auth | 38 ++ test/run-usim-gsm-auth | 36 2 files changed, 74 insertions(+) create mode 100755 test/run-isim-umts-auth create mode

Re: [PATCHv4 6/6] doc: documentation for SimAuth dbus interfaces

Hi James, On 10/11/2017 06:22 PM, James Prestwood wrote: --- doc/sim-auth-api.txt | 104 +++ 1 file changed, 104 insertions(+) create mode 100644 doc/sim-auth-api.txt Applied, thanks. Regards, -Denis

Re: [PATCHv4 1/6] sim-auth: implementation of core sim-auth atom

Hi James, On 10/11/2017 06:22 PM, James Prestwood wrote: The sim-auth module atom can now be used for SIM application discovery and authentication. The atom will automatically discover SIM applications available on the SIM and register a new DBus object under the modem, whos name is the AID

Re: [PATCHv3 2/7] sim-auth: implementation of core sim-auth atom

Hi James, On 10/11/2017 01:57 PM, James Prestwood wrote: The sim-auth module atom can now be used for SIM application discovery and authentication. The atom will automatically discover SIM applications available on the SIM and register a new DBus object under the modem, whos name is the AID

Re: [PATCHv3 7/7] doc: documentation for SimAuth dbus interfaces

Hi James, On 10/11/2017 01:57 PM, James Prestwood wrote: --- doc/sim-auth-api.txt | 101 +++ 1 file changed, 101 insertions(+) create mode 100644 doc/sim-auth-api.txt diff --git a/doc/sim-auth-api.txt b/doc/sim-auth-api.txt new file mode

Re: [PATCHv3 1/7] sim-auth: prep simauth/dbus headers

Hi James, On 10/11/2017 01:57 PM, James Prestwood wrote: Added new dbus interfaces for SimAuth module as well as function prototype definitions to simauth header. org.ofono.SimAuthentication: Interface to hold the auth object to type mapping property org.ofono.USimApplication:

Re: [PATCHv2 11/11] doc: documentation for SimAuth dbus interfaces

Hi James, On 10/10/2017 04:36 PM, James Prestwood wrote: --- doc/sim-auth-api.txt | 78 1 file changed, 78 insertions(+) create mode 100644 doc/sim-auth-api.txt diff --git a/doc/sim-auth-api.txt b/doc/sim-auth-api.txt new file mode

Re: [PATCHv2 05/11] sim-auth: prep simauth/dbus headers

Hi James, On 10/10/2017 04:36 PM, James Prestwood wrote: Added new dbus interfaces for SimAuth module as well as function prototype definitions to simauth header. org.ofono.SimAuthentication: Interface to hold the auth object to type mapping property org.ofono.USimApplication:

Re: [PATCHv2 04/11] sim: new API to check for a UST service only

Hi James, On 10/10/2017 04:36 PM, James Prestwood wrote: The existing service check API takes both SST and UST services and could inadvertently return success on a service if one (SST or UST) service did not exist. This adds an API specifically for checking for a UST service, and if the UST dir

Re: [PATCHv2 02/11] simutil: Added authenticate builder/parser API

Hi James, On 10/10/2017 04:36 PM, James Prestwood wrote: Used to compose/parse non-TLV formatted authenticate commands for GSM and UMTS authentication. --- src/simutil.c | 130 ++ src/simutil.h | 14 +++ 2 files changed, 144

Re: [PATCHv2 01/11] simutil: Added app type to application parser

Hi James, On 10/10/2017 04:36 PM, James Prestwood wrote: Parsing a SIM application only copied the 16 byte AID portion, which included the application type. Parsing out the type makes sorting much easier for modules using the parser. --- src/simutil.c | 2 ++ src/simutil.h | 12

Re: [PATCH 5/6] xmm7modem: Add support for ims

Hi Ankit, On 10/05/2017 12:15 PM, Ankit Navik wrote: --- plugins/xmm7xxx.c | 2 ++ 1 file changed, 2 insertions(+) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono

Re: [PATCH 4/6] xmm7modem: Add ims atom driver

Hi Ankit, On 10/05/2017 12:15 PM, Ankit Navik wrote: --- Makefile.am | 3 +- drivers/xmm7modem/ims.c | 255 ++ drivers/xmm7modem/xmm7modem.c | 2 + drivers/xmm7modem/xmm7modem.h | 3 + plugins/xmm7xxx.c |

Re: [PATCH 3/6] ims: add implementation for IMS atom

Hi Ankit, On 10/05/2017 12:15 PM, Ankit Navik wrote: This implementation includes: * D-Bus interface * interaction with driver --- Makefile.am | 2 +- src/ims.c | 389 src/ofono.h | 2 + 3 files changed, 392 insertions(+),

Re: [PATCH 6/6] test: add scripts to test ims registration

Hi Ankit, On 10/04/2017 12:07 AM, Ankit Navik wrote: --- Makefile.am | 4 +++- test/ims-register | 18 ++ test/ims-unregister | 18 ++ 3 files changed, 39 insertions(+), 1 deletion(-) create mode 100755 test/ims-register create mode 100755

Re: [PATCH 1/6] doc: add ims atom documentation

Hi Ankit, On 10/03/2017 10:42 PM, Ankit Navik wrote: --- Makefile.am | 3 ++- doc/ims-api.txt | 60 + 2 files changed, 62 insertions(+), 1 deletion(-) create mode 100755 doc/ims-api.txt Patch 1 & 2 applied, thanks. Regards,

Re: [PATCH 4/6] xmm7modem: Add ims atom driver

Hi Ankit, On 10/04/2017 12:07 AM, Ankit Navik wrote: --- Makefile.am | 3 +- drivers/xmm7modem/ims.c | 257 ++ drivers/xmm7modem/xmm7modem.c | 2 + drivers/xmm7modem/xmm7modem.h | 3 + plugins/xmm7xxx.c |

Re: [PATCH] nokia-gpio: do not create links to gpios in /dev/cmt

On 09/26/2017 09:56 PM, Clayton Craft wrote: The nokia-gpio plugin should not try to create symlinks to relevant gpio pins under /dev/cmt, since the location it is looking is no longer correct on newer kernels and it might change again in the future. This patch removes code from nokia-gpio that

Re: [PATCH 1/2] include: Add ofono_modem_get_sim

Hi Slava, On 09/29/2017 04:49 AM, Slava Monich wrote: --- include/modem.h | 2 ++ 1 file changed, 2 insertions(+) Both applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono

Re: [PATCH] phonesim: fixup to remove printf from recent commit

Hi James, On 10/04/2017 11:52 AM, James Prestwood wrote: --- src/phonesim.cpp | 2 -- 1 file changed, 2 deletions(-) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono

Re: [PATCH] ublox: Disable DCD to avoid HUP when leaving data mode.

Hi Richard, On 10/04/2017 01:49 PM, Richard Röjfors wrote: The HUP results in errors in gatio which will deref parts of the AT channel. This makes it impossible to recover and send further AT commands after the HUP. --- plugins/ublox.c | 2 ++ 1 file changed, 2 insertions(+) Applied,

Re: [PATCH] doc: Add missing LTE interface to Interfaces list

Hi John, On 10/05/2017 02:14 AM, John Ernberg wrote: From: John Ernberg --- doc/modem-api.txt | 1 + 1 file changed, 1 insertion(+) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] atmodem: Fix use after free in sim_state_cb

Hi Slava, On 10/05/2017 10:36 AM, Slava Monich wrote: ==2941== Invalid read of size 4 ==2941==at 0x69338: sim_state_cb (sim.c:1301) ==2941==by 0x71DCB: cpin_check_cb (atutil.c:567) ==2941==by 0xA602B: at_chat_finish_command (gatchat.c:459) ==2941==by 0xA6277:

Re: [PATCH 2/7] sim-auth: implementation of core sim-auth atom

org.ofono.SimAuthentication on path /modem1 SimAuthentication would have a property with signature 'a{sv}' Applications Actually reminds me that all our other interfaces do it using the array{object,dict} pattern. E.g. array{object,dict} GetModems() array{object,dict} GetCards()

Re: [PATCH 2/7] sim-auth: implementation of core sim-auth atom

Hi James, On 09/26/2017 11:26 AM, James Prestwood wrote: The sim-auth module atom can now be used for SIM application discovery and authentication. The atom will automatically discovery SIM applications available on the SIM and register 'discover' ? a DBus interface for each. These

Re: [PATCH 1/5] comp128: GSM algorithm (comp128) implementation.

Hi James, On 10/03/2017 11:35 AM, James Prestwood wrote: --- src/comp128.c | 247 ++ src/comp128.h | 32 2 files changed, 279 insertions(+) create mode 100644 src/comp128.c create mode 100644 src/comp128.h All 5

Re: [PATCH 7/7] doc: documentation for SimAuth dbus interfaces

Hi James, On 09/21/2017 01:12 PM, James Prestwood wrote: --- doc/sim-auth-api.txt | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 doc/sim-auth-api.txt diff --git a/doc/sim-auth-api.txt b/doc/sim-auth-api.txt new file mode 100644 index 000..466ca3a

Re: [PATCH] huawei: add LTE support

Hi Christophe, On 09/14/2017 03:18 AM, Christophe Ronco wrote: Huawei LTE modems use AT^SYSCFGEX and AT^SYSINFOEX instead of AT^SYSCFG and AT^SYSINFO. If we want to be able to attach on LTE with this modem, we must use AT^SYSCFGEX to configure rat mode and band. Using AT^SYSCFG, mode any means

Re: [PATCH 1/4] atutil: Add logic for cgcontrdp to get address and netmask

Hi Ankit, On 09/12/2017 09:28 PM, Ankit Navik wrote: --- drivers/atmodem/atutil.c | 40 drivers/atmodem/atutil.h | 3 +++ 2 files changed, 43 insertions(+) All four patches have been applied, thanks. Regards, -Denis

Re: Support for samsung-ipc

Hi Tomas, On 09/13/2017 07:45 AM, Tomáš Šafařík wrote: Hello Denis On 09/12/2017 07:36 PM, Denis Kenzior wrote: From what I remember there was an initial RFC submission but the licenses were incompatible there was no follow up after that. I just checked COPYING in libsamsung-ipc

Re: Support for samsung-ipc

Hi Tomas, On 09/12/2017 04:19 PM, Tomáš Šafařík wrote: Hello Denis, Please no top-posting on this mailing list. I noticed that Simon uses also different email on github. So I also added it to CC just in case. I would like to ask other question - there is some ofono driver for ril if I

Re: [PATCH v2 0/3] QMI NetworkMonitor

Hi Jonas, On 09/12/2017 05:52 AM, Jonas Bonn wrote: This is a resubmission of the network-monitor series for QMI modems. Changes in v2: * Fix endianess errors * Add patch to fix out of tree build Jonas Bonn (3): Fix out of tree build qmi: add NetworkMonitor interface gobi: create

Re: [PATCH v2] qmimodem: implement SIM write functions

Hi Joey, On 09/10/2017 12:48 AM, Joey Hewitt wrote: --- Hi Denis, Sorry about the style issues. I think I've cleaned them all up here, and implemented the other tweaks. -Joey drivers/qmimodem/sim.c | 121 + 1 file changed, 121 insertions(+)

Re: Support for samsung-ipc

Hi Tomas, On 09/12/2017 08:24 AM, Tomáš Šafařík wrote: Hello, I would like to ask about support for Samsung devices that use IPC like i9100 (galaxys2). I would like to get it work for postmarketOS project - http:/wiki.postmarketos.org / I found this old post

Re: [PATCH] netmonagent: fix unnecessary function declaration

Hi Nishanth, On 09/12/2017 04:01 AM, Nishanth V wrote: --- src/netmonagent.h | 2 -- 1 file changed, 2 deletions(-) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono

Re: [PATCH 1/2] udev: fixes for detection of non-USB modems

Hi Jonas, On 09/12/2017 03:11 AM, Jonas Bonn wrote: This patch fixes up some fallout from the merging of the udev and udevng modules. i) The 'serial' modems in question are not necessarily serial modems at all; for example, the N900 ISI modems appear as network devices and don't have a

Re: nokia-modem (N900) not detected after migration to udevng

Hi Clayton, On 09/11/2017 10:44 AM, Clayton Craft wrote: Hi Denis, The following patches are also necessary to help bring up the isimodem device, I don't think they were accepted/merged. If you need anything else to help get these in, please let me know!

Re: [PATCH 2/2] qmimodem/network-registration: register callbacks after ofono_netreg_register()

Hi Alexander, On 09/10/2017 07:25 PM, Alexander Couzens wrote: When registering callbacks before ofono_netreg_register(), callbacks will use the netreg api which might lead into undefined behaviour, because certain fields aren't yet initilized. --- drivers/qmimodem/network-registration.c | 13

Re: [PATCH 1/2] network.c: notify_status_watches: check for NULL

Hi Alexander, On 09/10/2017 07:25 PM, Alexander Couzens wrote: In rare cases when ofono_netreg_status_notify() is called before ofono_netreg_register() netreg->status_watches is NULL. --- src/network.c | 3 +++ 1 file changed, 3 insertions(+) Applied, thanks. Regards, -Denis

Re: [PATCH] rilmodem: netmon fix missing notify for g_ril_send

Hi Nishanth, On 09/11/2017 01:15 AM, Nishanth V wrote: --- drivers/rilmodem/netmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 1/1] isimodem: Use correct callback for pin status

Hi Clayton, On 09/10/2017 01:41 PM, Clayton Craft wrote: Hi Denis, Ah, ok, I think see what you mean. Sorry for the misunderstanding, and thank you for your patience. I have now implemented a proper query method based on the 2010 patch you referenced. I don't have a PIN set on my SIM, but it

Re: [PATCH] qmimodem: implement SIM write_file_linear

Hi Joey, On 09/10/2017 12:48 AM, Joey Hewitt wrote: cyclic and transparent not enabled, because I haven't tested them. --- I wonder what to do with sw1 and sw2. I've seen in the case of a read, that a file-not-found is converted into a QMI error in addition to the SW values being returned. I'm

Re: [PATCH v2] gobi: enable message waiting atom

Hi Joey, Now that I understand more that the legacy SIM will probably never be able to write SIM files, should the message waiting atom be "half-functional" if it's legacy, or not enabled at all? Does DMS provide support to twiddle the EFmwis/EFmwi/EFmbdn by some other means? From what I

Re: nokia-modem (N900) not detected after migration to udevng

Hi Clayton, On 09/09/2017 12:58 PM, Clayton Craft wrote: Ok, now the modem is initializing (after applying 3 patches from Jonas), I get this seg fault in ofonod when I run the "enable-modem" test script: See https://lists.ofono.org/pipermail/ofono/2017-May/017311.html Regards, -Denis

Re: [PATCH 1/7] netmon: modified api.txt for network monitor agent

Hi Jonas, Why not create a second interface .AsynchNetworkMonitor that sends PropertyChanged signals. This interface can be disabled by default, but can be requested by setting to org.ofono.Modem.AsynchronousNetworkMonitorEnabled to 'true', at which point the interface is created on the

Re: [PATCH 1/7] netmon: modified api.txt for network monitor agent

Hi Slava, On 09/09/2017 04:30 AM, Slava Monich wrote: Hi Denis, Hi Slava, In the Sailfish OS case, one is the positioning helper, and there's the factory test app. That makes it at least two. The factory test app often plays the role of the second client since it's touching pretty much

Re: [PATCH] qmimodem: enable message waiting atom

Hi Joey, On 09/08/2017 08:26 PM, Joey Hewitt wrote: Conditional on one of UIM (SIM), DMS (legacy SIM), or WMS (SMS). --- Tested on my Android phone. It correctly reported VoicemailMailboxNumber, and VoicemailWaiting property when a voicemail was sent. I got an error "Queuing a EF-MWI write to

Re: [PATCH 1/7] netmon: modified api.txt for network monitor agent

Hi Nishanth, On 09/06/2017 11:23 PM, Nishanth V wrote: added new DBUS methods RegisterAgent and UnregisterAgent to Networkmonitor interface so that any client of ofono can register for serving cell updates. Added new agent interface NetworkMonitorAgent with two methods,

Re: [PATCH 7/7] gobi: add location-reporting atom

Hi Jonas, On 09/07/2017 09:40 PM, Jonas Bonn wrote: This patch is submitted as a request for advice: where should these changes go??? The patch is required for Quectel QMI modems to get location-reporting working: the 'aux' AT interface needs to be set up and passed to the location-reporting

Re: [PATCH 4/6] qmimodem: extract network time from serving system

Hi Jonas, + +time_3gpp = qmi_result_get(result, QMI_NAS_RESULT_3GPP_TIME, ); And here: /* Universal Time and Local Time Zone 3GPP */ time_3gpp = qmi_result_get(result, 0x1c, ); (That might be the sound of Denis screaming in the background you hear! :) I'm not sure he'll agree

Re: [PATCH 1/1] Fix compilation on armhf/Musl

Hi Clayton, On 09/08/2017 11:18 AM, Clayton Craft wrote: The following patch is needed to successfully build ofono on armhf with musl (in place of libc) Applied. Please note that I had to hand-apply this patch since it didn't apply cleanly. Are you using the latest git? Also, I split

Re: [PATCH 6/7] udev: fix quectelqmi gps interface

Hi Jonas, On 09/07/2017 09:40 PM, Jonas Bonn wrote: Using location-reporting requires both the 'aux' and 'gps' interfaces; the GPS interface is interface 1, not 2. --- plugins/udevng.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) Applied, thanks. Regards, -Denis

Re: [PATCH 5/7] Add Quectel location-reporting

Hi Jonas, On 09/07/2017 09:40 PM, Jonas Bonn wrote: This adds Quectel-specific functionality for initializing and getting the GPS/NMEA file descriptor. This is common to both AT and QMI modems as the GPS functionality needs to be set up via AT commands in both cases. --- Makefile.am

Re: [PATCH 3/7] qmi: add NetworkMonitor interface

Hi Jonas, On 09/07/2017 09:40 PM, Jonas Bonn wrote: This is a rudimentary implementation that contains technology and RSSI and BitErrorRate, plus RSRQ/RSRP for LTE networks. More data can be added as needed. This implementations uses the 'Get Signal Strength' QMI method to retrieve the data.

Re: [PATCH 2/7] doc: RSSI is also an LTE property

Hi Jonas, On 09/07/2017 09:40 PM, Jonas Bonn wrote: --- doc/networkmonitor-api.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 1/7] qmi: provide AvailableTechnologies in radio-settings

Hi Jonas, On 09/07/2017 09:47 PM, Jonas Bonn wrote: This provides the list of available technologies in the radio-settings atom. The list is queried by the DMS Get Capabilities method; ofono takes care of caching the available technologies for us so we don't need to worry about this method

Re: [PATCH][v2 1/2] voicecall, common: move call_status_to_string() to common

Hi Alexander, On 09/07/2017 05:27 PM, Alexander Couzens wrote: call_status_to_string() is useful for debug output. Change signature to contain enum call_status Replace default case to get compiler warning when new enums added --- src/common.c| 22 ++ src/common.h|

Re: [PATCH 1/6] voicecall, common: promote call_status_to_string() to be public

Hi Alexander, On 09/07/2017 03:22 PM, Alexander Couzens wrote: call_status_to_string() is useful for debug output. Change signature to contain enum call_status Replace default case to get compiler warning when new enums added --- src/common.c| 21 + src/common.h|

Re: [PATCH 6/6] plugins/udevng: use else if instead of if

Hi Alexander, On 09/07/2017 03:23 PM, Alexander Couzens wrote: The same variable is checked in two `if's. --- plugins/udevng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Regards, -Denis ___ ofono mailing list

Re: [PATCH 5/6] gprs: use registration_status_to_string in debug messages

Hi Alexander, On 09/07/2017 03:22 PM, Alexander Couzens wrote: --- src/gprs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 4/6] qmimodem: extract network time from serving system

Hi Alexander, On 09/07/2017 03:22 PM, Alexander Couzens wrote: --- drivers/qmimodem/nas.h | 12 +++ drivers/qmimodem/network-registration.c | 37 + 2 files changed, 49 insertions(+) Applied, thanks. Regards, -Denis

Re: [PATCH 3/6] qmimodem: add strength (in %) to the debug output

Hi Alexander, On 09/07/2017 03:22 PM, Alexander Couzens wrote: --- drivers/qmimodem/network-registration.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] udevng/Sierra: use first cdc-wdm interface

Hi Alexander, On 09/07/2017 02:33 PM, Alexander Couzens wrote: Using the voice firmware on a mc7304 the modem stopped accepting qmi messages on the second cdc-wdm interface. --- plugins/udevng.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) Applied,

Re: [PATCH 3/3] qmi/discovery: sync the qmi state with the modem

Hi Alexander, On 09/07/2017 02:23 PM, Alexander Couzens wrote: The qmi sync call release all previous resources. Only call sync when the CTL service is >= 1.5 --- drivers/qmimodem/qmi.c | 47 +++ drivers/qmimodem/qmi.h | 5 - plugins/gobi.c

Re: [PATCH 2/3] qmi/discovery: include control service into service list

Hi Alexander, On 09/07/2017 02:23 PM, Alexander Couzens wrote: There is no need to exclude it. It helps debugging because the service is now logged. --- drivers/qmimodem/qmi.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/qmimodem/qmi.c

Re: [PATCH 1/3] qmi/discovery: remove useless code

Hi Alexander, On 09/07/2017 02:23 PM, Alexander Couzens wrote: --- drivers/qmimodem/qmi.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/qmimodem/qmi.c b/drivers/qmimodem/qmi.c index c538cb978393..1af86aaccb08 100644 --- a/drivers/qmimodem/qmi.c +++ b/drivers/qmimodem/qmi.c

Re: how to handle ofono_netreg_status_notify() without valid LAC or cellid or status

Hi Alexander, On 09/07/2017 03:49 PM, Alexander Couzens wrote: Hi, I've noticed when using a Quectel EC20 (qmimodem) sometimes I see a LAC and a cellid, sometimes I do not. After looking into it, the problems lies in the ofono plugin api or in the qmimodem driver. I'm unsure where I should fix

Re: [PATCH 5/5] qmi: add NetworkMonitor interface

Hi Jonas, On 09/07/2017 07:11 AM, Jonas Bonn wrote: This is a rudimentary implementation that contains technology, RSSI, and BitErrorRate, plus RSRQ/RSRP for LTE networks. More data can be added as needed. This implementations uses the 'Get Signal Strength' QMI method to retrieve the data.

Re: [PATCH 1/7] netmon: modified api.txt for network monitor agent

Hi Slava, In the Sailfish OS case, one is the positioning helper, and there's the factory test app. That makes it at least two. The factory test app often plays the role of the second client since it's touching pretty much all the important interfaces in the system. And there are 3rd party

Re: [PATCH 3/5] qmi: provide AvailableTechnologies in radio-settings

Hi Jonas, On 09/07/2017 07:11 AM, Jonas Bonn wrote: This provides the list of available technologies in the radio-settings atom. Note that this list is hard-coded and includes LTE unconditionally which is probably not correct for all QMI devices. I don't like this idea. There has to be a

Re: [PATCH 2/5] qmi: implement RAT selection

Hi Jonas, On 09/07/2017 07:11 AM, Jonas Bonn wrote: The QMI radio-settings atom was just a skeleton and did not even implement the mandtory property TechnologyPreference. As such, it probably should never even have been registered for the modem. Nonetheless, this patch puts this mandatory

Re: [PATCH 2/2] atmodem: correctly report lte bearer for huawei modems

Hi Christophe, On 09/06/2017 04:42 AM, Christophe Ronco wrote: --- drivers/atmodem/gprs.c | 22 ++ drivers/atmodem/network-registration.c | 25 + 2 files changed, 47 insertions(+) Applied, thanks. Regards, -Denis

Re: [PATCH 1/2] huawei: add LTE support

Hi Christophe, On 09/06/2017 04:42 AM, Christophe Ronco wrote: Huawei LTE modems use AT^SYSCFGEX and AT^SYSINFOEX instead of AT^SYSCFG and AT^SYSINFO. If we want to be able to attach on LTE with this modem, we must use AT^SYSCFGEX to configure rat mode and band. Using AT^SYSCFG, mode any means

Re: [PATCH 1/7] netmon: modified api.txt for network monitor agent

Hi Slava, On 09/07/2017 08:06 AM, Slava Monich wrote: On 07/09/17 12:47, Jonas Bonn wrote: On 09/07/2017 06:23 AM, Nishanth V wrote: added new DBUS methods RegisterAgent and UnregisterAgent to Networkmonitor interface so that any client of ofono can register for serving cell updates. Added

Re: [PATCH 1/7] netmon: modified api.txt for network monitor agent

Hi Jonas, On 09/07/2017 04:47 AM, Jonas Bonn wrote: On 09/07/2017 06:23 AM, Nishanth V wrote: added new DBUS methods RegisterAgent and UnregisterAgent to Networkmonitor interface so that any client of ofono can register for serving cell updates. Added new agent interface NetworkMonitorAgent

Re: connmand[186]: Online check failed but running dhclient manually fixes this issue

Hi Daniel, If this is true, then falling back to DHCP would seem to be required for many Qualcomm based devices. This seems to be a recently introduced 'bug' as older QMI devices did not need this workaround. Do you think we should try to figure out which Qualcomm device is misbehaving or

Re: [PATCH] qmimodem: report failure in case of invalid pin type

Hi Christophe, On 09/06/2017 03:31 AM, Christophe Ronco wrote: Hi Denis, I wasn't able to reproduce yesterday. From traces I kept, with problematic SIM card, I had this trace when problem appeared: ../git/drivers/qmimodem/sim.c:get_card_status() info1->app_state:0x6:

Re: [PATCH 3/6] atutil: Add logic for cgcontrdp to get address and netmask

Hi Ankit, On 09/01/2017 12:53 AM, Ankit Navik wrote: --- drivers/atmodem/atutil.c | 44 drivers/atmodem/atutil.h | 3 +++ 2 files changed, 47 insertions(+) diff --git a/drivers/atmodem/atutil.c b/drivers/atmodem/atutil.c index 1487348..1067f20

Re: [PATCH 2/6] Add support for Intel xmm7xxx series modem driver

Hi Ankit, On 09/01/2017 12:53 AM, Ankit Navik wrote: This adds driver as xmm7modem for radio-settings --- Makefile.am| 5 + drivers/xmm7modem/radio-settings.c | 233 + drivers/xmm7modem/xmm7modem.c | 50

Re: [PATCH 1/6] atmodem: Add lte atom driver

Hi Ankit, On 09/01/2017 12:53 AM, Ankit Navik wrote: Adds atmodem driver for setting the default APN command. The default APN is manage by config storage. --- Makefile.am | 3 +- drivers/atmodem/atmodem.c | 2 + drivers/atmodem/atmodem.h | 3 + drivers/atmodem/lte.c

Re: [PATCH][v2] common.c: move strlen(apn) check into is_valid_apn()

Hi Alexander, On 09/05/2017 09:27 AM, Alexander Couzens wrote: --- src/common.c | 8 src/gprs.c | 9 - src/lte.c| 3 --- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/src/common.c b/src/common.c index 17d1d58a0be3..46b59223272e 100644 ---

Re: connmand[186]: Online check failed but running dhclient manually fixes this issue

Hi, On 09/05/2017 09:46 AM, Alexander Couzens wrote: On Thu, 10 Aug 2017 12:47:28 +0200 Daniel Wagner wrote: Bus 001 Device 003: ID 1bc7:1201 Telit Wireless Solutions Here is a compile tested 'fix'. I don't know if this works and\ obviously it doesn't follow the coding

Re: [PATCH] include/gprs-context.h: declare struct ofono_modem

Hi Alexander, On 09/05/2017 09:20 AM, Alexander Couzens wrote: Fix a warning. ./include/gprs-context.h:99:61: error: ‘struct ofono_modem’ declared inside parameter list will not be visible outside of this definition or declaration... --- include/gprs-context.h | 1 + 1 file changed, 1

Re: [PATCH v2 2/3] gemalto: add PLS8 support

Hi Sebastian, On 08/30/2017 11:30 AM, Sebastian Arnd wrote: diff --git a/drivers/gemaltomodem/gemaltomodem.c b/drivers/gemaltomodem/gemaltomodem.c index 91cf238..01bdb43 100644 --- a/drivers/gemaltomodem/gemaltomodem.c +++ b/drivers/gemaltomodem/gemaltomodem.c @@ -35,6 +35,7 @@ static int

Re: [PATCH v2 3/3] gemalto: add PLS8 support

Hi Sebastian, On 08/30/2017 11:30 AM, Sebastian Arnd wrote: diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index 7c33c22..17d0be9 100644 --- a/drivers/atmodem/sim.c +++ b/drivers/atmodem/sim.c This patch should come before the plugins/gemalto.c changes... @@ -64,7 +64,7 @@

Re: [PATCH] qmimodem: report failure in case of invalid pin type

Hi Christophe, On 08/29/2017 07:29 AM, Christophe Ronco wrote: This will avoid a crash seen in sim_pin_query_cb (src/sim.c) if pin type is OFONO_SIM_PASSWORD_INVALID. --- drivers/qmimodem/sim-legacy.c | 5 - drivers/qmimodem/sim.c| 6 +- 2 files changed, 9 insertions(+), 2

Re: [PATCH] unit: Avoid use of uninitialised data in test-simutil

Hi Slava, On 08/24/2017 05:17 PM, Slava Monich wrote: GTest: run: /testsimutil/ber tlv encode EFpnn ==16777== Conditional jump or move depends on uninitialised value(s) ==16777==at 0x4068CB: ber_tlv_iter_next (simutil.c:369) ==16777==by 0x406C39: ber_tlv_find_by_tag (simutil.c:483)

Re: [PATCH] at/cdma/ifxmodem: Use /dev/net/tun to check for TUN support

driver, but the other two seem similar enough that it should work there as well. This is a verbatim resend of this patch, orginally sent on 15th of July, as requested by Denis Kenzior. Applied, thanks. Regards, -Denis ___ ofono mailing list ofono

Re: [PATCH] qmi/sms: require WMS version >= 1.2 for bearer calls

Hi Alexander, On 08/22/2017 07:25 AM, Alexander Couzens wrote: I've never seen a major 0 service. The gobi2000 comes with WMS 1.0 and doesn't support the bearer command. Guessing it's 1.2 required. --- drivers/qmimodem/sms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: APN provisioning with connman (and duplicate profiles in MBPI)

Hi Matthijs, On 08/22/2017 01:50 AM, Matthijs Kooijman wrote: Hi Denis, oFono creates a single sentinel context when automatic provisioning fails. This is an indication to the provisioning UI that the user should be helped/asked/guided in providing a valid context configuration (e.g. APN,

Re: [PATCH] sms: Pass const pointer to dispatch_app_datagram

Hi Slava, On 08/19/2017 04:26 AM, Slava Monich wrote: --- src/sms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono

Re: [PATCH 2/2] common.c: move strlen(apn) check into is_valid_apn()

Hi Alexander, On 08/08/2017 08:53 AM, Alexander Couzens wrote: --- src/common.c | 5 + src/gprs.c | 9 - src/lte.c| 3 --- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/src/common.c b/src/common.c index 17d1d58a..013e2452 100644 --- a/src/common.c +++

Re: [PATCH 1/2] gprs-context: set apn length to 100 bytes

Hi Alexander, On 08/08/2017 08:53 AM, Alexander Couzens wrote: According to ETSI TS 123 003 version 9.15.0 Chapter 9.1 --- include/gprs-context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. I added a comment about the relevant section in a follow on commit.

Re: [PATCH v2] add call-list helper to manage voice call lists

Hi Alexander, We are not exposing glib into the oFono plugin API. So the use of GSList, etc data structures across driver <-> core boundary is not possible. The reasons are somewhat historic, but essentially non-GLib based plugins must be possible. Also, oFono's use of GLib will be replaced

Re: gemalto: AGPS functionality

Hi Vincent, On 06/21/2017 06:45 AM, Vincent CESSON wrote: Hi, I am trying to add AGPS functionality to Gemalto modems. I took a look at interface AssistedSatelliteNavigation and implementation in drivers/atmodem/gnss.c. Unfortunately, Gemalto does not support AT+CPOS command but it uses a

Re: [PATCH] ussd: Switch the state from USER_ACTION to IDLE

Hi Slava, On 06/21/2017 06:54 AM, Slava Monich wrote: ... when a USSD notification is received. Some networks send 0 (no further user action required) after the response timeout expires. That should result in the user input form getting removed from the ME screen. --- src/ussd.c | 14

Re: APN provisioning with connman (and duplicate profiles in MBPI)

Hi Matthijs, On 07/16/2017 02:10 PM, Matthijs Kooijman wrote: Hey folks, I just tried Connman and oFono on a Debian stretch system for the first time, hoping to get a more robust solution for keeping a cellular and/or ethernet connection up. It seems the duo is quite capable of doing what I

<    4   5   6   7   8   9   10   11   12   13   >