at is missing to have the context show up
> in the meego-network-panel?
It seems that somehow connman doesn't detect the modem. Once connman
detects it, I would assume UI would show it as well.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
>
> so I assume you take yo the task to add support for it once we have the
> rest of framework merged.
Sure. But I can't promise when I get the task finished :)
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
ld active its
> usage. And yes, I want to make it possible to build all plugins at all
> time.
Even better, maybe just a bit trickier to implement. But at least
mobile-broadband-provider-info already supports pkgconfig so the
location of the xml should be easy to detect automatically during
ns in ofono tree and
enable/disable them with configure switches.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
"Awad, Majid" writes:
> It's fixed now.
Thank you for fixing it.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
an email to
ofono@ofono.org
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Jukka Saunamaki writes:
> Hello
Moro,
> On Mon, 2011-01-03 at 10:57 +0200, Kalle Valo wrote:
>> Jukka Saunamaki writes:
>>
>> > > > apn="mms.apn" protocol="ipv4" username="mmsuser" password="mmspass"
>> > p
. Any particular reason why you can't use the
same format as in mobile-broadband-provider-info?
http://git.gnome.org/browse/mobile-broadband-provider-info/tree/serviceproviders.xml
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
tivating a context by default would be very bad for power
> consumption and standby times, unless both the handset and the network
> support CPC.
If I plugin a usb modem on my laptop, I really want to connect it
automatically.
> The decision should be up to the user.
And with the aut
t's the bug are you fixing? Logs etc would help here. Also what is
the exact model of the Huawei modem with you see the bug?
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Alexander A Khryukin writes:
> # patch -p1 < ofono.patch
>
> patching file plugins/huawei.c
> Hunk #1 FAILED at 624.
> 1 out of 1 hunk FAILED -- saving rejects to file plugins/huawei.c.rej
>
> im using
> http://www.kernel.org/pub/linux/network/ofono/ofono-0.31.tar.bz2
My patch was against lates
Alexander A Khryukin writes:
>> Sorry, I wasn't able to immeadiately say from the logs what went wrong.
>> Can you get a log which includes AT commands? It would help a lot.
>>
>> Just run this command to get the logs:
>>
>> OFONO_AT_DEBUG=1 /usr/sbin/ofonod -n
>>
>> What's the exact version o
e logs:
OFONO_AT_DEBUG=1 /usr/sbin/ofonod -n
What's the exact version of ofono you are using? Huawei has had some
changes lately.
Also is the SIM configured to ask for PIN or not? I'm guessing no from
the log, but can't be sure.
--
Kalle Valo
On 10/02/2010 02:08 PM, Debayan Banerjee wrote:
> On 2 October 2010 16:28, Debayan Banerjee wrote:
>> 2010/10/2 Debayan Banerjee :
>>> On 2 October 2010 12:42, Debayan Banerjee wrote:
>
> I built 0.61, which is the latest stable release. Still no luck :(
i can see a new interfac
The recently introduced online support to huawei didn't work with my
Huawei E1552. The problem was that with command AT+CFUN=1;+CFUN=5
the modem didn't initialise the sim state properly.
To fix this I changed the logic so that CFUN=5 is called only after the sim
state has switched to a valid state
On my Huawei E1552 when I plug in the modem (ie. cold start) with PIN locked
SIM, the sim state is 255 (HUAWEI_SIM_STATE_NOT_EXISTENT). As the modem
doesn't send ^SIMST notifications, poll the sim state until it's ready.
In theory it might be possible to do this better, for example follow
^BOOT no
Here's my second round of getting huawei working again in cold start.
Locked pin sims worked in v1, but in these patches they are again
broken. I had to omit that problem now because I want to have Huawei
working again quickly.
Please test and provide feedback.
---
Kalle Valo (2):
h
modem);
>>
>> +if (data->query_sim_state)
>> + g_source_remove(data->query_sim_state);
>> +
>
> You need to set the timeout variable also to 0. Otherwise you have some
> funny side effect then next time enabling the modem.
>
> Also I prefer check for the timeout variables with > 0.
Fixed.
I'll send v2 shortly.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Kalle Valo writes:
> I'm guessing ofono_sim_inserted_notify() has something to do this. When
> I did some quick tests, IIRC I was able to see HUAWEI_SIM_STATE_VALID
> only after I had called ofono_sim_inserted_notify().
>
> I think the way you are after is that we
WEI_SIM_STATE_VALID (or the three other valid states) and only then
call ofono_sim_inserted_notify(). At least to me that would make sense.
I just don't know how to do that because I see only later in the
initialisation phase.
Thoughts?
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Kalle Valo writes:
> I finally was able to start look at Huawei again. Like reported multiple
> times, huawei currently works in only in the "warm start" case (ie. plug in
> modem and restart ofono). This is a regression, this worked ok a month ago.
>
> Here's
---
plugins/huawei.c | 79 ++
1 files changed, 55 insertions(+), 24 deletions(-)
diff --git a/plugins/huawei.c b/plugins/huawei.c
index ad1c3ae..0b4e65e 100644
--- a/plugins/huawei.c
+++ b/plugins/huawei.c
@@ -78,6 +78,7 @@ struct huawei_data
On my Huawei E1552 when I plug in the modem (ie. cold start) with PIN locked
SIM, the sim state is 255 (HUAWEI_SIM_STATE_NOT_EXISTENT). As the modem
doesn't send ^SIMST notifications, poll the sim state until it's ready.
In theory it might be possible to do this better, for example follow
^BOOT no
till don't work. I'll
send the patches as RFC anyway. Please test and give feedback.
---
Kalle Valo (2):
huawei: poll sim state
huawei: fix online logic
plugins/huawei.c | 121 --
1 files changed, 99 in
y a solution is not far off.
The Ubuntu beta released last week kept me quite busy and I hasn't been
able to work on ofono at all. I'm travelling right now, but as I get
back home early next week I'll start looking huawei again.
--
Kalle Valo
___
sn't GSM also support this? If yes, any pointers/tips how to access
the retry count from the modem/SIM? I need this in my UI and I would
like to give a shot implementing this in ofono, but I don't know where
to start.
(Actually I doubt that my Huawei E1552 even supports this, but miracles
"Kouassu, AlainX" writes:
> Kouassu, AlainX would like to recall the message, "RAT , signal
> Strength indication ofono 0.23".
-EUNSUPPORTED
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
e patches against the ofono plugin to the
> connman list. It seems to work fine with my N900 and isimodem driver,
> scratching Kalle's most immediate itches.
Awesome! I'll test them as soon as they are commited to git.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
>
> This way if the SIM is not PIN locked, the driver can call sim_inserted
> and sim_ready at once. If the PIN is locked, the driver can notify
> sim_ready later.
Sounds good to me. Do you want to implement it? ;) I'm a bit busy right
now and it might
Denis Kenzior writes:
> Hi Kalle,
Hi Denis,
> On 08/10/2010 04:57 AM, Kalle Valo wrote:
>
>> In theory it might be possible to do this better, for example follow
>> ^BOOT notifications or something, but it's unknown what parameter we
>> should check for.
Do you
ctly.
What about old style serial port modems? How can we configure them if
you remove modemconf?
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
now it's
impossible to use N900 as a modem with connman because the modem is in
offline state.
Will you accept patches to ofono to change the default state? It can be
reverted once the connman support is finished.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
On my Huawei E1552 with PIN locked SIM sim_state is 0 when calling
huawei_post_sim() and gprs context is not registered. This is because
^SIMST notification is received only after huawei_post_sim() is called:
Aug 10 12:38:33 tukki ofonod[6565]: plugins/huawei.c:huawei_post_sim() 0x6cdb50
[...]
Aug
On my Huawei E1552 when I plug in the modem (ie. cold start) with PIN locked
SIM, the sim state is 255 (HUAWEI_SIM_STATE_NOT_EXISTENT). As the modem
doesn't send ^SIMST notifications, poll the sim state until it's ready.
In theory it might be possible to do this better, for example follow
^BOOT no
After these two patches PIN unlock works always with my Huawei E1552.
---
Kalle Valo (2):
huawei: poll sim state
huawei: postpone post_sim until SIM is ready
plugins/huawei.c | 136 ++
1 files changed, 86 insertions(+), 50
---
Makefile.am |4 +++-
test/lock-pin | 27 +++
test/unlock-pin | 27 +++
3 files changed, 57 insertions(+), 1 deletions(-)
create mode 100755 test/lock-pin
create mode 100755 test/unlock-pin
diff --git a/Makefile.am b/Makefile.am
Inaky Perez-Gonzalez writes:
> Hi Kale
Hola,
> On Thu, 2010-08-05 at 08:54 +0300, Kalle Valo wrote:
>>
>> This is my setup:
>>
>> ; from linux/Documentation/CodingStyle
>> (defun c-lineup-arglist-tabs-only (ignored)
>> "Line up argument li
Inaky Perez-Gonzalez writes:
> Hi Kale
Hi Inaky,
> On Thu, 2010-05-20 at 10:35 +0300, Kalle Valo wrote:
>> Denis Kenzior writes:
>>
>> > No mixing of tabs & spaces for indentation
>>
>> Fixed.
>>
>> Oh man, I have to fix my emacs sett
quickly tested current git (which should contain this patch) with
Huawei E1552 and ofono doesn't crash anymore. But now ofono doesn't
connect after a few rounds of connect, disconnect, connect, disconnect
testing. I need to unplug and plug in my modem to get it working agai
this gprs context, we should reply the pending DBus
> message to the client.
I tested the patch with my Huawei E1552 and it worked perfectly. Earlier
it was very easy to trigger the crash. I even tried some of my evil
tests and found no issues.
Tested-by: Kalle Valo
l issue during the last three
months I have been testing my Huawei E1552.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
emove() atom:
0x6c88a0
So huawei_disconnect() is recursively in an endless loop. Any ideas how
to fix this properly?
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
On 07/21/2010 07:47 AM, Zheng Zhang wrote:
Hi,
Hi Zheng,
I have a plan to use oFono in the TDS-CDMA environment in China.(Maybe I
can use Huawei E180 USB Wireless modem).
And it seems like that oFone only supported for WCDMA/GSM, so do I need
some adaptation of oFone for the TDS-CDMA support?
On 07/21/2010 10:56 AM, Kalle Valo wrote:
On 07/18/2010 01:04 PM, Florian Steinel wrote:
SIM doesn't seem to be ready. I would expect to see ^SIMST messages in
the log to notify when the SIM is ready, but for some reason there
aren't any.
Do you know what was the last commit when
On 07/18/2010 01:04 PM, Florian Steinel wrote:
Hi,
Hi Florian,
I can't get my Huawei E176 USB Stick into the online state.
I'm travelling and I don't have access to my Huawei E1552 right now. But
I'll test it as soon as I get back home.
Maybe commit cc6a43c477c1310643279139ba6808799a8
, pending = 0x6e43c0, driver = 0x6d80a0,
driver_data = 0x6ee1d0, atom = 0x6e4460}
(gdb) p *gcd
$2 = {chat = 0x6e49a0, active_context = 1,
username = '\000' , password = '\000' ,
ppp = 0x0, state = STATE_ENABLING, {
down_cb = 0x48fc7f ,
up_
---
TODO |7 ---
doc/overview.txt |6 --
2 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/TODO b/TODO
index a25394a..470d4a6 100644
--- a/TODO
+++ b/TODO
@@ -200,13 +200,6 @@ Flight Mode
GPRS
-- PPP gprs-context driver support. Add an implement
Huawei always closes the tty port after PPP disconnect. Handle this in
huawei plugin, similarly as done with novatel. Now there's no need
to unplug the modem after disconnection.
Tested with Huawei E1552.
Based on a patch by Marcel Holtmann:
commit 0329a6ceaf8f69857cb5f8437b9db86ca327ef1d
Author
>> ENV{OFONO_IFACE_NUM}="$attr{bInterfaceNumber}" +SUBSYSTEMS=="usb",
>> ATTRS{bInterfaceNumber}=="ff",
>> ENV{OFONO_IFACE_NUM}="$attr{bInterfaceNumber}"
>
> This has now been fixed upstream.
I tested the current git version an
S=="usb", ATTRS{bInterfaceNumber}=="ff",
ENV{OFONO_IFACE_NUM}="$attr{bInterfaceNumber}"
After I change "ff" back to "?*" my modem works again. What's the reason
behind this change? Can we revert it back?
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
, though.
https://wiki.ubuntu.com/ConnMan
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Kalle Valo writes:
> I saw a crash in ppp_disconnect() when I unplugged my huawei modem while
> connected. Also connman crashed at the same time.
Oh yeah, forgot to mention that I was using ofono commit 236f3acc0f.
--
Kalle Valo
___
ofono m
tch=,
self=)
at /build/buildd/glib2.0-2.24.1/glib/gmain.c:2591
#15 0x77934c55 in IA__g_main_loop_run (loop=0x6d90e0)
at /build/buildd/glib2.0-2.24.1/glib/gmain.c:2799
#16 0x0045ce35 in main (argc=1, argv=0x7fffe668) at src/main.c:227
--
Kalle V
Kalle Valo writes:
>>> But now connman doesn't show the operator name "Saunalahti" anymore, the
>>> name property in connman Service is just empty:
>>>
>>> ./cmcc show cellular_244053111242822_huawei0_primarycontext1
>>> AutoConnect:
ome times you get the name other times you don't.
Thanks, that's good to know. I have been testing connman and ofono for
some time now, but I saw this problem first time only yesterday. But I
might have been just lucky earlier.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
"Zhang, Zhenhua" writes:
> Hi Kalle,
Hi Zhenhua,
> Kalle Valo wrote:
>> Hi,
>>
>> I mentioned this briefly on irc, but I'll inform it here as well. This
>> patch broke ofono support for my Huawei E1552:
>>
>> commit 6ab0b6f29acc8f6b2a5
uawei plugin uses /dev/ttyUSB1 for the event channel but for my modem
it should be /dev/ttyUSB2. We need to solve this problem somehow, even
if we need to add usb ids to ofono.rules.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofon
Handy when debugging udev problems.
---
plugins/huawei.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/plugins/huawei.c b/plugins/huawei.c
index 9e50288..63dd06a 100644
--- a/plugins/huawei.c
+++ b/plugins/huawei.c
@@ -201,11 +201,11 @@ static int huawei_enable(struct
quot; port. Is it certain that port numbering will be
the same across all distributions and kernels?
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
vices out there, that handling
the usb ids for all of them is difficult.
I personally would prefer a solution which would dynamically probe the
ports and choose them based on results. I believe modemmanager does
something like this, but I haven't looked in detail.
But Denis and Marcel should comment here, they know best.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Denis Kenzior writes:
> Hi Gustavo,
Hi Denis,
>> +#ifndef __BLUETOOTH_H
>> +#define __BLUETOOTH_H
>
> No ifdef guards please.
I'm curious, why not?
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
maller.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
>> +case STATE_ENABLING:
>> CALLBACK_WITH_FAILURE(gcd->up_cb, NULL, FALSE, NULL,
>> NULL, NULL, NULL, gcd->cb_data);
>> -return;
>> +break;
>
> just double-checking that you really wanna ha
Ofono either crashed or busy looped with my Huawei E1552 3G modem when I
tried to deactivate GPRS context. The reason was that gcd->chat was
unreferenced already in setup_ppp() but the chat was still accessed
later in at_gprs_deactivate_primary().
To fix the problem, change the logic instead to su
It's enough that we shutdown PPP, no need to send CGACT after that.
Recommended by Denis.
---
drivers/atmodem/gprs-context.c | 51 +---
1 files changed, 16 insertions(+), 35 deletions(-)
diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-cont
"Zhang, Zhenhua" writes:
> Hi Valo,
Hi Zhenhua,
> Kalle Valo wrote:
>> -channel = g_at_chat_get_channel(gcd->chat);
>> -g_at_chat_unref(gcd->chat);
>> +g_at_chat_suspend(gcd->chat);
>>
>> /* open ppp */
>
Ofono either crashed or busy looped with my Huawei E1552 3G modem when I
tried to deactivate GPRS context. The reason was that gcd->chat was
unreferenced already in setup_ppp() but the chat was still accessed
later in at_gprs_deactivate_primary().
To fix the problem, change the logic instead to su
It's enough that we shutdown PPP, no need to send CGACT after that.
Recommended by Denis.
---
drivers/atmodem/gprs-context.c | 51 +---
1 files changed, 16 insertions(+), 35 deletions(-)
diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-cont
ybe splitting this into one patch
> that removes the CGACT and another that adds suspend/resume calls seems
> a bit cleaner to me.
I'll send v3 soon.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Kalle Valo writes:
> Ofono either crashed or busy looped with my Huawei E1552 3G modem when I
> tried to deactivate GPRS context. The reason was that gcd->chat was
> unreferenced already in setup_ppp() but the chat was still accessed
> later in at_gprs_deactivate_primary().
Ofono either crashed or busy looped with my Huawei E1552 3G modem when I
tried to deactivate GPRS context. The reason was that gcd->chat was
unreferenced already in setup_ppp() but the chat was still accessed
later in at_gprs_deactivate_primary().
To fix the problem, change the logic instead to su
These modems don't support voicecall anyway. Recommended by Denis.
---
plugins/huawei.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/plugins/huawei.c b/plugins/huawei.c
index d7697b9..1b7a185 100644
--- a/plugins/huawei.c
+++ b/plugins/huawei.c
@@ -289,7 +289,6 @@ stat
---
plugins/huawei.c | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/plugins/huawei.c b/plugins/huawei.c
index 962895a..d7697b9 100644
--- a/plugins/huawei.c
+++ b/plugins/huawei.c
@@ -47,6 +47,9 @@
#include
#include
+static const char *none_prefix[] = {
Instead of using ofono_modem_set_powered(), use ofono_sim_inserted_notify()
which is the proper way to notify about sim state changes.
Now the problem is that voicecall commands fail with my Huawei E1552:
ofonod[12395]: > AT+CRC=1\r
ofonod[12395]: src/sim.c:ofono_sim_add_state_watch() 0x1bf8e50
o
---
plugins/huawei.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/plugins/huawei.c b/plugins/huawei.c
index a2492a7..1c44be1 100644
--- a/plugins/huawei.c
+++ b/plugins/huawei.c
@@ -91,7 +91,7 @@ static void sysinfo_cb(gboolean ok, GAtResult *result,
gpointe
Some more love to Huawei, based on Dennis' comments.
---
Kalle Valo (4):
huawei: remove voicecall support
huawei: send a prefix with AT commands
huawei: properly notify sim state to ofono
huawei: use g_at_result_iter_skip_next()
plugins/huawei.c |
Huawei modems have an annoying feature to hangup the chat line
after ppp shutdown. Basically what happens is this:
14:15:08 ofonod[11768]: > AT+CGACT=0,1\r
14:15:09 ofonod[11768]: EventChannel: < \r\n^BOOT:38645652,0,0,0,87\r\n
14:15:10 ofonod[11768]: EventChannel: < \r\n^RSSI:22\r\n
ofono sends
Ofono either crashed or busy looped with my Huawei E1552 3G modem when I
tried to deactivate GPRS context. The reason was that gcd->chat was
unreferenced already in setup_ppp() but the chat was still accessed
later in at_gprs_deactivate_primary().
To fix the problem, change the logic instead to su
With Huawei E1552 I got sim busy errors when I plugged in the modem
and ofono was already running:
May 24 17:02:04 tukki ofonod[7619]: > AT+CRC=1\r
May 24 17:02:04 tukki ofonod[7619]: < \r\n+CME ERROR: SIM busy\r\n
May 24 17:02:04 tukki ofonod[7619]: > AT+CLIP=1\r
May 24 17:02:04 tukki ofonod[7619
_state;
>> +enum huawei_state state;
>> };
>
> I think the sim_state should be just enough.
You are right. I'll remove the state variable and send v2.
Thanks for the review.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
With Huawei E1552 I got sim busy errors when I plugged in the modem
and ofono was already running:
May 24 17:02:04 tukki ofonod[7619]: > AT+CRC=1\r
May 24 17:02:04 tukki ofonod[7619]: < \r\n+CME ERROR: SIM busy\r\n
May 24 17:02:04 tukki ofonod[7619]: > AT+CLIP=1\r
May 24 17:02:04 tukki ofonod[7619
s
> checking for GLIB... yes
> checking for DBUS... no
> configure: error: D-Bus >= 1.0 is required
You need libdbus-1-dev.
Check the build dependencies from a ofono debian/ubuntu package, for
example 'apt-get build-dep ' command is really handy. But I
think ofono is not in
Tested with Huawei E1552 HSDPA USB stick using a finnish Saunalahti prepaid
SIM.
---
drivers/atmodem/network-registration.c |4 ++
plugins/huawei.c | 61 +++-
2 files changed, 64 insertions(+), 1 deletions(-)
diff --git a/drivers/atmodem/ne
The function is needed in two different places, better to move it
to atutil.h.
---
drivers/atmodem/atutil.h | 12
drivers/atmodem/network-registration.c | 22 ++
2 files changed, 18 insertions(+), 16 deletions(-)
diff --git a/drivers/atmodem/atu
---
plugins/huawei.c | 67 +++---
plugins/udev.c | 61 +++--
2 files changed, 106 insertions(+), 22 deletions(-)
diff --git a/plugins/huawei.c b/plugins/huawei.c
index df4d177..489f3e2 100644
--- a
v5 of my Huawei GPRS support. Hopefully ready now :)
Please take a look and comment.
---
Kalle Valo (3):
huawei: add gprs context
Move report_signal_strength to atutil
huawei: detect possible secondary device
drivers/atmodem/atutil.h | 12 +++
drivers
ta->event = create_port(modem_device);
>> +
>
> Event port using the modem device again?
Good catch. I actually fixed this, but commited to the wrong patch. I
moved that part now from patch 3 to patch 1.
>> +if (data->event) {
>> +g_at_chat_cancel_all(
ngth and removing
> it
> from this file as well? ;)
Oops, I totally forgot to remove the function network-registration.c.
Fixed now.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Tested with Huawei E1552 HSDPA USB stick using a finnish Saunalahti prepaid
SIM.
---
drivers/atmodem/network-registration.c |4 ++
plugins/huawei.c | 63 +++-
2 files changed, 65 insertions(+), 2 deletions(-)
diff --git a/drivers/atmodem/ne
The function is needed in two different places, better to move it
to atutil.h.
---
drivers/atmodem/atutil.h | 12
drivers/atmodem/network-registration.c |4 ++--
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/atmodem/atutil.h b/drivers/atm
---
plugins/huawei.c | 68 --
plugins/udev.c | 61 ++--
2 files changed, 108 insertions(+), 21 deletions(-)
diff --git a/plugins/huawei.c b/plugins/huawei.c
index df4d177..2a95cf6 100644
--- a/
Hello,
here's v4 of Huawei GPRS support. Lots of whitespace cleanup, a memory leak
fixed and a new function at_util_convert_signal_strength(). All based on
comments from Denis.
---
Kalle Valo (3):
huawei: add gprs context
Move report_signal_strength to atutil
huawei: d
huawei_cgreg_notify, FALSE, gprs, NULL);
>
> And here
Fixed.
>> +
>> +/* huawei uses non-standard "^RSSI:18" strings */
>> +g_at_chat_register(data->event, "^RSSI:",
>> + huawei_rssi_notify, FALSE, netreg, NULL);
>
> And here
Fixed.
Thank you for the comments. I'll run some tests first and send v4 soon.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
g_at_chat_set_debug(data->event, huawei_event_debug, NULL);
>> +
>> +
>
> Why the extra space?
You mean the newline, right? That's by accident, I removed it now.
> Also, this entire sequence leaks the data->chat i
at_ppp_shutdown and then reactivate the gatchat using
> g_at_chat_resume
Ok, thank you for the tips. I'll take a look at this later, I have to
fix some other issues first.
> (assuming the Huawei does not HUP the tty when disconnecting the ppp
> link.)
Let's hope not.
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
"Zhang, Zhenhua" writes:
> Hi Kalle,
Hi Zhenhua,
> Kalle Valo wrote:
>> Kalle Valo writes:
>>
>>> while working on third version of my huawei gprs patches I noticed
>>> that this commit breaks huawei:
>>>
>>> commit af
hutdown() is most likely not enough, because nobody is not
creating gcd->chat again which is needed during subsequent activate
call.
Comments?
--
Kalle Valo
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Kalle Valo writes:
> while working on third version of my huawei gprs patches I noticed that
> this commit breaks huawei:
>
> commit af976f7e524746b1b55645967e11ab8250f593a8
> Author: Zhenhua Zhang
> Date: Tue May 11 09:04:28 2010 +0800
>
> Fix Use hasht
em support, any plans to document that part?
That's my main concern right now.
Is there a list containing various types of modems and models available
somewhere? Naturally it is bound to be incomplete, but at least that
would be a good start.
--
Kalle Valo
Tested with Huawei E1552 HSDPA USB stick using a finnish Saunalahti prepaid
SIM.
---
drivers/atmodem/network-registration.c |4 ++
plugins/huawei.c | 73
2 files changed, 76 insertions(+), 1 deletions(-)
diff --git a/drivers/atmodem/ne
1 - 100 of 126 matches
Mail list logo
