Hi Jeevaka,
> Following patch is a proposal for emergency mode. Test has been done
> with the phonesim.
>
> Listed down few important cases to give an overview of the state
> changes that happen in each case.
and I think we should turn this into a doc/emergency-call-handling.txt
and extend a bi
Hi Guillaume,
> doc/dialup-overview.txt | 47
> +++
> 1 files changed, 47 insertions(+), 0 deletions(-)
> create mode 100644 doc/dialup-overview.txt
patch has been applied. Thanks.
Regards
Marcel
___
Hi Guillaume,
> doc/data-call.txt | 47 +++
> 1 files changed, 47 insertions(+), 0 deletions(-)
> create mode 100644 doc/data-call.txt
looks great. Just call it doc/dialup-overview.txt since data-call is a
little unclear what this is about.
Regards
Hi Denis,
> > doc/stk-api.txt | 11 +++
> > 1 files changed, 11 insertions(+), 0 deletions(-)
> >
> > diff --git a/doc/stk-api.txt b/doc/stk-api.txt
> > index f8a115e..fc69bb9 100644
> > --- a/doc/stk-api.txt
> > +++ b/doc/stk-api.txt
> > @@ -252,6 +252,7 @@ Methods byte Reques
Hi Jarko,
> this patch provides logic to re-construct XML-formatted string prefixed with
> +CPOSR as defined in 27.007.
>
> Br,
> Jarko
>
> drivers/atmodem/gnss.c | 134
> ++--
> 1 files changed, 118 insertions(+), 16 deletions(-)
>
> diff --git a
Hi Sankar,
>
> > I would like to know if there is any proposal to support the
> Operator
> > Preferred List in oFono. This is being a key feature,
> allowing the user
> > to add/delete/modify the PLMNSel, PLMNWact files on the
> card, which
Hi Lucas,
> > first mail, please be gentle. I wish to create a new rootfs for my ARM920T
> > microcontroller based device using BUILDROOT. The device has a serial port
> > attached huawei 3G modem that could theoretically be used with stock
> > chap/ppp. I do vividly remember though my aggreviance
Hi Aki,
> > Unfortunately that ship has sailed. Every vendor except Nokia uses AT
> > command modems, or at least implements a (somewhat) full-featured AT
> > backend.
>
> Not quite the way I see things. There are notable exceptions to this,
> for example, Qualcomm modems don't use AT commands b
Hi Jeevaka,
> drivers/atmodem/network-registration.c | 26 ++
> 1 files changed, 26 insertions(+), 0 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org
Hi Jeevaka,
> drivers/atmodem/network-registration.c | 25 +++--
> 1 files changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/atmodem/network-registration.c
> b/drivers/atmodem/network-registration.c
> index 4913611..0dbc72d 100644
> --- a/drivers/atmodem/n
Hi Olivier,
> diff --git a/doc/dialup-command-set.txt b/doc/dialup-command-set.txt
> index 97ff009..554707d 100644
> --- a/doc/dialup-command-set.txt
> +++ b/doc/dialup-command-set.txt
> @@ -184,6 +184,7 @@ Device:
> +GMRRequest Revision Identification
> +CGSN Req
Hi Olivier,
> These patches only add a list of AT commands that should be added in
> the emulator. This list is not only related to bluetooth stuff.
Applying: doc: fix typo and incorrect line length
/data/devel/ofono/.git/rebase-apply/patch:84: trailing whitespace.
RINGThe DCE
Hi Olivier,
> doc/dialup-command-set.txt | 252
> ++--
> 1 files changed, 218 insertions(+), 34 deletions(-)
>
> diff --git a/doc/dialup-command-set.txt b/doc/dialup-command-set.txt
> index a7a1df3..9d80170 100644
> --- a/doc/dialup-command-set.txt
> +++
Hi Mika,
> > So during OSTS Samuel, Marcel and I sat down and tried to
> > figure out the
> > IPv6 stuff. Based on this discussion and your implementation
> > I pushed a
> > series of patches implementing IPv6 and dual-stack contexts. I have
> > taken (and later re-worked) some of your patches
Hi Lass,e
> Here is an updated version of STE unit test, originally done by Marit (sent
> on 15th of Feb).
> This one should apply smoothly
one question ahead of time. Are you guys up to the task to maintain this
unit test? Since it is clearly out of the scope of Denis and I to make
sure it wil
Hi Guillaume,
> > > diff --git a/plugins/ifx.c b/plugins/ifx.c
> > > index 527a8c4..9c2a5c1 100644
> > > --- a/plugins/ifx.c
> > > +++ b/plugins/ifx.c
> > > @@ -26,8 +26,12 @@
> > > #include
> > > #include
> > > #include
> > > +#include
> > > #include
> > > #include
> > > +#include
> >
Hi Antti,
> > > drivers/atmodem/network-registration.c |2 ++
> > > 1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/atmodem/network-registration.c
> > > b/drivers/atmodem/network-registration.c
> > > index 4913611..2d589f0 100644
> > > --- a/drivers/atmodem
Hi Guillaume,
> Using kernel mux, a recursive locking is detected. This issue is
> due to the fact that the DLC_AUX is not closed by ofono. This is
> not done because the shutdown_device() function in charge of it
> is called in the context of an AT callback function and for an
> AT sent in this s
Hi Lucas,
> drivers/ifxmodem/gprs-context.c | 95
> +--
> 1 files changed, 91 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ifxmodem/gprs-context.c b/drivers/ifxmodem/gprs-context.c
> index 2c68b44..0d133f9 100644
> --- a/drivers/ifxmodem/gprs-cont
Hi Lucas,
> diff --git a/plugins/ifx.c b/plugins/ifx.c
> index 527a8c4..9c2a5c1 100644
> --- a/plugins/ifx.c
> +++ b/plugins/ifx.c
> @@ -26,8 +26,12 @@
> #include
> #include
> #include
> +#include
> #include
> #include
> +#include
> +#include
> +#include
please move unistd.h up sinc
Hi Antti,
> drivers/atmodem/network-registration.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/atmodem/network-registration.c
> b/drivers/atmodem/network-registration.c
> index 4913611..2d589f0 100644
> --- a/drivers/atmodem/network-registration.c
> ++
Hi Lucas,
> cb_data_new() uses g_new0(), hence there's no need to check the return
> value being NULL.
> ---
> drivers/mbmmodem/location-reporting.c |4
> 1 files changed, 0 insertions(+), 4 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
Hi Lucas,
> cb_data_new() uses g_new0(), hence there's no need to check the return
> value being NULL.
> ---
> plugins/huawei.c |4
> 1 files changed, 0 insertions(+), 4 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
___
ofono
Hi Martin,
> huawei_disconnect is used to recovery the io and gprs context when
> io error happends, see commit 39382730d7758b093ca6271f4e9dea875fa04b3a
> However, io error not only happends at PPP disconnect, in theory it
> can happends at any situation. I also observed that it happens when modem
Hi Lucas,
> >> struct gps_data {
> >> GAtChat *chat;
> >> - GAtChat *data_chat;
> >> +
> >> + struct {
> >> + GIOChannel *channel;
> >> + guint idle_source;
> >> + gsize written;
> >> + ofono_location_reporting_enable_cb_t cb;
> >> +
Hi Lucas,
> struct gps_data {
> GAtChat *chat;
> - GAtChat *data_chat;
> +
> + struct {
> + GIOChannel *channel;
> + guint idle_source;
> + gsize written;
> + ofono_location_reporting_enable_cb_t cb;
> + void *cb_data;
> +
Hi Fred,
> gatchat/gatresult.c | 25 +
> gatchat/gatresult.h |2 ++
> 2 files changed, 27 insertions(+), 0 deletions(-)
>
> diff --git a/gatchat/gatresult.c b/gatchat/gatresult.c
> index 8a6dfae..0003f0b 100644
> --- a/gatchat/gatresult.c
> +++ b/gatchat/gatresult.c
Hi Marit,
> Redesigned, there will be only one contexts for each instance of
> the driver and only one CAIF interface, no longer need the list
> of caif devices.
> ---
> drivers/stemodem/gprs-context.c | 273
> ---
> 1 files changed, 57 insertions(+), 216 del
Hi Marit,
> plugins/ste.c | 17 -
> 1 files changed, 12 insertions(+), 5 deletions(-)
patch has been applied.
Regards
Marcel
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Hi Lasse,
> I've seen an issue in Unsolicited Result code handling in gatchat. If
> ofono has sent an AT command and is waiting for a response, but modem
> has sent an UR code just before the AT command reached the modem,
> gatchat does not handle that UR code correctly (it drops it).
>
> 27.007
Hi Marit,
>
> Is this approach ok, and has anyone had the chance to look at these
> pathces? (this one plus [PATCH 2/2] stemodem: Add support for multiple
> pdp contexts)
it is fine with me. Just re-send them with the warning fixed.
Regards
Marcel
___
Hi Marit,
> Redesigned, there will be only one contexts for each instance of
> the driver and only one CAIF interface, no longer need the list
> of caif devices.
> ---
> drivers/stemodem/gprs-context.c | 273
> ---
> 1 files changed, 57 insertions(+), 216 del
Hi Gustavo,
> plugins/bluetooth.c |4
> 1 files changed, 4 insertions(+), 0 deletions(-)
patch has been applied.
Regards
Marcel
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Hi Gustavo,
> When bluetoothd is not running we should not call RemoveRecord()
> ---
> plugins/bluetooth.c | 12
> 1 files changed, 12 insertions(+), 0 deletions(-)
patch has been applied.
Regards
Marcel
___
ofono mailing list
ofono@
Hi Gustavo,
> plugins/bluetooth.c | 33 -
> 1 files changed, 20 insertions(+), 13 deletions(-)
patch has been applied.
Regards
Marcel
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Hi Gustavo,
> This fix a issue with sending DBus messages when bluetoothd is not up yet.
> ---
> plugins/bluetooth.c | 24 ++--
> 1 files changed, 14 insertions(+), 10 deletions(-)
patch has been applied.
Regards
Marcel
___
of
Hi Gustavo,
> plugins/bluetooth.c | 52 +-
> 1 files changed, 26 insertions(+), 26 deletions(-)
patch has been applied.
Regards
Marcel
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/l
Hi Zhigan,
> > >+ g_str_has_suffix(desc, "Data Modem") ||
>
> > I think this should be "Module Data Modem".
>
> This is confusing part, with my test with this modem on MeeGo image, the
> Module Data Modem doesn't work and only Data Modem works.
>
> So I think it should be ok.
Hi Denis,
> >> This contradicts commit bb58a729073abcb6c5b0b2fb8b120973dfa42a07.
> > I can't quite understand why Dietrich needs to this commit. We formal
> > configure can just make EM770W works.
> > Could you help on this?
>
> The Huawei firmware is funny, it can actually reconfigure the modem
Hi Denis,
> > ---
> > include/gprs.h |2 +
> > src/gprs.c | 63
> >
> > 2 files changed, 65 insertions(+), 0 deletions(-)
> >
>
> So I went in a slightly different direction with the emulator API. Can
> you please have a look?
Hi Andrew,
> >> -src/builtin.h: src/genbuiltin $(builtin_sources)
> >> +src/builtin.h: src/genbuiltin config.status
> >> $(AM_V_GEN)$(srcdir)/src/genbuiltin $(builtin_modules) > $@
> >
> > so depending on config.status is fine, but why no longer on
> > $(builtin_sources)?
>
> I didn't see a
Hi Andrew,
> Earlier versions lack struct sockaddr_l2::l2_cid and/or
> struct bt_security.
> ---
> configure.ac |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 4f0348d..810b9f2 100644
> --- a/configure.ac
> +++ b/configure.ac
>
Hi Andrew,
> Make builtin.h depend on config.status to force regeneration when
> plugins may have been enabled or disabled. There may be a better
> way to do that. The dependency on builtin_sources is not needed.
> ---
> Makefile.am |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Hi Michael,
> >> In theory there might be more than one IMS APN for a operator,
>
> >> but I really don't see this as a real life scenario for this.
>
> >> If anyone disagrees please speak out and explain...
>
>
>
> One such scenario is the in-vehicle use model, where the ISP provides
> netw
Hi Jeevaka,
> drivers/ifxmodem/radio-settings.c |5 -
> 1 files changed, 4 insertions(+), 1 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
Hi Robertino,
> Has anyone seen this issue with oFono:
> Error activating /ifx0/context1: org.ofono.Error.NotAttached: GPRS is
> not attached
this normally does mean exactly what it says. You are not attached to
the GPRS network. If not attached you can not establish any GPRS
connection.
> I am
Hi Jeevaka,
> Command used for self test is not working for all
> versions of the modem firmware.
> ---
> plugins/ifx.c | 65 +---
> 1 files changed, 2 insertions(+), 63 deletions(-)
patch has been applied. Thanks for taking care of this.
Re
Hi Anand,
> It is a fix to support the selftest at command syntax changed in latest
> IFX fw version
>
> ---
> plugins/ifx.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/plugins/ifx.c b/plugins/ifx.c
> index 2a95720..a41fc36 100644
> --- a/plugins/ifx.c
> ++
Hi Antti,
> > > plugins/nettime.c | 326
> > > +
> > > 1 files changed, 326 insertions(+), 0 deletions(-)
> > > create mode 100644 plugins/nettime.c
> >
> > I would prefer if we call this nokia-timed.c or in case this actually
> > becomes de
Hi Marit,
> diff --git a/plugins/ste.c b/plugins/ste.c
> index cf8aed8..749c4f3 100644
> --- a/plugins/ste.c
> +++ b/plugins/ste.c
> @@ -66,6 +66,7 @@
> #include
>
> #define NUM_CHAT 1
> +#define MAX_PDP_CONTEXTS 4
>
> static const char *cpin_prefix[] = { "+CPIN:", NULL };
>
> @@
Hi Anand,
> Infineon modem selftest, during ifx_enable().
> Two steps trigger, with timeout. In case one fails, modem will not power up
>
> ---
> plugins/ifx.c | 66 +++-
> 1 files changed, 64 insertions(+), 2 deletions(-)
patch has been app
Hi Antti,
> +#define OFONO_CI_FIELD_TA_UNDEFINED 0xFF
> +#define OFONO_CI_FIELD_UCID_UNDEFINED 0x
> +#define OFONO_CI_FIELD_ECN0_UNDEFINED 0xFF
> +#define OFONO_CI_FIELD_RSCP_UNDEFINED -127
> +#define OFONO_CI_FIELD_PATHLOSS_UNDEFINED 0xFF
> +#define OFONO_CI_FIELD_FREQ_UNDEFINED 0x
>
Hi Antti,
> include/dbus.h |1 +
> src/ofono.h|1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/dbus.h b/include/dbus.h
> index 12768f6..f2e18bf 100644
> --- a/include/dbus.h
> +++ b/include/dbus.h
> @@ -45,6 +45,7 @@ extern "C" {
> #define OFONO_MESS
Hi Antti,
> doc/cell-info.txt | 121
> +
> 1 files changed, 121 insertions(+), 0 deletions(-)
> create mode 100644 doc/cell-info.txt
>
> diff --git a/doc/cell-info.txt b/doc/cell-info.txt
> new file mode 100644
> index 000..64d9db6
> ---
Hi Mika,
> > > +enum ofono_gprs_addrconf {
> > > + OFONO_GPRS_ADDRCONF_NONE,
> > > + OFONO_GPRS_ADDRCONF_STATIC,
> > > + OFONO_GPRS_ADDRCONF_DHCP,
> > > +};
> > > +
> >
> > What exactly is the _NONE addrconf for? And why don't we use
> > a gboolean
> > here like before?
>
> Neither "static" no
Hi Antti,
> doc/network-time-api.txt | 36
> 1 files changed, 36 insertions(+), 0 deletions(-)
> create mode 100644 doc/network-time-api.txt
>
> diff --git a/doc/network-time-api.txt b/doc/network-time-api.txt
> new file mode 100644
> index 000..9133a7
Hi Antti,
> plugins/nettime.c | 326
> +
> 1 files changed, 326 insertions(+), 0 deletions(-)
> create mode 100644 plugins/nettime.c
I would prefer if we call this nokia-timed.c or in case this actually
becomes default part of MeeGo, them ma
Hi Jeevaka,
> @@ -722,6 +772,7 @@ static int ifx_voicecall_probe(struct ofono_voicecall
> *vc, unsigned int vendor,
>
> g_at_chat_send(chat, "AT+XCALLSTAT=1", none_prefix, NULL, NULL, NULL);
> g_at_chat_send(chat, "AT+XEMC=1", none_prefix, NULL, NULL, NULL);
> + g_at_chat_send(v
---
modules/history-agent.c | 686 +++
1 files changed, 686 insertions(+), 0 deletions(-)
create mode 100644 modules/history-agent.c
diff --git a/modules/history-agent.c b/modules/history-agent.c
new file mode 100644
index 000..6979195
--- /dev/nu
Hi Jeevaka,
> Following patch adds a new mandatory coding rule and provides
> the coding style fixes according to the new rule.
all 7 patches have been applied. Thanks.
Regards
Marcel
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/li
Hi Anand,
> Infineon modem selftest, during ifx_enable().
> Two steps trigger, with timeout. In case one fails, modem will not power up.
so I would prefer if you use git send-email and then use linux.intel.com
as your SMTP server.
That way we are sure that Exchange does not mangle the email and
Hi Jeevaka,
> Following set of patches makes use of the defined call_status enum
> instead of using the actual defined values.
all 5 patches have been applied. Thanks.
Regards
Marcel
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/lis
Hi Mikhail,
> > > And the failure mode of the agent disconnecting is... to drop events
> > on the floor???
> >
> > Who said that? D-Bus is an asynchronous message bus with a method call
> > and a method return message. Where do you see events being dropped?
>
> When you receive a callback on Nam
Hi Mikhail,
> > In the text message case we already provide the history plugin with
> > _everything_ that it needs. If you want to implement a particular API,
> > then history is the right avenue to do so. There is no inherent
> > benefit
> > of having oFono core do so and we do not want to intr
Hi Mikhail,
> > > Why, you already cache fragments by their respective message refs
> > efficiently.
> > > The only thing missing is a thin API to provide a view on complete
> > messages.
> >
> > we are not storing the complete message. We give it to the history API.
>
> Somehow we never got to
Hi Mikhail,
> > > I totally agree. But it means that you have code in oFono to reliably
> > store an ordered collection of stuff in a filesystem. I wouldn't like
> > MeeGo developers to maintain very similar code in a different
> > component, just for API adaptation reasons.
> >
> > No we do not.
Hi Mikhail,
> > one of the really early design choices was to not expose TPDU outside
> > of
> > oFono core. We do not give TPDUs to history nor do we hand them out
> > over
> > D-Bus. That is a fundamental design decision and even after over 2
> > years
> > that is still the right one.
>
> I tot
Hi Jeevaka,
> with the latest modem firmware, xctms prefix
> is returned as per the 3GPP format.
> ---
> drivers/ifxmodem/ctm.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
___
ofono
Hi Konrad,
> test/test-sms | 102 +---
> 1 files changed, 60 insertions(+), 42 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
___
ofono mailing list
ofono@ofono.org
http://lists.ofon
Hi Mikhail,
> > >> I am not really getting what you are saying. oFono will reassembly
> > the
> > >> message for you piece by piece. And we are making sure fragments are
> > >> stored reliably. However once the message is complete we give it to
> > >> history for further processing. Mainly to get
Hi Kai,
> > So yes, there might be conditions where you crash before fsync really
> > completes and you lose the SMS. However, there's nothing in the world
> > you can do about this case anyway, since both the write and the fsync
> > succeeded.
>
> I think this is perfectly reasonable. Even if s
Hi Kai,
> >> - The history agent does not wait until the agent replies it has
> >> handled the message, but instead it calls agent_request_dispatch
> >> and then already returns to core (which acks the message to modem).
> >
> > I know this actually. The missing piece is the storing to disk h
Hi Mikhail,
> > How is this any better? If all messages get send when the agents
> > registers to oFono. And we can easily use D-Bus results to either
> > delete
> > messages from the spool or not. Since D-Bus is asynchronous and that
> > will just work out fine.
>
> Am I right in assuming that t
Hi Fred,
> > > plugins/ifx.c | 21 ++---
> > > 1 files changed, 2 insertions(+), 19 deletions(-)
> > >
> > > diff --git a/plugins/ifx.c b/plugins/ifx.c
> > > index 411c012..ae53193 100644
> > > --- a/plugins/ifx.c
> > > +++ b/plugins/ifx.c
> > > @@ -345,23 +345,6 @@ error:
> > >
Hi Jeevaka,
> plugins/ifx.c | 21 ++---
> 1 files changed, 2 insertions(+), 19 deletions(-)
>
> diff --git a/plugins/ifx.c b/plugins/ifx.c
> index 411c012..ae53193 100644
> --- a/plugins/ifx.c
> +++ b/plugins/ifx.c
> @@ -345,23 +345,6 @@ error:
> ofono_modem_set_powered(m
Hi Kai,
> here's a few comments about the SMS delivery part. These apply to
> the history plugin interface as well, so not specifically only about
> this patchset.
and this is just a RFC so I really want comments.
> > + void MessageReceived(dict info)
> > +
> > + In
Hi Konrad,
> Makefile.am |3 +-
> test/test-sms | 213
> +
> 2 files changed, 215 insertions(+), 1 deletions(-)
> create mode 100755 test/test-sms
patch has been applied.
I like this. Can we get a few more of these style test scri
Hi Aki,
> > > +enum isi_version {
> > > + ISI_20 = 0,
> > > + ISI_25 = 1
> > > +};
> >
> > so what is the final decision here now. ISI doing auto-detection and
> > this gets not exposed to the modem drivers or we do.
>
> Like I replied earlier, I don't see the need for this. Also, it will not
>
Hi Sjur,
> >> > The current API has 'gsm', 'umts', 'lte' and 'any'. I think you are
> >> > suggesting something like 'all-but-lte', right?
> >> I think it would be nice if user could be able to select multiple
> >> preferred bands, not just only one. The use case I came up with was
> >> this 'all
Hi Paavo,
> > The current API has 'gsm', 'umts', 'lte' and 'any'. I think you are
> > suggesting something like 'all-but-lte', right?
> I think it would be nice if user could be able to select multiple
> preferred bands, not just only one. The use case I came up with was
> this 'all-but-lte'.
ca
Hi Robertino,
> Infineon modem selftest, during ifx_enable().
> Two steps trigger, with timeout. In case one
> fails, modem will not power up.
>
> ---
> plugins/ifx.c | 58 ++--
> 1 files changed, 51 insertions(+), 7 deletions(-)
>
> diff --
Hi Aki,
> > > > How does a normal user actually know what this means for him and the
> > > > network he is using? Is the network actually honoring these values at
> > > > all these days?
> > >
> > > These are not clear to me either, so I don't see the point in exposing
> > > this setting over the
Hi Lucas,
> Here are some spelling fixes. The only relevant ones are those in the docs,
> but
> since they are trivial to be included, I'm sending this patch set fixing all
> of
> them. Feel free to ignore the others if you prefer.
>
> They were caught by a new tool I've made, codespell:
> http
Hi Lucas,
> Some fields in struct ofono_call such as cnap_validity and clip_validity
> are not correctly initialized as 0 since this means they are present. If
> driver does not implement the necessary handlers, it might send to core
> an ofono_call signalling that cnap and clip are available when
---
plugins/history-agent.c | 509 +++
1 files changed, 509 insertions(+), 0 deletions(-)
create mode 100644 plugins/history-agent.c
diff --git a/plugins/history-agent.c b/plugins/history-agent.c
new file mode 100644
index 000..42298c1
--- /dev/nu
---
doc/history-agent-api.txt | 83 +
1 files changed, 83 insertions(+), 0 deletions(-)
create mode 100644 doc/history-agent-api.txt
diff --git a/doc/history-agent-api.txt b/doc/history-agent-api.txt
new file mode 100644
index 000..373974d
--- /d
Hi Remi,
> drivers/atmodem/sim.c | 48
> 1 files changed, 48 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c
> index 0938998..dfd40f8 100644
> --- a/drivers/atmodem/sim.c
> +++ b/drivers/atmodem/sim.c
Hi Andreas,
> >> diff --git a/plugins/udev.c b/plugins/udev.c
> >> index ce1efe6..49b5eb8 100644
> >> --- a/plugins/udev.c
> >> +++ b/plugins/udev.c
> >> @@ -185,7 +185,8 @@ static void add_hso(struct ofono_modem *modem,
> >>devnode = udev_device_get_devnode(udev_device);
> >>
> >>
Hi Lasse,
> STE modems support standard AT commands in CBS
> ---
> plugins/ste.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.
Hi Jessica,
> drivers/isimodem/debug.c | 132
>
> drivers/isimodem/debug.h |9 +++
> drivers/isimodem/mtc.h | 38 +
> drivers/isimodem/version.h | 26 +
> 4 files changed, 205 insertions(+), 0 deletions(-)
> creat
Hi Jessica,
> Makefile.am |4 +
> plugins/ofono.rules |3 +
> plugins/u8500.c | 507
> +++
> 3 files changed, 514 insertions(+), 0 deletions(-)
> create mode 100644 plugins/u8500.c
as mentioned in the other email. Put ofono.r
Hi Jessica,
> plugins/udev.c |5 -
> 1 files changed, 4 insertions(+), 1 deletions(-)
so you wanna combine the udev rule change and the udev change together
actually. They both belong together. The actual modem plugin driver is
not related.
> diff --git a/plugins/udev.c b/plugins/udev.c
Hi Jeevaka,
> drivers/atmodem/sim.c | 46 ++
> 1 files changed, 46 insertions(+), 0 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.
Hi Remi,
> drivers/atmodem/sim.c | 48
> 1 files changed, 48 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c
> index 0938998..dfd40f8 100644
> --- a/drivers/atmodem/sim.c
> +++ b/drivers/atmodem/sim.c
Hi Jeevaka,
> drivers/atmodem/sim.c | 46 ++
> 1 files changed, 46 insertions(+), 0 deletions(-)
and this is conflicting with Remi's patch for the generic CPINR now.
Regards
Marcel
___
ofono mailing lis
Hi Robertino,
> Request for comments on attempt to integrate new kernel-space
> MUX driver with oFono, for Infineon modem
I am doing just a basic review here to get things going into the right
direction.
> ---
> drivers/ifxmodem/gprs-context.c | 82 +++-
> plug
Hi Denis,
> > On Thu, 2011-01-27 at 15:22 +0200, Jukka Saunamaki wrote:
> >> Here is an asynchronous implementation of SIM Service Provider Name
> >> (EF-SPN) getter API.
> >> The trick is to delay setting sim ready until spn reading is finished.
> >
> > Any comments about this?
> > So, yes, it
Hi Robertino,
> Infineon modem selftest, during ifx_enable().
> Two steps trigger, with timeout. In case one
> fails, modem will not power up.
>
> ---
> plugins/ifx.c | 50 +++---
> 1 files changed, 47 insertions(+), 3 deletions(-)
>
> diff --git a/
Hi Robertino,
> Infineon modem selftest, during ifx_enable().
> Two steps trigger, with timeout. In case one
> fails, modem will not power up.
>
> ---
> plugins/ifx.c | 112
> -
> 1 files changed, 95 insertions(+), 17 deletions(-)
>
> di
Hi Miia,
> > and what does this all buy you? There are so many funny ideas in GSM
> > that having nothing to do with reality anymore since the world has moved
> > on since 1995.
> First of all, I don't think people stopped drinking and sending stupid
> messages after 1995. Or that no one does any
301 - 400 of 1281 matches
Mail list logo
