[PATCH v4 1/7] plugins/ste: Include STK support from MBM driver.

From: Sjur Brændeland sjur.brandel...@stericsson.com --- Marcel Holtmann wrote: ... The build system builds the plugins properly and you can cross reference modem drivers from your modem plugin without any problems. Simply refering to MBM driver from ste.c one minor nitpick here. Can you

[PATCH v4 2/7] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks.

From: Sjur Brændeland sjur.brandel...@stericsson.com --- Marcel Holtmann wrote: ... do we really wanna create another vendor quirk here. If both modems behave identical then just pass OFONO_VENDOR_MBM in the SIM atom registration and be done with it. Re-use the MBM quirk rather than adding STE

[PATCH v4 6/7] stemodem: Use RTNL for creating CAIF interface

From: Sjur Brændeland sjur.brandel...@stericsson.com CAIF in Linux kernel 2.6.35 must use RTNL for configuring CAIF interfaces. --- drivers/stemodem/gprs-context.c | 51 +-- drivers/stemodem/rtnl.c | 318 +++ drivers/stemodem/rtnl.h

[PATCH 1/6] bugfix: distcheck fail due to rename of dataconnectionmanager-api.txt

--- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index 83aa8f3..2f0b745 100644 --- a/Makefile.am +++ b/Makefile.am @@ -301,7 +301,7 @@ doc_files = doc/overview.txt doc/ofono-paper.txt \

[PATCH 3/6] stemodem: Add support for STK.

Copy and rename stk.c from mbmmodem.c Original author: Andrzej Zaborowski andrew.zaborow...@intel.com --- Makefile.am |3 +- drivers/stemodem/stemodem.c |2 + drivers/stemodem/stemodem.h |2 + drivers/stemodem/stk.c | 245

[PATCH 5/6] stemodem: Add Radio Settings to STE Modem

--- Makefile.am |3 +- drivers/stemodem/radio-settings.c | 217 + drivers/stemodem/stemodem.c |2 + drivers/stemodem/stemodem.h |3 + plugins/ste.c |2 + 5 files changed, 226 insertions(+),

[PATCH 6/6] stemodem: Use RTNL for creating CAIF interface

CAIF in Linux kernel 2.6.35 must use RTNL for configuring CAIF interfaces. --- Makefile.am |4 +- drivers/stemodem/gprs-context.c | 51 +-- drivers/stemodem/rtnl.c | 313 +++ drivers/stemodem/rtnl.h | 24 +++ 4

Re: Terminating emergency calls

Denis Kenzior denk...@gmail.com wrote: I thought of one more issue with voice calls. I don't think it is safe to to terminate emergency calls using release_specific, AT+CHLD=1X. At least this don't work for STE modems. I suggest calls in state active should be terminated using hangup_all or

[PATCH 1/3] voicecall: Rename cb-function hangup to hangup_active in core and drivers.

From: Sjur Brændeland s...@sjur-laptop.(none) --- drivers/atmodem/voicecall.c |4 ++-- drivers/calypsomodem/voicecall.c |2 +- drivers/hfpmodem/voicecall.c |2 +- drivers/isimodem/voicecall.c |2 +- drivers/stemodem/voicecall.c |2 +- include/voicecall.h

[PATCH 3/3] voicecall: manager_hangup_all should not terminate waiting calls.

From: Sjur Brændeland s...@sjur-laptop.(none) --- src/voicecall.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 49b9c79..4341d29 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -758,15 +758,21 @@ static void

[PATCH 1/3] stedriver: remove unsupported CAIF socket IOCTLs.

From: Sjur Brændeland sjur.brandel...@stericsson.com --- drivers/stemodem/gprs-context.c | 48 +- 1 files changed, 2 insertions(+), 46 deletions(-) diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c index 2e54f9f..29ee446 100644

[PATCH 2/3] stedriver: Copy caif_socket.h from 2.6.36 release candidate.

From: Sjur Brændeland sjur.brandel...@stericsson.com Copied include/linux/caif/caif_socket.h and added AF_CAIF, PF_CAIF and SOL_CAIF definitions found in linux/include/socket.h. --- drivers/stemodem/caif_socket.h | 207 1 files changed, 123 insertions

[RFCv2] STE-driver: Terminating voice call in state DIALING/ALERTING.

From: Sjur Brændeland sjur.brandel...@stericsson.com This patch fixes problem with terminating calls in state DIALING/ALERTING for STE-modem. The main change is that voicecall-callback function hangup is split into the functions hangup_all and hangup_active. CHANGES: include/voicecall.h: o

Re: [RFC] STE-driver: Terminating voice call in state DIALING/ALERTING.

Hi Denis, Denis Kenzior wrote: I'm picking up a really old thread here... Yes a really old thread ;) Better late than never, right? :-) ... However, I think we can solve this even simpler if we just call hangup for any ALERTING/DIALING call.. This is a real gray area. On some devices this

[RFC] STE-driver: Terminating voice call in state DIALING/ALERTING.

From: Sjur Brændeland sjur.brandel...@stericsson.com This patch splits the callback hangup into hangup_all and hangup_active. --- Hi Denis, I'm picking up a really old thread here... Denis Kenzior wrote: c) If you have an call on hold and initiate a new call, but want to terminate the newly

RE: [PATCH 1/2] Fix: Username and Password must be set after context is created.

Hi Marcel. Marcel Holtmann wrote: len = sprintf(buf, AT+CGDCONT=%u,\IP\, ctx-cid); if (ctx-apn) snprintf(buf + len, sizeof(buf) - len - 3, ,\%s\, ctx-apn); +/* Set username and password. Must be done after context creation */ +len = strlen(buf); +

RE: [PATCH 2/2] Fix: Check if interface exists before creating it.

Hi Marcel. Marcel Holtmann wrote: Hi Sjur, diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c index c178fb6..79e697b 100644 --- a/drivers/stemodem/gprs-context.c +++ b/drivers/stemodem/gprs-context.c @@ -187,9 +187,11 @@ static gboolean caif_if_create(const

FW: FW: [RFC 3/3] STE-plugin: Adding STE plugin

Hi Denis. We have done some testing with the STE modem for call termination, and this is the result: TC |Call #1 | Call #2 | Call #3 | Command | Result ---| 1 |ACTIVE | ACTIVE | .. | ATH | call 1, 2

FW: [RFC 3/3] STE-plugin: Adding STE plugin

Hi Denis. Denis Kenzior denk...@gmail.com wrote: +static void ste_release_specific(struct ofono_voicecall *vc, int id, +ofono_voicecall_cb_t cb, void *data) { +struct voicecall_data *vd = ofono_voicecall_get_data(vc); +struct release_id_req *req =

RE: [RFC 3/3] STE-plugin: Adding STE plugin

Hi Marcel. Thank you for lots of feedback on patches. Marit who has done most of the implementation is gone for a few days so we'll have to wait until end of next week with the next oFono patch-set. Marcel Holtmann wrote: + /* Need to change to gsm_permissive syntax in order to + * parse

RE: [RFC 3/3] STE-plugin: Adding STE plugin

)); +channel = g_io_channel_unix_new(fd); You need to check the results of socket() and connect() calls. Sure, will fix this. Regards Sjur Brændeland ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

<    1   2