Re: [PATCH] hso: Set modem name based on udev network interface name

2010-11-07 Thread Benoît Monin
Hi Marcel, [Sorry for the delay] Le lundi 25 octobre 2010 14:15:55 Marcel Holtmann, vous avez écrit : > actually do you get the serial number from the USB descriptors? > No, the serial number comes from an AT command, I guess. > oFono does not have the concept of physical devices actually. We mo

Re: [PATCH] hso: Set modem name based on udev network interface name

2010-10-25 Thread Marcel Holtmann
Hi Benoit, please fix your mail client. You keep breaking threading every single time you respond. That is pretty annoying. > > the friendly modem name is for devices that do have a friendly name, > > like Bluetooth headsets. Why do you wanna misuse the interface name > > here. I am a bit against

Re: [PATCH] hso: Set modem name based on udev network interface name

2010-10-25 Thread Benoît Monin
Hi Marcel, > De : Marcel Holtmann > > Hi Benoit, > > the friendly modem name is for devices that do have a friendly name, > like Bluetooth headsets. Why do you wanna misuse the interface name > here. I am a bit against this, because it leads to speculation and > assumptions in userspace programs

Re: [PATCH] hso: Set modem name based on udev network interface name

2010-10-25 Thread Marcel Holtmann
Hi Benoit, > Subject: [PATCH] hso: Set modem name based on udev network interface name > > Useful if you have multiple identical modems and you need a way > to know which modem you're talking to. > --- > plugins/hso.c |6 ++ > 1 files changed, 6 insertions(+)

Re: [PATCH] hso: Set modem name based on udev network interface name

2010-10-25 Thread Benoît Monin
Hi Denis, > De : Denis Kenzior > > Hi Benoît, > > I prefer you do this in plugins/hso and not in udev. > Is the patch below correct ? I moved the call to set_name to hso_probe. Benoît -- Subject: [PATCH] hso: Set modem name based on udev network interface name Useful if

Re: [PATCH] hso: Set modem name based on udev network interface name

2010-10-22 Thread Denis Kenzior
Hi Benoît, On 10/21/2010 03:26 AM, "Benoît Monin" wrote: > Useful if you have multiple identical modems and you need a way > to know which modem you're talking to. > --- > plugins/udev.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/plugins/udev.c b/plugins/udev.c

[PATCH] hso: Set modem name based on udev network interface name

2010-10-21 Thread Benoît Monin
Useful if you have multiple identical modems and you need a way to know which modem you're talking to. --- plugins/udev.c |    1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index 737a637..e687c01 100644 --- a/plugins/udev.c +++ b/plugins/udev.c