Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-08 Thread Rémi Denis-Courmont
On Wednesday 08 December 2010 10:13:45 ext Aki Niemi, you wrote: > Hi Rémi, > > On Tue, 2010-12-07 at 18:12 +0200, ext Rémi Denis-Courmont wrote: > > More than one second delay over D-Bus is not unheard of, especially on > > mobile devices. I don't see the point of sending _both_ the reception > >

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-08 Thread Aki Niemi
Hi Marcel, 2010/12/8 Marcel Holtmann : >> is timed actually open source and I can have a look at it? > > so what about this? Where is the timed respository? I really wanna have > a look at it and see what it is doing. Knock yourself out: http://meego.gitorious.org/meego-middleware/timed Cheers,

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-08 Thread Marcel Holtmann
Hi Aki, > > > where is this timed running? I prefer the plugin just send a D-Bus > > > message to the timed directly instead of a Get/Changed API kind of > > > thing. > > > > AFAIK, timed is in system bus. However, I fail to see how you can make > > this any simpler. In the end, one of the two en

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-08 Thread Aki Niemi
Hi Rémi, On Tue, 2010-12-07 at 18:12 +0200, ext Rémi Denis-Courmont wrote: > More than one second delay over D-Bus is not unheard of, especially on mobile > devices. I don't see the point of sending _both_ the reception timestamp and > the original NITZ value, but I do see the point in sending a

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-07 Thread Rémi Denis-Courmont
On Tuesday 07 December 2010 09:51:57 ext Aki Niemi, you wrote: > > Passing the time over D-Bus may cause extra drift/imprecision than we > > already have. I wonder if it would make sense to provide not just the > > current time but both: > > - the current time for trivial programs, and > > - the sy

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-07 Thread Rémi Denis-Courmont
On Tuesday 07 December 2010 10:58:37 ext Marcel Holtmann, you wrote: > I have seen a bunch of devices where we have not a proper clock value to > begin with. And in that case there is nothing really useful we can do > with it, except just set the system clock right away. Are you kidding me? You cl

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-07 Thread Antti Paila
Hi Marcel, > I have seen a bunch of devices where we have not a proper clock value to > begin with. And in that case there is nothing really useful we can do > with it, except just set the system clock right away. We are not using any absolute time value from any clock, but instead we use relativ

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-07 Thread Antti Paila
> Hi Rémi, > > 2010/12/6 Rémi Denis-Courmont : > >> +static struct tm *refresh_nw_time(struct tm *nw_time, > >> + time_t received) > >> +{ > >> + time_t now, new_nw_time; > >> + > >> + now = get_monotonic_time(); > >> + new_nw_time = timegm(nw_time) + now -

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-07 Thread Marcel Holtmann
Hi Remi, > > > > where is this timed running? I prefer the plugin just send a D-Bus > > > > message to the timed directly instead of a Get/Changed API kind of > > > > thing. > > > > > > AFAIK, Get/Changed is the simplest functional way to avoid races, where > > > say oFono would receive the time

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-06 Thread Aki Niemi
Hi Rémi, 2010/12/6 Rémi Denis-Courmont : >> +static struct tm *refresh_nw_time(struct tm *nw_time, >> +                             time_t received) >> +{ >> +     time_t now, new_nw_time; >> + >> +     now = get_monotonic_time(); >> +     new_nw_time = timegm(nw_time) + now - received; >> +     r

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-06 Thread Rémi Denis-Courmont
On Tuesday 07 December 2010 01:29:34 ext Marcel Holtmann, you wrote: > > > where is this timed running? I prefer the plugin just send a D-Bus > > > message to the timed directly instead of a Get/Changed API kind of > > > thing. > > > > AFAIK, Get/Changed is the simplest functional way to avoid rac

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-06 Thread Marcel Holtmann
Hi Remi, > > > The only thing I would change here are the names. It's customary to > > > avoid repeating the interface name in the signal or method, but of > > > course the problem here is then what to call these. Maybe just Get() > > > and Changed()? ;-) > > > > > > Oh, and you probably should h

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-06 Thread Rémi Denis-Courmont
Nitpicking... On Friday 03 December 2010 11:47:26 ext Antti Paila, you wrote: > diff --git a/plugins/nettime.c b/plugins/nettime.c > new file mode 100644 > index 000..0f99bb1 > --- /dev/null > +++ b/plugins/nettime.c > @@ -0,0 +1,293 @@ > +/* > + * > + * oFono - Open Source Telephony > + * >

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-06 Thread Rémi Denis-Courmont
On Saturday 04 December 2010 02:02:56 ext Marcel Holtmann, you wrote: > Hi Aki, > > > The only thing I would change here are the names. It's customary to > > avoid repeating the interface name in the signal or method, but of > > course the problem here is then what to call these. Maybe just Get()

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-05 Thread Marcel Holtmann
Hi Aki, > > where is this timed running? I prefer the plugin just send a D-Bus > > message to the timed directly instead of a Get/Changed API kind of > > thing. > > AFAIK, timed is in system bus. However, I fail to see how you can make > this any simpler. In the end, one of the two entities has t

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-04 Thread Aki Niemi
Hi Marcel, 2010/12/4 Marcel Holtmann : > where is this timed running? I prefer the plugin just send a D-Bus > message to the timed directly instead of a Get/Changed API kind of > thing. AFAIK, timed is in system bus. However, I fail to see how you can make this any simpler. In the end, one of the

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-03 Thread Marcel Holtmann
Hi Aki, > The only thing I would change here are the names. It's customary to > avoid repeating the interface name in the signal or method, but of > course the problem here is then what to call these. Maybe just Get() > and Changed()? ;-) > > Oh, and you probably should have included a short desc

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-03 Thread Aki Niemi
Hi Antti, 2010/12/3 Antti Paila : > +static GDBusMethodTable nettime_methods[] = { > +       { "GetNetworkTime", "", "a{sv}", nettime_get_time }, > +       { } > +}; > + > +static GDBusSignalTable nettime_signals[] = { > +       { "NetworkTimeChanged", "a{sv}" }, > +       { } > +}; The only thin

[PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-03 Thread Antti Paila
--- include/dbus.h|1 + plugins/nettime.c | 293 + 2 files changed, 294 insertions(+), 0 deletions(-) create mode 100644 plugins/nettime.c diff --git a/include/dbus.h b/include/dbus.h index 9e29afb..0c48f83 100644 --- a/include/dbus.h