Hi Denis
Thank you for reviewing this series of patches. We shall submit new
versions according to your comments. Please find any other clarifying
points inline.
On Thu, 2010-12-09 at 09:36 +0100, ext Denis Kenzior wrote:
+
+static void voicecall_set_call_status(struct
Hi Dara,
If not, then using an enum defined in include/cdma-voicecall.h would be
better. One major benefit of defining a dedicated enum for CDMA is the
compiler checking that all enum values are being handled. If you re-use
the GSM version you would have to resort to using default
Hi Dara,
On 12/02/2010 05:31 PM, Dara Spieker-Doyle wrote:
---
Makefile.am |3 +-
src/cdma-voicecall.c | 449
++
src/common.c | 42 +
src/common.h | 14 ++
src/ofono.h |3 +
5 files
Hi Rajesh,
On 12/03/2010 03:34 PM, rajesh.naga...@elektrobit.com wrote:
Hi Dara,
-Original Message-
From: ofono-boun...@ofono.org
[mailto:ofono-boun...@ofono.org] On Behalf Of Dara Spieker-Doyle
Sent: 03 December 2010 13:21
+enum cdma_call_status {
+
Hi Denis
On Tue, 2010-12-07 at 04:16 +0100, ext Denis Kenzior wrote:
Hi Rajesh,
On 12/03/2010 03:34 PM, rajesh.naga...@elektrobit.com wrote:
Hi Dara,
-Original Message-
From: ofono-boun...@ofono.org
[mailto:ofono-boun...@ofono.org] On Behalf Of Dara Spieker-Doyle
Hi Rajesh
On Fri, 2010-12-03 at 01:30 +0100, ext rajesh.naga...@elektrobit.com
wrote:
+enum cdma_call_status {
+ CDMA_CALL_STATUS_ACTIVE = 0,
+ CDMA_CALL_STATUS_DIALING = 1,
+ CDMA_CALL_STATUS_ALERTING = 2,
+ CDMA_CALL_STATUS_INCOMING = 4,
Should be 3 ?
Yes indeed. I will
Hi Dara,
-Original Message-
From: ofono-boun...@ofono.org
[mailto:ofono-boun...@ofono.org] On Behalf Of Dara Spieker-Doyle
Sent: 03 December 2010 13:21
+enum cdma_call_status {
+ CDMA_CALL_STATUS_ACTIVE = 0,
+ CDMA_CALL_STATUS_DIALING = 1,
+ CDMA_CALL_STATUS_ALERTING =
---
Makefile.am |3 +-
src/cdma-voicecall.c | 449 ++
src/common.c | 42 +
src/common.h | 14 ++
src/ofono.h |3 +
5 files changed, 510 insertions(+), 1 deletions(-)
create mode 100644
Hi Dara,
+enum cdma_call_status {
+ CDMA_CALL_STATUS_ACTIVE = 0,
+ CDMA_CALL_STATUS_DIALING = 1,
+ CDMA_CALL_STATUS_ALERTING = 2,
+ CDMA_CALL_STATUS_INCOMING = 4,
Should be 3 ?
+ CDMA_CALL_STATUS_DISCONNECTED
+};
We can use the existing gsm call status itself ?
