Re: Need Clarification on DCS handling in Status Report for SMS

2010-12-02 Thread Denis Kenzior
Hi Rajesh, > > Yes, this is a bug. But rather than setting the DCS to default in > this case, we should rather not call that sms_dcs_decode() function > from ofono_sms_status_notify(), as the class information derived from > the DCS decoding is not used there and also we are not handling the > op

Re: Need Clarification on DCS handling in Status Report for SMS

2010-12-01 Thread Sankar
Hi Rajesh, On Thu, Dec 2, 2010 at 7:33 AM, wrote: > Hi Sankar, > > > In the decode SMS function, there is a check to find out if > > there is a PI (parameter identifier). If there is a PI and no > > DCS flag set, then the ofono core sets the dcs to default. If > > the PI itself is missing in th

RE: Need Clarification on DCS handling in Status Report for SMS

2010-12-01 Thread Rajesh.Nagaiah
Hi Sankar, > In the decode SMS function, there is a check to find out if > there is a PI (parameter identifier). If there is a PI and no > DCS flag set, then the ofono core sets the dcs to default. If > the PI itself is missing in the PDU received from the > network, then the dcs values are no

Need Clarification on DCS handling in Status Report for SMS

2010-12-01 Thread Sankar
Hi, While doing a code reading for ofono SMS, it is observed that there seems to be an issue with the way DCS is handled for SMS status report notify. In the decode SMS function, there is a check to find out if there is a PI (parameter identifier). If there is a PI and no DCS flag set, then the o