Re: Ofono has too tight limits for SIM lock code lengths

2011-01-28 Thread Pekka Pessi
Moro Jussi, 2011/1/27 Jussi Kangas jussi.kan...@tieto.com: so every single enum has kept some sort of proper namespacing. And I would really prefer to not break this for ofono_sim_password_type. I suppose u are talking about parameter name here? and OFONO_PASSWORD_PIN_TYPE_NET is somehow

Re: Ofono has too tight limits for SIM lock code lengths

2011-01-27 Thread Jussi Kangas
Hi Marcel, On Thu, 2011-01-27 at 15:09 +0200, Marcel Holtmann wrote: so every single enum has kept some sort of proper namespacing. And I would really prefer to not break this for ofono_sim_password_type. I suppose u are talking about parameter name here? and OFONO_PASSWORD_PIN_TYPE_NET is

Re: Ofono has too tight limits for SIM lock code lengths

2011-01-20 Thread Denis Kenzior
Hi Jussi, On 01/19/2011 03:04 AM, Jussi Kangas wrote: Hi, I've been testing SIM locks with Ofono and it looks to me that method is_valid_pin in src/common.c has somewhat too tight rules for PIN lenghts. SIM or subsidy lock codes can be longer than 8 digits (as dictated in 22.022 chapter

Ofono has too tight limits for SIM lock code lengths

2011-01-19 Thread Jussi Kangas
Hi, I've been testing SIM locks with Ofono and it looks to me that method is_valid_pin in src/common.c has somewhat too tight rules for PIN lenghts. SIM or subsidy lock codes can be longer than 8 digits (as dictated in 22.022 chapter 14) There are several ways to fix this. My current favourite