RE: [PATCH] G1: Add an SMS quirk for CNMI mode

2009-09-03 Thread Bastian, Waldo
- /* Mode doesn't matter, but sounds like 2 is the sanest option */ - if (!append_cnmi_element(buf, len, cnmi_opts[0], 2310, FALSE)) + if (data-vendor == OFONO_VENDOR_HTC_G1) + /* The G1 advertises support for mode 2, but returns an error + * if we attempt

Re: [PATCH] G1: Add an SMS quirk for CNMI mode

2009-09-03 Thread Denis Kenzior
Hi Waldo, Instead of having vendor checks all over the place, wouldn't it be cleaner if the plugin had a way to provide/fix cnmi_opts? For now we decided to do it this way, since providing arbitrary properties per atom seemed to be too much. The hope is that there are not many modems that

Re: [PATCH] G1: Add an SMS quirk for CNMI mode

2009-09-02 Thread Marcel Holtmann
Hi Andres, The G1 doesn't support mode2, despite advertising it. The G1 chokes w/ an Error 303 when we specify NMI mode 2. Adding a quirk to drop that mode from the supported list (just use mode 1) allows the G1 to properly deal with SMS. --- drivers/atmodem/sms.c| 19