Re: [Okular-devel] Review Request 122787: Saves the state, if Thumbnail side container should be displayed at startup or not

2015-07-12 Thread Albert Astals Cid
On mar. 16, 2015, 11:05 p.m., Albert Astals Cid wrote: Can you write an auto test for this? This sidebar thing breaks a lot, having it auto tested would be great. See the tests/ folder. ping? - Albert --- This is an

Re: [Okular-devel] Review Request 122752: Fixed change in mouse cursor appearance (when selected Selection tool)

2015-07-12 Thread Albert Astals Cid
On mar. 30, 2015, 6:11 p.m., Albert Astals Cid wrote: ui/pageview.cpp, line 3846 https://git.reviewboard.kde.org/r/122752/diff/3/?file=355849#file355849line3846 Where does this 5 come from? ping? - Albert --- This is an

[Okular-devel] [okular] [Bug 272258] okular should have rotate left and right shortcuts in the toolbar

2015-07-12 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=272258 Albert Astals Cid aa...@kde.org changed: What|Removed |Added CC||aa...@kde.org --- Comment #4

Re: [Okular-devel] Review Request 123676: FEATURE: Implement the '--unique-per-file' as suggested in Bug #319839

2015-07-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123676/#review82416 --- Hi Jonathan, thanks for the patch, sorry it took so much for

[Okular-devel] [okular] [Bug 272258] okular should have rotate left and right shortcuts in the toolbar

2015-07-12 Thread Clemens Nyffeler
https://bugs.kde.org/show_bug.cgi?id=272258 --- Comment #5 from Clemens Nyffeler cnyffe...@gmail.com --- Oh sweet, and there is an icons-only option too! Apologies for that post, that was quite premature. -- You are receiving this mail because: You are the assignee for the bug.

[Okular-devel] [okular] [Bug 272258] okular should have rotate left and right shortcuts in the toolbar

2015-07-12 Thread Clemens Nyffeler
https://bugs.kde.org/show_bug.cgi?id=272258 Clemens Nyffeler cnyffe...@gmail.com changed: What|Removed |Added CC||cnyffe...@gmail.com ---

[Okular-devel] [okular] [Bug 346264] okular crashed when reloading file via emacs

2015-07-12 Thread schochet
https://bugs.kde.org/show_bug.cgi?id=346264 --- Comment #9 from schoc...@post.tau.ac.il --- (In reply to Albert Astals Cid from comment #8) This is really strange, the two backtraces are totally different altogether and the fact that valgrinds makes your system crash is still even weirder.

Re: [Okular-devel] Review Request 124027: s/auto_ptr/unique_ptr/

2015-07-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124027/#review82383 --- Okular is being built in C++11 mode anyway Is it? Can you

Re: [Okular-devel] Review Request 119785: allow getting DPI from core/generator publically

2015-07-12 Thread Diggory Hardy
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119785/ --- (Updated jul. 12, 2015, 2:35 p.m.) Review request for Okular, Albert

[Okular-devel] [okular] [Bug 346264] okular crashed when reloading file via emacs

2015-07-12 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=346264 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|NEEDSINFO |UNCONFIRMED