Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

2016-07-20 Thread Fahad Al-Saidi
> On July 20, 2016, 6:29 p.m., Olivier Churlaud wrote: > > Mostly style correction. Then I think it will be fine. (I'll check again) Great. All requested changes done. Thanks - Fahad --- This is an automatically generated e-mail. To rep

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

2016-07-20 Thread Fahad Al-Saidi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/ --- (Updated July 21, 2016, 5:07 a.m.) Review request for Okular and Albert A

Re: [Okular-devel] Review Request 127628: [WIP] building against Qt 5

2016-07-20 Thread René J . V . Bertin
> On July 20, 2016, 10 p.m., Olivier Churlaud wrote: > > I think this can be dropped, as the frameworks branch is already in good > > shape. What do you think? If someone has duplicated (sort of) and gone beyond my efforts then well, then "this" might indeed be dropped. I got side-tracked comp

Re: [Okular-devel] Review Request 125847: Change pages in presentation mode by swiping on touch screen

2016-07-20 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125847/#review97676 --- As the port of the framework is not over, it cannot get new f

Re: [Okular-devel] Review Request 127628: [WIP] building against Qt 5

2016-07-20 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127628/#review97675 --- I think this can be dropped, as the frameworks branch is alre

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

2016-07-20 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/#review97673 --- Mostly style correction. Then I think it will be fine. (I'll

Re: [Okular-devel] Review Request 127541: Add support for importing annotations from another document.

2016-07-20 Thread Jonathan Verner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127541/#review97650 --- I don't want to be pushy, I know that time is scarce and peop

Re: [Okular-devel] Review Request 126445: i18n issue missing setApplicationDomain

2016-07-20 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126445/#review97648 --- This should be probably recommitted with the right author. -