Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130218/#review103584 --- Ship it! Ok, you're the printing maintainer now ;) Good

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-09 Thread Oliver Sander
> On Aug. 6, 2017, 3:17 p.m., Albert Astals Cid wrote: > > Rasterizing usually makes stuff look quite bad (because the wrong > > resolution is chosen) , have you tried printing text or things with sharp > > lines? > > Oliver Sander wrote: > Yes I tried that, and it looks very good. It

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-09 Thread Oliver Sander
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130218/ --- (Updated Aug. 9, 2017, 8:58 p.m.) Review request for Okular. Changes

[okular] [Bug 374728] Changing annotation colours

2017-08-09 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=374728 Christoph Feck changed: What|Removed |Added CC||andres...@gmail.com ---

[okular] [Bug 383331] Feature request: select highlight color with one click

2017-08-09 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=383331 Christoph Feck changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[okular] [Bug 169847] split view feature

2017-08-09 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=169847 Christoph Feck changed: What|Removed |Added CC||andres...@gmail.com ---

[okular] [Bug 383329] Feature request: split screen

2017-08-09 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=383329 Christoph Feck changed: What|Removed |Added Resolution|--- |DUPLICATE

[okular] [Bug 383331] Feature request: select highlight color with one click

2017-08-09 Thread andresimi
https://bugs.kde.org/show_bug.cgi?id=383331 andresimi changed: What|Removed |Added Keywords||usability

[okular] [Bug 383331] New: Feature request: select highlight color with one click

2017-08-09 Thread andresimi
https://bugs.kde.org/show_bug.cgi?id=383331 Bug ID: 383331 Summary: Feature request: select highlight color with one click Product: okular Version: unspecified Platform: Mint (Ubuntu based) OS: Linux Status:

[okular] [Bug 383329] Feature request: split screen

2017-08-09 Thread andresimi
https://bugs.kde.org/show_bug.cgi?id=383329 andresimi changed: What|Removed |Added Keywords||usability

[okular] [Bug 383329] New: Feature request: split screen

2017-08-09 Thread andresimi
https://bugs.kde.org/show_bug.cgi?id=383329 Bug ID: 383329 Summary: Feature request: split screen Product: okular Version: unspecified Platform: Mint (Ubuntu based) OS: Linux Status: UNCONFIRMED Severity:

Re: Review Request 130219: Enable background color to be changed from settings

2017-08-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130219/#review103582 --- Thanks for contributing to Okular :) Why would you need a

[okular] [Bug 383301] Feature request: one click selection highlight color, split screen of the same document

2017-08-09 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=383301 Albert Astals Cid changed: What|Removed |Added Resolution|--- |INVALID

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-09 Thread Albert Astals Cid
> On Aug. 6, 2017, 3:17 p.m., Albert Astals Cid wrote: > > Rasterizing usually makes stuff look quite bad (because the wrong > > resolution is chosen) , have you tried printing text or things with sharp > > lines? > > Oliver Sander wrote: > Yes I tried that, and it looks very good. It

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

2017-08-09 Thread Oliver Sander
> On Aug. 6, 2017, 3:17 p.m., Albert Astals Cid wrote: > > Rasterizing usually makes stuff look quite bad (because the wrong > > resolution is chosen) , have you tried printing text or things with sharp > > lines? > > Oliver Sander wrote: > Yes I tried that, and it looks very good. It

Re: Review Request 130219: Enable background color to be changed from settings

2017-08-09 Thread Albert Freeman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130219/ --- (Updated Aug. 9, 2017, 12:59 p.m.) Review request for Okular.

Re: What should okular background color be

2017-08-09 Thread Oliver Sander
Can you please add 'okular' as reviewer (under Reviewers --> groups). Because it is not on me to decide whether this features is wanted at all. smime.p7s Description: S/MIME Cryptographic Signature

Re: What should okular background color be

2017-08-09 Thread Albert Freeman
https://git.reviewboard.kde.org/r/130219/ On 9 August 2017 at 22:23, Oliver Sander wrote: > Hi Albert, > > can you please upload the patch to > >https://git.reviewboard.kde.org/ > > It is easier to review there. > > Thanks, > Oliver > >

[okular] [Bug 364809] can't print file that contains invalid UTF-8 sequence

2017-08-09 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=364809 --- Comment #15 from ralf...@gmx.de --- Indeed. % unsetenv LC_ALL % locale LANG=de_DE.UTF-8 LC_CTYPE="de_DE.UTF-8" LC_NUMERIC=POSIX LC_TIME="de_DE.UTF-8" LC_COLLATE="de_DE.UTF-8" LC_MONETARY="de_DE.UTF-8" LC_MESSAGES="de_DE.UTF-8"

Re: What should okular background color be

2017-08-09 Thread Oliver Sander
Hi Albert, can you please upload the patch to https://git.reviewboard.kde.org/ It is easier to review there. Thanks, Oliver smime.p7s Description: S/MIME Cryptographic Signature

[okular] [Bug 364809] can't print file that contains invalid UTF-8 sequence

2017-08-09 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=364809 --- Comment #14 from Luigi Toscano --- (In reply to ralfixx from comment #13) > Here is my locale (redirected from Bug-Id 383274) > > % locale > LANG=de_DE.UTF-8 > LC_CTYPE="C" > LC_NUMERIC="C" > LC_TIME="C" > LC_COLLATE="C"

[okular] [Bug 364809] can't print file that contains invalid UTF-8 sequence

2017-08-09 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=364809 --- Comment #13 from ralf...@gmx.de --- Here is my locale (redirected from Bug-Id 383274) % locale LANG=de_DE.UTF-8 LC_CTYPE="C" LC_NUMERIC="C" LC_TIME="C" LC_COLLATE="C" LC_MONETARY="C" LC_MESSAGES="C" LC_PAPER="C" LC_NAME="C" LC_ADDRESS="C"