D15205: Support setting font color for typewriter annotation

tobiasdeiminger edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15205 To: tobiasdeiminger Cc: kde-doc-english, sander, okular-devel, ngraham, skadinna, aacid

D15205: Support setting font color for typewriter annotation

tobiasdeiminger updated this revision to Diff 42457. tobiasdeiminger added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. Rebase on master. Some review fixes. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15205

[okular] [Bug 361792] [frameworks] Crash when closing Okular while form is in edit mode

https://bugs.kde.org/show_bug.cgi?id=361792 Oliver Sander changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[okular] [Bug 361792] [frameworks] Crash when closing Okular while form is in edit mode

https://bugs.kde.org/show_bug.cgi?id=361792 --- Comment #6 from don@gmail.com --- I tested it again and it doesn't crash for me anymore. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 361792] [frameworks] Crash when closing Okular while form is in edit mode

https://bugs.kde.org/show_bug.cgi?id=361792 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #5 from

[okular] [Bug 361792] [frameworks] Crash when closing Okular while form is in edit mode

https://bugs.kde.org/show_bug.cgi?id=361792 --- Comment #4 from don@gmail.com --- What information do you need? -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 386408] Text color printed incorrectly

https://bugs.kde.org/show_bug.cgi?id=386408 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #13 from Andrew Croutha

[okular] [Bug 396761] menu items "no text"

https://bugs.kde.org/show_bug.cgi?id=396761 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #14 from Andrew Croutha

[okular] [Bug 334343] when i open a PDF file an i make an annotation with the highlighter, i close the PDF file and i open again the same PDF all the pages are blank

https://bugs.kde.org/show_bug.cgi?id=334343 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #20 from Andrew Croutha

[okular] [Bug 394999] Fonts mangled when printed but look fine on screen

https://bugs.kde.org/show_bug.cgi?id=394999 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #6 from Andrew Croutham

[okular] [Bug 266739] okular ignores the printer settings

https://bugs.kde.org/show_bug.cgi?id=266739 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #12 from Andrew Croutha

[okular] [Bug 393459] text in file not shown in viewer

https://bugs.kde.org/show_bug.cgi?id=393459 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #14 from Andrew Croutha

[okular] [Bug 361792] [frameworks] Crash when closing Okular while form is in edit mode

https://bugs.kde.org/show_bug.cgi?id=361792 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew Croutham

[okular] [Bug 387925] Automatically switch from navigate to select mode after a delay

https://bugs.kde.org/show_bug.cgi?id=387925 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #5 from Andrew Croutham

[okular] [Bug 391385] Going to the presentation mode twice closes the document

https://bugs.kde.org/show_bug.cgi?id=391385 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #7 from Andrew Croutham

[okular] [Bug 396822] Form data are not printed out completely

https://bugs.kde.org/show_bug.cgi?id=396822 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #4 from Andrew Croutham

[okular] [Bug 392463] Okular segfaults all the time when used with emacs/latex

https://bugs.kde.org/show_bug.cgi?id=392463 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #6 from Andrew Croutham

[okular] [Bug 252596] okular printing options not working when printing to file (pdf/ps)

https://bugs.kde.org/show_bug.cgi?id=252596 Dr. Chapatin changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this m

[okular] [Bug 342927] More Vim-like shortcuts

https://bugs.kde.org/show_bug.cgi?id=342927 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #6 from Andrew Croutham

[okular] [Bug 375506] Crashing when highlighting in long document

https://bugs.kde.org/show_bug.cgi?id=375506 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #6 from Andrew Croutham

[kdelibs] [Bug 288086] No 'Pages' or 'Jobs' tabs in printing dialog

https://bugs.kde.org/show_bug.cgi?id=288086 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #8 from Andrew Croutham

[okular] [Bug 379497] Okular crashed when closing

https://bugs.kde.org/show_bug.cgi?id=379497 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew Croutham

[okular] [Bug 364809] can't print file that contains invalid UTF-8 sequence

https://bugs.kde.org/show_bug.cgi?id=364809 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #16 from Andrew Croutha

[okular] [Bug 378473] Medieval Sharp font does not print bold correctly

https://bugs.kde.org/show_bug.cgi?id=378473 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #9 from Andrew Croutham

[okular] [Bug 375747] Okular: bad font kerning when printing PDF

https://bugs.kde.org/show_bug.cgi?id=375747 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #2 from Andrew Croutham

[okular] [Bug 370967] Highlight and Underline do not work

https://bugs.kde.org/show_bug.cgi?id=370967 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #3 from Andrew Croutham

[okular] [Bug 378449] Fall back to PDF when file type cannot be inferred from extension

https://bugs.kde.org/show_bug.cgi?id=378449 Damian Nowak changed: What|Removed |Added Status|NEEDSINFO |REPORTED Resolution|WAITINGFORINFO

[okular] [Bug 357822] Superscript characters sometimes not displayed

https://bugs.kde.org/show_bug.cgi?id=357822 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #15 from Andrew Croutha

[okular] [Bug 376016] okular crash when opening a latex beamer presentation using the multimedia package

https://bugs.kde.org/show_bug.cgi?id=376016 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #2 from Andrew Croutham

[okular] [Bug 351670] Error opening arabic named PDFs

https://bugs.kde.org/show_bug.cgi?id=351670 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #19 from Andrew Croutha

[okular] [Bug 385458] pdf form remain blank in Bulgarian

https://bugs.kde.org/show_bug.cgi?id=385458 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #8 from Andrew Croutham

[okular] [Bug 378449] Fall back to PDF when file type cannot be inferred from extension

https://bugs.kde.org/show_bug.cgi?id=378449 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #8 from Andrew Croutham

[okular] [Bug 385980] Darstellungs Problem

https://bugs.kde.org/show_bug.cgi?id=385980 Andrew Crouthamel changed: What|Removed |Added Keywords||triaged --- Comment #6 from Andrew Croutham

[okular] [Bug 399118] Small feature suggestion: ability to remove the most-left pane in okular

https://bugs.kde.org/show_bug.cgi?id=399118 Nate Graham changed: What|Removed |Added Resolution|--- |WORKSFORME CC|

D15205: Support setting font color for typewriter annotation

tobiasdeiminger added inline comments. INLINE COMMENTS > editannottooldialog.cpp:275 > engineElement.setAttribute( QStringLiteral("type"), > QStringLiteral("PickPoint") ); > -engineElement.setAttribute( QStringLiteral("color"), > QStringLiteral("#00") ); > +engineEl