D18144: Implemented find function from console

joaonetto updated this revision to Diff 49349. joaonetto added a comment. Changed variable names and deleted QString after use REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18144?vs=49325=49349 BRANCH arcpatch-D18144 REVISION DETAIL

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#392071 , @sander wrote: > Guys, stop fighting. I'll make it optional in the next patch upload, all I need is a bit of time. Please make it so that once you click the box, it stays locked in through

D18144: Implemented find function from console

joaonetto added inline comments. INLINE COMMENTS > aacid wrote in part.cpp:1716 > That is, move the code from findTextOnStartUp here, also clean up the > textToFind variable. Tried this, didn't work for network files REPOSITORY R223 Okular REVISION DETAIL

D18144: Implemented find function from console

aacid added inline comments. INLINE COMMENTS > part.cpp:377 > +// also connect to the find argument from terminal, searching only after > loading file. > +connect(this, SIGNAL(completed()), this, SLOT(findTextOnStartUp())); > connect(this, ::ReadOnlyPart::canceled, this, >

D18179: PDF: Implement scaling for non-rasterized printing

aacid added a comment. In D18179#391915 , @michaelweghorn wrote: > In D18179#391664 , @aacid wrote: > > > Maybe an enum is better than a bool so if in the future more scaling options are

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

sander added a comment. Guys, stop fighting. I'll make it optional in the next patch upload, all I need is a bit of time. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18118 To: sander, #okular, ngraham Cc: gbodley, michaelweghorn, aacid, ngraham, okular-devel,

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#392035 , @aacid wrote: > In D18118#391950 , @gbodley wrote: > > > In D18118#391651 , @aacid wrote: > > > > > I

[okular] [Bug 403148] New: Cannot print in original size to paper printer

https://bugs.kde.org/show_bug.cgi?id=403148 Bug ID: 403148 Summary: Cannot print in original size to paper printer Product: okular Version: 1.4.3 Platform: Kubuntu Packages OS: Linux Status: REPORTED

Re: Help regarding GSOC contribution.

El dimecres, 9 de gener de 2019, a les 10:31:15 CET, Kurvesh Patel va escriure: > Hello, I'm Kurvesh from India and I'm new to open-source and decided to > work for ocular for GSOC 2019 . You mean okular, right? > I'm interested in this work so can anybody > guide me what specific work I want to

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

aacid added a comment. In D18118#391950 , @gbodley wrote: > In D18118#391651 , @aacid wrote: > > > I still object to this, you're changing the default behaviour of the software for the 0.03% of

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#391667 , @ngraham wrote: > In D18118#391655 , @aacid wrote: > > > In D18118#391654 , @ngraham wrote: > > > > > The

D18118: Presentation mode: go to previous page when left-clicking on left half of the page

gbodley added a comment. In D18118#391651 , @aacid wrote: > I still object to this, you're changing the default behaviour of the software for the 0.03% of users that use okular to play in a touch screen while playing the piano. As a

D18144: Implemented find function from console

joaonetto updated this revision to Diff 49325. joaonetto added a comment. Deleted remains and formatting issues REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18144?vs=49324=49325 BRANCH arcpatch-D18144_1 REVISION DETAIL

D18144: Implemented find function from console

joaonetto updated this revision to Diff 49324. joaonetto added a comment. Made changes that allows file to be searched only when loaded REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18144?vs=49206=49324 BRANCH arcpatch-D18144_1 REVISION DETAIL

D18179: PDF: Implement scaling for non-rasterized printing

michaelweghorn added a comment. In D18179#391664 , @aacid wrote: > Maybe an enum is better than a bool so if in the future more scaling options are implemented we don't need to change the signature again? Sounds reasonable. I'll change