Re: [Okular-devel] Branch 'epub-qtextdoc' review

On Wed, Jun 26, 2013 at 1:57 AM, Albert Astals Cid wrote: > El Dilluns, 24 de juny de 2013, a les 23:57:35, Jaydeep Solanki va > escriure: > > Hello, > > I have put together some of my work, in a branch named 'epub-qtextdoc'. > > > > It would be real

Re: [Okular-devel] Branch 'epub-qtextdoc' review

On Tue, Jun 25, 2013 at 7:39 PM, Fabio D'Urso wrote: > On Tuesday, June 25, 2013 06:32:52 PM Jaydeep Solanki wrote: > > On Tue, Jun 25, 2013 at 4:50 AM, Fabio D'Urso > wrote: > > > On Monday, June 24, 2013 11:57:35 PM Jaydeep Solanki wrote: > > > > He

Re: [Okular-devel] Branch 'epub-qtextdoc' review

On Tue, Jun 25, 2013 at 4:50 AM, Fabio D'Urso wrote: > On Monday, June 24, 2013 11:57:35 PM Jaydeep Solanki wrote: > > Hello, > > I have put together some of my work, in a branch named 'epub-qtextdoc'. > > > > It would be really nice if you can review it

[Okular-devel] Branch 'epub-qtextdoc' review

Hello, I have put together some of my work, in a branch named 'epub-qtextdoc'. It would be really nice if you can review it. Cheers, Jaydeep ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 111138: Make TextDocument_Generator Threaded

an wait. - Jaydeep --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/38/#review34919 --- On June 19, 2013, 7:26 p.m., J

[Okular-devel] Review Request 111138: Make TextDocument_Generator Threaded

drawingContent. Diffs - CMakeLists.txt 217337f core/textdocumentgenerator.cpp b260b3f Diff: http://git.reviewboard.kde.org/r/38/diff/ Testing --- Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https

Re: [Okular-devel] Epub qtextdocument high cpu usage

On Mon, Jun 17, 2013 at 11:31 PM, Albert Astals Cid wrote: > El Dilluns, 17 de juny de 2013, a les 21:42:23, Jaydeep Solanki va > escriure: > > On Sun, Jun 16, 2013 at 8:42 PM, Albert Astals Cid > wrote: > > > El Diumenge, 16 de juny de 2013, a les 20:2

Re: [Okular-devel] Epub qtextdocument high cpu usage

On Sun, Jun 16, 2013 at 8:42 PM, Albert Astals Cid wrote: > El Diumenge, 16 de juny de 2013, a les 20:29:37, Jaydeep Solanki va > escriure: > > Hello, > > As I was finding it difficult to make progress using webkit to render > epub, > > I spent some time experimentin

[Okular-devel] Epub qtextdocument high cpu usage

Hello, As I was finding it difficult to make progress using webkit to render epub, I spent some time experimenting around with QTextDocument. A small patch is attached which fixes the issues with the body tag (eg : background color). It works fine with me, the only issue I'm facing is that it give

[Okular-devel] Need sample epub

Hello, If you have an epub with non-white background, please forward it to me. I have had some success with an epub created by me [link ]. But I want to test it with a proper epub file. Cheers, Jaydeep __

Re: [Okular-devel] Epub - webkit, getting text bounds

On Wed, Jun 12, 2013 at 2:57 AM, Albert Astals Cid wrote: > El Dimecres, 12 de juny de 2013, a les 01:57:45, Jaydeep Solanki va > escriure: > > It would be great if you could suggest me something because I'm out of > > ideas. > > What's the problem? QtWebKit o

Re: [Okular-devel] Epub - webkit, getting text bounds

It would be great if you could suggest me something because I'm out of ideas. On Tue, Jun 11, 2013 at 11:44 PM, Albert Astals Cid wrote: > El Dimarts, 11 de juny de 2013, a les 16:26:07, Jaydeep Solanki va > escriure: > > The current version of QtWebkit works only with Qt

Re: [Okular-devel] Epub - webkit, getting text bounds

The current version of QtWebkit works only with Qt5, will that be a problem ? Cheers, Jaydeep On Mon, Jun 10, 2013 at 1:02 PM, Jaydeep Solanki wrote: > > > > On Sat, Jun 8, 2013 at 9:28 PM, Albert Astals Cid wrote: > >> El Divendres, 7 de juny de 2013, a les 23:35:4

Re: [Okular-devel] Epub - webkit, getting text bounds

On Sat, Jun 8, 2013 at 9:28 PM, Albert Astals Cid wrote: > El Divendres, 7 de juny de 2013, a les 23:35:41, Jaydeep Solanki va > escriure: > > Will it be a good idea to look for something in QtWebkit source that can > > get us bounding rects ? > > Makes sense, there is *

Re: [Okular-devel] Epub - webkit, getting text bounds

Will it be a good idea to look for something in QtWebkit source that can get us bounding rects ? Cheers, Jaydeep On Fri, Jun 7, 2013 at 3:41 AM, Jaydeep Solanki wrote: > But it will give the bounding rect of the HTML element, not the text. We > can use the box of the HTML element to p

Re: [Okular-devel] Epub - webkit, getting text bounds

org/5ysz1z79v/wrapp_all_arround.png> Cheers, Jaydeep On Fri, Jun 7, 2013 at 2:41 AM, Albert Astals Cid wrote: > El Dimarts, 4 de juny de 2013, a les 20:00:51, Jaydeep Solanki va escriure: > > On Mon, Jun 3, 2013 at 2:43 AM, Albert Astals Cid wrote: > > > El Dilluns, 3 de juny

Re: [Okular-devel] Epub - webkit, getting text bounds

On Mon, Jun 3, 2013 at 2:43 AM, Albert Astals Cid wrote: > El Dilluns, 3 de juny de 2013, a les 01:52:04, Jaydeep Solanki va escriure: > > Hi, > > While working on getting text bounds work I discovered that > > QWebFrame::hitTestContent(QPoint()) hits the outermost e

[Okular-devel] Epub - webkit, getting text bounds

Hi, While working on getting text bounds work I discovered that QWebFrame::hitTestContent(QPoint()) hits the outermost element, inside body. Consider the below HTML, some text... ... some other text.. Now we have two QPoints; QPoint pt1 => which points somewhere within p1 QPoint pt2 => which p

Re: [Okular-devel] Okular webkit - paginating issue

On Sat, May 25, 2013 at 2:52 AM, Jaydeep Solanki wrote: > Hi, > I'm having some pagination issues with webkit. > I'm unable to predict the number of pages in a document. > > In, EpubDocument::pageCount(), I'm calculating the number of pages taking > a standard

[Okular-devel] Fwd: Okular webkit - paginating issue

Hi, I'm having some pagination issues with webkit. I'm unable to predict the number of pages in a document. In, EpubDocument::pageCount(), I'm calculating the number of pages taking a standard page size (600,800), which is not always true, when viewed on a higher resolution the number of pages re

Re: [Okular-devel] demo epub - using webkit

On Wed, May 8, 2013 at 3:35 AM, Albert Astals Cid wrote: > El Diumenge, 5 de maig de 2013, a les 01:46:34, Jaydeep Solanki va > escriure: > > Hello, > > I have created a small app that opens epub files and renders them using > > webkit. > > It has a lot of bugs,

Re: [Okular-devel] Continuous mode

On Tue, May 7, 2013 at 3:35 AM, Albert Astals Cid wrote: > El Divendres, 3 de maig de 2013, a les 05:26:26, Jaydeep Solanki va > escriure: > > Hi, > > I would like to know how is continuous mode implemented in Okular.. > > Can you be a bit more precise? > Wat I wante

[Okular-devel] demo epub - using webkit

Hello, I have created a small app that opens epub files and renders them using webkit. It has a lot of bugs, but I just want to verify that the approach that I'm using is appropriate or not. To load the resources in webview, I use a subclass of QNetworkAccessManager, that gets the resources using

Re: [Okular-devel] Continuous mode

BTW, why is it that always Albert answers me, no one else o.O ? On Fri, May 3, 2013 at 5:26 AM, Jaydeep Solanki wrote: > Hi, > I would like to know how is continuous mode implemented in Okular.. > > Cheers, > Jaydeep > ___ Okular-

[Okular-devel] Continuous mode

Hi, I would like to know how is continuous mode implemented in Okular.. Cheers, Jaydeep ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] GSoC Proposal melange

Hello, I have submitted my proposal and here's the link <http://www.google-melange.com/gsoc/proposal/review/google/gsoc2013/jaydp17/1>to it. Hoping to see some reviews. Cheers, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kd

Re: [Okular-devel] Fwd: GSoC Proposal Draft

Would you like to see my final proposal before I submit ? Cheers, Jaydeep On Mon, Apr 22, 2013 at 9:27 AM, Jaydeep Solanki wrote: > > > > On Mon, Apr 22, 2013 at 2:54 AM, Albert Astals Cid wrote: > >> El Dissabte, 20 d'abril de 2013, a les 18:07:20, Jaydeep Sola

Re: [Okular-devel] Fwd: GSoC Proposal Draft

On Mon, Apr 22, 2013 at 2:54 AM, Albert Astals Cid wrote: > El Dissabte, 20 d'abril de 2013, a les 18:07:20, Jaydeep Solanki va > escriure: > > I would go for webkit, because as HTML develops webkit developers will > > improve it where as in QTextDocument case it'

Re: [Okular-devel] Fwd: GSoC Proposal Draft

n Fri, Apr 19, 2013 at 2:54 AM, Albert Astals Cid wrote: > El Dijous, 18 d'abril de 2013, a les 23:49:00, Jaydeep Solanki va escriure: > > Incase my previous mail didn't reach you because of heavy attachment, > here > > is another one. > > Hello, > >

[Okular-devel] Fwd: GSoC Proposal Draft

Incase my previous mail didn't reach you because of heavy attachment, here is another one. Hello, I would be really happy if you can review the proposal that I have created. Proposal link : http://db.tt/7pynIIKN Thank you. Cheers, Jaydeep So

Re: [Okular-devel] Okular - Google Summer of Code 2013

On Wed, Apr 17, 2013 at 3:16 AM, Albert Astals Cid wrote: > El Dimarts, 16 d'abril de 2013, a les 12:52:32, Jaydeep Solanki va > escriure: > > I wanted to know if the ideas (bugs) that I have listed above, are those > > good enough to be a gsoc project ? > > It may b

Re: [Okular-devel] Okular - Google Summer of Code 2013

epub stuff. But after all it's your choice, what you consider as a more important improvement :) Cheers, Jaydeep On Tue, Apr 16, 2013 at 12:52 PM, Jaydeep Solanki wrote: > I wanted to know if the ideas (bugs) that I have listed above, are those > good enough to be a gsoc proje

Re: [Okular-devel] Okular - Google Summer of Code 2013

I wanted to know if the ideas (bugs) that I have listed above, are those good enough to be a gsoc project ? Regards, Jaydeep On Tue, Apr 16, 2013 at 3:45 AM, Albert Astals Cid wrote: > El Divendres, 12 d'abril de 2013, a les 23:08:00, Jaydeep Solanki va > escriure: > > Hi, &g

Re: [Okular-devel] Okular - Google Summer of Code 2013

s is what I came across. Suggestions ? The attachment can be found here <http://db.tt/Ul5agKjA>. Regards, Jaydeep On Tue, Apr 9, 2013 at 11:05 PM, Albert Astals Cid wrote: > El Dimarts, 9 d'abril de 2013, a les 12:26:07, Jaydeep Solanki va escriure: > > Hi, > > I would li

[Okular-devel] Okular - Google Summer of Code 2013

Hi, I would like to know, if the css problem that we are facing in epubs, can I have that as my GSoC 2013 project ? Regards, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 109041: Change search highlight color

sit: http://git.reviewboard.kde.org/r/109041/#review30386 --- On Feb. 19, 2013, 12:45 p.m., Jaydeep Solanki wrote: > > --- > This is an automatically generated e-mail. To re

Re: [Okular-devel] Regarding css in epubs

On Tue, Apr 2, 2013 at 4:17 AM, Albert Astals Cid wrote: > El Dilluns, 1 d'abril de 2013, a les 13:52:27, Jaydeep Solanki va escriure: > > Hello, > > I remember Albert, telling me about css being ignored in epub documents, > so > > I had a look into it. > >

Re: [Okular-devel] Regarding css in epubs

On Mon, Apr 1, 2013 at 11:55 PM, Azat Khuzhin wrote: > Hi > > Respectfully > Azat Khuzhin. > From phone. > > On Apr 1, 2013 12:22 PM, "Jaydeep Solanki" wrote: > > > > Hello, > > I remember Albert, telling me about css being ignored in epub docum

[Okular-devel] Regarding css in epubs

Here <http://paste.kde.org/713162/> is something that I tried. Please have a look at it. Cheers, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 108614: Open url in browser

, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Fwd: [Kde-pim] Get ready for GSoC! KDE++ aka Polishing Existing Things

On Tue, Mar 26, 2013 at 1:07 AM, Yuri Chornoivan wrote: > написане Mon, 25 Mar 2013 21:34:00 +0200, Jaydeep Solanki < > jayd...@gmail.com>: > > > On Tue, Mar 26, 2013 at 12:58 AM, Albert Astals Cid >> wrote: >> >> El Dimarts, 26 de març de 2013, a les 00

Re: [Okular-devel] Fwd: [Kde-pim] Get ready for GSoC! KDE++ aka Polishing Existing Things

On Tue, Mar 26, 2013 at 12:58 AM, Albert Astals Cid wrote: > El Dimarts, 26 de març de 2013, a les 00:37:56, Jaydeep Solanki va > escriure: > > -- Forwarded message -- > > From: Lydia Pintscher > > Date: Mon, Mar 25, 2013 at 1:52 AM > > Subject: Re

[Okular-devel] Fwd: [Kde-pim] Get ready for GSoC! KDE++ aka Polishing Existing Things

f we add an idea for Okular, something like polish okular, where the students would be given tasks to fix certain parts of Okular that you think need improvement. Or something that you have in your mind. Please I want to see Okular this year in GSoC. Regards, Jaydeep Solanki We need to finish ou

Re: [Okular-devel] Review Request 108614: Open url in browser

. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 108614: Open url in browser

pears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 108614: Open url in browser

an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 108614: Open url in browser

/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 108614: Open url in browser

> On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote: > > Seems more appropriate for me. But one more thing, is reg1 still needed? > > Jaydeep Solanki wrote: > Yes, because it prevents "asdfhttp://www.google.com"; from getting > detected. > > Azat Khuzh

Re: [Okular-devel] Review Request 108614: Open url in browser

> On March 10, 2013, 12:27 a.m., Azat Khuzhin wrote: > > Seems more appropriate for me. But one more thing, is reg1 still needed? > > Jaydeep Solanki wrote: > Yes, because it prevents "asdfhttp://www.google.com"; from getting > detected. > > Azat Khuzh

Re: [Okular-devel] Review Request 108614: Open url in browser

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/#review28857 --- On March 9, 2013, 8:13 p.m., Jaydeep Solanki wrote: > > ---

Re: [Okular-devel] Review Request 108614: Open url in browser

Diffs (updated) - ui/pageview.cpp b018dfe Diff: http://git.reviewboard.kde.org/r/108614/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing

Re: [Okular-devel] Review Request 108614: Open url in browser

Diffs (updated) - ui/pageview.cpp b018dfe Diff: http://git.reviewboard.kde.org/r/108614/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing

Re: [Okular-devel] Review Request 108614: Open url in browser

/pageview.cpp b018dfe Diff: http://git.reviewboard.kde.org/r/108614/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https

Re: [Okular-devel] Review Request 108614: Open url in browser

if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 108614: Open url in browser

kde.org/r/108614/#review28357 --- On Feb. 24, 2013, 1:55 a.m., Jaydeep Solanki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewb

Re: [Okular-devel] Review Request 108614: Open url in browser

used to positively and negatively test > > the regexp so we can put it in a testcase > > Jaydeep Solanki wrote: > You mean "holahttps://okular.org"; should not be detected as an url, & > "hola https://okular.org"; should be. > Am I right ??

Re: [Okular-devel] Review Request 108614: Open url in browser

Diffs (updated) - ui/pageview.cpp 60a273d Diff: http://git.reviewboard.kde.org/r/108614/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing

Re: [Okular-devel] Review Request 108614: Open url in browser

-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/#review27846 --- On Feb. 20, 2013, 2:21 p.m., Jaydeep Solanki wrote: > > --

Re: [Okular-devel] Review Request 108614: Open url in browser

Diff: http://git.reviewboard.kde.org/r/108614/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org

Re: [Okular-devel] Review Request 109041: Change search highlight color

highlights to a specific color. - Jaydeep --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109041/#review27755 ------- On Feb.

[Okular-devel] Review Request 109041: Change search highlight color

://git.reviewboard.kde.org/r/109041/diff/ Testing --- Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 108614: Open url in browser

> On Jan. 27, 2013, 7:02 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 2775 > > <http://git.reviewboard.kde.org/r/108614/diff/1/?file=109368#file109368line2775> > > > > Why did you decide that icon name? > > Jaydeep Solanki wrote: >

Re: [Okular-devel] Review Request 108614: Open url in browser

ows an icon. I decided to keep, the later one because I have used it in one of my apps, & at that time it worked. - Jaydeep --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108614/#review26271 --

Re: [Okular-devel] Review Request 108614: Open url in browser

/pageview.cpp 60a273d Diff: http://git.reviewboard.kde.org/r/108614/diff/ Testing --- just check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https

Re: [Okular-devel] Okular - GSoC 2013

On Thu, Feb 14, 2013 at 3:51 AM, Albert Astals Cid wrote: > El Dimecres, 13 de febrer de 2013, a les 22:24:16, Jaydeep Solanki va > escriure: > > Hi, > > I just wanted to inquire if Okular is going to be a part of Google Summer > > of Code 2013. > > &

[Okular-devel] Okular - GSoC 2013

Hi, I just wanted to inquire if Okular is going to be a part of Google Summer of Code 2013. I saw some ideas here , & I'm curious to know about Okular. Regards, Jaydeep ___ Okular-devel mailing list Okular-devel

[Okular-devel] regarding bug 281027

Hi Albert, I'm sorry to say, but my exams are approaching so will it be okay if I delay the fix a bit ?? Regards, Jaydeep ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 108614: Open url in browser

check if the icon appears properly, because I have an issue with the icon. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Right Click Kmenu Problem

please ignore the previous mail I found the answer. On Sat, Jan 26, 2013 at 11:41 PM, Jaydeep Solanki wrote: > Hi, > I have a tiny issue with the Kmenu that appears when a selected text is > right clicked. > > I have attached a screenshot, please let me know if you have any idea

Re: [Okular-devel] TOC Reload

On Fri, Jan 18, 2013 at 10:34 PM, Albert Astals Cid wrote: > > --- El vie, 18/1/13, Albert Astals Cid escribió: > > > > --- El vie, 18/1/13, Jaydeep Solanki escribió: > > > Hi, > > > can you please confirm if the toc reload is working, because it's

[Okular-devel] TOC Reload

Hi, can you please confirm if the toc reload is working, because it's not working with me. Jaydeep ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Feature - Open url in browser

Hi, I would like to implement a feature (Bug 281027) where the mouse pointer changes to pointing_hand when hovered over a url. I guess we have two options: i ) during the load time of the document fill in the url info, just like SourceReferences. ii ) w

[Okular-devel] Review Request 108404: Bugs in toc reload

9bd ui/tocmodel.h 42d6533 ui/tocmodel.cpp 214a218 Diff: http://git.reviewboard.kde.org/r/108404/diff/ Testing --- Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 107994: Unfolded toc remains unfolded on reload unless the file is changed

Diff: http://git.reviewboard.kde.org/r/107994/diff/ Testing --- Checked. Works fine with me. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

=312138 Diffs (updated) - part.cpp 1922128 ui/toc.h eeeff98 ui/toc.cpp 4c84b62 ui/tocmodel.h a857dc0 ui/tocmodel.cpp 39add80 Diff: http://git.reviewboard.kde.org/r/107994/diff/ Testing --- Checked. Works fine with me. Thanks, Jaydeep Solanki

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

?id=312138 Diffs (updated) - part.cpp 1922128 ui/toc.h eeeff98 ui/toc.cpp 4c84b62 ui/tocmodel.h a857dc0 ui/tocmodel.cpp 39add80 Diff: http://git.reviewboard.kde.org/r/107994/diff/ Testing --- Checked. Works fine with me. Thanks, Jaydeep Solanki

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

://bugs.kde.org/show_bug.cgi?id=312138 Diffs (updated) - part.cpp 1922128 ui/toc.h eeeff98 ui/toc.cpp 4c84b62 ui/tocmodel.h a857dc0 ui/tocmodel.cpp 39add80 Diff: http://git.reviewboard.kde.org/r/107994/diff/ Testing --- Checked. Works fine with me. Thanks, Jaydeep Solanki

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

> On Jan. 2, 2013, 9:46 p.m., Albert Astals Cid wrote: > > part.cpp, line 1622 > > <http://git.reviewboard.kde.org/r/107994/diff/5/?file=103405#file103405line1622> > > > > Do we really need this collapse here? > > Jaydeep Solanki wrote: > yes

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

> On Jan. 2, 2013, 9:46 p.m., Albert Astals Cid wrote: > > part.cpp, line 1622 > > <http://git.reviewboard.kde.org/r/107994/diff/5/?file=103405#file103405line1622> > > > > Do we really need this collapse here? > > Jaydeep Solanki wrote: > yes

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

at node will also get expanded. - Jaydeep --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107994/#review24512 ------- On Dec. 31, 2012, 2 p.m., Jaydeep Solanki wrote: > >

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

/show_bug.cgi?id=312138 Diffs (updated) - part.h 0c57560 part.cpp 1922128 ui/toc.h eeeff98 ui/toc.cpp 4c84b62 ui/tocmodel.h a857dc0 ui/tocmodel.cpp 39add80 Diff: http://git.reviewboard.kde.org/r/107994/diff/ Testing --- Checked. Works fine with me. Thanks, Jaydeep Solanki

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

> On Dec. 28, 2012, 11:56 p.m., Albert Astals Cid wrote: > > Why did you add an "id"? What is that "id" supposed to mean? > > Jaydeep Solanki wrote: > because when the display name of two nodes are same, okular won't know > which one to expand

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

/show_bug.cgi?id=312138 Diffs (updated) - part.h 0c57560 part.cpp 1922128 ui/toc.h eeeff98 ui/toc.cpp 4c84b62 ui/tocmodel.h a857dc0 ui/tocmodel.cpp 39add80 Diff: http://git.reviewboard.kde.org/r/107994/diff/ Testing --- Checked. Works fine with me. Thanks, Jaydeep Solanki

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

> On Dec. 28, 2012, 11:56 p.m., Albert Astals Cid wrote: > > Why did you add an "id"? What is that "id" supposed to mean? > > Jaydeep Solanki wrote: > because when the display name of two nodes are same, okular won't know > which one to expand

Re: [Okular-devel] Regarding okular generators

On Sun, Dec 30, 2012 at 12:50 AM, Albert Astals Cid wrote: > El Diumenge, 30 de desembre de 2012, a les 00:30:41, Jaydeep Solanki va > escriure: > > I'm aware about Textpage algorithms that regardless of the generator, > makes > > text selection work properly in column

Re: [Okular-devel] Regarding okular generators

On Sun, Dec 30, 2012 at 12:46 AM, Albert Astals Cid wrote: > El Diumenge, 30 de desembre de 2012, a les 00:30:41, Jaydeep Solanki va > escriure: > > I'm aware about Textpage algorithms that regardless of the generator, > makes > > text selection work properly in column

Re: [Okular-devel] Regarding okular generators

ec 29, 2012 at 11:22 PM, Albert Astals Cid wrote: > El Dissabte, 29 de desembre de 2012, a les 22:56:12, Jaydeep Solanki va > escriure: > > As you might be knowing that Poppler::Page::textList() generates text in > > the correct order (i.e. left to right). Now poppler not only

Re: [Okular-devel] [Bug 312138] Unfolded table of contents folds in upon reloading of document

Oh sorry, that was meant to be on a new thread. On Sat, Dec 29, 2012 at 8:46 PM, Albert Astals Cid wrote: > El Dissabte, 29 de desembre de 2012, a les 06:28:09, Jaydeep Solanki va > escriure: > > On Sat, Dec 29, 2012 at 5:25 AM, Albert Astals Cid > wrote: > > > El Dis

[Okular-devel] Regarding okular generators

As you might be knowing that Poppler::Page::textList() generates text in the correct order (i.e. left to right). Now poppler not only generates it in the correct order but it also considers the layout, for example in a two column document, it follows the column layout while indexing the text. [imag

Re: [Okular-devel] [Bug 312138] Unfolded table of contents folds in upon reloading of document

On Sat, Dec 29, 2012 at 5:25 AM, Albert Astals Cid wrote: > El Dissabte, 29 de desembre de 2012, a les 04:47:08, Jaydeep Solanki va > escriure: > > All the libraries that Okular generators use, do all of them generate > text > > in the correct order ? > > By correct

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

--- On Dec. 28, 2012, 11:15 p.m., Jaydeep Solanki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107994/ > --

Re: [Okular-devel] [Bug 312138] Unfolded table of contents folds in upon reloading of document

wrote: > El Divendres, 28 de desembre de 2012, a les 01:48:55, Jaydeep Solanki va > escriure: > > I would like to give it a try, please point me to the source. > > You know where the source is ;-) > > Have you tried searching for where the code that is responsible of this &

[Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

/toc.h eeeff98 ui/toc.cpp 4c84b62 ui/tocmodel.h a857dc0 ui/tocmodel.cpp 39add80 Diff: http://git.reviewboard.kde.org/r/107994/diff/ Testing --- Checked. Works fine with me. Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel

Re: [Okular-devel] [Bug 312138] Unfolded table of contents folds in upon reloading of document

I would like to give it a try, please point me to the source. & in the case where the toc is updated/changed, I guess that part should remain folded & the rest should restore to it's previous state. What's your opinion on this ?? btw is this for the reload action only, or is it about to store it &

[Okular-devel] Interested in working on presentation mode

s the presenter screen & the audience see only the current page. Correct my if I'm wrong. Regards, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: GUI to configure the Graphics Anti-alias.

--------- On Nov. 15, 2012, 8:23 p.m., Jaydeep Solanki wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106660/ >

Re: [Okular-devel] Review Request: GUI to configure the Graphics Anti-alias.

tp://git.reviewboard.kde.org/r/106660/#review21979 ----------- On Nov. 15, 2012, 8:23 p.m., Jaydeep Solanki wrote: > > --- > This is an automatically generated e-mail.

Re: [Okular-devel] Review Request: GUI to configure the Graphics Anti-alias.

e.ui 3a9f9aa conf/okular_core.kcfg e807cbc Diff: http://git.reviewboard.kde.org/r/106660/diff/ Testing --- Thanks, Jaydeep Solanki ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

<    1   2   3   >