Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review20442 --- This review has been submitted with commit 7ce6990098755f5318b

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

> On Oct. 6, 2012, 6:12 p.m., Albert Astals Cid wrote: > > Hmmm, having that perl script seems an ugly workaround, i'll see if we can > > get kconf_update fixed thanks for the work so far :-) Indeed, it is not the best solution. Please let me know if I can help with kconf_update. - Bogdan

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review20017 --- Hmmm, having that perl script seems an ugly workaround, i'll se

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated Oct. 6, 2012, 12:49 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review19797 --- I'm getting this at .kde/share/apps/kconf_update/log/update.log

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

> On Sept. 26, 2012, 9:14 p.m., Albert Astals Cid wrote: > > If we are not going to change it to a different file, do we really need the > > upd file? Yes, because some keys belong now to different groups. However, if we decide to change also the settings file name, that will imply only a mino

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review19480 --- If we are not going to change it to a different file, do we rea

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

> On Sept. 8, 2012, 1:46 p.m., Albert Astals Cid wrote: > > okular.upd, line 5 > > > > > > Seems, you are missing the mention of the old file here, no? > > http://techbase.kde.org/Development/Tools/Using_kconf_update

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated Sept. 26, 2012, 8:25 p.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review18686 --- okular.upd

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated Aug. 26, 2012, 7:31 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated Aug. 26, 2012, 7:31 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review15696 --- This looks great, there is only one problem left, since we now

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

> On June 18, 2012, 8:59 p.m., Albert Astals Cid wrote: > > Why did you add a new patch file instead of updating the review request? It > > makes it kind of difficult to continue the review if we have the code > > splitting in two different places, can you update the review request patch, > >

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated June 19, 2012, 7:23 p.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review14866 --- Why did you add a new patch file instead of updating the review

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

> On June 5, 2012, 8:35 p.m., Albert Astals Cid wrote: > > part.cpp, line 286 > > > > > > Are you sure we need all this SettingsCore calls here? Seems a bit > > weird they are needed if Settings inherits from Setti

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated June 17, 2012, 10:27 p.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

> On June 5, 2012, 8:35 p.m., Albert Astals Cid wrote: > > part.cpp, line 286 > > > > > > Are you sure we need all this SettingsCore calls here? Seems a bit > > weird they are needed if Settings inherits from Setti

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

> On June 5, 2012, 8:35 p.m., Albert Astals Cid wrote: > > part.cpp, line 286 > > > > > > Are you sure we need all this SettingsCore calls here? Seems a bit > > weird they are needed if Settings inherits from Setti

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review14433 --- okular.spec

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

> On May 22, 2012, 10:48 p.m., Albert Astals Cid wrote: > > Hmmm, having a bad feeling about this, have you actually checked that > > changing the memory usage level from the config dialog still works? You were correct, Settings class needs to be derived from SettingsCore in order to have all

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated June 3, 2012, 8:30 p.m.) Review request for Okular. Description

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated June 3, 2012, 8:28 p.m.) Review request for Okular. Changes ---

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review14067 --- Hmmm, having a bad feeling about this, have you actually checke

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- (Updated May 16, 2012, 4:38 p.m.) Review request for Okular. Changes ---

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

> On May 15, 2012, 9:38 p.m., Albert Astals Cid wrote: > > Why is EnableCompositing in core if it is only used in ui? > > Bogdan Cristea wrote: > It belongs to "Dlg Performance" group, same as "MemoryLevel" entry which > is used in core, because I have tried to keep groups intact. If that i

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

> On May 15, 2012, 9:38 p.m., Albert Astals Cid wrote: > > Why is EnableCompositing in core if it is only used in ui? It belongs to "Dlg Performance" group, same as "MemoryLevel" entry which is used in core, because I have tried to keep groups intact. If that is ok, I could split the groups to

Re: [Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/#review13868 --- Why is EnableCompositing in core if it is only used in ui? - A

[Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- Review request for Okular. Description --- Default settings file shou

[Okular-devel] Review Request: Default settings file is separated in two files corresponding to the back end and the front end

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104947/ --- Review request for Okular. Description --- Default settings file shou