Re: [Okular-devel] Review Request: make core/document.cpp compile without warning when QT_ASCII_CAST_WARNINGS is set

2012-09-11 Thread Albert Astals Cid
On Aug. 28, 2011, 6:54 p.m., Albert Astals Cid wrote: Personally i do not like this kind of change because i've been already bit by Laurent blindly changing some code in KTuberling to fix this and the code stopping to work. I am not going to make the silly effort to make sure you

Re: [Okular-devel] Review Request: make core/document.cpp compile without warning when QT_ASCII_CAST_WARNINGS is set

2012-07-19 Thread Albert Astals Cid
On Aug. 28, 2011, 6:54 p.m., Albert Astals Cid wrote: Personally i do not like this kind of change because i've been already bit by Laurent blindly changing some code in KTuberling to fix this and the code stopping to work. I am not going to make the silly effort to make sure you

Re: [Okular-devel] Review Request: make core/document.cpp compile without warning when QT_ASCII_CAST_WARNINGS is set

2011-12-28 Thread Albert Astals Cid
On Aug. 28, 2011, 6:54 p.m., Albert Astals Cid wrote: Personally i do not like this kind of change because i've been already bit by Laurent blindly changing some code in KTuberling to fix this and the code stopping to work. I am not going to make the silly effort to make sure you

Re: [Okular-devel] Review Request: make core/document.cpp compile without warning when QT_ASCII_CAST_WARNINGS is set

2011-08-28 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102453/ --- (Updated Aug. 27, 2011, 11:57 a.m.) Review request for Okular. Changes

[Okular-devel] Review Request: make core/document.cpp compile without warning when QT_ASCII_CAST_WARNINGS is set

2011-08-28 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102453/ --- Review request for Okular. Summary --- Or: flood code with

Re: [Okular-devel] Review Request: make core/document.cpp compile without warning when QT_ASCII_CAST_WARNINGS is set

2011-08-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102453/#review6109 --- Personally i do not like this kind of change because i've been