Re: [Okular-devel] Review Request 109047: Install active desktop file only when active found

2013-02-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/#review27779 --- This review has been submitted with commit 27c37c1fd1b87e8db40

Re: [Okular-devel] Review Request 109047: Install active desktop file only when active found

2013-02-20 Thread Albert Astals Cid
> On Feb. 19, 2013, 8:59 p.m., Albert Astals Cid wrote: > > You prefer this over the TryExec solution? Works for me. > > > > Please make sure you commit this to KDE/4.10 first and then merge to master > > (you'll have to take care the txt backend is only in master) > > Marco Martin wrote: >

Re: [Okular-devel] Review Request 109047: Install active desktop file only when active found

2013-02-20 Thread Marco Martin
> On Feb. 19, 2013, 8:59 p.m., Albert Astals Cid wrote: > > You prefer this over the TryExec solution? Works for me. > > > > Please make sure you commit this to KDE/4.10 first and then merge to master > > (you'll have to take care the txt backend is only in master) > > Marco Martin wrote: >

Re: [Okular-devel] Review Request 109047: Install active desktop file only when active found

2013-02-20 Thread Albert Astals Cid
> On Feb. 19, 2013, 8:59 p.m., Albert Astals Cid wrote: > > You prefer this over the TryExec solution? Works for me. > > > > Please make sure you commit this to KDE/4.10 first and then merge to master > > (you'll have to take care the txt backend is only in master) > > Marco Martin wrote: >

Re: [Okular-devel] Review Request 109047: Install active desktop file only when active found

2013-02-20 Thread Marco Martin
> On Feb. 19, 2013, 8:59 p.m., Albert Astals Cid wrote: > > You prefer this over the TryExec solution? Works for me. > > > > Please make sure you commit this to KDE/4.10 first and then merge to master > > (you'll have to take care the txt backend is only in master) hmm, yeah, in this case in d

Re: [Okular-devel] Review Request 109047: Install active desktop file only when active found

2013-02-19 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/#review27744 --- Ship it! You prefer this over the TryExec solution? Works for

[Okular-devel] Review Request 109047: Install active desktop file only when active found

2013-02-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109047/ --- Review request for Okular. Description --- this should solve https://