Re: [Okular-devel] Review Request 112135: Fix for Bug 323262 and Bug 323263

2013-10-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112135/#review41948 --- This review has been submitted with commit

Re: [Okular-devel] Review Request 112135: Fix for Bug 323262 and Bug 323263

2013-10-18 Thread Jaan Vajakas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112135/ --- (Updated Oct. 18, 2013, 2:44 p.m.) Status -- This change has been

Re: [Okular-devel] Review Request 112135: Fix for Bug 323262 and Bug 323263

2013-10-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112135/#review41949 --- Thanks a lot for the patch Jaan, it'll be available in 4.12.0

Re: [Okular-devel] Review Request 112135: Fix for Bug 323262 and Bug 323263

2013-10-05 Thread Jaan Vajakas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112135/ --- (Updated Oct. 5, 2013, 8:20 p.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 112135: Fix for Bug 323262 and Bug 323263

2013-10-05 Thread Jaan Vajakas
On Sept. 25, 2013, 9 p.m., Albert Astals Cid wrote: core/textpage.cpp, line 120 http://git.reviewboard.kde.org/r/112135/diff/2/?file=185753#file185753line120 This is an unrelated fix, right? Yes, I noticed it by reviewing the code. I have also added a test for it

Re: [Okular-devel] Review Request 112135: Fix for Bug 323262 and Bug 323263

2013-09-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112135/#review40819 --- Thanks and sorry for the delay in review, was away in holiday

Re: [Okular-devel] Review Request 112135: Fix for Bug 323262 and Bug 323263

2013-08-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112135/#review38076 --- Nice, still haven't had a look at the code, will try find some

Re: [Okular-devel] Review Request 112135: Fix for Bug 323262 and Bug 323263

2013-08-18 Thread Jaan Vajakas
On Aug. 18, 2013, 3:28 p.m., Albert Astals Cid wrote: Nice, still haven't had a look at the code, will try find some time for it next week. What would be awesome is if you could add some autotests (we are trying to get more and more of those) to make sure that we don't break stuff

[Okular-devel] Review Request 112135: Fix for Bug 323262 and Bug 323263

2013-08-17 Thread Jaan Vajakas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112135/ --- Review request for Okular. Description --- This patch solves Bug