Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-05-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112370/#review57365 --- Commited! Thanks for your work :) Feel free to pick something

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-05-05 Thread Tingnan Zhang
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112370/ --- (Updated May 5, 2014, 10:48 p.m.) Status -- This change has been mar

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-05-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112370/#review57364 --- This review has been submitted with commit fad9c4e6fd532e0e80

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-05-05 Thread Tingnan Zhang
> On April 28, 2014, 10:45 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 3654 > > > > > > The code in ZoomIn and ZoomOut seem to be very much the same (can only > > find a -1 difference) > > > >

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-05-05 Thread Tingnan Zhang
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112370/ --- (Updated May 5, 2014, 8 p.m.) Review request for Okular. Repository: ok

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-04-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112370/#review56806 --- ui/pageview.cpp

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-04-27 Thread Tingnan Zhang
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112370/ --- (Updated April 27, 2014, 11:23 p.m.) Review request for Okular. Reposit

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-04-26 Thread Tingnan Zhang
> On April 23, 2014, 11:02 p.m., Albert Astals Cid wrote: > > Hello, anyone in there? Hi Albert: Sorry I was distracted. Will submit the update tomorrow. - Tingnan --- This is an automatically generated e-mail. To reply, visit: https:/

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-04-23 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112370/#review56336 --- Hello, anyone in there? - Albert Astals Cid On Nov. 28, 201

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-01-26 Thread Albert Astals Cid
> On Dec. 30, 2013, 12:42 a.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 3594 > > > > > > This 6 and 12 are connected to the 6 and 12 used in > > PageView::slotRelayoutPages? It'd be great if you coul

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-01-10 Thread Albert Astals Cid
> On Dec. 30, 2013, 12:42 a.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 3594 > > > > > > This 6 and 12 are connected to the 6 and 12 used in > > PageView::slotRelayoutPages? It'd be great if you coul

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2014-01-09 Thread Tingnan Zhang
> On Dec. 30, 2013, 12:42 a.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 3594 > > > > > > This 6 and 12 are connected to the 6 and 12 used in > > PageView::slotRelayoutPages? It'd be great if you coul

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-12-29 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112370/#review46423 --- ui/pageview.cpp

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-11-27 Thread Tingnan Zhang
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112370/ --- (Updated Nov. 28, 2013, 7:35 a.m.) Review request for Okular. Changes --

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-10-14 Thread Tingnan Zhang
> On Oct. 2, 2013, 11:14 p.m., Albert Astals Cid wrote: > > Hmmm, i like how now, if i write 154% on there and press the zoom > > in+zoomout i'm still at 154%, while with your code i'm back to 144% > > > > But not sure if that is of any value but i still like it. What do you guys > > think, is

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-10-05 Thread Jaan Vajakas
> On Oct. 2, 2013, 11:14 p.m., Albert Astals Cid wrote: > > Hmmm, i like how now, if i write 154% on there and press the zoom > > in+zoomout i'm still at 154%, while with your code i'm back to 144% > > > > But not sure if that is of any value but i still like it. What do you guys > > think, is

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-10-02 Thread Tingnan Zhang
> On Oct. 2, 2013, 11:14 p.m., Albert Astals Cid wrote: > > Hmmm, i like how now, if i write 154% on there and press the zoom > > in+zoomout i'm still at 154%, while with your code i'm back to 144% > > > > But not sure if that is of any value but i still like it. What do you guys > > think, is

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-10-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112370/#review41149 --- Hmmm, i like how now, if i write 154% on there and press the zo

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-10-01 Thread Tingnan Zhang
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112370/ --- (Updated Oct. 1, 2013, 11:52 p.m.) Review request for Okular. Repository

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-09-30 Thread Fabio D'Urso
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112370/#review41052 --- Hi! I haven't actually tried the code yet, but I see some avoid

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-09-28 Thread Tingnan Zhang
> On Sept. 25, 2013, 8:51 p.m., Albert Astals Cid wrote: > > ui/pageview.cpp, line 3580 > > > > > > Sorry for tha late reply, been on holiday. > > > > Since incFactor and decFactor are only used inside s

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-09-26 Thread Tingnan Zhang
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112370/ --- (Updated Sept. 27, 2013, 1:21 a.m.) Review request for Okular. Descripti

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-09-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112370/#review40818 --- ui/pageview.cpp

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-08-30 Thread Tingnan Zhang
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112370/ --- (Updated Aug. 30, 2013, 2:26 p.m.) Review request for Okular. Descriptio

[Okular-devel] Review Request 112370: BugFix for bug 323434/323435

2013-08-29 Thread Tingnan Zhang
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112370/ --- Review request for Okular. Description --- BugFix 323434/323435. Zoom