Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/ --- (Updated Feb. 19, 2014, 10:41 p.m.) Status -- This change has been m

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/#review50288 --- This review has been submitted with commit c07ee043a3e12772bf

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

> On Feb. 17, 2014, 9:53 p.m., Albert Astals Cid wrote: > > active/components/documentitem.cpp, line 210 > > > > > > Doesn't this add the observer twice? > > Michal Humpula wrote: > This is a plasma extensio

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/ --- (Updated Feb. 19, 2014, 5:56 a.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

> On Feb. 17, 2014, 9:53 p.m., Albert Astals Cid wrote: > > active/components/documentitem.cpp, line 210 > > > > > > Doesn't this add the observer twice? > > Michal Humpula wrote: > This is a plasma extensio

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/ --- (Updated Feb. 18, 2014, 6:52 a.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

> On Feb. 17, 2014, 9:53 p.m., Albert Astals Cid wrote: > > active/components/documentitem.cpp, line 210 > > > > > > Doesn't this add the observer twice? This is a plasma extension (?), completely separated from

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/#review50107 --- active/components/documentitem.cpp

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/ --- (Updated Feb. 17, 2014, 6:29 a.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/#review4 --- core/page.h

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/ --- (Updated Feb. 15, 2014, 7:28 p.m.) Review request for Okular. Repositor

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

> On Feb. 15, 2014, 3:15 p.m., Albert Astals Cid wrote: > > I'd say you have uploaded the wrong diff. ahh, sorry, so lame. - Michal --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/#review49833 --- I'd say you have uploaded the wrong diff. - Albert Astals Cid

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

> On Feb. 9, 2014, 12:26 a.m., Albert Astals Cid wrote: > > core/page.cpp, line 758 > > > > > > deleting null is fine, you don't need the if Thanks for review. Remembering what and why I done after three months

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/ --- (Updated Feb. 15, 2014, 2:47 p.m.) Review request for Okular. Changes -

Re: [Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113986/#review49312 --- core/document.cpp

[Okular-devel] Review Request 113986: Multiple Tiles Managers per Page

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113986/ --- Review request for Okular. Repository: okular Description --- First