Re: [Okular-devel] Review Request 119894: Only update zoomFactor for current page

2014-08-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119894/ --- (Updated Aug. 24, 2014, 8:38 p.m.) Status -- This change has been ma

Re: [Okular-devel] Review Request 119894: Only update zoomFactor for current page

2014-08-24 Thread Albert Astals Cid
> On ago. 24, 2014, 2:11 p.m., Fabio D'Urso wrote: > > So we had a loop that set d->zoomFactor repeatedly, I didn't know that, I > > guess the last iteration was the one that won :P > > > > I've tried your patch on the document from the bug and I'm noticing this > > issue: if you choose, say,

Re: [Okular-devel] Review Request 119894: Only update zoomFactor for current page

2014-08-24 Thread Fabio D'Urso
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119894/#review65121 --- So we had a loop that set d->zoomFactor repeatedly, I didn't k

Re: [Okular-devel] Review Request 119894: Only update zoomFactor for current page

2014-08-22 Thread Markus Trippelsdorf
> On Aug. 22, 2014, 9:05 a.m., Markus Trippelsdorf wrote: > > I've tested the patch with a number of problematic pdfs and it works fine. > > Thanks. > > Albert Astals Cid wrote: > Can you discard your proposal then? Done. I hadn't actually tested your patch only, but the combination with my

Re: [Okular-devel] Review Request 119894: Only update zoomFactor for current page

2014-08-22 Thread Albert Astals Cid
> On ago. 22, 2014, 9:05 a.m., Markus Trippelsdorf wrote: > > I've tested the patch with a number of problematic pdfs and it works fine. > > Thanks. Can you discard your proposal then? - Albert --- This is an automatically generated e-m

Re: [Okular-devel] Review Request 119894: Only update zoomFactor for current page

2014-08-22 Thread Markus Trippelsdorf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119894/#review65014 --- I've tested the patch with a number of problematic pdfs and it

Re: [Okular-devel] Review Request 119894: Only update zoomFactor for current page

2014-08-22 Thread Markus Trippelsdorf
> On Aug. 22, 2014, 8:14 a.m., Markus Trippelsdorf wrote: > > Patch is missing, but the idea sounds right to me. > > Albert Astals Cid wrote: > What do you mean patch is missing? I didn't see the patch. Why doesn't review-board display it by default? But never mind, I've now found the "Vie

Re: [Okular-devel] Review Request 119894: Only update zoomFactor for current page

2014-08-22 Thread Albert Astals Cid
> On ago. 22, 2014, 8:14 a.m., Markus Trippelsdorf wrote: > > Patch is missing, but the idea sounds right to me. What do you mean patch is missing? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.rev

Re: [Okular-devel] Review Request 119894: Only update zoomFactor for current page

2014-08-22 Thread Markus Trippelsdorf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119894/#review65010 --- Patch is missing, but the idea sounds right to me. - Markus T

[Okular-devel] Review Request 119894: Only update zoomFactor for current page

2014-08-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119894/ --- Review request for Okular, Markus Trippelsdorf and Tingnan Zhang. Bugs: 3