D18179: PDF: Implement scaling for non-rasterized printing

aacid added a comment. We would need a @since marker for the enum and for the new methods and a // TODO merge with function above when a BIC change happens somehwere else would also make sense INLINE COMMENTS > fileprinter.h:58 > + */ > +enum ScaleMode { FitToPrintArea, None }; >

D18179: PDF: Implement scaling for non-rasterized printing

michaelweghorn marked an inline comment as done. michaelweghorn added a comment. Thanks for the feedback and info. I've update the change accordingly now. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvo

D18179: PDF: Implement scaling for non-rasterized printing

michaelweghorn marked 2 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen

D18179: PDF: Implement scaling for non-rasterized printing

michaelweghorn updated this revision to Diff 49519. michaelweghorn added a comment. Undo accidental whitespace changes REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18179?vs=49518&id=49519 BRANCH michaelweghorn/UPDATE_20191115_D18179_allowScaledPrintingW

D18179: PDF: Implement scaling for non-rasterized printing

michaelweghorn updated this revision to Diff 49518. michaelweghorn added a comment. Implement improvements suggested by Albert: - use an enum rather than a bool for scale mode - avoid ABI breakage by adding extra methods that take an additional parameter for scale mode and make existing

D18179: PDF: Implement scaling for non-rasterized printing

aacid added a comment. In D18179#391915 , @michaelweghorn wrote: > In D18179#391664 , @aacid wrote: > > > Maybe an enum is better than a bool so if in the future more scaling options are implemented

D18179: PDF: Implement scaling for non-rasterized printing

michaelweghorn added a comment. In D18179#391664 , @aacid wrote: > Maybe an enum is better than a bool so if in the future more scaling options are implemented we don't need to change the signature again? Sounds reasonable. I'll change th

D18179: PDF: Implement scaling for non-rasterized printing

aacid added a comment. Maybe an enum is better than a bool so if in the future more scaling options are implemented we don't need to change the signature again? INLINE COMMENTS > fileprinter.h:82 >PageSelectPolicy pageSelectPolicy = > FilePrinter::ApplicationSele

D18179: PDF: Implement scaling for non-rasterized printing

michaelweghorn added a dependency: D10974: Add option to ignore print margins for non-PDF generators. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: okular-devel, ngraham, darcyshen, aacid

D18179: PDF: Implement scaling for non-rasterized printing

michaelweghorn created this revision. michaelweghorn added reviewers: Okular, ngraham, sander. Herald added a project: Okular. michaelweghorn requested review of this revision. REVISION SUMMARY This extends 'FilePrinter::printFile' by an optional parameter to specify whether or not to do scali