El Dijous, 8 d'agost de 2013, a les 01:36:12, Jaydeep Solanki va escriure:
> On Thu, Aug 8, 2013 at 1:21 AM, Albert Astals Cid wrote:
> > El Dijous, 8 d'agost de 2013, a les 01:09:27, Jaydeep Solanki va escriure:
> > > Yes I know I have not took care of it her
https://bugs.kde.org/show_bug.cgi?id=323275
Albert Astals Cid changed:
What|Removed |Added
CC||aa...@kde.org
Severity|minor
https://bugs.kde.org/show_bug.cgi?id=306572
Albert Astals Cid changed:
What|Removed |Added
Status|NEEDSINFO |CONFIRMED
Resolution
El Divendres, 9 d'agost de 2013, a les 01:09:18, Jaydeep Solanki va escriure:
> forgot to attach
Can you explain your locking, not sure i understand it.
Cheers,
Albert
>
> On Fri, Aug 9, 2013 at 1:07 AM, Jaydeep Solanki wrote:
> > Hi,
> >
> > Finally an end to cloning and threading issue.
>
El Divendres, 9 d'agost de 2013, a les 01:11:25, Jaydeep Solanki va escriure:
> On Thu, Aug 8, 2013 at 2:25 AM, Albert Astals Cid wrote:
> > El Dijous, 8 d'agost de 2013, a les 01:36:12, Jaydeep Solanki va escriure:
> > > On Thu, Aug 8, 2013 at 1:21 AM, Albert Astals C
El Divendres, 9 d'agost de 2013, a les 01:35:19, Jaydeep Solanki va escriure:
> On Fri, Aug 9, 2013 at 1:31 AM, Albert Astals Cid wrote:
> > El Divendres, 9 d'agost de 2013, a les 01:09:18, Jaydeep Solanki va
> >
> > escriure:
> > > forgot to attach
&g
El Divendres, 9 d'agost de 2013, a les 01:36:18, Jaydeep Solanki va escriure:
> yes it won't wait
So the UI thread won't block, right? Because you said it would.
Cheers,
Albert
>
> On Fri, Aug 9, 2013 at 1:33 AM, Albert Astals Cid wrote:
> > El Divendres, 9 d
https://bugs.kde.org/show_bug.cgi?id=318998
--- Comment #4 from Albert Astals Cid ---
Clayton?
--
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman
https://bugs.kde.org/show_bug.cgi?id=318998
Albert Astals Cid changed:
What|Removed |Added
CC||cgrs...@gmail.com
--- Comment #5 from
https://bugs.kde.org/show_bug.cgi?id=308240
Albert Astals Cid changed:
What|Removed |Added
CC||aa...@kde.org
--- Comment #29 from Albert
4 years? I
sincerely don't see how you can think this is a good idea.
- Albert Astals Cid
On Aug. 9, 2013, 6:33 p.m., Elias Probst wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
https://bugs.kde.org/show_bug.cgi?id=323391
Albert Astals Cid changed:
What|Removed |Added
CC||aa...@kde.org
--- Comment #5 from Albert
https://bugs.kde.org/show_bug.cgi?id=323434
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
CC
https://bugs.kde.org/show_bug.cgi?id=323434
Albert Astals Cid changed:
What|Removed |Added
Keywords||junior-jobs
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=323435
Albert Astals Cid changed:
What|Removed |Added
Keywords||junior-jobs
Status|UNCONFIRMED
El Dissabte, 10 d'agost de 2013, a les 01:19:14, Jaydeep Solanki va escriure:
> Hi,
> I have tested yesterday's patch (without lock) with about 15 different
> epubs, and it crashed only once. I tried the same epub that made it crash
> once a few more times, but it didn't crash. Thus, crash doesn't
https://bugs.kde.org/show_bug.cgi?id=308683
--- Comment #8 from Albert Astals Cid ---
Yes, that is much better. Can we mark this bug as discarded?
--
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
https://bugs.kde.org/show_bug.cgi?id=323393
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
CC
El Dimarts, 13 d'agost de 2013, a les 00:27:48, Jaydeep Solanki va escriure:
> Hi,
>
> Setup gerrit and created review request, for "visibility : collapse".
> https://codereview.qt-project.org/#change,62839
Nice :-)
> I'll be working on updating it as and when I get more info.
It's there :D
>
https://bugs.kde.org/show_bug.cgi?id=323454
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
CC
https://bugs.kde.org/show_bug.cgi?id=323391
--- Comment #8 from Albert Astals Cid ---
You noticed wrong, okular_part properly exports the option to remove the page
bar (since you can access it perfectly from Konqueror), if Kile doesn't show
it, complain to Kile people.
And no, i'm not
https://bugs.kde.org/show_bug.cgi?id=323484
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |NEEDSINFO
CC
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/38/
---
(Updated Aug. 14, 2013, 9:19 p.m.)
Status
--
This change has been dis
nding loop after looking at the
code
If you think it works, please commit it. To which branch i don't know, 4.11 i
guess?
- Albert Astals Cid
On July 29, 2013, 6:48 p.m., Fabio D'Urso wrote:
>
> ---
> This is an automa
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111793/#review37804
---
Can you autotest this?
- Albert Astals Cid
On July 30, 2013
applies for files you've never opened? Is this your
problem?
- Albert Astals Cid
On July 7, 2013, 11:04 p.m., Thomas Fischer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
ce pdftocairo not always support svg, if you look
at the code it is surrounded by
#if CAIRO_HAS_SVG_SURFACE
Maybe you should grep pdftocairo -h (k) output to make sure it supports
svg?
generators/poppler/generator_pdf.cpp
<http://git.reviewboard.kde.org/r/111410/#comment
oard.kde.org/r/111681/
> ---
>
> (Updated July 25, 2013, noon)
>
>
> Review request for Okular and Albert Astals Cid.
>
>
> Description
> ---
>
> As indicated in bug 322547, some documents do not specify a
> On July 21, 2013, 3:37 p.m., Albert Astals Cid wrote:
> > Jaydeep, can you confirm you are working so that
> > http://bugs.kde.org/attachment.cgi?id=51488 can be correctly seen in a dark
> > colorscheme?
>
> Jaydeep Solanki wrote:
> I tried it, w
036/#comment27997>
should we set this also when enable is false?
- Albert Astals Cid
On July 22, 2013, 10:12 a.m., Stefan Radermacher wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.rev
914/#comment27998>
Why are you changing the dbus names? This will break whatever scripts
people where using.
- Albert Astals Cid
On Aug. 3, 2013, 10:03 p.m., Jonathan Doman wrote:
>
> ---
> This is an automatically generated e
El Dijous, 15 d'agost de 2013, a les 00:47:45, Jaydeep Solanki va escriure:
> Hi,
Hi
> I talked with qt guys, one thing I found out is no more features will be
> added to 4.8, so the visibility patch will be added to qt5. May be it will
> be helpful when KDE Frameworks 5 will release and Okular
https://bugs.kde.org/show_bug.cgi?id=323484
Albert Astals Cid changed:
What|Removed |Added
Status|NEEDSINFO |RESOLVED
Resolution|WAITINGFORINFO
https://bugs.kde.org/show_bug.cgi?id=323563
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |NEEDSINFO
CC
> On Aug. 15, 2013, 9:03 p.m., Albert Astals Cid wrote:
> > generators/poppler/generator_pdf.cpp, line 683
> > <http://git.reviewboard.kde.org/r/111829/diff/2/?file=175890#file175890line683>
> >
> > Don't use this-> makes me unhappy to see it in C++ c
still exist (and
potentially mark them as deprecated) and add the new ones with the correct
@since marker
generators/poppler/generator_pdf.cpp
<http://git.reviewboard.kde.org/r/111829/#comment28041>
Don't use this-> makes me unhappy to see it in C++ code :D
- Albert Astal
https://bugs.kde.org/show_bug.cgi?id=311775
Albert Astals Cid changed:
What|Removed |Added
Status|NEEDSINFO |RESOLVED
Resolution|WAITINGFORINFO
https://bugs.kde.org/show_bug.cgi?id=311885
Albert Astals Cid changed:
What|Removed |Added
Status|NEEDSINFO |RESOLVED
Resolution|WAITINGFORINFO
https://bugs.kde.org/show_bug.cgi?id=313986
Albert Astals Cid changed:
What|Removed |Added
Status|NEEDSINFO |RESOLVED
Resolution|WAITINGFORINFO
https://bugs.kde.org/show_bug.cgi?id=315354
Albert Astals Cid changed:
What|Removed |Added
Status|NEEDSINFO |RESOLVED
Resolution|WAITINGFORINFO
https://bugs.kde.org/show_bug.cgi?id=311037
Albert Astals Cid changed:
What|Removed |Added
Status|NEEDSINFO |RESOLVED
Resolution|WAITINGFORINFO
https://bugs.kde.org/show_bug.cgi?id=303607
Albert Astals Cid changed:
What|Removed |Added
Status|NEEDSINFO |RESOLVED
Resolution|WAITINGFORINFO
https://bugs.kde.org/show_bug.cgi?id=310343
Albert Astals Cid changed:
What|Removed |Added
Status|NEEDSINFO |RESOLVED
Resolution|WAITINGFORINFO
https://bugs.kde.org/show_bug.cgi?id=308683
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolution
return QSizeF
core/utils.h
<http://git.reviewboard.kde.org/r/111829/#comment28049>
something's up with indentation
- Albert Astals Cid
On Aug. 15, 2013, 10:46 p.m., Eugene Shalygin wrote:
>
> ---
> This is an automa
> On Aug. 15, 2013, 9:03 p.m., Albert Astals Cid wrote:
> >
>
> Eugene Shalygin wrote:
> Thanks for the review! I've tried to fix the issues. The only one left is
> question with Generator::DPI. I've replaced it with QSizeF (not the best
> choice, I k
key, till it reaches the end of document or crashes.
>
> *Note:* it doesn't always crash. In fact the probability of it crashing is
> very low, thus it gets difficult to debug.
Have you tried with the helgrind tool of valgrind?
Cheers,
Albert
>
> On Tue, Aug 13, 2013 at 3:
> On Aug. 14, 2013, 9:55 p.m., Albert Astals Cid wrote:
> > "Second, I am trying to add "Auto Fit" as one of the default zoom settings
> > in the configuration dialog. Although I was quite sure I did not miss a
> > spot and the option turns up in the
> On Aug. 15, 2013, 9:03 p.m., Albert Astals Cid wrote:
> >
>
> Eugene Shalygin wrote:
> Thanks for the review! I've tried to fix the issues. The only one left is
> question with Generator::DPI. I've replaced it with QSizeF (not the best
> choice, I k
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111681/
---
(Updated Aug. 16, 2013, 8:58 p.m.)
Review request for Okular.
Descriptio
text color (so
all is fine, none of "our" colors is used) and if no color is set, i would
undertand that the color scheme by the user provides acceptable colors.
So where is the problem?
- Albert Astals Cid
On July 25, 2013, n
just in case the binary
is there but none of the options is supported?
- Albert Astals Cid
On Aug. 16, 2013, 9:17 p.m., Thomas Fischer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote:
> > To be honest i'm a bit confused by all the different patches trying to fix
> > the same thing, there's this one, the other one that tries to use
> > kcolorscheme, the other one that tries to let the u
https://bugs.kde.org/show_bug.cgi?id=323639
Albert Astals Cid changed:
What|Removed |Added
Priority|NOR |HI
Status|UNCONFIRMED
> On Aug. 14, 2013, 10:29 p.m., Albert Astals Cid wrote:
> > shell/shell.h, line 49
> > <http://git.reviewboard.kde.org/r/110914/diff/2/?file=176095#file176095line49>
> >
> > Why are you changing the dbus names? This will break whatever scripts
> >
i'll give a final
review, but i think it's good to go.
- Albert Astals Cid
On Aug. 17, 2013, 12:02 a.m., Eugene Shalygin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.r
https://bugs.kde.org/show_bug.cgi?id=323267
Albert Astals Cid changed:
What|Removed |Added
CC||mail...@gmail.com
--- Comment #1 from
https://bugs.kde.org/show_bug.cgi?id=323262
--- Comment #2 from Albert Astals Cid ---
For completion: Jaan says he is interested in fixing this in bug 323263
--
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel
https://bugs.kde.org/show_bug.cgi?id=322919
Albert Astals Cid changed:
What|Removed |Added
Status|NEEDSINFO |CONFIRMED
Resolution
https://bugs.kde.org/show_bug.cgi?id=322919
--- Comment #8 from Albert Astals Cid ---
Possible solutions, make
TOCModel *m_oldModel;
be a QPointer so it gets automatically nulled when it's deleted or
change parentship of m_model in toc.cpp when calling
setOldModelData/clearOldMode
https://bugs.kde.org/show_bug.cgi?id=249364
Albert Astals Cid changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Resolution
nd calling setWordList on them and then checking that
findTextInternalForward/findTextInternalBackward return the correct values. Can
you try to do that?
- Albert Astals Cid
On Aug. 17, 2013, 7:48 p.m., Jaan Vajakas wrote:
>
>
El Diumenge, 18 d'agost de 2013, a les 02:13:50, Jaydeep Solanki va escriure:
> On Sat, Aug 17, 2013 at 2:06 AM, Albert Astals Cid wrote:
> > El Divendres, 16 d'agost de 2013, a les 22:29:38, Jaydeep Solanki va
> >
> > escriure:
> > > How it occurs :
>
> On Aug. 16, 2013, 8:58 p.m., Albert Astals Cid wrote:
> > To be honest i'm a bit confused by all the different patches trying to fix
> > the same thing, there's this one, the other one that tries to use
> > kcolorscheme, the other one that tries to let the u
https://bugs.kde.org/show_bug.cgi?id=323669
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |NEEDSINFO
CC
ttp://git.reviewboard.kde.org/r/111410/#comment28164>
Any reason you made m_pdfToCairoSinglePageFormatsAlreadySearched class
static while formats is function static? Seems a bit "confusing" to me
- Albert Astals Cid
On Aug. 17, 2013, 9:11 p.m., Thom
oard.kde.org/r/110914/#comment28170>
Please use const & for an non "trivial" types passed as paramaters, gives
us 0.00000000001% speed boost by not having to crate a new QPoint :D
- Albert Astals Cid
On Aug. 17, 2013, 3:06 p.m., Jonathan Doman wrote:
>
> -
> On Aug. 14, 2013, 10:29 p.m., Albert Astals Cid wrote:
> > shell/shell.h, line 49
> > <http://git.reviewboard.kde.org/r/110914/diff/2/?file=176095#file176095line49>
> >
> > Why are you changing the dbus names? This will break whatever scripts
> >
https://bugs.kde.org/show_bug.cgi?id=323721
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |NEEDSINFO
CC
https://bugs.kde.org/show_bug.cgi?id=323721
--- Comment #3 from Albert Astals Cid ---
Works fine here (i.e. i get a can't open file dialog), and your backtrace seems
to imply it's crashing somewhere else totally unrelated, does it crash for you
every time you open this file? Can yo
https://bugs.kde.org/show_bug.cgi?id=322993
--- Comment #5 from Albert Astals Cid ---
No idea here, but given that both
A) pdftops myfile.pdf ; lpr myfile.ps
B) lpr myfile.pdf
give you a duplexed printout I'm not sure okular is to blame here to be honest
(i.e. i'm not sure this bug i
https://bugs.kde.org/show_bug.cgi?id=323721
--- Comment #5 from Albert Astals Cid ---
hmmm, so just opening okular without any file gets you a crash?
That's really weird. Is the backtrace of the crash the same as the one you
attached in the report?
Also can you run "valgrind okular&q
https://bugs.kde.org/show_bug.cgi?id=323669
Albert Astals Cid changed:
What|Removed |Added
Status|NEEDSINFO |UNCONFIRMED
Resolution
> On Aug. 18, 2013, 8:41 p.m., Albert Astals Cid wrote:
> > shell/main.cpp, line 112
> > <http://git.reviewboard.kde.org/r/110914/diff/3/?file=183075#file183075line112>
> >
> > This looks like a separate feature than the tabs feature, maybe makes
> >
914/#comment28280>
one more nitpick about style, when comparing pointers just do
"if (part)" instead of "if (part != 0)"
and
"if (!part)" instead of "if (part == 0)"
- Albert Astals Cid
On A
> On Aug. 18, 2013, 8:41 p.m., Albert Astals Cid wrote:
> > part.cpp, line 838
> > <http://git.reviewboard.kde.org/r/110914/diff/3/?file=183074#file183074line838>
> >
> > This looks a bit weird, you never initialize nor use m_dbusObjectName
> &
829/#comment28282>
Do we need this one?
- Albert Astals Cid
On Aug. 17, 2013, 6:29 p.m., Eugene Shalygin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboar
https://bugs.kde.org/show_bug.cgi?id=323810
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |NEEDSINFO
CC
https://bugs.kde.org/show_bug.cgi?id=323810
--- Comment #7 from Albert Astals Cid ---
This is weird, three things:
* Can you confirm that without trim margins everything looks fine?
* Are you a "new" user of okular or you've been using it for a long time? We
did some settings
El Dissabte, 24 d'agost de 2013, a les 00:27:34, Jaydeep Solanki va escriure:
> Hi,
>
> I still have two more exams left, on Monday & Tuesday, but I can work on
> weekend.
>
> In the effort to make ePubs view video and play audio, I previously tried
> Movie annotations, unfortunately it didn't wo
https://bugs.kde.org/show_bug.cgi?id=322993
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |NEEDSINFO
Resolution
Hi guys, what do you think about build.kde.org sending this list an email when
okular[1] fails compiling (or the tests stop passing)?
I think it's an awesome idea but don't want to tell the sysadmins to flip the
switch if people here think those emails would be spam.
Also, hopefully we should n
El Dissabte, 24 d'agost de 2013, a les 20:18:31, Jaydeep Solanki va escriure:
> On Sat, Aug 24, 2013 at 3:01 AM, Albert Astals Cid wrote:
> > El Dissabte, 24 d'agost de 2013, a les 00:27:34, Jaydeep Solanki va
> >
> > escriure:
> > > Hi,
> > >
ly generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111829/
> ---
>
> (Updated Aug. 21, 2013, 12:56 a.m.)
>
>
> Review request for Okular and Albert Astals Cid.
>
>
> Description
> ---
>
> This patch relies on master branch of LibKScreen.
>
> On Aug. 20, 2013, 9:40 p.m., Albert Astals Cid wrote:
> > shell/shell.cpp, line 669
> > <http://git.reviewboard.kde.org/r/110914/diff/4/?file=183348#file183348line669>
> >
> > one more nitpick about style, when comparing pointers just do
> >
&
> On Aug. 18, 2013, 8:41 p.m., Albert Astals Cid wrote:
> > shell/main.cpp, line 112
> > <http://git.reviewboard.kde.org/r/110914/diff/3/?file=183075#file183075line112>
> >
> > This looks like a separate feature than the tabs feature, maybe makes
> >
https://bugs.kde.org/show_bug.cgi?id=324094
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |NEEDSINFO
CC
El Dissabte, 24 d'agost de 2013, a les 13:54:58, Albert Astals Cid va
escriure:
> Hi guys, what do you think about build.kde.org sending this list an email
> when okular[1] fails compiling (or the tests stop passing)?
>
> I think it's an awesome idea but don't want to
https://bugs.kde.org/show_bug.cgi?id=324094
Albert Astals Cid changed:
What|Removed |Added
Status|NEEDSINFO |RESOLVED
Resolution|WAITINGFORINFO
https://bugs.kde.org/show_bug.cgi?id=324167
Albert Astals Cid changed:
What|Removed |Added
CC||aa...@kde.org
--- Comment #4 from Albert
https://bugs.kde.org/show_bug.cgi?id=324094
--- Comment #5 from Albert Astals Cid ---
> How I should hide it? The yellow bar on top I closed.
Though luck, if you closed the bar you'll have to use the menu option.
> Also, how a normal
> user should know that he have to do this? b
https://bugs.kde.org/show_bug.cgi?id=324167
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0
> On Aug. 25, 2013, 4:13 p.m., Albert Astals Cid wrote:
> > Ok, the code looks "sane" but there are two things that still make me
> > unsure about this whole thing:
> >
> > * Why you need Pixels?
> > In the bug you say "Points, but actually
nless someone else takes care
of this review you'll have to wait until I come back.
- Albert Astals Cid
On Aug. 27, 2013, 8:11 p.m., Thomas Fischer wrote:
>
> ---
> This is an automatically generated e-mail. To r
nless someone else takes care
of this review you'll have to wait until I come back.
- Albert Astals Cid
On Aug. 23, 2013, 8:06 p.m., Jonathan Doman wrote:
>
> ---
> This is an automatically generated e-mail. To r
https://bugs.kde.org/show_bug.cgi?id=249364
--- Comment #13 from Albert Astals Cid ---
4.12 or 4.12.0 is both fine
--
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https
> On Aug. 25, 2013, 4:13 p.m., Albert Astals Cid wrote:
> > Ok, the code looks "sane" but there are two things that still make me
> > unsure about this whole thing:
> >
> > * Why you need Pixels?
> > In the bug you say "Points, but actually
https://bugs.kde.org/show_bug.cgi?id=323391
--- Comment #11 from Albert Astals Cid ---
Or at least adding them as CC, yeah, can you do that, please?
--
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing
https://bugs.kde.org/show_bug.cgi?id=324427
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |NEEDSINFO
CC
https://bugs.kde.org/show_bug.cgi?id=324504
Albert Astals Cid changed:
What|Removed |Added
Status|UNCONFIRMED |NEEDSINFO
CC
701 - 800 of 9470 matches
Mail list logo