Re: AOO.Next IBM Priorities

2012-11-01 Thread Lei Wang
No, this is property panel in the sidebar, not the sidebar framework. The sidebar framework looks like: http://wiki.openoffice.org/wiki/AOO_UX_Design_Exploration_-_Docked_Task_Pane_Container_-_Tab_User_Interface_Design On Fri, Nov 2, 2012 at 10:29 AM, Jorg Schmidt wrote: > > > -- A major UI enh

Re: [UX] - Design Exploration - Dockable Task Pane (Sidebar) - Tab User Interface Design

2012-11-01 Thread Lei Wang
I like beveled tab option. One question, what kinds of content should be put into the sidebar? A navigator window or a style list window should be put into sidebar as a tab panel. On Thu, Nov 1, 2012 at 4:59 PM, Kevin Grignon wrote: > Hello All, > > I've been exploring design alternatives for ad

Re: Application form for Conference

2012-10-08 Thread Lei Wang
Forwarded Oliver's mail -- Forwarded message -- From: Oliver-Rainer Wittmann Date: Fri, Oct 5, 2012 at 3:27 PM Subject: Re: ApacheCon EU 2012 To: ooo-dev@incubator.apache.org Cc: gary_domke Hi Gary, please help us and use the application form to apply for a travel expense sub

Re: [Call for Review]120962 - [From Symphony]Chart data lost if the source data refers to a range name which is defined as a reference formula

2012-09-21 Thread Lei Wang
I have reviewed your patch. It looks good. I submitted it. Thanks for your patch. On Fri, Sep 21, 2012 at 2:29 PM, Clarence GUO wrote: > HI~ > I have a code review request, > https://issues.apache.org/ooo/show_bug.cgi?id=120962 > This defect is indeed a feature gap. Chart of AOO doesn't support

Re: [Call for Review]121058 - [From Symphony]To open a sample file contains chart with large data source can lead to Symphony crash

2012-09-21 Thread Lei Wang
I have reviewed your patch. It looks good. I submitted it. Thanks for your patch. On Fri, Sep 21, 2012 at 2:46 PM, Clarence GUO wrote: > HI~ > Have a code review request, > https://issues.apache.org/ooo/show_bug.cgi?id=121058. > > Thanks & BRs, > Clarence >

Re: [Call-for-Review]Bug 119487 - [From Symphony]Images lose macro association when open Excel file in AOO

2012-09-07 Thread Lei Wang
I just review your code. I have one question. When loading a xls file with a picture which does not have any related macro, will SetSimpleMacro(true) bring side effect. On Thu, Sep 6, 2012 at 2:46 PM, Chen Peng wrote: > Hi All, > I have fixed a bug about macro doesn't work on images, as sho

Re: Duplicate code in module binfilter [was: Re: svn commit: r1379349 - in /incubator/ooo/trunk/main: offapi/com/sun/star/sheet/ offapi/type_reference/ oox/inc/oox/xls/ oox/source/xls/ sc/inc/ sc/sour

2012-09-03 Thread Lei Wang
mail.com> wrote: > Hi, > > On 03.09.2012 12:35, Lei Wang wrote: > >> [snip] >> >> Why there are duplicated codes in binfilter\inc\bf_sc and sc\inc? >> >> > The module binfilter is more or less a stripped version of the complete > code in order to get

Re: svn commit: r1379349 - in /incubator/ooo/trunk/main: offapi/com/sun/star/sheet/ offapi/type_reference/ oox/inc/oox/xls/ oox/source/xls/ sc/inc/ sc/source/core/data/ sc/source/core/tool/ sc/source/

2012-09-03 Thread Lei Wang
Hi Ariel Thanks for your suggestion. I will work with Zhao Shao Zhi to add 2 new interfaces instead of adding new member functions to the existed interface. BTW, Why there are duplicated codes in binfilter\inc\bf_sc and sc\inc? On Mon, Sep 3, 2012 at 12:54 PM, Ariel Constenla-Haile wrote: > Hi

[Call for Test] Enhancement 120478 is done, support sheet scoped named ranges in Calc

2012-08-31 Thread Lei Wang
Hi, The enhancement 120478(https://issues.apache.org/ooo/show_bug.cgi?id=120478) is done, support sheet scoped named ranges in Calc. Code is committed in revision 1379349The build will be ready. Please test it when build is ready. An

Re: [Call for review][Calc]Featue enchancement- Name Scope enhancement for spreadsheet

2012-08-31 Thread Lei Wang
I have reviewed the codes. After communicated with shzh zhao, he did some modification and provide a new patch. The new patch looks good. I committed the patch in revision 1379349 Thanks Shao Zhi. On Tue, Aug 21, 2012 at 11:09 AM, shzh

Re: [DISCUSS]: I would like to propose a new conversion mode parameter

2012-08-20 Thread Lei Wang
On Tue, Aug 21, 2012 at 4:18 AM, Marcus (OOo) wrote: > Am 08/20/2012 04:54 PM, schrieb Jürgen Schmidt: > > OpenOffice is not only used as desktop application but also as hidden >> part of other software and often as a conversion engine in the backend. >> >> OpenOffice has very good filters for m

Re: [VOTE] Apache OpenOffice Community Graduation Vote

2012-08-20 Thread Lei Wang
+1 On Sun, Aug 19, 2012 at 11:52 PM, Rob Weir wrote: > Per the IPMC's "Guide to Successful Graduation" [1] this is the > optional, but recommended, community vote for us to express our > willingness/readiness to govern ourselves. If this vote passes then > we continue by drafting a charter, sub

Re: request for enchancement of the define name function in calc

2012-08-14 Thread Lei Wang
ecked this formula "=SUM((B3:B5,D3:D5))"(union directly > used) > > > created in Excel 2003. It will be imported as "=SUM((B3:B5~D3:D5))" > which > > > is correct. While Excel 2003 filter still imports the union as ";". But > > as > &

Re: request for enchancement of the define name function in calc

2012-08-08 Thread Lei Wang
Hi Regina I saw your comments in https://issues.apache.org/ooo/show_bug.cgi?id=120478 It is glad to know that ODF1.2 support sheet scoped defined name. It is very important to comply with ODF1.2. So our plan will be changed to Step 1, support interoperability with sheet scoped defined name in Exc

Re: request for enchancement of the define name function in calc

2012-08-08 Thread Lei Wang
Hi, May be Shao Zhi do not clearly state his proposal. Let me try again. Excel 2007 can define same name for different sheet. When AOO loading a xlsx file which has duplicated defined name, AOO will only change the name. But any other place which uses the defined name is not changed, which will c

Re: [Call-for-​​Review][Calc]Data validity works incorrectly with criteria "Allow text length" for numbers

2012-08-01 Thread Lei Wang
Herbert, thank you for applying the patch. I planed to do it. But after merging this patch and updating to latest trunk code, I can not build trunk successfully for several days. On Wed, Aug 1, 2012 at 9:53 PM, Herbert Duerr wrote: > On 25.07.2012 07:11, Zhang Lu wrote: > >> One fix for review.

Re: trunk build fails, likely in python

2012-08-01 Thread Lei Wang
With updating to revision 1367616, I can build python module successfully in Windows XP. Thank you for your fixing. On Tue, Jul 31, 2012 at 11:32 PM, Pedro Giffuni wrote: > Thank you Tsutomu! > > The other patches should also be used. I am not sure if dmake supports > the += operator so I just w

Re: [Call-for-​​Review][Calc]Data validity works incorrectly with criteria "Allow text length" for numbers

2012-07-27 Thread Lei Wang
I am taking care of this On Wed, Jul 25, 2012 at 1:11 PM, Zhang Lu wrote: > Hi~ > > One fix for review. > > https://issues.apache.org/ooo/show_bug.cgi?id=93128 > > Step: > > 1 Select the cells for which you want to define a new validity rule > 2 Choose Data - Validity > 3 On the Criteria tab pag

Re: remove system font selection

2012-07-26 Thread Lei Wang
wrote: > Lei, > > Thanks for your reply, > > Can you details what did you mean by "build your owner AOO"? > > > Thanks, > Wie > > On Fri, Jul 27, 2012 at 12:36 PM, Lei Wang wrote: > > This must be done by core. You need build your owner AOO. You n

Re: remove system font selection

2012-07-26 Thread Lei Wang
This must be done by core. You need build your owner AOO. You need change the font selection UI control from toolbar and property dialog. On Fri, Jul 27, 2012 at 1:04 PM, Wie Kiang wrote: > Hello, > > Any idea how to remove system font selection on open office UI > (Writer, Calc and Impress)? >

[DISCUSS][CALC] String content to numeric value

2012-07-26 Thread Lei Wang
In ODFF standard 6.3.5 Conversion to Number, If the expected type is Number, then if value is of type: ● Text: The specific conversion is implementation-defined; an evaluator may return 0, an Error value, or the results of its attempt to convert the Text value to a Number (and fall back to 0 or Err

Re: [Call-for-​​Review][From Symphony] Function "Case sensitive" in "Special Filter" dialog can not work.

2012-07-26 Thread Lei Wang
I will take care of this On Thu, Jul 26, 2012 at 4:09 PM, Clarence GUO wrote: > HI~ > I have one fix waiting for review. Root cause and solution please goto the > issue's comments. > https://issues.apache.org/ooo/show_bug.cgi?id=119637 > > Regrads > Clarence >

Re: [UX]Why does AOO use semicolon and space as the default separators when open one csv?

2012-07-23 Thread Lei Wang
Liu Zhe I agree with you. +1 for me On Mon, Jul 23, 2012 at 3:00 PM, Zhe Liu wrote: > Hi, > I use Calc to open a csv. "Text Import" dialog pops up. Semicolon & > Space are checked by default as separators. Most of csv files in the > world use comma as separator, right? I prefer comma. > In add

Re: [RELEASE][3.5] Process thinking - defect&feature rules, iteration...

2012-07-19 Thread Lei Wang
I add some items for Calc application for 3.5 plan in 3.5 Release Planning wiki< https://cwiki.apache.org/confluence/display/OOOUSERS/AOO+3.5+Release+Planning > If there are anything which must be in 3.5 for Calc, please discuss it here or put it in the list in the planning wiki. On Fri, Jul 20,

Re: spreadsheet source

2012-07-07 Thread Lei Wang
Hi, Shawn There are some documents about the implementation listed http://wiki.services.openoffice.org/wiki/Calc/Implementation On Fri, Jul 6, 2012 at 9:34 PM, Shawn Pringle wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > I am a new subscriber and there are some bugs I am trying to

[Calc] Dose Calc support Excel similar function "Move but don't size with cell" for drawing object/picture

2012-07-05 Thread Lei Wang
Hi, In Excel, user can set object positioning properties for a drawing object/graphic. There are three options. AOO does not have similar properties. But it use anchor attribute to reflect these properties. Excel AOO Move and size with cells

Re: [Calc][Discuss]Interoperability with Excel for SUMIF, COUNTIF, COUNTBLANK, DCOUNT, DSUM, ... with empty cells and "" and ="" empty string criteria.

2012-07-04 Thread Lei Wang
cumentation on these cases is probably also important. > > - Dennis > > -Original Message- > From: Andrew Pitonyak [mailto:and...@pitonyak.org] > Sent: Monday, July 02, 2012 07:39 > To: ooo-dev@incubator.apache.org > Subject: Re: [Calc][Discuss]Interoperability with E

Re: [DISCUSS]Macros are lost after saving the xls file to ods, then save as to xls again

2012-07-03 Thread Lei Wang
anged...The only difference is that > the saved binary VBA streams within the ods file will be exported to the > xls file at that time.Thus,when end users launch the xls file in MS > Excel,the original VBA will be there.That's the expected result.thanks. > > On Tue, Jul 3, 2012 a

Re: [DISCUSS]Macros are lost after saving the xls file to ods, then save as to xls again

2012-07-03 Thread Lei Wang
Jian Hong, Will AOO save VBA as Star Basic in ods file when saving a xls file with VBA as ods file? If it is true, can user modify the Star Basic in the new ods file? What happened if user change the Star Basic in the ods file then save as a xls file? On Tue, Jul 3, 2012 at 3:57 PM, chengjh wrot

[Calc][Discuss]Interoperability with Excel for SUMIF, COUNTIF, COUNTBLANK, DCOUNT, DSUM, ... with empty cells and "" and ="" empty string criteria.

2012-07-02 Thread Lei Wang
Hi all, There is an old bug i65221( https://issues.apache.org/ooo/show_bug.cgi?id=65221). It is about interoperability with Excel for SUMIF, COUNTIF, COUNTBLANK, DCOUNT, DSUM, ... with empty cells and "" and ="" empty string criteria. There is some discussion about it, but no conclusion. Some peo

Re: colours in Calc

2012-07-01 Thread Lei Wang
Hi Pam, >From your description, I do not really understand your problem. I guess you have a Spreadsheet document(ods file). It worked fine in your old OOo (may be OOo3.3). After you upgrade OOo to AOO3.4, it does not work now. You can open/file a bug in https://issues.apache.org/ooo . Please attac

Re: [Discussion]Active Doc/Sheet protection password related blocks

2012-06-28 Thread Lei Wang
Hi Jian Yuan, The file tabprotection.hxx is created by CWS scheetprotection02. I go through the comments when this CWS integrated into the trunk. But I do not find any useful information. If Excel use another hash algorithm, AOO can not unprotect the sheet/doc even user input the right password.

Re: [Call-for-Review][Calc][From Symphony]Crash if undo redo creating data pilot from imported data

2012-06-13 Thread Lei Wang
Done. Thanks for your contribution On Wed, Jun 13, 2012 at 9:03 PM, Lei Wang wrote: > I will take care of this one. > > > On Wed, Jun 13, 2012 at 2:04 PM, 彭云全 wrote: > >> hI All, >> >>My name is pengyunquan. I am a developer working several years in >&

Re: [Call-for-Review][Calc][From Symphony]Formula GETPIVOTDATA returns #REF! value

2012-06-13 Thread Lei Wang
Done. Thanks for your contribution On Wed, Jun 13, 2012 at 9:02 PM, Lei Wang wrote: > I will take care of this one. > > > On Wed, Jun 13, 2012 at 2:07 PM, 彭云全 wrote: > >> Hi All, >> >>My name is pengyunquan. I am a developer working several years in >&

Re: [Call-for-Review][Calc][From Symphony]Crash if undo redo creating data pilot from imported data

2012-06-13 Thread Lei Wang
I will take care of this one. On Wed, Jun 13, 2012 at 2:04 PM, 彭云全 wrote: > hI All, > >My name is pengyunquan. I am a developer working several years in > Symphony team. My specail areas are PivotTable / Graphic / VCL / > Performance. > > I have a patch for review. > https://issues.apache.or

Re: [Call-for-Review][Calc][From Symphony]Formula GETPIVOTDATA returns #REF! value

2012-06-13 Thread Lei Wang
I will take care of this one. On Wed, Jun 13, 2012 at 2:07 PM, 彭云全 wrote: > Hi All, > >My name is pengyunquan. I am a developer working several years in > Symphony team. My special areas are PivotTable / Graphic / VCL / > Performance. > > I have a patch for review. > https://issues.apache.or

[Calc][DISCUSS] What is your expected behavior when doing paste with a whole column or a whole sheet.

2012-06-12 Thread Lei Wang
Hi, When I review bug i118863 ( https://issues.apache.org/ooo/show_bug.cgi?id=118863), I find there are some other related user cases which can get AOO crash or freeze. Scenario 1 1)New a calc doc. 2)Input 1, 2, 3 in cell A1, A2, A3 3)Set background color for cell A1, A2, A3 as blue, green, red 4

Re: patch for issue 118863

2012-05-31 Thread Lei Wang
Hi Debin, I have reviewed the codes for 118877 https://issues.apache.org/ooo/show_bug.cgi?id=11887 > > It seems it still has some problems. I add comments in the issues. Please check. On Mon, May 21, 2012 at 3:09 PM, debin lei wrote: > I h

Re: Ooo for Win XP, type ahead feature

2012-03-29 Thread Lei Wang
What is typing the words ahead? Do you means word completion? On Wed, Mar 28, 2012 at 11:54 PM, Luciano wrote: > I have Ooo for Linux and Ooo for Win XP. I noticed that the Ooo for win xp > doesn't type the words ahead like the one on Linux does. Is this feature > going to be added some day to t

Re: Is any one here familiar with OpenOffice?

2012-03-13 Thread Lei Wang
Hello Rob I am Spreadsheet team leader for Lotus Symphony Development. I participated with several work related with OpenOffice from 2002. I did performance improvement for Symphony start up, document loading and saving. I fix issues and add new features for Spreadsheet. I implemented a well know

[RELEASE] Bug 118537 When there are a large number of Charts in a spreadsheet a number of charts just display OLE

2012-03-09 Thread Lei Wang
Hi, >From my point of view, Issue 118537, https://issues.apache.org/ooo/show_bug.cgi?id=118537 is not a release blocker. It is not a crash, regression, other serious issue. Now I can not get the sample file because of the file can not be downloaded in the specified URL. So I can not investigate

[RELEASE] Bug 119024 Calc 3.4 crash constant when sorting a named areas where the columns being sorted contains empty cells

2012-03-08 Thread Lei Wang
Hi, Issue 119024 - https://issues.apache.org/ooo/show_bug.cgi?id=119024 - should be closed as it can not be reproduced in AOO3.4 rev 1296433 from my point of view. If anyone can reproduce this issue in the latest AOO3.4 build(rev 1296433), please add comments and give detail description about the