On Wed, Aug 09, 2017 at 04:11:18PM +0200, Benjamin Block wrote:
> + return 0 == (bc->hdr.flags & BSG_FLAG_Q_AT_TAIL);
return !(bc->hdr.flags & BSG_FLAG_Q_AT_TAIL); and make the function return
bool? I have to admit, this is the 1st time I have seen the above construct.
Thanks,
Johanne
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG N
Looks fine,
Reviewed-by: Christoph Hellwig
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send e
We can't use an on-stack buffer for the sense data, as drivers will
dma to it. So we should reuse the SCSI init_rq_fn() for the BSG
queues and/or implement the same scheme.
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this
Looks fine,
Reviewed-by: Christoph Hellwig
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send e
On Thu, Aug 10, 2017 at 10:24:56AM +0200, Johannes Thumshirn wrote:
> On Wed, Aug 09, 2017 at 04:11:18PM +0200, Benjamin Block wrote:
> > + return 0 == (bc->hdr.flags & BSG_FLAG_Q_AT_TAIL);
>
> return !(bc->hdr.flags & BSG_FLAG_Q_AT_TAIL); and make the function return
> bool? I have to admit, th
On Wed, Aug 09, 2017 at 04:11:19PM +0200, Benjamin Block wrote:
> Since struct bsg_command is now used in every calling case, we don't
> need separation of arguments anymore that are contained in the same
> bsg_command.
>
> Signed-off-by: Benjamin Block
> ---
> block/bsg.c | 13 ++---
>
Looks good,
Reviewed-by: Christoph Hellwig
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send e
>>> Johannes Thumshirn schrieb am 10.08.2017 um 10:24 in
Nachricht <20170810082456.gi4...@linux-x5ow.site>:
> On Wed, Aug 09, 2017 at 04:11:18PM +0200, Benjamin Block wrote:
>> +return 0 == (bc->hdr.flags & BSG_FLAG_Q_AT_TAIL);
>
> return !(bc->hdr.flags & BSG_FLAG_Q_AT_TAIL); and make the fu
>>> Christoph Hellwig schrieb am 10.08.2017 um 11:32 in Nachricht
<20170810093217.gl24...@lst.de>:
> We can't use an on-stack buffer for the sense data, as drivers will
> dma to it. So we should reuse the SCSI init_rq_fn() for the BSG
Doesn't it just depend on WHEN the DMA is done? If the functi
On Thu, Aug 10, 2017 at 11:32:17AM +0200, Christoph Hellwig wrote:
> We can't use an on-stack buffer for the sense data, as drivers will
> dma to it. So we should reuse the SCSI init_rq_fn() for the BSG
> queues and/or implement the same scheme.
>
BSG is odd in this regard. Here is the data mode
On Thu, Aug 10, 2017 at 10:24:56AM +0200, Johannes Thumshirn wrote:
> On Wed, Aug 09, 2017 at 04:11:18PM +0200, Benjamin Block wrote:
> > + return 0 == (bc->hdr.flags & BSG_FLAG_Q_AT_TAIL);
>
> return !(bc->hdr.flags & BSG_FLAG_Q_AT_TAIL); and make the function return
> bool? I have to admit, th
On Thu, Aug 10, 2017 at 11:35:31AM +0200, Christoph Hellwig wrote:
> On Wed, Aug 09, 2017 at 04:11:19PM +0200, Benjamin Block wrote:
> > Since struct bsg_command is now used in every calling case, we don't
> > need separation of arguments anymore that are contained in the same
> > bsg_command.
> >
On Fri, Aug 11, 2017 at 12:10:38AM +0200, Benjamin Block wrote:
> On Thu, Aug 10, 2017 at 11:32:17AM +0200, Christoph Hellwig wrote:
> > We can't use an on-stack buffer for the sense data, as drivers will
> > dma to it. So we should reuse the SCSI init_rq_fn() for the BSG
> > queues and/or impleme
15 matches
Mail list logo
