Re: [PATCH] scsi: Fix reference count leak in iscsi_boot_create_kobj.

2020-06-05 Thread 'Qiushi Wu' via open-iscsi
Thanks! On Tue, Jun 2, 2020 at 9:32 PM Martin K. Petersen < martin.peter...@oracle.com> wrote: > On Thu, 28 May 2020 15:13:53 -0500, wu000...@umn.edu wrote: > > > kobject_init_and_add() should be handled when it return an error, > > because kobject_init_and_add() takes reference even when it

Re: [PATCH] iscsi: Add break to while loop

2020-06-05 Thread The Lee-Man
On Thursday, June 4, 2020 at 5:10:49 AM UTC-7, Wu Bo wrote: > > From: liubo > > Fix the potential risk of rc value being washed out by jumping out of the > loop > > Signed-off-by: liubo > Reported-by: Zhiqiang Liu > --- > utils/fwparam_ibft/fwparam_sysfs.c | 5 - > 1 file changed, 4

Re: [EXT] [PATCH] iscsi: Add break to while loop

2020-06-05 Thread The Lee-Man
On Thursday, June 4, 2020 at 7:43:13 AM UTC-7, Uli wrote: > > >>> Wu Bo schrieb am 04.06.2020 um 14:23 in Nachricht > <7784_1591272646_5ED8E4C6_7784_490_1_1591273415-689835-1-git-send-email-wubo40@h > > > awei.com>: > > From: liubo > > > > Fix the potential risk of rc value being washed

RFC: what to do about the open-iscsi GPL license vs. the open-ssl BSD license?

2020-06-05 Thread The Lee-Man
Hi All: I believe there is a conflict between the current open-iscsi license and the open-ssl license, noticed recently when Chris Leech updated open-iscsi to use newer encryption algorithms. You can see more about this on github, where it was brought up as an issue