Re: [PATCH 2/3] iscsi: bidi support - libiscsi

2008-02-11 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Thu, 31 Jan 2008 22:29 +0200: > iscsi bidi support at the generic libiscsi level > - prepare the additional bidi_read rlength header. > - access the right scsi_in() and/or scsi_out() side of things. > also for resid. > - Handle BIDI underflow overflow from ta

Re: [PATCH 2/3] iscsi: bidi support - libiscsi

2008-02-11 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Mon, 11 Feb 2008 18:05 +0200: > You are most probably right I will investigate what happened. It looks > like I went back to some old version right? or a merge fallout > Thanks for reviewing. > > Please also test latest head-of-line code if possible + iscsi patches > +

Re: [PATCH 0/3] iscsi bidi & varlen support

2008-02-12 Thread Pete Wyckoff
could use more testing. Note that this does > rely on the 3 patches quoted above. Similar, for varlen support to iSER. Probably apply this one before the bidi one I just sent. -- Pete From: Pete Wyckoff <[EMAIL PROTECTED]> Subject: [PATCH] iscsi iser: varlen Hand

Re: [PATCH 0/3] iscsi bidi & varlen support

2008-02-12 Thread Pete Wyckoff
could use more testing. Note that this does rely on the 3 patches quoted above. -- Pete From: Pete Wyckoff <[EMAIL PROTECTED]> Support bidirectional SCSI commands in iSCSI iSER. The handling of data buffers for each direction was already mostly separated. It was necessary t

Re: [PATCH 0/3] iscsi bidi & varlen support

2008-02-18 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Mon, 18 Feb 2008 17:39 +0200: > On Tue, Feb 12 2008 at 22:17 +0200, Pete Wyckoff <[EMAIL PROTECTED]> wrote: > > From: Pete Wyckoff <[EMAIL PROTECTED]> > > Subject: [PATCH] iscsi iser: varlen > > > > Handle variable-length CDB

Re: [Ips] Calculating the VA in iSER header

2008-04-16 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Wed, 16 Apr 2008 11:22 +0300: > According to Mike's explanation below it seems that we have a bug in > iSER initiator. > Fixing this bug will require a fix in the stgt iSER code. > > The problem is that the initiator send a VA which already includes an > offset for the

Re: [ofa-general] Re: [Ips] Calculating the VA in iSER header

2008-04-29 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Thu, 17 Apr 2008 14:13 +0300: > On Wed, Apr 16, 2008 at 6:46 PM, Roland Dreier <[EMAIL PROTECTED]> wrote: > > > Agree with the interpretation of the spec, and it's probably a bit > > > clearer that way too. But we have working initiators and targets > > > that do i

Re: [ofa-general] [PATCH] IB/iSER: Add module param to count alignment violations

2008-04-30 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Mon, 28 Apr 2008 08:51 -0700: > > Add read only module param to count alignment violations. > > I don't think a module parameter is the way to report statistics from > the kernel. Can't you just add a device attribute or something? Or > stick a file in debugfs? This

Re: [ofa-general] [PATCH] IB/iSER: Count fmr alignment violations per session

2008-04-30 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Tue, 29 Apr 2008 10:33 +0300: > Count fmr alignment violations per session > as part of the iscsi statistics. > > Signed-off-by: Eli Dorfman <[EMAIL PROTECTED]> Brilliant. Thanks for this. -- Pete --~--~-~--~~~---~--~~

Re: [ofa-general] Re: [Ips] Calculating the VA in iSER header

2008-05-01 Thread Pete Wyckoff
backwards. > On Tue, Apr 29, 2008 at 8:05 PM, Pete Wyckoff <[EMAIL PROTECTED]> wrote: > > But you missed the impact of immediate data. We run with the > > defaults (I think) that say the first write request packet should be > > filled with a bit of the c

Re: Publishing iSER limitations

2008-05-02 Thread Pete Wyckoff
a nice addition that would definitely help some of our apps. My patch "iscsi iser: remove DMA alignment restriction" changes iser to make the alignment 0, rather than the default 512, to avoid the bounce buffering in __blk_rq_map_user(). Else confirming single-element or multi-element

Re: Publishing iSER limitations

2008-05-04 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Sun, 04 May 2008 11:21 +0300: > Pete Wyckoff wrote: > > [EMAIL PROTECTED] wrote on Mon, 28 Apr 2008 11:20 -0500: > >> Erez Zilber wrote: > >>> I understand that IB's requirements are too difficult to force. I guess &

[PATCH] fix host number sysfs parsing

2008-05-04 Thread Pete Wyckoff
ut changed yet again. Accommodate new kernels (2.6.25-rc1 at least), but probably break the parsing on older ones. Signed-off-by: Pete Wyckoff <[EMAIL PROTECTED]> --- usr/iscsi_sysfs.c | 19 +++ 1 files changed, 7 insertions(+), 12 deletions(-) diff --git a/usr/isc

modifying transport_name

2008-05-22 Thread Pete Wyckoff
I confess to having lost the plot on the iface rearrangements. I'm trying to mount up a remote iser target using 2.6.26-rc3 and open-iscsi git HEAD userspace plus hacks to read the new sysfs layout. The old style, before login, was to modify node.transport_name, which now has been changed to liv

Re: modifying transport_name

2008-05-23 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Thu, 22 May 2008 16:58 -0500: > Oh yeah, so let me know what you think would be easier for you? I > thought just passing in "-I iser" during discovery would be nice and > save a step. If it is worse then let me know. In the end we will have > bnx2i, iser, chelsio and