Marc--
Quick work! Thanks for taking care of these things. Couple of comments:
I didn't realize there was a de-facto minimum time
Typically, vote time runs for 3 days, which gives folks in different
time zones and day jobs enough time to have a look.
I did follow-up with a thread on Kevi
On 10/19/06, Marc Prud'hommeaux <[EMAIL PROTECTED]> wrote:
Eddie-
> - Is there an SVN tag for this?
No, although the SVN revision number is contained in the release
(FTR, it can be seen by running: "java
org.apache.openjpa.conf.OpenJPAVersion").
Is there a policy on SVN tag names for incu
Eddie-
On Oct 19, 2006, at 10:17 AM, Eddie O'Neil wrote:
Marc--
A couple of comments:
#1: Since the vote has only been open for 24 hours, there may not have
been enough time for everyone to comment on the release -- while there
are already 3 +1s which are sufficient to declare a release, the
On 10/19/06, Patrick Linskey <[EMAIL PROTECTED]> wrote:
Also, I noticed that you have a tearDown() in your test case.
Historically, we've typically not written tearDown() methods, and just
put the tear-down logic in the beginning of setUp().
That's funny, 'cause I copied one of the existing t
[ x] Separate setUp() and tearDown()
[ ] Separate setUp() and tearDown(), but setUp() invokes tearDown()
[ ] Typically no tearDown(); put cleanup logic in setUp()
[ ] Other. Please describe.
IMO, if we're diligent in writing proper tearDown methods, there's no
reason to put the tearDown logic
Also, I noticed that you have a tearDown() in your test case.
Historically, we've typically not written tearDown() methods, and just
put the tear-down logic in the beginning of setUp(). I understand the
value of having a separate tearDown() to keep things clean, but it'd be
good if you called tearD
Just so everyone is aware of this ASF infrastructure downtime.
-- Forwarded message --
From: Sander Striker <[EMAIL PROTECTED]>
Date: Oct 18, 2006 4:53 PM
Subject: [NOTICE] Scheduled downtime for critical infrastructure
To: [EMAIL PROTECTED]
Hi,
Upcoming Saturday 21st throug
Thanks, Abe. Will take care of this shortly.
On 10/19/06, Abe White <[EMAIL PROTECTED]> wrote:
Kevin --
Thanks for the test case. Unfortunately, the test will always fail
for databases that don't support auto-assigning column values. The
test should probably look for DBDictionary.supportsAu
Took care of the easy typo... accidentally did this with the updates to get
rid of the "-all" suffix...
- The JAR's MANIFEST.MF file has an extra "$" character for the
Specification Vendor
Kevin
On 10/19/06, Eddie O'Neil <[EMAIL PROTECTED]> wrote:
Marc--
A couple of comments:
#1: Since
It also appears that the LICENSE and NOTICE files are missing from SVN.
The STATUS file is missing as well -- I'll add that.
Eddie
On 10/19/06, Eddie O'Neil <[EMAIL PROTECTED]> wrote:
Marc--
A couple of comments:
#1: Since the vote has only been open for 24 hours, there may not have
be
Kevin --
Thanks for the test case. Unfortunately, the test will always fail
for databases that don't support auto-assigning column values. The
test should probably look for DBDictionary.supportsAutoAssign and
skip itself (early on, before any attempt to create the schema for
the classes
Marc--
A couple of comments:
#1: Since the vote has only been open for 24 hours, there may not have
been enough time for everyone to comment on the release -- while there
are already 3 +1s which are sufficient to declare a release, the
additional time allows those who haven't had time to look a
OpenJPA People-
The final tally of the vote is:
+1 votes: 3
Bryan Noll: http://mail-archives.apache.org/mod_mbox/incubator-open-
jpa-dev/200610.mbox/[EMAIL PROTECTED]
Abe White: http://mail-archives.apache.org/mod_mbox/incubator-open-
jpa-dev/200610.mbox/[EMAIL PROTECTED]
Patrick Linksey:
13 matches
Mail list logo