Re: [OE-core] [PATCH v3 1/2] ntirpc: Add ntirpc recipe

2022-09-15 Thread Paulo Neves
On 9/15/22 12:50, Ross Burton wrote: On 28 Aug 2022, at 18:43, Paulo Neves via lists.openembedded.org wrote: ntirpc is an actively maintained rpc implementation. We cannot completely remove libtirpc due to arising circular dependencies where ntirpc depends on libnsl2, which in turn depends

Re: [OE-core] [PATCH v3 2/2] nfs-ganesha: Replace unfs3 with nfs-ganesha

2022-09-15 Thread Paulo Neves
is not compatible with tirpc. I spent sometime trying to make it so but it is huge increase in scope for the current delivery. ntirpc is also requiring some adaptations with musl that i did not anticipate. Some upstream discussions are also taking a bit longer than expected. Paulo Neves On 9/14/22 23:19

Re: [OE-core] [PATCH 1/1] watchdog: Remove unneeded tirpc dependency

2022-09-12 Thread Paulo Neves
it should as there is no rpc code in the project as far as i scanned. I built it with musl successfully. Paulo Neves On 9/12/22 17:06, Khem Raj wrote: On Mon, Sep 12, 2022 at 2:21 AM Paulo Neves wrote: watchdog code does not have any dependency on rpc code, therefore the dependency

[OE-core] [PATCH 1/1] watchdog: Remove unneeded tirpc dependency

2022-09-12 Thread Paulo Neves
watchdog code does not have any dependency on rpc code, therefore the dependency and flags to try to use it are removed. Signed-off-by: Paulo Neves --- meta/recipes-extended/watchdog/watchdog_5.16.bb | 4 1 file changed, 4 deletions(-) diff --git a/meta/recipes-extended/watchdog

Re: [OE-core] [PATCH 1/2] ntirpc: Add ntirpc recipe

2022-08-29 Thread Paulo Neves
No. The rationale for ntirpc is that it is a dependency of nfs-ganesha, which in turn is the implementation not maintained. Paulo Neves On 8/29/22 20:01, Alexander Kanavin wrote: I think the rationale is that the implementation it replaces is not anymore maintained? Alex On Mon, 29 Aug 2022

Re: [OE-core] [PATCH 2/2] nfs-ganesha: Replace unfs3 with nfs-ganesha

2022-08-28 Thread Paulo Neves
and an unknown license in it. Alex On Sat, 27 Aug 2022 at 19:46, Paulo Neves wrote: nfs-ganesha is actively maintained in contrast with unfs3. glibc tests pass with nfs-ganesha. Signed-off-by: Paulo Neves --- meta/lib/oeqa/utils/nfs.py| 2 +- ...ix-possible-null-pointer

[OE-core] [PATCH v3 2/2] nfs-ganesha: Replace unfs3 with nfs-ganesha

2022-08-28 Thread Paulo Neves
nfs-ganesha is actively maintained in contrast with unfs3. glibc tests pass with nfs-ganesha. Signed-off-by: Paulo Neves --- meta/lib/oeqa/utils/nfs.py| 2 +- ...ix-possible-null-pointer-dereference.patch | 38 + ...-Workaround-for-erroneous-gcc-Werror.patch | 33

[OE-core] [PATCH v3 1/2] ntirpc: Add ntirpc recipe

2022-08-28 Thread Paulo Neves
ntirpc is an actively maintained rpc implementation. We cannot completely remove libtirpc due to arising circular dependencies where ntirpc depends on libnsl2, which in turn depends on an RPC implementation. libtirpc and ntirpc are not mutually exclusive. Signed-off-by: Paulo Neves --- meta

Re: [OE-core] [PATCH 1/2] ntirpc: Add ntirpc recipe

2022-08-28 Thread Paulo Neves
Hello Alexander, Thank you for your review I updated the commit message for v2 to contain the following text: We cannot completely  remove libtirpc due to arising circular dependencies where ntirpc depends on libnsl2, which  in turn depends on an RPC implementation. Paulo Neves On 8/27/22

[OE-core] [PATCH v2 2/2] nfs-ganesha: Replace unfs3 with nfs-ganesha

2022-08-28 Thread Paulo Neves
nfs-ganesha is actively maintained in contrast with unfs3. glibc tests pass with nfs-ganesha. Signed-off-by: Paulo Neves --- meta/lib/oeqa/utils/nfs.py| 2 +- ...ix-possible-null-pointer-dereference.patch | 38 + ...-Workaround-for-erroneous-gcc-Werror.patch | 33

[OE-core] [PATCH v2 1/2] ntirpc: Add ntirpc recipe

2022-08-28 Thread Paulo Neves
ntirpc is an actively maintained rpc implementation. We cannot completely remove libtirpc due to arising circular dependencies where ntirpc depends on libnsl2, which in turn depends on an RPC implementation. libtirpc and ntirpc are not mutually exclusive. Signed-off-by: Paulo Neves --- meta

[OE-core] [PATCH 2/2] nfs-ganesha: Replace unfs3 with nfs-ganesha

2022-08-27 Thread Paulo Neves
nfs-ganesha is actively maintained in contrast with unfs3. glibc tests pass with nfs-ganesha. Signed-off-by: Paulo Neves --- meta/lib/oeqa/utils/nfs.py| 2 +- ...ix-possible-null-pointer-dereference.patch | 40 + ...-Workaround-for-erroneous-gcc-Werror.patch | 33

[OE-core] [PATCH 1/2] ntirpc: Add ntirpc recipe

2022-08-27 Thread Paulo Neves
ntirpc is an actively maintained rpc implementation. We cannot completely remove libtirpc due to arising circular dependencies. libtirpc and ntirpc are not mutually exclusive. Signed-off-by: Paulo Neves --- meta/recipes-extended/ntirpc/ntirpc_4.0.bb| 30 +++ meta/recipes

Re: [OE-core] [PATCH 1/1] lame: Remove hardcoded rpaths

2022-07-27 Thread Paulo Neves
    sed -i -e 's|hardcode_into_libs=yes|hardcode_into_libs=no|' ${B}/libtool The hardcode_into_libs=no did not fix things for the lame case. We have a patch for libtools that looks like could be the culprit and need tightening [1] [1] recipes-devtools/libtool/libtool/0004-ltmain.sh-Fix-sysroot-paths-bein

[OE-core] [PATCH 1/1] lame: Remove hardcoded rpaths

2022-07-26 Thread Paulo Neves
Due to hardcoded rpaths tmpdir contamination happened on lame executable. This commit hot patches libtool to not hardcode the .libs directory in the rpath. This solves [YOCTO #14863] Signed-off-by: Paulo Neves --- meta/recipes-multimedia/lame/lame_3.100.bb | 4 1 file changed, 4 insertions

[OE-core] [PATCH v2 1/1] oeqa: test_invalid_recipe_src_uri expect parse time error

2022-07-14 Thread Paulo Neves
-off-by: Paulo Neves --- meta/lib/oeqa/selftest/cases/bbtests.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/meta/lib/oeqa/selftest/cases/bbtests.py b/meta/lib/oeqa/selftest/cases/bbtests.py index b42bbb651d..89267c7145 100644 --- a/meta/lib/oeqa/selftest/cases

Re: [OE-core] [PATCH 2/3] oeqa/sysroot.py: Check bitbake return status

2022-07-07 Thread Paulo Neves
After re-thinking this is the correct version of the patch. We need to ignore_status because we are asserting that it actually fails. Otherwise the bitbake() will fail the test on the desired failure. Paulo Neves On 7/4/22 16:30, Richard Purdie wrote: On Mon, 2022-07-04 at 16:28 +0200, Paulo

Re: [OE-core] [poky] [PATCH] perl: Fix perms to avoid patch fails

2022-07-07 Thread Paulo Neves
On 7/7/22 03:26, Randy MacLeod wrote: Hi K, Add oe-core list and move poky to BCC to ensure follow to the main oe-core code review list. On 2022-06-17 03:13, K. wrote: Fix missing write permissions to avoid problems with applying patches in particular on compressed filesystems: ERROR:

[OE-core] [PATCH v2 2/3] utils: create_cmdline_shebang_wrapper preserve permission and ownership

2022-07-04 Thread Paulo Neves
-by: Paulo Neves Signed-off-by: Richard Purdie --- .../wrapper/cmdline-shebang-wrapper-test.bb | 11 ++- meta/classes/utils.bbclass| 3 +++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/meta-selftest/recipes-test/wrapper/cmdline-shebang

[OE-core] [PATCH v2 3/3] oeqa/sysroot.py: Check bitbake return status

2022-07-04 Thread Paulo Neves
bitbake ran but we incorrectly did not check the exit status needs to be non 0. Now all sysroot tests commands expected to fail are verified to do so. Signed-off-by: Paulo Neves --- meta/lib/oeqa/selftest/cases/sysroot.py | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff

[OE-core] [PATCH v2 1/3] utils: create_cmdline_shebang_wrapper whitespace and sed refactor

2022-07-04 Thread Paulo Neves
Correct whitespace to match the rest of the code in utils. Refactored sed expression with a simpler equivalent. Signed-off-by: Paulo Neves Signed-off-by: Richard Purdie --- meta/classes/utils.bbclass | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/meta/classes

Re: [OE-core] [PATCH 2/3] oeqa/sysroot.py: Check bitbake return status

2022-07-04 Thread Paulo Neves
On 7/4/22 16:16, Richard Purdie wrote: On Sun, 2022-07-03 at 13:41 +0200, Paulo Neves wrote: bitbake ran but we incorrectly did not assert the exit status needs to be non 0. Now all sysroot tests commands expected to fail are verified to do so. Signed-off-by: Paulo Neves --- meta/lib/oeqa

[OE-core] [PATCH 2/3] oeqa/sysroot.py: Check bitbake return status

2022-07-03 Thread Paulo Neves
bitbake ran but we incorrectly did not assert the exit status needs to be non 0. Now all sysroot tests commands expected to fail are verified to do so. Signed-off-by: Paulo Neves --- meta/lib/oeqa/selftest/cases/sysroot.py | 5 + 1 file changed, 5 insertions(+) diff --git a/meta/lib/oeqa

[OE-core] [PATCH 3/3] utils: create_cmdline_shebang_wrapper preserve permission and ownership

2022-07-03 Thread Paulo Neves
-by: Paulo Neves --- .../wrapper/cmdline-shebang-wrapper-test.bb | 11 ++- meta/classes/utils.bbclass| 3 +++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/meta-selftest/recipes-test/wrapper/cmdline-shebang-wrapper-test.bb b/meta-selftest

[OE-core] [PATCH 1/3] utils: create_cmdline_shebang_wrapper whitespace and sed refactor

2022-07-03 Thread Paulo Neves
Correct whitespace to match the rest of the code in utils. Refactored sed expression with a simpler equivalent. Signed-off-by: Paulo Neves --- meta/classes/utils.bbclass | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/meta/classes/utils.bbclass b/meta/classes

[OE-core] [PATCH v6 7/7] libcheck: Fix too long shebang for native case.

2022-06-19 Thread Paulo Neves
It requires a shebang wrapper due to the fact that awk interpreter has an argument. --- meta/recipes-support/libcheck/libcheck_0.15.2.bb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta/recipes-support/libcheck/libcheck_0.15.2.bb b/meta/recipes-support/libcheck/libcheck_0.15.2.bb

[OE-core] [PATCH v6 4/7] oeqa/selftest: Add test for shebang overflow

2022-06-19 Thread Paulo Neves
Make sure we do not stage any executable with a bigger shebang than 128. Fixes [1] [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=11053 Signed-off-by: Paulo Neves --- .../sysroot-test/sysroot-shebang-test_1.0.bb | 12 meta/lib/oeqa/selftest/cases/sysroot.py

[OE-core] [PATCH v6 6/7] utils: Add cmdline_shebang_wrapper util.

2022-06-19 Thread Paulo Neves
selftest/cases/wrapper.py @@ -0,0 +1,11 @@ +from oeqa.selftest.case import OESelftestTestCase +from oeqa.utils.commands import bitbake + +class WrapperTests(OESelftestTestCase): +def test_shebang_wrapper(self): +""" +Summary: Build a recipe which will fail if the cmdline_sheba

[OE-core] [PATCH v6 5/7] oeqa/selftest: Test staged .la and .pc files

2022-06-19 Thread Paulo Neves
These files are checked by qa_check_staged but there was no test cases for whether the tests actually worked. Now there are. Signed-off-by: Paulo Neves --- .../sysroot-test/sysroot-la-test_1.0.bb | 16 + .../sysroot-test/sysroot-pc-test_1.0.bb | 12 +++ meta/lib/oeqa

[OE-core] [PATCH v6 1/7] python: Avoid shebang overflow on python-config.py

2022-06-19 Thread Paulo Neves
The native path may be too big, leading to shebang overflow. Just use the #!/usr/bin/env python3. Signed-off-by: Paulo Neves --- ...shebang-overflow-on-python-config.py.patch | 33 +++ .../recipes-devtools/python/python3_3.10.4.bb | 1 + 2 files changed, 34 insertions

[OE-core] [PATCH v6 2/7] gtk-doc: Fix potential shebang overflow on gtkdoc-mkhtml2

2022-06-19 Thread Paulo Neves
A native path can cause a shebang overflow on gtkdoc-mkhtml. Replace it with /usr/bin/env. Signed-off-by: Paulo Neves --- meta/recipes-gnome/gtk-doc/gtk-doc_1.33.2.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/recipes-gnome/gtk-doc/gtk-doc_1.33.2.bb b/meta/recipes-gnome/gtk-doc

[OE-core] [PATCH v6 3/7] insane.bbclass: Make do_qa_staging check shebangs

2022-06-19 Thread Paulo Neves
://bugzilla.yoctoproject.org/show_bug.cgi?id=11053 Signed-off-by: Paulo Neves --- meta/classes/insane.bbclass | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 9ca84bace9..b2951a48fe 100644 --- a/meta/classes

Re: [OE-core] [PATCH v5 6/7] utils: Add cmdline_shebang_wrapper util.

2022-06-19 Thread Paulo Neves
You are right never mind. Paulo Neves On 6/16/22 00:16, Peter Kjellerstedt wrote: -Original Message- From: Paulo Neves Sent: den 15 juni 2022 15:51 To: Peter Kjellerstedt ; Ross Burton Cc: openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH v5 6/7] utils: Add

Re: [OE-core] [PATCH v5 3/7] insane.bbclass: Make do_qa_staging check shebangs

2022-06-19 Thread Paulo Neves
Yes, when I was making the change I also realized the scope of the check was quite bigger than before. I am going to deliver the final changes requested and leave it up to you to decide on the merge. Let me know your decision so I can close the bug as well. Paulo Neves On Fri, Jun 17, 2022, 18

Re: [OE-core] [PATCH v5 6/7] utils: Add cmdline_shebang_wrapper util.

2022-06-15 Thread Paulo Neves
cmdline_shebang_wrapper util. On 14 Jun 2022, at 16:11, Paulo Neves via lists.openembedded.org wrote: +create_cmdline_shebang_wrapper () { The indentation in this function is a mix of tabs and spaces, please unify. + argument="$(basename "$(head -n1 $cmd | sed -e 's|#![ ]*||g' )”)”

Re: [OE-core] [PATCH 1/3] insane.bbclass: Make do_qa_staging check shebangs

2022-06-15 Thread Paulo Neves
:) The function should probably be refactored so it does not imply it is only useful for packaging. Paulo Neves On 6/15/22 13:08, Ross Burton wrote: Never mind, can’t read :) On 15 Jun 2022, at 12:07, Ross Burton wrote: +if not skip_shebang_size: +errors

Re: [OE-core] [PATCH v4 6/7] utils: Add cmdline_shebang_wrapper util.

2022-06-14 Thread Paulo Neves
Thanks for the great tips. Yeah the habit of using the FILESPATH is that mostly I work on bbappends. Today i learned. I sent a new v5 with the corrections you mention. Paulo Neves On 6/14/22 16:17, Martin Jansa wrote: You can use bitbake-getvar to see the default FILESPATH, but "files&q

[OE-core] [PATCH v5 6/7] utils: Add cmdline_shebang_wrapper util.

2022-06-14 Thread Paulo Neves
/lib/oeqa/selftest/cases/wrapper.py @@ -0,0 +1,11 @@ +from oeqa.selftest.case import OESelftestTestCase +from oeqa.utils.commands import bitbake + +class WrapperTests(OESelftestTestCase): +def test_shebang_wrapper(self): +""" +Summary: Build a recipe which will fail if the cmd

[OE-core] [PATCH v5 7/7] libcheck: Fix too long shebang for native case.

2022-06-14 Thread Paulo Neves
It requires a shebang wrapper due to the fact that awk interpreter has an argument. --- meta/recipes-support/libcheck/libcheck_0.15.2.bb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta/recipes-support/libcheck/libcheck_0.15.2.bb b/meta/recipes-support/libcheck/libcheck_0.15.2.bb

[OE-core] [PATCH v5 5/7] oeqa/selftest: Test staged .la and .pc files

2022-06-14 Thread Paulo Neves
These files are checked by qa_check_staged but there was no test cases for whether the tests actually worked. Now there are. Signed-off-by: Paulo Neves --- .../sysroot-test/sysroot-la-test_1.0.bb | 16 ++ .../sysroot-test/sysroot-pc-test_1.0.bb | 12 +++ meta/lib/oeqa

[OE-core] [PATCH v5 4/7] oeqa/selftest: Add test for shebang overflow

2022-06-14 Thread Paulo Neves
Make sure we do not stage any executable with a bigger shebang than 128. Fixes [1] [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=11053 Signed-off-by: Paulo Neves --- .../sysroot-test/sysroot-shebang-test_1.0.bb | 12 meta/lib/oeqa/selftest/cases/sysroot.py

[OE-core] [PATCH v5 1/7] python: Avoid shebang overflow on python-config.py

2022-06-14 Thread Paulo Neves
The native path may be too big, leading to shebang overflow. Just use the #!/usr/bin/env python3. Signed-off-by: Paulo Neves --- ...shebang-overflow-on-python-config.py.patch | 33 +++ .../recipes-devtools/python/python3_3.10.4.bb | 1 + 2 files changed, 34 insertions

[OE-core] [PATCH v5 3/7] insane.bbclass: Make do_qa_staging check shebangs

2022-06-14 Thread Paulo Neves
://bugzilla.yoctoproject.org/show_bug.cgi?id=11053 Signed-off-by: Paulo Neves --- meta/classes/insane.bbclass | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 9ca84bace9..b2951a48fe 100644 --- a/meta/classes

[OE-core] [PATCH v5 2/7] gtk-doc: Fix potential shebang overflow on gtkdoc-mkhtml2

2022-06-14 Thread Paulo Neves
A native path can cause a shebang overflow on gtkdoc-mkhtml. Replace it with /usr/bin/env. Signed-off-by: Paulo Neves --- meta/recipes-gnome/gtk-doc/gtk-doc_1.33.2.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/recipes-gnome/gtk-doc/gtk-doc_1.33.2.bb b/meta/recipes-gnome/gtk-doc

Re: [OE-core] [PATCH v4 6/7] utils: Add cmdline_shebang_wrapper util.

2022-06-14 Thread Paulo Neves
than i need to add a license file, which seems a bit overkill for a one line. Am I wrong? What license should it even be? Dont Panic is a common string used in awk docs. Paulo Neves On 6/14/22 15:39, Martin Jansa wrote: FILESEXTRAPATHS:prepend doesn't seem to be needed and LICENSE is really

[OE-core] [PATCH v4 7/7] libcheck: Fix too long shebang for native case.

2022-06-14 Thread Paulo Neves
It requires a shebang wrapper due to the fact that awk interpreter has an argument. --- meta/recipes-support/libcheck/libcheck_0.15.2.bb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta/recipes-support/libcheck/libcheck_0.15.2.bb b/meta/recipes-support/libcheck/libcheck_0.15.2.bb

[OE-core] [PATCH v4 5/7] oeqa/selftest: Test staged .la and .pc files

2022-06-14 Thread Paulo Neves
These files are checked by qa_check_staged but there was no test cases for whether the tests actually worked. Now there are. Signed-off-by: Paulo Neves --- .../sysroot-test/sysroot-la-test_1.0.bb | 16 ++ .../sysroot-test/sysroot-pc-test_1.0.bb | 12 +++ meta/lib/oeqa

[OE-core] [PATCH v4 6/7] utils: Add cmdline_shebang_wrapper util.

2022-06-14 Thread Paulo Neves
oeqa.selftest.case import OESelftestTestCase +from oeqa.utils.commands import bitbake + +class WrapperTests(OESelftestTestCase): +def test_shebang_wrapper(self): +""" +Summary: Build a recipe which will fail if the cmdline_shebang_wrapp

[OE-core] [PATCH v4 4/7] oeqa/selftest: Add test for shebang overflow

2022-06-14 Thread Paulo Neves
Make sure we do not stage any executable with a bigger shebang than 128. Fixes [1] [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=11053 Signed-off-by: Paulo Neves --- .../sysroot-test/sysroot-shebang-test_1.0.bb | 12 meta/lib/oeqa/selftest/cases/sysroot.py

[OE-core] [PATCH v4 3/7] insane.bbclass: Make do_qa_staging check shebangs

2022-06-14 Thread Paulo Neves
://bugzilla.yoctoproject.org/show_bug.cgi?id=11053 Signed-off-by: Paulo Neves --- meta/classes/insane.bbclass | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 9ca84bace9..b2951a48fe 100644 --- a/meta/classes

[OE-core] [PATCH v4 1/7] python: Avoid shebang overflow on python-config.py

2022-06-14 Thread Paulo Neves
The native path may be too big, leading to shebang overflow. Just use the #!/usr/bin/env python3. Signed-off-by: Paulo Neves --- ...shebang-overflow-on-python-config.py.patch | 33 +++ .../recipes-devtools/python/python3_3.10.4.bb | 1 + 2 files changed, 34 insertions

[OE-core] [PATCH v4 2/7] gtk-doc: Fix potential shebang overflow on gtkdoc-mkhtml2

2022-06-14 Thread Paulo Neves
A native path can cause a shebang overflow on gtkdoc-mkhtml. Replace it with /usr/bin/env. Signed-off-by: Paulo Neves --- meta/recipes-gnome/gtk-doc/gtk-doc_1.33.2.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/recipes-gnome/gtk-doc/gtk-doc_1.33.2.bb b/meta/recipes-gnome/gtk-doc

Re: [OE-core] [PATCH v2 4/5] oeqa/selftest: Add test for shebang overflow

2022-06-13 Thread Paulo Neves
Hey Luca, I sent a new patchset and from my tests it all should be good now. Paulo Neves On 6/8/22 17:06, Luca Ceresoli wrote: Hi Paulo, On Wed, 8 Jun 2022 14:53:05 +0200 "Luca Ceresoli via lists.openembedded.org" wrote: Hi Paulo, On Tue, 7 Jun 2022 17:11:22 +0200 "Paul

Re: [OE-core] [PATCH v3 1/7] python: Avoid shebang overflow on python-config.py

2022-06-13 Thread Paulo Neves
As requested https://github.com/python/cpython/pull/93760 Paulo Neves On 6/13/22 09:30, Alexander Kanavin wrote: As requested, please submit upstream. Alex On Fri, 10 Jun 2022 at 23:43, Paulo Neves wrote: The native path may be too big, leading to shebang overflow. Just use the #!/usr/bin

[OE-core] [PATCH v3 7/7] libcheck: Fix too long shebang for native case.

2022-06-10 Thread Paulo Neves
It requires a shebang wrapper due to the fact that awk interpreter has an argument. --- meta/recipes-support/libcheck/libcheck_0.15.2.bb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/meta/recipes-support/libcheck/libcheck_0.15.2.bb b/meta/recipes-support/libcheck/libcheck_0.15.2.bb

[OE-core] [PATCH v3 6/7] utils: Add cmdline_shebang_wrapper util.

2022-06-10 Thread Paulo Neves
oeqa.selftest.case import OESelftestTestCase +from oeqa.utils.commands import bitbake + +class WrapperTests(OESelftestTestCase): +def test_shebang_wrapper(self): +""" +Summary: Build a recipe which will fail if the cmdline_shebang_wrapp

[OE-core] [PATCH v3 5/7] oeqa/selftest: Test staged .la and .pc files

2022-06-10 Thread Paulo Neves
These files are checked by qa_check_staged but there was no test cases for whether the tests actually worked. Now there are. Signed-off-by: Paulo Neves --- .../sysroot-test/sysroot-la-test_1.0.bb | 16 ++ .../sysroot-test/sysroot-pc-test_1.0.bb | 12 +++ meta/lib/oeqa

[OE-core] [PATCH v3 4/7] oeqa/selftest: Add test for shebang overflow

2022-06-10 Thread Paulo Neves
Make sure we do not stage any executable with a bigger shebang than 128. Fixes [1] [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=11053 Signed-off-by: Paulo Neves --- .../sysroot-test/sysroot-shebang-test_1.0.bb | 12 meta/lib/oeqa/selftest/cases/sysroot.py

[OE-core] [PATCH v3 3/7] insane.bbclass: Make do_qa_staging check shebangs

2022-06-10 Thread Paulo Neves
://bugzilla.yoctoproject.org/show_bug.cgi?id=11053 Signed-off-by: Paulo Neves --- meta/classes/insane.bbclass | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 9ca84bace9..b2951a48fe 100644 --- a/meta/classes

[OE-core] [PATCH v3 1/7] python: Avoid shebang overflow on python-config.py

2022-06-10 Thread Paulo Neves
The native path may be too big, leading to shebang overflow. Just use the #!/usr/bin/env python3. Signed-off-by: Paulo Neves --- ...shebang-overflow-on-python-config.py.patch | 29 +++ .../recipes-devtools/python/python3_3.10.4.bb | 1 + 2 files changed, 30 insertions

[OE-core] [PATCH v3 2/7] gtk-doc: Fix potential shebang overflow on gtkdoc-mkhtml2

2022-06-10 Thread Paulo Neves
A native path can cause a shebang overflow on gtkdoc-mkhtml. Replace it with /usr/bin/env. Signed-off-by: Paulo Neves --- meta/recipes-gnome/gtk-doc/gtk-doc_1.33.2.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/recipes-gnome/gtk-doc/gtk-doc_1.33.2.bb b/meta/recipes-gnome/gtk-doc

Re: [OE-core] [PATCH] e2fsprogs: add alternatives handling of lsattr as well

2022-06-08 Thread Paulo Neves
Looks good to me. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#166756): https://lists.openembedded.org/g/openembedded-core/message/166756 Mute This Topic: https://lists.openembedded.org/mt/91622646/21656 Group Owner:

Re: [OE-core] [PATCH v2 4/5] oeqa/selftest: Add test for shebang overflow

2022-06-08 Thread Paulo Neves
On 6/8/22 14:53, Luca Ceresoli wrote: Hi Paulo, On Tue, 7 Jun 2022 17:11:22 +0200 "Paulo Neves" wrote: Make sure we do not stage any executable with a bigger shebang than 128. Fixes [1] [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=11053 Signed-off-by: Paulo Neves

Re: [OE-core] [PATCH] vim: put xxd in its own package

2022-06-08 Thread Paulo Neves
Looks good to me then ;) Had a look at the code [1] and indeed it is a very minimal standalone binary. Grateful for your patience Paulo Neves [1] https://github.com/vim/vim/blob/master/src/xxd/xxd.c On 6/8/22 14:36, Rasmus Villemoes wrote: On 08/06/2022 14.30, Paulo Neves wrote: On 6/8/22

Re: [OE-core] [PATCH] vim: put xxd in its own package

2022-06-08 Thread Paulo Neves
On 6/8/22 14:13, Rasmus Villemoes wrote: On 08/06/2022 13.58, Paulo Neves via lists.openembedded.org wrote: Forgive me if it is a stupid question, but does xxd not rdepend on ncurses-terminfo-base as well? No, it does not, it's a trivial standalone utility whose only dynamic dependency

Re: [OE-core] [PATCH] vim: put xxd in its own package

2022-06-08 Thread Paulo Neves
Forgive me if it is a stupid question, but does xxd not rdepend on ncurses-terminfo-base as well? I ask because before your patch it could was implied it that it did, s part of PN. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#166701):

Re: [OE-core] [PATCH v2 1/5] python: Avoid shebang overflow on python-config.py

2022-06-07 Thread Paulo Neves
I think this patch will never be accepted because it hard-codes and depends on env. I recall that red hat for example does not accept the use of env, possibly for security reasons. Paulo Neves On Tue, Jun 7, 2022, 18:53 Alexander Kanavin wrote: > I'm not sure this is Inappropriate. Can

[OE-core] [PATCH v2 5/5] oeqa/selftest: Test staged .la and .pc files

2022-06-07 Thread Paulo Neves
These files are checked by qa_check_staged but there was no test cases for whether the tests actually worked. Now there are. Signed-off-by: Paulo Neves --- .../sysroot-test/sysroot-la-test_1.0.bb | 16 ++ .../sysroot-test/sysroot-pc-test_1.0.bb | 12 +++ meta/lib/oeqa

[OE-core] [PATCH v2 3/5] insane.bbclass: Make do_qa_staging check shebangs

2022-06-07 Thread Paulo Neves
://bugzilla.yoctoproject.org/show_bug.cgi?id=11053 Signed-off-by: Paulo Neves --- meta/classes/insane.bbclass | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 9ca84bace9..b2951a48fe 100644 --- a/meta/classes

[OE-core] [PATCH v2 4/5] oeqa/selftest: Add test for shebang overflow

2022-06-07 Thread Paulo Neves
Make sure we do not stage any executable with a bigger shebang than 128. Fixes [1] [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=11053 Signed-off-by: Paulo Neves --- .../sysroot-test/sysroot-shebang-test_1.0.bb | 12 meta/lib/oeqa/selftest/cases/sysroot.py

[OE-core] [PATCH v2 1/5] python: Avoid shebang overflow on python-config.py

2022-06-07 Thread Paulo Neves
The native path may be too big, leading to shebang overflow. Just use the #!/usr/bin/env python3. Signed-off-by: Paulo Neves --- ...shebang-overflow-on-python-config.py.patch | 29 +++ .../recipes-devtools/python/python3_3.10.4.bb | 1 + 2 files changed, 30 insertions

[OE-core] [PATCH v2 2/5] gtk-doc: Fix potential shebang overflow on gtkdoc-mkhtml2

2022-06-07 Thread Paulo Neves
A native path can cause a shebang overflow on gtkdoc-mkhtml. Replace it with /usr/bin/env. Signed-off-by: Paulo Neves --- meta/recipes-gnome/gtk-doc/gtk-doc_1.33.2.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/recipes-gnome/gtk-doc/gtk-doc_1.33.2.bb b/meta/recipes-gnome/gtk-doc

[OE-core] [PATCH 1/3] insane.bbclass: Make do_qa_staging check shebangs

2022-06-06 Thread Paulo Neves
As reported in the bug report [1], there was no check for shebang sizes on native scripts and now this is fixed. The path scope of qa_staging needed to be increased from just checking libdir to all the relevant SYSROOT_DIRS. It is possible to skip this check through INSANE_SKIP. [1]

[OE-core] [PATCH 3/3] oeqa/selftest: Test staged .la and .pc files

2022-06-06 Thread Paulo Neves
self.assertTrue(expected in res.output, msg=res.output) + +def test_sysroot_la(self): +""" +Summary: Check that workdir paths are not contained in .la files. +Expected: Fail when a workdir path is found in the file content. +Author:

[OE-core] [PATCH 2/3] oeqa/selftest: Add test for shebang overflow

2022-06-06 Thread Paulo Neves
s. To confirm [YOCTO #11053] is closed. + Expected: Fail when a shebang bigger than the max shebang-size is reached. +Author:Paulo Neves +""" +expected = "maximum shebang size exceeded, the maximum size is 128. [shebang-size]" +

Re: [OE-core] [PATCH] wget: update to 1.20.3

2019-05-08 Thread Paulo Neves
This patch is useful to go around CVE-2019-5953 but other versions of poky, like the thud do not have the correction. Should this version bump be backported or the patch http://git.savannah.gnu.org/cgit/wget.git/commit/?id=692d5c5215de0db482c252492a92fc424cc6a97c be applied in older versions? On

Re: [OE-core] [PATCH 1/2] util-linux: disable systemd

2019-01-04 Thread Paulo Neves
Hello all, I have the need to enable this services from system. What is the current status of this circular dependency? There was talk of coming back to this topic after the milesone but 4 years passed and there was no changes to this topic? Is it still applicable? Paulo Neves

Re: [OE-core] [meta-oe][PATCH v2 4/4] testimage: Moved write_image_test_data to testimage bbclass.

2018-10-02 Thread Paulo Neves
this topic merged but I do not see a clear guidance for me to fix what was clearly broken. Actually the current code put there by intel should should be reverted in my opinion, as it broke all the controllers besides simpleremote and qemu. Paulo Neves On Tue, Sep 4, 2018 at 12:30 PM Richard Purdie

[OE-core] [meta-oe][PATCH v2 4/4] testimage: Moved write_image_test_data to testimage bbclass.

2018-08-30 Thread Paulo Neves
the tests can be ran independently again. Signed-off-by: Paulo Neves --- meta/classes/rootfs-postcommands.bbclass | 22 -- meta/classes/testimage.bbclass | 19 ++- 2 files changed, 18 insertions(+), 23 deletions(-) diff --git a/meta/classes/rootfs

[OE-core] [meta-oe][PATCH v2 3/4] masterimage: Check for rootfs path instead of file.

2018-08-30 Thread Paulo Neves
The rootfs might be a directory path or a file path. A case in point is if the test wants to deploy a rootfs directly by rsyncing it to the target or even use it as part of a tftp server. Signed-off-by: Paulo Neves --- meta/lib/oeqa/controllers/masterimage.py | 6 +- 1 file changed, 1

[OE-core] [meta-oe][PATCH v2 2/4] testimage: target.start exceptions not masked.

2018-08-30 Thread Paulo Neves
Previously the target.start exceptions were being masked by the catch clause of RuntimeError and BlockingIOError which are very broad. We decoupled the start method try clause from the runTests try clause which requires catching the BlockingIOError and RuntimeError. Signed-off-by: Paulo Neves

[OE-core] [meta-oe][PATCH v2 1/4] testimage: Refactoring and fixing.

2018-08-30 Thread Paulo Neves
to the manual were successfully tested. Signed-off-by: Paulo Neves --- meta/classes/testimage.bbclass | 18 +--- meta/lib/oeqa/controllers/masterimage.py | 107 ++--- .../target/qemu.py => controllers/qemutarget.py} | 30 -- meta/lib/o

Re: [OE-core] [meta-oe][PATCH 1/3] testimage: Refactoring and fixing.

2018-08-18 Thread Paulo Neves
Ping. Does anybody have any comments? Also I noticed that my commit once was in the master-next but it was removed. Without it being in master I cannot submit my changes to poky mailing list with the fixes for the remaining targets. Paulo Neves On Sun, Aug 12, 2018 at 9:49 PM Paulo Neves wrote

Re: [OE-core] [meta-oe][PATCH 1/3] testimage: Refactoring and fixing.

2018-08-12 Thread Paulo Neves
ses/rootfs-postcommands.bbclass. Can anybody tell me if changing a variable in the datastore and accessing it in the postprocess_command will never trigger the postprocess_command? It happens that in this case this variable is not important for the rootfs task itself but only for the post-process. P

[OE-core] [meta-oe][PATCH 2/3] testimage: target.start exceptions not masked.

2018-08-10 Thread Paulo Neves
Previously the target.start exceptions were being masked by the catch clause of RuntimeError and BlockingIOError which are very broad. We decoupled the start method try clause from the runTests try clause which requires catching the BlockingIOError and RuntimeError. Signed-off-by: Paulo Neves

[OE-core] [meta-oe][PATCH 1/3] testimage: Refactoring and fixing.

2018-08-10 Thread Paulo Neves
to the manual were successfully tested. Signed-off-by: Paulo Neves --- meta/classes/testimage.bbclass | 18 +--- meta/lib/oeqa/controllers/masterimage.py | 107 ++--- .../target/qemu.py => controllers/qemutarget.py} | 30 -- meta/lib/o

[OE-core] [meta-oe][PATCH 3/3] masterimage: Check for rootfs path instead of file.

2018-08-10 Thread Paulo Neves
The rootfs might be a directory path or a file path. A case in point is if the test wants to deploy a rootfs directly by rsyncing it to the target or even use it as part of a tftp server. Signed-off-by: Paulo Neves --- meta/lib/oeqa/controllers/masterimage.py | 6 +- 1 file changed, 1

Re: [OE-core] [PATCH] classes/reproducible_build: Avoid dereferencing symlinks

2018-08-08 Thread Paulo Neves
minor nitpick. Your patch changed the whitespace indentation ;) On Mon, Aug 6, 2018 at 5:25 PM, Joshua Watt wrote: > Using os.path.getmtime() will dereference symbolic links in an attempt > to get the last modified time. This can cause errors if the target > doesn't exist, or worse map to some

Re: [OE-core] ✗ patchtest: failure for "[meta-oe,v2] context.py: Do no..." and 3 more

2018-08-06 Thread Paulo Neves
Can anybody help me sort out this changeset? As this was my second attempt at submitting my changes with errors on not using the correct mailing list I checked the patchtest-oe and I saw that I would need to split my series into 3 mailing lists [oe-core, doc, poky]. The splitting would need the

[OE-core] [meta-oe][PATCH v2 4/4] masterimage: Check for rootfs path instead of file.

2018-08-06 Thread Paulo Neves
The rootfs might be a directory path or a file path. A case in point is if the test wants to deploy a rootfs directly by rsyncing it to the target or even use it as part of a tftp server. Signed-off-by: Paulo Neves --- meta/lib/oeqa/controllers/masterimage.py | 6 +- 1 file changed, 1

[OE-core] [meta-oe][PATCH v2 2/4] testimage: Refactoring and fixing.

2018-08-06 Thread Paulo Neves
successfully tested. Signed-off-by: Paulo Neves --- .../lib/oeqa/controllers/beaglebonetarget.py | 6 +- .../lib/oeqa/controllers/edgeroutertarget.py | 6 +- meta-yocto-bsp/lib/oeqa/controllers/grubtarget.py | 4 +- meta/classes/testimage.bbclass | 18 +--- meta/lib

[OE-core] [meta-oe][PATCH v2 1/4] context.py: Do not mask exceptions needlessly.

2018-08-06 Thread Paulo Neves
the controller would just be skipped and the task would just complain it could not find the controller. Now for example, if there is a NamerError due to a variable not being declared, the user will get that report. Signed-off-by: Paulo Neves --- meta/lib/oeqa/runtime/context.py | 14 -- 1

[OE-core] [meta-oe][PATCH v2 3/4] testimage: target.start exceptions not masked.

2018-08-06 Thread Paulo Neves
Previously the target.start exceptions were being masked by the catch clause of RuntimeError and BlockingIOError which are very broad. We decoupled the start method try clause from the runTests try clause which requires catching the BlockingIOError and RuntimeError. Signed-off-by: Paulo Neves

[OE-core] [PATCH 3/4] testimage: target.start exceptions not masked.

2018-08-05 Thread Paulo Neves
Previously the target.start exceptions were being masked by the catch clause of RuntimeError and BlockingIOError which are very broad. We decoupled the start method try clause from the runTests try clause which requires catching the BlockingIOError and RuntimeError. Signed-off-by: Paulo Neves

[OE-core] [PATCH 4/4] masterimage: Check for rootfs path instead of file.

2018-08-05 Thread Paulo Neves
The rootfs might be a directory path or a file path. A case in point is if the test wants to deploy a rootfs directly by rsyncing it to the target or even use it as part of a tftp server. Signed-off-by: Paulo Neves --- meta/lib/oeqa/controllers/masterimage.py | 6 +- 1 file changed, 1

[OE-core] [PATCH 2/4] testimage: Refactoring and fixing.

2018-08-05 Thread Paulo Neves
. The SimpleRemoteTarget, OEQemuTarget and a custom controller, developed according to the manual were successfully tested. Signed-off-by: Paulo Neves --- .../dev-manual/dev-manual-common-tasks.xml | 8 +- documentation/ref-manual/ref-variables.xml | 19 +--- .../lib/oeqa/controllers

[OE-core] [PATCH 1/4] context.py: Do not mask exceptions needlessly.

2018-08-05 Thread Paulo Neves
the controller would just be skipped and the task would just complain it could not find the controller. Now for example, if there is a NamerError due to a variable not being declared, the user will get that report. Signed-off-by: Paulo Neves --- meta/lib/oeqa/runtime/context.py | 14 -- 1

Re: [OE-core] u-boot crash on network code hardkernel v2017.05

2018-07-23 Thread Paulo Neves
is raises an issue: Is there not a better way to depend on a version of GCC for a specific recipe? Solving issues like these can be way beyond most people's abilities (at least my own), and having a mechanism in yocto to choose another gcc version might be desirable. Paulo Neves [1] https://list

Re: [OE-core] u-boot crash on network code hardkernel v2017.05

2018-07-21 Thread Paulo Neves
Replying to myself in the hope that it further helps: I narrowed down the bug to a gcc 7 problem. Using the prebuilt gcc from linaro, i am able to use networking functionalities in gccv6 but not gccv7. gcc7 is the default gcc version of poky/sumo. Paulo Neves On Sat, Jul 21, 2018 at 12:08 PM

[OE-core] u-boot crash on network code hardkernel v2017.05

2018-07-21 Thread Paulo Neves
192.168.3.123; our IP address is 192.168.3.71 Filename 'zImage'. Load address: 0x40008000 Loading: * Let me know if you have any suggestions. Paulo Neves -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org

  1   2   >