[OE-core] [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

2015-08-26 Thread Patrick Ohly
The unconditional removal of -DWITHOUT_XATTR accidentally introduced a compile-time dependency on "acl", because "sys/acl.h" gets included. This caused random compile failures. To fix this, we introduce a proper PACKAGECONFIG for the "xattr" support, with the distro's "xattr" feature determining t

Re: [OE-core] [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

2015-08-26 Thread Mark Hatle
While I haven't tried this, it is exactly what I would have expected. Acked-by: Mark Hatle On 8/26/15 11:10 AM, Patrick Ohly wrote: > The unconditional removal of -DWITHOUT_XATTR accidentally introduced a > compile-time dependency on "acl", because "sys/acl.h" gets > included. This caused random

Re: [OE-core] [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

2015-08-26 Thread Andre McCurdy
On Wed, Aug 26, 2015 at 9:10 AM, Patrick Ohly wrote: > The unconditional removal of -DWITHOUT_XATTR accidentally introduced a > compile-time dependency on "acl", because "sys/acl.h" gets > included. This caused random compile failures. > > To fix this, we introduce a proper PACKAGECONFIG for the "

Re: [OE-core] [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

2015-08-26 Thread Khem Raj
On Aug 26, 2015 9:11 AM, "Patrick Ohly" wrote: > > The unconditional removal of -DWITHOUT_XATTR accidentally introduced a > compile-time dependency on "acl", because "sys/acl.h" gets > included. This caused random compile failures. > > To fix this, we introduce a proper PACKAGECONFIG for the "xatt

Re: [OE-core] [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

2015-08-26 Thread Patrick Ohly
On Wed, 2015-08-26 at 12:16 -0700, Khem Raj wrote: > > On Aug 26, 2015 9:11 AM, "Patrick Ohly" > wrote: > > +EXTRA_OEMAKE = "'CC=${CC}' 'RANLIB=${RANLIB}' 'AR=${AR}' 'CFLAGS=${CFLAGS} > > ${@bb.utils.contains('PACKAGECONFIG', 'xattr', '', '-DWITHOUT_XATTR', d)} > > -I${S}/include' 'BUILDDIR=${S

Re: [OE-core] [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

2015-08-26 Thread Patrick Ohly
On Wed, 2015-08-26 at 12:02 -0700, Andre McCurdy wrote: > On Wed, Aug 26, 2015 at 9:10 AM, Patrick Ohly wrote: > > The unconditional removal of -DWITHOUT_XATTR accidentally introduced a > > compile-time dependency on "acl", because "sys/acl.h" gets > > included. This caused random compile failures

Re: [OE-core] [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

2015-08-27 Thread Khem Raj
On Wed, Aug 26, 2015 at 11:43 PM, Patrick Ohly wrote: > The one in bb.utils.contains()? That is there intentionally: it's for > the "xattr enabled" case, in which case nothing gets added to > EXTRA_OEMAKE. is it required to have extra " ? can it work without it -- ___

Re: [OE-core] [PATCH 1/1] mtd-utils: add xattr PACKAGECONFIG and fix acl dependency

2015-08-27 Thread Patrick Ohly
On Thu, 2015-08-27 at 06:32 -0700, Khem Raj wrote: > On Wed, Aug 26, 2015 at 11:43 PM, Patrick Ohly wrote: > > The one in bb.utils.contains()? That is there intentionally: it's for > > the "xattr enabled" case, in which case nothing gets added to > > EXTRA_OEMAKE. > > is it required to have extra