Re: [OE-core] [PATCH v2 07/11] kea: Remove -fvisibility-inlines-hidden from C++ flags

2024-05-14 Thread Alexander Kanavin
Can you also try webkitgtk please? It's directly in core, no extra layer or special setup needed. Alex On Tue, 14 May 2024 at 17:43, Khem Raj wrote: > > On Tue, May 14, 2024 at 8:25 AM Randy MacLeod > wrote: > > > > On 2024-05-07 3:56 p.m., Alexander Kanavin via lists.openembedded.org wrote:

Re: [OE-core] [PATCH v2 07/11] kea: Remove -fvisibility-inlines-hidden from C++ flags

2024-05-14 Thread Khem Raj
On Tue, May 14, 2024 at 8:25 AM Randy MacLeod wrote: > > On 2024-05-07 3:56 p.m., Alexander Kanavin via lists.openembedded.org wrote: > > On Tue, 7 May 2024 at 18:13, Khem Raj wrote: > > Firstly I am inclined towards removing it if we can, since I think it should > be > packages to decide to

Re: [OE-core] [PATCH v2 07/11] kea: Remove -fvisibility-inlines-hidden from C++ flags

2024-05-14 Thread Randy MacLeod via lists.openembedded.org
On 2024-05-07 3:56 p.m., Alexander Kanavin via lists.openembedded.org wrote: On Tue, 7 May 2024 at 18:13, Khem Raj wrote: Firstly I am inclined towards removing it if we can, since I think it should be packages to decide to use it, then they can maintain it better from testing POV, However,

Re: [OE-core] [PATCH v2 07/11] kea: Remove -fvisibility-inlines-hidden from C++ flags

2024-05-07 Thread Khem Raj
On Tue, May 7, 2024 at 12:56 PM Alexander Kanavin wrote: > > On Tue, 7 May 2024 at 18:13, Khem Raj wrote: > > Firstly I am inclined towards removing it if we can, since I think it > > should be > > packages to decide to use it, then they can maintain it better from testing > > POV, > >

Re: [OE-core] [PATCH v2 07/11] kea: Remove -fvisibility-inlines-hidden from C++ flags

2024-05-07 Thread Alexander Kanavin
On Tue, 7 May 2024 at 18:13, Khem Raj wrote: > Firstly I am inclined towards removing it if we can, since I think it should > be > packages to decide to use it, then they can maintain it better from testing > POV, > However, there is something > to consider w.r.t. to this option. This does help

Re: [OE-core] [PATCH v2 07/11] kea: Remove -fvisibility-inlines-hidden from C++ flags

2024-05-07 Thread Khem Raj
On Tue, May 7, 2024 at 3:15 AM Alexander Kanavin wrote: > > On Tue, 7 May 2024 at 07:33, Khem Raj via lists.openembedded.org > wrote: > > > +CXXFLAGS:remove = "-fvisibility-inlines-hidden" > > Same comment as v1: this seems like the wrong way around. Why do we > have it as a global glibc/musl

Re: [OE-core] [PATCH v2 07/11] kea: Remove -fvisibility-inlines-hidden from C++ flags

2024-05-07 Thread Alexander Kanavin
On Tue, 7 May 2024 at 07:33, Khem Raj via lists.openembedded.org wrote: > +CXXFLAGS:remove = "-fvisibility-inlines-hidden" Same comment as v1: this seems like the wrong way around. Why do we have it as a global glibc/musl setting in the first place? Shouldn't we just remove it from there? I did

[OE-core] [PATCH v2 07/11] kea: Remove -fvisibility-inlines-hidden from C++ flags

2024-05-06 Thread Khem Raj
This fixes build with gcc-14, where default visibility is extended to inline functions and getAll() function now falls into this category and functions are marked hidden resulting in linking errors Fixes