[OE-core] [wic][PATCH] directdisk*.wks: add serial console support

2016-09-20 Thread Ed Bartosh
Added serial console to kernel command line to to make it easier to boot wic images on devices without display. Tested on MinnowBoard MAX. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/lib/wic/canned-wks/directdisk-gpt.wks | 2 +- scripts/lib/wic/cann

[OE-core] [wic][PATCH v2] wic: remove partition images

2016-09-23 Thread Ed Bartosh
Preserving images for every partition doubles disk space consumed by an image build. As those images are not used, so it's better to remove them after assembling final image. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/lib/wic/utils/partitionedfs.py | 9 -

Re: [OE-core] [wic][PATCH] wic: add beaglebone.wks

2016-09-22 Thread Ed Bartosh
On Wed, Sep 21, 2016 at 06:34:33PM +0200, Maciej Borzęcki wrote: > On Wed, Sep 21, 2016 at 5:18 PM, Ed Bartosh <ed.bart...@linux.intel.com> > wrote: > > Added wks to make an image for Beaglebone board. > > > > Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.

Re: [OE-core] [wic][PATCH] wic: add beaglebone.wks

2016-09-22 Thread Ed Bartosh
Please, ignore this patch. It's not needed as fully functional image can be built using existing wks file sdimage-bootpart.wks On Wed, Sep 21, 2016 at 06:18:12PM +0300, Ed Bartosh wrote: > Added wks to make an image for Beaglebone board. > > Signed-off-by: Ed Bartosh <ed.bart...@lin

[OE-core] [wic][PATCH] wic: remove partition images

2016-09-22 Thread Ed Bartosh
Preserving images for every partition doubles disk space consumed by a build. As those images are not used it's better to remove them after assembling final image. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/lib/wic/utils/partitionedfs.py | 2 +- 1 file chan

[OE-core] [wic][PATCH] image_types: add parted-native to do_image_wic depends

2016-09-16 Thread Ed Bartosh
As parted is always used by wic it makes sense to make do_image_wic dependent on parted-native:do_populate_sysroot. This should help to avoid adding it to all wic image recipes. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta-selftest/recipes-test/images/wic-image-minimal.

[OE-core] [wic][PATCH] wic: selftest: add test for mksystemd-bootdisk

2016-09-29 Thread Ed Bartosh
Test creation of mksystemd-bootdisk image. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta/lib/oeqa/selftest/wic.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/lib/oeqa/selftest/wic.py index e550785..6012abc 100644 ---

[OE-core] [wic][PATCH] image_types.bbclass: remove redundant dependency

2016-09-27 Thread Ed Bartosh
Removed parted-native dependency from do_image_wic as it's already mentioned in IMAGE_DEPENDS_wic variable. Thanks to Christopher Larson for pointing out to this. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta/classes/image_types.bbclass | 1 - 1 file changed, 1 de

[OE-core] [PATCH] scripts: add new script

2016-09-28 Thread Ed Bartosh
Added 'native' convenience shell script to run native tools. Example of usage: > bitbake bmap-tools-native > native bmaptool --version Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/native | 48 1 file

[OE-core] [PATCH] runqemu: explicitly set image format

2016-09-28 Thread Ed Bartosh
will be restricted. Specify the 'raw' format explicitly to remove the restrictions. Set image format to 'vmdk', 'qcow2' or 'vdi' for correspondent image types. Set it to 'raw' for the rest of image types. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/runqem

[OE-core] [wic][PATCH] mkefidisk.wks: use partition UUID and GPT partition table

2016-09-30 Thread Ed Bartosh
in wks file. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/lib/wic/canned-wks/mkefidisk.wks | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/lib/wic/canned-wks/mkefidisk.wks b/scripts/lib/wic/canned-wks/mkefidisk.wks index 696e94e..73886ab

Re: [OE-core] [PATCH v2] scripts: add new script 'native'

2016-10-03 Thread Ed Bartosh
On Sun, Oct 02, 2016 at 04:30:58PM +0200, Ulf Magnusson wrote: > On Sun, Oct 2, 2016 at 4:15 PM, Jérémy Rosen wrote: > > "native" might be a bit too generic... > > > > could I suggest oe_native-run or bitbake-native ? > > > > something that says it's yocto-galaxy specific

[OE-core] [PATCH] wic: selftest: add test for sdimage-bootpart

2016-09-29 Thread Ed Bartosh
Test image creation using mksystemd-bootdisk.wks Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta/lib/oeqa/selftest/wic.py | 8 1 file changed, 8 insertions(+) diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/lib/oeqa/selftest/wic.py index 6012abc..b05300c

[OE-core] [PATCH v2] scripts: add new script 'native'

2016-09-30 Thread Ed Bartosh
Added 'native' convenience shell script to run native tools. Example of usage: > bitbake bmap-tools-native > native bmaptool --version Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/native | 48 1 file

[OE-core] [PATCH v2] uninative: rebuild uninative for gcc 4.8 and 4.9

2016-10-27 Thread Ed Bartosh
gcc is either 4.8 or 4.9 and it doesn't match gcc version used to build uninative. [YOCTO #10441] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta/classes/uninative.bbclass | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/meta/c

[OE-core] [PATCH] uninative: rebuild uninative for gcc 4.8 and 4.9

2016-10-26 Thread Ed Bartosh
gcc is either 4.8 or 4.9 and it doesn't match gcc version used to build uninative. [YOCTO #10441] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta/classes/uninative.bbclass | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/meta/c

Re: [OE-core] [PATCH] mkefidisk.sh: add deprecation warning to the output

2016-11-07 Thread Ed Bartosh
On Thu, Nov 03, 2016 at 02:42:39PM -0700, Khem Raj wrote: > > > On Oct 31, 2016, at 3:46 AM, Ed Bartosh <ed.bart...@linux.intel.com> wrote: > > > > mkefidisk.sh will soon be deprecated in favor of .wic images. > > > > Added deprecation warning to the scri

Re: [OE-core] [PATCH] mkefidisk.sh: add deprecation warning to the output

2016-11-07 Thread Ed Bartosh
On Thu, Nov 03, 2016 at 07:23:24PM -0700, Christopher Larson wrote: > On Thu, Nov 3, 2016 at 2:42 PM, Khem Raj <raj.k...@gmail.com> wrote: > > > > On Oct 31, 2016, at 3:46 AM, Ed Bartosh <ed.bart...@linux.intel.com> > > wrote: > > > > > > mk

Re: [OE-core] [PATCH 2/5] wic: use partition size when creating empty partition files

2016-11-09 Thread Ed Bartosh
On Tue, Nov 08, 2016 at 04:56:08PM +0100, Maciej Borzecki wrote: > It seems that prepare_empty_partition_ext() and > prepare_empty_partition_btrfs() got broken in commit > c8669749e37fe865c197c98d5671d9de176ff4dd, thus one could observe the > following backtrace: > > Backtrace: > File

Re: [OE-core] [PATCH 5/5] wic: add --fixed-size wks option

2016-11-09 Thread Ed Bartosh
On Tue, Nov 08, 2016 at 04:56:11PM +0100, Maciej Borzecki wrote: > Added new option --fixed-size to wks. The option can be used to indicate > the exact size of a partition. The option cannot be added together with > --size, in which case an error will be raised. Other options that > influence

Re: [OE-core] [PATCH 0/5] wic: bugfixes & --fixed-size support

2016-11-09 Thread Ed Bartosh
On Tue, Nov 08, 2016 at 04:56:06PM +0100, Maciej Borzecki wrote: > The patch series is a follow-up after a previous attempt of adding > --reserved-size option to wic[1]. > > The series introduces a number of fixes in patches 1 - 4. > > The last patch in the series introduces --fixed-size option

Re: [OE-core] [PATCH 3/5] wic: check that filesystem is specified for a rootfs partition

2016-11-09 Thread Ed Bartosh
On Tue, Nov 08, 2016 at 04:56:09PM +0100, Maciej Borzecki wrote: > Signed-off-by: Maciej Borzecki > --- > scripts/lib/wic/partition.py | 4 > 1 file changed, 4 insertions(+) > > diff --git a/scripts/lib/wic/partition.py b/scripts/lib/wic/partition.py > index >

Re: [OE-core] [PATCH] mkefidisk.sh: add deprecation warning to the output

2016-11-09 Thread Ed Bartosh
On Tue, Nov 08, 2016 at 01:05:23PM -0800, John Hawley wrote: > On 11/08/2016 12:44 PM, Randy Witt wrote: > We should also document, the wic steps in wiki pages e.g. > http://wiki.minnowboard.org/Yocto_Project > >>> It's already documented in README.hardware: > >>>

[OE-core] [PATCH v2] uninative: rebuild uninative for gcc 4.8 and 4.9

2016-11-08 Thread Ed Bartosh
gcc is either 4.8 or 4.9 and it doesn't match gcc version used to build uninative. [YOCTO #10441] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta/classes/uninative.bbclass | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/meta/c

Re: [OE-core] [PATCH] wic: add --reserved-size wks option

2016-10-18 Thread Ed Bartosh
On Tue, Oct 18, 2016 at 01:07:48PM +0200, Maciej Borzęcki wrote: > On Tue, Oct 18, 2016 at 12:17 PM, Ed Bartosh <ed.bart...@linux.intel.com> > wrote: > > On Tue, Oct 18, 2016 at 12:24:55PM +0200, Maciej Borzęcki wrote: > >> On Tue, Oct 18, 2016 at 11:27 AM, Ed Bartosh

Re: [OE-core] [PATCH] wic: add --reserved-size wks option

2016-10-18 Thread Ed Bartosh
On Tue, Oct 18, 2016 at 12:24:55PM +0200, Maciej Borzęcki wrote: > On Tue, Oct 18, 2016 at 11:27 AM, Ed Bartosh <ed.bart...@linux.intel.com> > wrote: > > On Tue, Oct 18, 2016 at 11:24:14AM +0200, Maciej Borzęcki wrote: > >> On Tue, Oct 18, 2016 at 10:38 AM, Ed Bartosh

Re: [OE-core] [PATCH] wic: add --reserved-size wks option

2016-10-18 Thread Ed Bartosh
On Mon, Oct 17, 2016 at 04:46:00PM +0200, Maciej Borzęcki wrote: > On Mon, Oct 17, 2016 at 3:22 PM, Ed Bartosh <ed.bart...@linux.intel.com> > wrote: > > Hi Maciej, > > > > There is already --size and --extra-space options. > > Can we get the same or similar res

Re: [OE-core] [PATCH] wic: add --reserved-size wks option

2016-10-18 Thread Ed Bartosh
On Tue, Oct 18, 2016 at 11:24:14AM +0200, Maciej Borzęcki wrote: > On Tue, Oct 18, 2016 at 10:38 AM, Ed Bartosh <ed.bart...@linux.intel.com> > wrote: > > On Tue, Oct 18, 2016 at 10:37:22AM +0200, Maciej Borzęcki wrote: > >> On Tue, Oct 18, 2016 at 9:31 AM, Ed Bartosh

Re: [OE-core] [PATCH] wic: add --reserved-size wks option

2016-10-18 Thread Ed Bartosh
On Tue, Oct 18, 2016 at 10:37:22AM +0200, Maciej Borzęcki wrote: > On Tue, Oct 18, 2016 at 9:31 AM, Ed Bartosh <ed.bart...@linux.intel.com> > wrote: > > On Mon, Oct 17, 2016 at 04:46:00PM +0200, Maciej Borzęcki wrote: > >> On Mon, Oct 17, 2016 at 3:22 PM, Ed Bartosh

Re: [OE-core] [PATCH] wic: add --reserved-size wks option

2016-10-18 Thread Ed Bartosh
On Tue, Oct 18, 2016 at 03:59:23PM +0200, Maciej Borzęcki wrote: > >> >> >> > What's the advantage of creating unusable gap over creating > >> >> >> > partition of > >> >> >> > the same size that can be used? > >> >> >> > >> >> >> Just convenience. > >> >> >> > >> >> > What's the convenience of

Re: [OE-core] [wic][PATCH] systemd-bootdisk.wks: use PARTUUID

2016-10-25 Thread Ed Bartosh
On Mon, Oct 24, 2016 at 10:34:40AM -0700, Saul Wold wrote: > On Mon, 2016-10-24 at 16:54 +0300, Ed Bartosh wrote: > > Root device name in systemd-bootdisk.wks is 'sda'. This can cause > > images, produced using this wks to refuse booting if real device > > name is not 'sd

[OE-core] [wic][PATCH] systemd-bootdisk.wks: use PARTUUID

2016-10-24 Thread Ed Bartosh
device /dev/sda2... This happens because real device name of MicroSD card on this device is mmcblk1. Used --use-uuid option for root partition. This should make wic to put partiion UUID instead of device name into kernel command line. [YOCTO #10485] Signed-off-by: Ed Bartosh <ed.b

Re: [OE-core] [PATCH v1] wic: Add --exclude-path option to rootfs source plugin.

2016-11-25 Thread Ed Bartosh
On Fri, Nov 25, 2016 at 01:07:34PM +0100, Kristian Amlie wrote: > On 25/11/16 11:33, Patrick Ohly wrote: > > On Fri, 2016-11-25 at 11:15 +0100, Kristian Amlie wrote: > >> +if os.stat(real_rootfs_dir).st_dev == > >> os.stat(cr_workdir).st_dev: > >> +# Optimization if

Re: [OE-core] [PATCH v1] wic: Add --exclude-path option to rootfs source plugin.

2016-11-25 Thread Ed Bartosh
On Fri, Nov 25, 2016 at 01:35:53PM +0100, Kristian Amlie wrote: > On 25/11/16 13:28, Maciej Borzęcki wrote: > > On Fri, Nov 25, 2016 at 11:15 AM, Kristian Amlie > >> +# Disallow '..', because doing so could be quite > >> disastrous > >> +# (we will delete the

Re: [OE-core] Contents of non-rootfs partitions

2016-11-23 Thread Ed Bartosh
On Tue, Nov 22, 2016 at 12:54:52PM +0100, Kristian Amlie wrote: > On 22/11/16 12:10, Patrick Ohly wrote: > >> ... > > > > All of these introduce some special mechanism. Let me propose something > > that might integrate better with the existing tooling: > > > > The "rootfs" directory gets

Re: [OE-core] [PATCH v4 5/7] wic: selftest: do not repeat core-image-minimal

2016-11-23 Thread Ed Bartosh
On Wed, Nov 23, 2016 at 12:39:26PM +0100, Maciej Borzęcki wrote: > On Wed, Nov 23, 2016 at 12:23 PM, Ed Bartosh <ed.bart...@linux.intel.com> > wrote: > > On Wed, Nov 23, 2016 at 08:46:31AM +0100, Maciej Borzecki wrote: > >> Replace repeated core-image-m

Re: [OE-core] Contents of non-rootfs partitions

2016-11-23 Thread Ed Bartosh
On Wed, Nov 23, 2016 at 02:08:28PM +0100, Kristian Amlie wrote: > On 23/11/16 13:08, Ed Bartosh wrote: > > On Tue, Nov 22, 2016 at 12:54:52PM +0100, Kristian Amlie wrote: > >> On 22/11/16 12:10, Patrick Ohly wrote: > >>>> ... > >>> > >>&

Re: [OE-core] Contents of non-rootfs partitions

2016-11-23 Thread Ed Bartosh
On Wed, Nov 23, 2016 at 02:08:28PM +0100, Kristian Amlie wrote: > On 23/11/16 13:08, Ed Bartosh wrote: > > On Tue, Nov 22, 2016 at 12:54:52PM +0100, Kristian Amlie wrote: > >> On 22/11/16 12:10, Patrick Ohly wrote: > >>>> ... > >>> > >>&

Re: [OE-core] [PATCH v4 7/7] wic: selftest: add tests for --fixed-size partition flags

2016-11-23 Thread Ed Bartosh
Hi Maciej, Thank you for the patchset! The changes and the tests look good to me. I have little suggestions, but most of them just a matter of taste, so feel free to ignore them. On Wed, Nov 23, 2016 at 08:46:33AM +0100, Maciej Borzecki wrote: > wic has a new flag for setting a fixed parition

Re: [OE-core] [PATCH v4 5/7] wic: selftest: do not repeat core-image-minimal

2016-11-23 Thread Ed Bartosh
On Wed, Nov 23, 2016 at 08:46:31AM +0100, Maciej Borzecki wrote: > Replace repeated core-image-minimal with Wic class field. > > Signed-off-by: Maciej Borzecki > --- > meta/lib/oeqa/selftest/wic.py | 111 > +++--- > 1 file

Re: [OE-core] Contents of non-rootfs partitions

2016-11-23 Thread Ed Bartosh
On Wed, Nov 23, 2016 at 02:51:20PM +0100, Maciej Borzęcki wrote: > On Wed, Nov 23, 2016 at 2:22 PM, Ed Bartosh <ed.bart...@linux.intel.com> > wrote: > > On Wed, Nov 23, 2016 at 02:08:28PM +0100, Kristian Amlie wrote: > >> On 23/11/16 13:08, Ed Bartosh wrote: > >

Re: [OE-core] Contents of non-rootfs partitions

2016-11-24 Thread Ed Bartosh
On Thu, Nov 24, 2016 at 08:38:46AM +0100, Kristian Amlie wrote: > On 24/11/16 07:15, Ulrich Ölmann wrote: > > Hi, > > > > On Wed, Nov 23, 2016 at 04:56:56PM +0100, Patrick Ohly wrote: > >> On Wed, 2016-11-23 at 15:22 +0200, Ed Bartosh wrote: > >>>

Re: [OE-core] [PATCH v1] wic: Add --exclude-path option to rootfs source plugin.

2016-11-28 Thread Ed Bartosh
On Mon, Nov 28, 2016 at 12:01:09PM +0100, Kristian Amlie wrote: > On 28/11/16 11:52, Ed Bartosh wrote: > > On Mon, Nov 28, 2016 at 08:15:26AM +0100, Kristian Amlie wrote: > >>> > >>> What's the reason of insisting that path must be absolute? > >>> May

[OE-core] [PATCH] buildhistory-diff: report directory renames

2016-11-28 Thread Ed Bartosh
The script detects directory renaming if two different directories with the same set of files are added and removed. [YOCTO #10691] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta/lib/oe/buildhistory_analysis.py | 34 +++--- 1 file chang

Re: [OE-core] Contents of non-rootfs partitions

2016-11-24 Thread Ed Bartosh
On Thu, Nov 24, 2016 at 03:43:18PM +0100, Kristian Amlie wrote: > On 24/11/16 14:23, Ed Bartosh wrote: > > On Thu, Nov 24, 2016 at 08:38:46AM +0100, Kristian Amlie wrote: > >> On 24/11/16 07:15, Ulrich Ölmann wrote: > >>> Hi, > >>> > >>> On Wed

[OE-core] [wic][PATCH] qemux86*.conf: set wic-related parameters

2016-11-24 Thread Ed Bartosh
] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta/conf/machine/qemux86-64.conf | 3 +++ meta/conf/machine/qemux86.conf| 3 +++ 2 files changed, 6 insertions(+) diff --git a/meta/conf/machine/qemux86-64.conf b/meta/conf/machine/qemux86-64.conf index f2b2aeb..7559724

Re: [OE-core] [PATCH v1] wic: Add --exclude-path option to rootfs source plugin.

2016-11-28 Thread Ed Bartosh
On Mon, Nov 28, 2016 at 08:15:26AM +0100, Kristian Amlie wrote: > > > > What's the reason of insisting that path must be absolute? > > May be it's just me, but I find it a bit scaring to use absolute path in > > .wks > > The patch is relative to the rootfs directory from my point of view. > > >

Re: [OE-core] [PATCH v1] wic: Add --exclude-path option to rootfs source plugin.

2016-11-28 Thread Ed Bartosh
On Mon, Nov 28, 2016 at 08:07:05AM +0100, Kristian Amlie wrote: > On 25/11/16 17:33, Ed Bartosh wrote: > > On Fri, Nov 25, 2016 at 01:35:53PM +0100, Kristian Amlie wrote: > >> On 25/11/16 13:28, Maciej Borzęcki wrote: > >>> On Fri, Nov 25, 20

[OE-core] [wic][PATCH] wic: call os.ftruncate instead of running truncate

2016-11-02 Thread Ed Bartosh
Replaced running of truncate utility with the standard library call os.ftruncate Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/lib/wic/imager/direct.py | 5 +++-- scripts/lib/wic/partition.py | 15 ++- 2 files changed, 13 insertions(+), 7 deletions(-)

Re: [OE-core] [PATCH] wic: Add dosfstools-native mtools-native to dependencies

2016-10-26 Thread Ed Bartosh
Hi Khem, On Tue, Oct 25, 2016 at 06:50:17PM -0700, Khem Raj wrote: > these tools are needed for building wic images for some > boards e.g. overo/gumstix NAK Usage of native tools depends on .wks content: modules, partition types, etc. Your change will cause unnecessary build activity for some

[OE-core] [PATCH] mkefidisk.sh: add deprecation warning to the output

2016-10-31 Thread Ed Bartosh
mkefidisk.sh will soon be deprecated in favor of .wic images. Added deprecation warning to the script to inform users that this script will soon be removed from the codebase. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/contrib/mkefidisk.sh | 5 + 1 file chan

[OE-core] [PATCH] image_types.bbclass: add dependency do_image_wic -> do_bootimg

2016-10-12 Thread Ed Bartosh
depend on do_bootimg. We only need to do it if do_bootimg present in task graph. Thank to Cristopher Larson for this fix. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta/classes/image_types.bbclass | 5 + 1 file changed, 5 insertions(+) diff --git a/meta/c

[OE-core] [wic][PATCH] canned-wks: use GPT partition table

2016-10-10 Thread Ed Bartosh
and attributes to define partition content type. - Each partition contains a 36 character human readable name. Used GPT partitioning in all EFI kickstart files. Tested result images on NUC, MinnowBoard MAX and MinnowBoard Turbot. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/l

[OE-core] [wic][PATCH] systemd-bootdisk.wks: update kernel command line

2016-10-10 Thread Ed Bartosh
Used ttyS0 console. Removed usage of ttyPCH0 (FRI2 leftover) Decreased bootloader timeout to 5 seconds Removed 'vmalloc=256MB snd-hda-intel.enable_msi=0' as it's not needed for any of reference BSPs. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/lib/wic/canned-wks/s

Re: [OE-core] [PATCH] wic: add --reserved-size wks option

2016-10-17 Thread Ed Bartosh
Hi Maciej, There is already --size and --extra-space options. Can we get the same or similar result by just using them? Do we really need new option for similar purpose? On Mon, Oct 17, 2016 at 03:06:18PM +0200, Maciej Borzecki wrote: > Added new option --reserved-size to wks. The option can be

[OE-core] [wic][PATCH] wic: rename command line option -p -> -s

2016-12-08 Thread Ed Bartosh
Short variant of wic command line option --skip-build-check is incorretly named -p. It's named -s in wic help and Yocto documentation. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/wic | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/wic b/s

[OE-core] [PATCH] oe-run-native: standardize usage output

2016-12-08 Thread Ed Bartosh
Made usage output of oe-run-native to look similar to the output of other oe scripts. [YOCTO #10751] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/oe-run-native | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/scripts/oe-run-native b/s

[OE-core] [PATCH] oe-trim-schemas: create usage output

2016-12-08 Thread Ed Bartosh
Created usage output for oe-trim-schemas script. [YOCTO #10751] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/oe-trim-schemas | 9 + 1 file changed, 9 insertions(+) diff --git a/scripts/oe-trim-schemas b/scripts/oe-trim-schemas index 66a1b8d..7c199ef

[OE-core] [PATCH] oe-setup-builddir: create usage output

2016-12-09 Thread Ed Bartosh
Created usage output for oe-setup-builddir script. [YOCTO #10751] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/oe-setup-builddir | 8 1 file changed, 8 insertions(+) diff --git a/scripts/oe-setup-builddir b/scripts/oe-setup-builddir index e53f73c..ef49551

[OE-core] [PATCH] oepydevshell-internal.py: standardize usage output

2016-12-09 Thread Ed Bartosh
Made usage output of oepydevshell-internal.py to look similar to the output of other oe scripts. [YOCTO #10751] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/oepydevshell-internal.py | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff

[OE-core] [PATCH] oe-find-native-sysroot: create usage output

2016-12-09 Thread Ed Bartosh
Created usage output for oe-find-native-sysroot script. [YOCTO #10751] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/oe-find-native-sysroot | 14 ++ 1 file changed, 14 insertions(+) diff --git a/scripts/oe-find-native-sysroot b/scripts/oe-find-native-s

[OE-core] [PATCH] oe-setup-rpmrepo: standardize usage output

2016-12-09 Thread Ed Bartosh
Made usage output of oe-setup-rpmrepo to look similar to the output of other oe scripts. [YOCTO #10751] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/oe-setup-rpmrepo | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/s

[OE-core] [PATCH] oe-git-proxy: create usage output

2016-12-09 Thread Ed Bartosh
Created usage output for oe-git-proxy script. [YOCTO #10751] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/oe-git-proxy | 21 + 1 file changed, 21 insertions(+) diff --git a/scripts/oe-git-proxy b/scripts/oe-git-proxy index 0078e95..7a43fe6

[OE-core] [PATCH v3] uninative: rebuild uninative for gcc 4.8 and 4.9

2016-12-13 Thread Ed Bartosh
gcc is either 4.8 or 4.9 and it doesn't match gcc version used to build uninative. [YOCTO #10441] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta/classes/populate_sdk_ext.bbclass | 5 +++-- meta/classes/uninative.bbclass| 2 +- meta/lib/oe/utils.py

Re: [OE-core] [PATCH] selftest/wic: extending test coverage for WIC script options

2016-12-14 Thread Ed Bartosh
On Tue, Dec 13, 2016 at 06:24:57PM -0600, Jair Gonzalez wrote: > Hi Ed, > > Thank you for your response and suggestions. Below are my comments. > > > > +@testcase(1557) > > > +def test_listed_images_help(self): > > > +"""Test wic listed images help""" > > > +output =

Re: [OE-core] [PATCH] wic: obey the rootfs size from the metadata

2016-12-16 Thread Ed Bartosh
Hi Christopher, Thank you for the patch! +1 On Thu, Dec 15, 2016 at 12:42:39PM -0700, Christopher Larson wrote: > From: Christopher Larson > > When no --size is specified for the rootfs in the .wks, we want to obey the > rootfs size from the metadata, otherwise the

Re: [OE-core] [PATCH v2 3/3] selftest/wic: Add tests for --exclude-dir option.

2016-12-16 Thread Ed Bartosh
On Wed, Dec 14, 2016 at 05:28:54PM +0100, Kristian Amlie wrote: > Based partially on an earlier patch by Maciej Borzecki. > > Signed-off-by: Kristian Amlie > --- > meta/lib/oeqa/selftest/wic.py | 106 > +- > 1 file changed, 105

Re: [OE-core] [PATCH] edgerouter.conf: enable generation of wic.bmap

2016-12-12 Thread Ed Bartosh
On Sat, Dec 10, 2016 at 11:40:38AM -0700, Christopher Larson wrote: > On Fri, Dec 9, 2016 at 10:46 AM, Ed Bartosh <ed.bart...@linux.intel.com> > wrote: > > > Enabled generation of block map(bmap) files for wic images > > built for edgerouter machine. This should s

[OE-core] [PATCH] populate_sdk_ext: get NATIVELSBSTRING variable

2016-12-13 Thread Ed Bartosh
Setting fixedlsbstring to 'universal' can break populate_sdk_ext task as NATIVELSBSTRING can be set to universal- in some cases. Getting NATIVELSBSTRING value using getVar should fix this. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta/classes/populate_sdk_ext.bbcla

Re: [OE-core] [PATCH v5 0/6] wic: bugfixes & --fixed-size support, tests, oe-selftest: minor fixes

2016-12-13 Thread Ed Bartosh
On Tue, Dec 13, 2016 at 09:07:30AM +0100, Maciej Borzęcki wrote: > On Thu, Nov 24, 2016 at 8:08 AM, Maciej Borzecki > wrote: > > v5 of a patch series previously posted here [1]. > > > > Changes since v4: > > > > * dropped `wic: selftest: do not repeat

Re: [OE-core] [PATCH] selftest/wic: extending test coverage for WIC script options

2016-12-13 Thread Ed Bartosh
Hi Jair, Thank you for the patch! My comments are below. On Tue, Dec 13, 2016 at 09:53:27AM -0600, Jair Gonzalez wrote: > The previous WIC script selftest didn't cover all of its command > line options. The following test cases were added to complete > covering them: > > 1552 Test wic --version

Re: [OE-core] [wic][PATCH] meta-yocto-bsp: add kickstart file for MPC8315

2016-12-16 Thread Ed Bartosh
Sorry, wrong commit subject line. Please, ignore. On Fri, Dec 16, 2016 at 07:05:14PM +0200, Ed Bartosh wrote: > Added kickstart file to produce partitioned image for > MPC8315 reference hardware. > > [YOCTO #8719] > > Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com&

[OE-core] [wic][PATCH] meta-yocto-bsp: add kickstart file for MPC8315

2016-12-16 Thread Ed Bartosh
Added kickstart file to produce partitioned image for MPC8315 reference hardware. [YOCTO #8719] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/lib/wic/canned-wks/mpc8315e-rdb.wks | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 scripts/lib/wic/cann

[OE-core] [wic][PATCH] wic: look for wks files in /recipes-images

2016-12-16 Thread Ed Bartosh
Currently wic looks for wks files in /scripts/lib/wic/canned-wks/ directories. This path is too nested and doesn't look consistent with the naming scheme of layer directories. Added 'recipes-images' directory to the list of paths to look for wks files. Signed-off-by: Ed Bartosh <ed.b

[OE-core] [PATCH] edgerouter.conf: enable generation of wic.bmap

2016-12-09 Thread Ed Bartosh
Enabled generation of block map(bmap) files for wic images built for edgerouter machine. This should simplify flashing images with bmaptool. [YOCTO #10621] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta-yocto-bsp/conf/machine/edgerouter.conf | 2 +- 1 file changed, 1 ins

[OE-core] [PATCH] oe-buildenv-internal: show usage output

2016-12-09 Thread Ed Bartosh
Show usage text if script is not sourced. Tested in bash, zsh and dash. [YOCTO #10751] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/oe-buildenv-internal | 12 1 file changed, 12 insertions(+) diff --git a/scripts/oe-buildenv-internal b/scripts/oe-bu

[OE-core] [PATCH] canned-wks: remove mpc8315e-rdb.wks

2017-01-09 Thread Ed Bartosh
This file has been moved to meta-yocto-bsp/wic/ Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/lib/wic/canned-wks/mpc8315e-rdb.wks | 6 -- 1 file changed, 6 deletions(-) delete mode 100644 scripts/lib/wic/canned-wks/mpc8315e-rdb.wks diff --git a/scripts/lib/wic/

[OE-core] [PATCH 2/2] wic: _exec_cmd: produce error if exit code is not 0

2017-01-10 Thread Ed Bartosh
#10816] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/lib/wic/utils/oe/misc.py | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/scripts/lib/wic/utils/oe/misc.py b/scripts/lib/wic/utils/oe/misc.py index fe188c9..fd71935 100644 --- a/s

[OE-core] [PATCH 1/2] direct.py: fix getting image name

2017-01-10 Thread Ed Bartosh
commandline. For example, when wic is called with --rootfs-dir= part.rootfs_dir will contain path and wic will crash trying to call bitbake -e to get value of ROOTFS_SIZE variable. Fixed the code by getting image name properly and checking if it's not a path. [YOCTO #10815] Signed-off-by: Ed

Re: [OE-core] [PATCH v1] wic: Add --exclude-path option to rootfs source plugin.

2016-11-30 Thread Ed Bartosh
On Wed, Nov 30, 2016 at 02:30:12PM +0100, Kristian Amlie wrote: > On 28/11/16 12:18, Ed Bartosh wrote: > > I'd appreciate if you also do the following before sending v2: > > - check that your code doesn't regress pylint checks > > Is there an official process here? Sorr

Re: [OE-core] [PATCH] buildhistory-diff: report directory renames

2016-12-01 Thread Ed Bartosh
On Tue, Nov 29, 2016 at 03:51:21PM +0200, Alexander Kanavin wrote: > On 11/28/2016 07:28 PM, Ed Bartosh wrote: > >The script detects directory renaming if two different > >directories with the same set of files are added and removed. > > What happens if the sets of files a

[OE-core] [wic][PATCH] selftest: wic: fix test_qemu

2016-12-02 Thread Ed Bartosh
failure. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta/conf/machine/qemux86-64.conf | 2 +- meta/lib/oeqa/selftest/wic.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/meta/conf/machine/qemux86-64.conf b/meta/conf/machine/qemux86-64.conf

Re: [OE-core] [PATCH v1] wic: Add --exclude-path option to rootfs source plugin.

2016-12-02 Thread Ed Bartosh
On Fri, Dec 02, 2016 at 03:36:47PM +0100, Kristian Amlie wrote: > On 30/11/16 16:29, Ed Bartosh wrote: > >> ... > > > > You're right. oe-selftest requires qemux86-64 target. > > > > Even if you usually work in different environment it makes sense to run

Re: [OE-core] [PATCH] oe-selftest: Improve BUILDDIR environment handling

2017-01-05 Thread Ed Bartosh
On Wed, Jan 04, 2017 at 11:48:53PM +, Richard Purdie wrote: > Its possible something (like bitbake/tinfoil2) may mess around with the > environment and using the enviroment as a global variable store isn't > particularly nice anyway. > > This patch changes the BUILDDIR usages so that the

Re: [OE-core] [PATCH] oe-selftest: Improve BUILDDIR environment handling

2017-01-05 Thread Ed Bartosh
On Thu, Jan 05, 2017 at 10:10:50AM +, Richard Purdie wrote: > On Thu, 2017-01-05 at 11:40 +0200, Ed Bartosh wrote: > > On Wed, Jan 04, 2017 at 11:48:53PM +, Richard Purdie wrote: > > > > > > Its possible something (like bitbake/tinfoil2) may mess around with

Re: [OE-core] [PATCH v4] wic/isoimage-isohybrid: remove do_stage_partition()

2017-01-09 Thread Ed Bartosh
Hi Ioan-Adrian, Thank you for the patch! It looks good to me. +1 On Sat, Jan 07, 2017 at 08:03:01PM +0200, Ioan-Adrian Ratiu wrote: > The purpouse of this function was to check dependencies for building a > hybrid iso and build them using bitbake if not found. Calling bitbake in > this context

[OE-core] [PATCH 2/2] populate_sdk_ext: whitelist do_package tasks

2017-01-04 Thread Ed Bartosh
#10832] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass index fc9cc22..d1b3fb4 100644 --- a/meta/classes/populate_sdk_ext.bbclass +++ b/meta/classes/populate_sdk_ext.bbclass @@ -305,7 +305,7 @@

[OE-core] [PATCH 1/2] populate_sdk_ext: fix working with uninative sstate

2017-01-04 Thread Ed Bartosh
Mapped uninative sstate directories to make ext SDK installer to use them when it's run on systems with gcc version different from gcc version used to build installer. [YOCTO #10832] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> diff --git a/meta/classes/populate_sdk_ext.bbcl

Re: [OE-core] [PATCH v2] wic/isoimage-isohybrid: check for grub-mkimage

2017-01-04 Thread Ed Bartosh
On Wed, Jan 04, 2017 at 09:04:43PM +0200, Ioan-Adrian Ratiu wrote: > The isohybrid plugin uses grub-mkimage but doesn't make sure it gets built. > Add a check to avoid the following error: > > Error: A native program grub-mkimage required to build the image was not > found (see details above). >

Re: [OE-core] [PATCH v2] wic/isoimage-isohybrid: check for grub-mkimage

2017-01-04 Thread Ed Bartosh
On Wed, Jan 04, 2017 at 10:12:55PM +0200, Ed Bartosh wrote: > On Wed, Jan 04, 2017 at 09:04:43PM +0200, Ioan-Adrian Ratiu wrote: > > The isohybrid plugin uses grub-mkimage but doesn't make sure it gets built. > > Add a check to avoid the following error: > > > > E

Re: [OE-core] [PATCH v6 0/5] wic: bugfixes & --fixed-size support, tests, oeqa: enhancements

2016-12-21 Thread Ed Bartosh
On Tue, Dec 20, 2016 at 07:27:04PM +0100, Maciej Borzęcki wrote: > On Tue, Dec 20, 2016 at 3:04 PM, Ed Bartosh <ed.bart...@linux.intel.com> > wrote: > > On Mon, Dec 19, 2016 at 12:20:56PM +0100, Maciej Borzecki wrote: > >> v6 of a patch series previously posted here [

[OE-core] [wic][PATCH] wic: fix parsing of 'bitbake -e' output

2016-12-21 Thread Ed Bartosh
Current parsing code can wrongly interpret arbitrary lines that are of 'key=value' format as legitimate bitbake variables. Implemented more strict parsing of key=value pairs using regular expressions. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- scripts/lib/wic/utils/oe/m

Re: [OE-core] [PATCH v2 0/4] selftest/wic: extending test coverage for WIC script options

2016-12-21 Thread Ed Bartosh
On Tue, Dec 20, 2016 at 04:04:06PM -0600, Jair Gonzalez wrote: > > -Original Message- > > From: Ed Bartosh [mailto:ed.bart...@linux.intel.com] > > Sent: Tuesday, December 20, 2016 7:07 AM > > To: Jair Gonzalez <jair.de.jesus.gonzalez.plascen...@linux.intel.com

Re: [OE-core] [PATCH v2] wic: look for wks files in /wic

2016-12-20 Thread Ed Bartosh
On Mon, Dec 19, 2016 at 03:31:29PM -0800, Khem Raj wrote: > On Mon, Dec 19, 2016 at 4:41 AM, Ed Bartosh <ed.bart...@linux.intel.com> > wrote: > > Currently wic looks for wks files in > > /scripts/lib/wic/canned-wks/ directories. > > This path is too nest

Re: [OE-core] [PATCH v2 0/4] selftest/wic: extending test coverage for WIC script options

2016-12-20 Thread Ed Bartosh
On Mon, Dec 19, 2016 at 03:07:30PM -0600, Jair Gonzalez wrote: > Changed in V2: > > The original patch was splitted and updated according to the discussion on: > http://lists.openembedded.org/pipermail/openembedded-core/2016-December/130131.html > NOTE: The WKS_FILE entry deletion was ommitted

Re: [OE-core] [PATCH v6 0/5] wic: bugfixes & --fixed-size support, tests, oeqa: enhancements

2016-12-20 Thread Ed Bartosh
On Mon, Dec 19, 2016 at 12:20:56PM +0100, Maciej Borzecki wrote: > v6 of a patch series previously posted here [1]. > > Changes since v5: > > * `oe-selftest: enforce en_US.UTF-8 locale` was merged to master, hence it's > no > longer part of this series > > * rebased on top of master

Re: [OE-core] [PATCH v2 3/3] selftest/wic: Add tests for --exclude-dir option.

2016-12-19 Thread Ed Bartosh
On Mon, Dec 19, 2016 at 10:09:22AM +0100, Kristian Amlie wrote: > > >> +def test_exclude_path(self): > >> +"""Test --exclude-path wks option.""" > >> + > >> +# For using 'e2ls'. > >> +old_path = os.environ['PATH'] > >> +os.environ['PATH'] = get_bb_var('PATH',

Re: [OE-core] [PATCH] wic: obey the rootfs size from the metadata

2016-12-19 Thread Ed Bartosh
On Fri, Dec 16, 2016 at 04:47:28PM +0200, Ed Bartosh wrote: > Hi Christopher, > > Thank you for the patch! > > +1 > Would you be willing to add test case(s) for this functionality to wic selftest module? > On Thu, Dec 15, 2016 at 12:42:39PM -0700, Christopher L

[OE-core] [PATCH] oe-selftest: import git module only when needed

2016-12-19 Thread Ed Bartosh
] Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.com> --- meta/lib/oeqa/utils/metadata.py | 2 +- scripts/oe-selftest | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/meta/lib/oeqa/utils/metadata.py b/meta/lib/oeqa/utils/metadata.py index ecbe763..5d8bf84

[OE-core] [PATCH v2] wic: look for wks files in /wic

2016-12-19 Thread Ed Bartosh
Currently wic looks for wks files in /scripts/lib/wic/canned-wks/ directories. This path is too nested and doesn't look consistent with the naming scheme of layer directories. Added /wic directory to the list of paths to look for wks files. Signed-off-by: Ed Bartosh <ed.bart...@linux.intel.

<    4   5   6   7   8   9   10   11   12   13   >