Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework

2015-05-01 Thread Otavio Salvador
On Fri, May 1, 2015 at 12:47 PM, Khem Raj raj.k...@gmail.com wrote: ping. Can this now be merged ? Yes ;-) -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750

Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework

2015-05-01 Thread Khem Raj
ping. Can this now be merged ? On Wed, Apr 29, 2015 at 10:54 AM, Khem Raj raj.k...@gmail.com wrote: On Apr 29, 2015 10:37 AM, Carlos Rafael Giani d...@pseudoterminal.org wrote: The latest one (V8) seems good to me. I was initially skeptical about the heavy chromium.inc refactoring, but

Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework

2015-04-29 Thread Carlos Rafael Giani
The latest one (V8) seems good to me. I was initially skeptical about the heavy chromium.inc refactoring, but these days we don't have multiple chromium versions in meta-browser, so it is okay. The shared object versioning bandaid wasn't done by me, I modified other parts, but I agree with the

Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework

2015-04-29 Thread Khem Raj
On Apr 29, 2015 10:37 AM, Carlos Rafael Giani d...@pseudoterminal.org wrote: The latest one (V8) seems good to me. I was initially skeptical about the heavy chromium.inc refactoring, but these days we don't have multiple chromium versions in meta-browser, so it is okay. The shared object

Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework

2015-04-27 Thread Andre McCurdy
Looks like some regressions may have crept back relative previous versions of the patch? - dubious indent in do_install() - .pak files being installed as executables - dev-so INSANE_SKIP shouldn't be requied On Mon, Apr 27, 2015 at 9:44 AM, Khem Raj raj.k...@gmail.com wrote: CEF is a

Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework

2015-04-27 Thread Khem Raj
On Apr 27, 2015, at 1:33 PM, Andre McCurdy armccu...@gmail.com wrote: Looks like some regressions may have crept back relative previous versions of the patch? - dubious indent in do_install() - .pak files being installed as executables - dev-so INSANE_SKIP shouldn't be requied

Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework

2015-04-27 Thread Khem Raj
On Apr 27, 2015, at 2:40 PM, Otavio Salvador ota...@ossystems.com.br wrote: Thanks for bringing it up. I will send a followup to fix it incrementally. Please wait for Carlos comments and send a new pathc revision. This is not yet merged so fixes are still possible. sent a V6 --

Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework

2015-04-27 Thread Otavio Salvador
On Mon, Apr 27, 2015 at 6:37 PM, Khem Raj raj.k...@gmail.com wrote: On Apr 27, 2015, at 1:33 PM, Andre McCurdy armccu...@gmail.com wrote: Looks like some regressions may have crept back relative previous versions of the patch? - dubious indent in do_install() - .pak files being installed

Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework

2015-04-27 Thread Otavio Salvador
On Mon, Apr 27, 2015 at 1:44 PM, Khem Raj raj.k...@gmail.com wrote: CEF is a framework to embed chromium based browsers into other applications Change-Id: Ieabae43042101331f67cf6e673391f6fe320561f Signed-off-by: pnandyala pavan.nandy...@lnttechservices.com Signed-off-by: knagabhirava

Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework

2015-04-27 Thread Khem Raj
On Apr 27, 2015, at 9:57 AM, Otavio Salvador ota...@ossystems.com.br wrote: - proper patch headers can you point to patch header guidelines for meta-browser ? -- ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org

Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework

2015-04-27 Thread Otavio Salvador
On Mon, Apr 27, 2015 at 2:12 PM, Khem Raj raj.k...@gmail.com wrote: On Apr 27, 2015, at 9:57 AM, Otavio Salvador ota...@ossystems.com.br wrote: - proper patch headers can you point to patch header guidelines for meta-browser ? Same as OE in general[1]. 1.

Re: [oe] [meta-browser][PATCH 1/2 V4] cef3: Add recipe for Chromium Embedded Framework

2015-04-27 Thread Khem Raj
On Apr 27, 2015, at 10:18 AM, Otavio Salvador ota...@ossystems.com.br wrote: On Mon, Apr 27, 2015 at 2:12 PM, Khem Raj raj.k...@gmail.com wrote: On Apr 27, 2015, at 9:57 AM, Otavio Salvador ota...@ossystems.com.br wrote: - proper patch headers can you point to patch header