Re: [Openerp-community] New member of community for Team Reviewer.

2013/9/11 Maxime Chambreuil > If you do it all today, we miss an opportunity to raise awareness to > everyone. > > To go even further with my proposal, we should : > >- start the check-list on a pad : >http://pad.openerp.com/p/community-review >- discuss it on the list >- put it i

Re: [Openerp-community] New member of community for Team Reviewer.

If you do it all today, we miss an opportunity to raise awareness to everyone. To go even further with my proposal, we should : * start the check-list on a pad : http://pad.openerp.com/p/community-review * discuss it on the list * put it in the documentation * write a script

Re: [Openerp-community] [Merge] lp:~savoirfairelinux-openerp/openerp-product-attributes/product_dependencies into lp:openerp-product-attributes

Hi again Pedro, The purpose of this module is add a list of dependencies for each product so you will know that product X have as dependencies product Y and product Z or even that product X have as dependencies some products from category W. -- https://code.launchpad.net/~savoirfairelinux-open

Re: [Openerp-community] New member of community for Team Reviewer.

If you agree, the first big action I want to take is to make translatable all community branches in Launchpad, creating pot files for each module and setting corresponding branch, so I need to make a lot of push that it's IMHO meaningless to pass the review process. Do you agree that I start the ta

[Openerp-community] [Merge] lp:~akretion-team/openerp-product-attributes/avoid-to-raise-when-no-custom-attributes into lp:openerp-product-attributes

The proposal to merge lp:~akretion-team/openerp-product-attributes/avoid-to-raise-when-no-custom-attributes into lp:openerp-product-attributes has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~akretion-team/openerp-product-attributes/avoid-t

Re: [Openerp-community] [Merge] lp:~savoirfairelinux-openerp/openerp-product-attributes/product_dependencies into lp:openerp-product-attributes

The typos have been corrected. Thanks for pointing it out. About the pep8 review. A fair share of the pep8 rules were made to improve the code readability but, in some cases we may end up losing readability by breaking a complex line just to be pep8 clean. I'm all up for pep8 but the E501 thing

Re: [Openerp-community] New member of community for Team Reviewer.

+1 On Wed, Sep 11, 2013 at 1:22 PM, Nhomar Hernández wrote: > > > > 2013/9/11 Pedro Manuel Baeza Romero > >> If you agree, the first big action I want to take is to make translatable >> all community branches in Launchpad, creating pot files for each module and >> setting corresponding branch,

Re: [Openerp-community] [Merge] lp:~savoirfairelinux-openerp/openerp-product-attributes/product_dependencies into lp:openerp-product-attributes

Review: Needs Information Hi, Joao, thank you very much for your contribution. I would like to know what is the purpose of this module? Can you explain briefly? Regards. -- https://code.launchpad.net/~savoirfairelinux-openerp/openerp-product-attributes/product_dependencies/+merge/185082 Your t

Re: [Openerp-community] New member of community for Team Reviewer.

2013/9/11 Pedro Manuel Baeza Romero > @Maxime, of course, the next step is to require in the review process that > new MPs have translation templates updated, but I was talking about all the > modules that are already in the community branches. But if you want, I can > make an MP for all of them.

Re: [Openerp-community] New member of community for Team Reviewer.

@Maxime, of course, the next step is to require in the review process that new MPs have translation templates updated, but I was talking about all the modules that are already in the community branches. But if you want, I can make an MP for all of them. @Nhomar, what are the problems you mention?

Re: [Openerp-community] New member of community for Team Reviewer.

I prefer adding this check in the list of things to do when reviewing than allowing you or anyone else (nothing personal here) to bypass the review step. If you are willing to put some big effort today, I suggest starting this check-list on a pad, discussing it on the list and then putting it i

Re: [Openerp-community] New member of community for Team Reviewer.

2013/9/11 Pedro Manuel Baeza Romero > If you agree, the first big action I want to take is to make translatable > all community branches in Launchpad, creating pot files for each module and > setting corresponding branch, so I need to make a lot of push that it's > IMHO meaningless to pass the re

Re: [Openerp-community] [Merge] lp:~akretion-team/openerp-product-attributes/avoid-to-raise-when-no-custom-attributes into lp:openerp-product-attributes

Review: Approve code review, no test -- https://code.launchpad.net/~akretion-team/openerp-product-attributes/avoid-to-raise-when-no-custom-attributes/+merge/173897 Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes. ___

[Openerp-community] [Merge] lp:~savoirfairelinux-openerp/openerp-product-attributes/product_dependencies into lp:openerp-product-attributes

Joao Alfredo Gama Batista has proposed merging lp:~savoirfairelinux-openerp/openerp-product-attributes/product_dependencies into lp:openerp-product-attributes. Requested reviews: Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) For more details, see: https://code.launchpad.net/~s

Re: [Openerp-community] [Merge] lp:~savoirfairelinux-openerp/openerp-product-attributes/product_dependencies into lp:openerp-product-attributes

Review: Needs Fixing code review, no test You have typos at line 169 and 191 : dependecies -> dependencies $ flake8 . ./__init__.py:23:1: F401 'product' imported but unused ./__openerp__.py:27:80: E501 line too long (273 > 79 characters) ./__openerp__.py:33:41: W291 trailing whitespace ./product.

Re: [Openerp-community] [Merge] lp:~akretion-team/openerp-product-attributes/avoid-to-raise-when-no-custom-attributes into lp:openerp-product-attributes

Review: Approve LGTM -- https://code.launchpad.net/~akretion-team/openerp-product-attributes/avoid-to-raise-when-no-custom-attributes/+merge/173897 Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes. ___ Mailing list: ht

Re: [Openerp-community] Removing inactive members from the reviewers team

2013/9/11 Serpent Consulting Services > Thanks Joel. > > Please allow > https://code.launchpad.net/~**serpent-consulting-services > (this is an id as a person used by Husen and Jay) > I honestly prefer use Husen and Jay accounts separ

Re: [Openerp-community] [Merge] lp:~akretion-team/openerp-product-attributes/avoid-to-raise-when-no-custom-attributes into lp:openerp-product-attributes

Review: Approve LGTM, a welcome fix! -- https://code.launchpad.net/~akretion-team/openerp-product-attributes/avoid-to-raise-when-no-custom-attributes/+merge/173897 Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes. ___

Re: [Openerp-community] Fwd: Re: About branches Community in Apps.

2013/9/11 Stefan > > On 09/10/2013 05:04 PM, Nhomar Hernández wrote: > >> >>> >>> You can see the list of "Blue Branches" attached to this email if >>> somebody has some comment regarding this point (the blue ones) we >>> really appreciate give us feedback in this thread. >>> >> >> > Hi, > > n

Re: [Openerp-community] Fwd: Re: About branches Community in Apps.

Hello, I'm not sure what kind of activity you are logging as I see in your draft list of branch, a bunch of branches which seems very active to me and I worked on. At least the 7.0 series Here are few exemples: https://code.launchpad.net/~sale-core-editors/sale-reports/7.0 No activities since 2

Re: [Openerp-community] New member of community for Team Reviewer.

Welcome !! On Wed, Sep 11, 2013 at 8:30 AM, Pedro Manuel Baeza Romero < pedro.ba...@gmail.com> wrote: > Hi all, > > Thank you very much to all that has supported me in the approval of the > membership. I'm going to do my best for contributing to get an standarized > quality community modules. I

Re: [Openerp-community] New member of community for Team Reviewer.

Hi all, Thank you very much to all that has supported me in the approval of the membership. I'm going to do my best for contributing to get an standarized quality community modules. I have been in this world not as long time as many of you, and I still have a lot to learn, but I'm going to try to

Re: [Openerp-community] Removing inactive members from the reviewers team

Just a word, started reviews again yesterday and I promise to do more in the future (I really had a few rush things in the last months that kept me away from that). I also want to mention that at Akretion we also made the internal commitment to to get more reviews from the other Akretion people to

Re: [Openerp-community] New member of community for Team Reviewer.

Sorry for my last email, you go so fast that I did not read this one!!! Thank you... Ana 2013/9/11 Joël Grand-Guillaume > Dear all, > > > I welcome Pedro Manuel Baeza (https://launchpad.net/~pedro.baeza) in the > community reviewer team as he received sponsor and support from most of the > actu

Re: [Openerp-community] Removing inactive members from the reviewers team

Hi Joël, at the end I don't know if you decided or not including Pedro Baeza as reviewer but if it's yes, then one task 3) is missing on your sumary Thank you: Ana 2013/9/11 Joël Grand-Guillaume > Dear all, > > > Thanks you for your input on that topic. So if I summarize: > > 1) Removal of peo

[Openerp-community] [Merge] lp:~jean-lelievre/openobject-addons/elico-7.0_modules_updates into lp:~openerp-community/openobject-addons/elico-7.0

The proposal to merge lp:~jean-lelievre/openobject-addons/elico-7.0_modules_updates into lp:~openerp-community/openobject-addons/elico-7.0 has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~jean-lelievre/openobject-addons/elico-7.0_modules_up

Re: [Openerp-community] Fwd: Re: About branches Community in Apps.

On 09/10/2013 05:04 PM, Nhomar Hernández wrote: You can see the list of "Blue Branches" attached to this email if somebody has some comment regarding this point (the blue ones) we really appreciate give us feedback in this thread. Hi, not even sure what the quest

[Openerp-community] [Merge] lp:~jean-lelievre/openobject-addons/elico-7.0_modules_updates into lp:~openerp-community/openobject-addons/elico-7.0

Jean LELIEVRE ElicoCorp has proposed merging lp:~jean-lelievre/openobject-addons/elico-7.0_modules_updates into lp:~openerp-community/openobject-addons/elico-7.0. Requested reviews: LIN Yu (lin-yu) For more details, see: https://code.launchpad.net/~jean-lelievre/openobject-addons/elico-7.0_mo

Re: [Openerp-community] About margin-analysis Project.

Hi Nhomar, Thanks to push this topic. I updated the project: https://launchpad.net/margin-analysis We now have a serie for version 7.0 without changing the branch name. I suggest to register the serie on apps rather than branches. All module are currently marke as installable = False as they st

Re: [Openerp-community] Removing inactive members from the reviewers team

Thanks Joel. Please allow  https://code.launchpad.net/~serpent-consulting-services  (this is an id as a person used by Husen and Jay) https://code.launchpad.net/~serpentcs is a team, so this should be removed if any. Thanks everyone.

Re: [Openerp-community] Fwd: Re: About branches Community in Apps.

Other votes ? On Wed, Sep 11, 2013 at 9:19 AM, Eric Caudal wrote: > I am in favor. > (Most of) the activity of the OCA should be transparent. > If necessary some more private topic, it could still be considered later > to create an additional resource no? > => Yes of course > > Should it be r

Re: [Openerp-community] New member of community for Team Reviewer.

Dear all, I welcome Pedro Manuel Baeza (https://launchpad.net/~pedro.baeza) in the community reviewer team as he received sponsor and support from most of the actual reviewers. Welcome on board and thank you Pedro for your investment in the community ! Regards, Joël On Wed, Sep 11, 2013 a

Re: [Openerp-community] Removing inactive members from the reviewers team

Dear all, Thanks you for your input on that topic. So if I summarize: 1) Removal of people from the reviewer team (nothing to do again with contribution, just to have people in there that take time to review and merge others work): We agreed to remove: Borja López Soilán : https://launchpad.ne

Re: [Openerp-community] New member of community for Team Reviewer.

I support Pedro for his work and reviews on the community projects. Pedro also got votes in other threads [0] A similar thread as started on the community reviewers team and he also got support on that list. [0] https://lists.launchpad.net/openerp-community/msg03122.html, https://lists.launchpad.

Re: [Openerp-community] Removing inactive members from the reviewers team

Dear Raphaël, I never mean here (and never will) that you do not contribute to OpenERP !! The thread here is about having an OpenERP Community Reviewer team with active people in it. That's not the same. You do contribute a lot, everybody agree on that. But without any harm, you are not making r

Re: [Openerp-community] Removing inactive members from the reviewers team

On 09/10/2013 11:54 PM, Daniel Reis wrote: Hello all, I may be missing somthing obvious, so I have to ask: What's the point on belonging to the Reviewers Team?: Anyone can participate in MP reviews. Yey, as much as possible ;-) It's each project's maintainers role to merge the approved MPs. I

Re: [Openerp-community] Removing inactive members from the reviewers team

Hello, I will also grant my vote to Pedro as a community reviewer. Regards Nicolas Le 10.09.13 16:40, Pedro Manuel Baeza Romero a écrit : > I take this opportunity to ask you to include me > as community reviewer or tell me what is > the method to do it,

Re: [Openerp-community] Removing inactive members from the reviewers team

Title: Eric CAUDAL I would be available for some functional review BUT: - Documentation of the provided modules should be up to date - Which tool could be used to assign and follow-up? Can we use the MP tool with an extra step? - Does somebody has a procedur

Re: [Openerp-community] Fwd: Re: About branches Community in Apps.

Title: Eric CAUDAL I am in favor. (Most of) the activity of the OCA should be transparent. If necessary some more private topic, it could still be considered later to create an additional resource no? Should it be read only or r/w

Re: [Openerp-community] Removing inactive members from the reviewers team

Hi Ana, The thread is quite diverging here, as the initial topic was the inactivation of the reviewers team, this is an interesting topic though. Some thoughts: On 09/10/2013 10:28 PM, Ana Juaristi wrote: Several comments: About functional test.. some doubts: Is there any kind of notifi

Re: [Openerp-community] Removing inactive members from the reviewers team

On 09/10/2013 11:54 PM, Daniel Reis wrote: Hello all, I may be missing somthing obvious, so I have to ask: What's the point on belonging to the Reviewers Team?: Anyone can participate in MP reviews. It's each project's maintainers role to merge the approved MPs. Right. I also want to sugges

Re: [Openerp-community] Fwd: Re: About branches Community in Apps.

We can give an access to the Trello board if everybody ask/agree on it. Note that was not the purpose because. The Trello board was setup by mostely me to share with the founders the remaining step and task to push the creation of the OCA forward. One of the card in that board concerned the regist

Re: [Openerp-community] [Openerp-community-reviewer] Removing inactive members from the reviewers team

On 09/10/2013 03:55 PM, Joël Grand-Guillaume wrote: Here is the list of people that are part of the Reviewer team and never found the time to contribute (I mean to the review process, nothing to do with their community work). Please, do not see any shame in the following list of names, it's just