Re: [Openerp-community] Questions about improve usability of partner base_location on NUTS Standard

2014-03-31 Thread Info SHS-AV
Hello, I prepared a web page to insert and gather informations about addresses. http://www.openerp.enterprises/wiki/OpenERP_Address Sorry, I inserted a little countries but I will add more countries in few days. Everybody can insert or update data, in Wikimedia format. Username is *OpenERP*

Re: [Openerp-community] Questions about improve usability of partner base_location on NUTS Standard

2014-03-31 Thread Pedro Manuel Baeza Romero
I have inserted Spain information. Regards. 2014-03-31 8:41 GMT+02:00 Info SHS-AV i...@shs-av.com: Hello, I prepared a web page to insert and gather informations about addresses. http://www.openerp.enterprises/wiki/OpenERP_Address Sorry, I inserted a little countries but I will add more

Re: [Openerp-community] Questions about improve usability of partner base_location on NUTS Standard

2014-03-31 Thread Eric Caudal
Title: Eric CAUDAL added China Eric Caudal CEO -- Elico Corporation, Shanghai branch OpenERP Premium Certified Training Partner Cell: + 86 186 2136 1670 Office: + 86 21 6211 8017/27/37 Skype: elico.corp eric.cau...@elico-corp.com

Re: [Openerp-community] Rationale for proposing the project openerp-nomenclature to join the OCA projects

2014-03-31 Thread Franco Tampieri
Hi Lionel can you approve my pending subscription? Regards Franco Tampieri System Engineer _ abstract.it - +39 06 9294 6938 Registro Imprese di Napoli 788429 / Cap. Soc. 10.000 Euro I.V. Avvertenze Legali – D. Lgs. 196/03 Tutela dei dati personali. Le informazioni contenute in questo

[Openerp-community] Reason to deprecate check_recursion() ?

2014-03-31 Thread Lionel Sausin
Dear Olivier, In v7 I just noticed that check_recursion() is deprecated in favor of _check_recursion(). That makes it a protected method, so by convention it should only be used inside osv.orm shouldn't it? Would you please be kind enough to explain the reason for this and if it's OK to call

Re: [Openerp-community] Reason to deprecate check_recursion() ?

2014-03-31 Thread Lionel Sausin
Le 31/03/2014 14:57, Lionel Sausin a écrit : Dear Olivier, In v7 I just noticed that check_recursion() is deprecated in favor of _check_recursion(). That makes it a protected method, so by convention it should only be used inside osv.orm shouldn't it? Would you please be kind enough to explain

Re: [Openerp-community] Reason to deprecate check_recursion() ?

2014-03-31 Thread Alexandre Fayolle
Hello Lionel, Pylint and Openobject have different conventions about protected methods. For Pylint, a method with a name starting with a single '_' is protected, meaning you should only call it from with the class or a class deriving from it, e.g. self._method() . Any call to obj._method()

Re: [Openerp-community] Reason to deprecate check_recursion() ?

2014-03-31 Thread Olivier Dony
On 03/31/2014 03:24 PM, Lionel Sausin wrote: Le 31/03/2014 14:57, Lionel Sausin a écrit : Dear Olivier, In v7 I just noticed that check_recursion() is deprecated in favor of _check_recursion(). That makes it a protected method, so by convention it should only be used inside osv.orm shouldn't

Re: [Openerp-community] New WMS. Call for testers 2

2014-03-31 Thread Eric Caudal
Title: Eric CAUDAL Hi Jos, thanks for the feedback. One thing about Incoterms: Usually this is a purchasing/sales option linked to invoicing and has few links with warehouse management. I would suggest to remove it from stock (and remove the entry of "Warehouse

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-postlogistics-file_type-imp into lp:carriers-deliveries

2014-03-31 Thread noreply
The proposal to merge lp:~camptocamp/carriers-deliveries/7.0-postlogistics-file_type-imp into lp:carriers-deliveries has been updated. Status: Needs review = Merged For more details, see:

[Openerp-community-reviewer] [Bug 1189480] Re: planned_hours, total_hours, effective_hours are wrongly calculated in parent project

2014-03-31 Thread Martin Trigaux (OpenERP)
Hello guys, Are you still able to reproduce this bug on a standard openerp ? The given test succeed on my side with and without the SQL patch. When discussed with Matthieu, he mentioned performances improvement but I did not notice them. Could you give me a way to reproduce ? Thanks -- You

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/7.0-add-description-field-dbl into lp:carriers-deliveries

2014-03-31 Thread Guewen Baconnier @ Camptocamp
Review: Approve code review I see no reason to change the lines 11-19, but I won't block the MP for that. Thanks -- https://code.launchpad.net/~akretion-team/carriers-deliveries/7.0-add-description-field-dbl/+merge/209728 Your team Stock and Logistic Core Editors is subscribed to branch

[Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/7.0-add-description-field-dbl into lp:carriers-deliveries

2014-03-31 Thread noreply
The proposal to merge lp:~akretion-team/carriers-deliveries/7.0-add-description-field-dbl into lp:carriers-deliveries has been updated. Status: Needs review = Merged For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk into lp:ocb-server

2014-03-31 Thread Holger Brunn (Therp)
Review: Approve code review -- https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk/+merge/212736 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-web/translate_warnings_1297525 into lp:ocb-web

2014-03-31 Thread Holger Brunn (Therp)
Review: Approve code review -- https://code.launchpad.net/~savoirfairelinux-openerp/ocb-web/translate_warnings_1297525/+merge/212739 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-server/ocb-add-fr_CA into lp:ocb-server

2014-03-31 Thread Holger Brunn (Therp)
Review: Needs Fixing I miss the bug report and the MP for upstream -- https://code.launchpad.net/~savoirfairelinux-openerp/ocb-server/ocb-add-fr_CA/+merge/212742 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-leaner-bzrignore-lep into lp:ocb-server

2014-03-31 Thread Holger Brunn (Therp)
Review: Disapprove agreed with Sandy's points -- https://code.launchpad.net/~camptocamp/ocb-server/7.0-leaner-bzrignore-lep/+merge/211290 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/6.1-leaner-bzrignore-lep into lp:ocb-server/6.1

2014-03-31 Thread Holger Brunn (Therp)
Review: Disapprove agreed with Sandy's points -- https://code.launchpad.net/~camptocamp/ocb-server/6.1-leaner-bzrignore-lep/+merge/211288 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245 into lp:ocb-addons

2014-03-31 Thread noreply
The proposal to merge lp:~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245 into lp:ocb-addons has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245/+merge/210926 --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-v7-port-base_delivery_carrier_files_document-addon_rde into lp:carriers-deliveries

2014-03-31 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/carriers-deliveries/7.0-v7-port-base_delivery_carrier_files_document-addon_rde into lp:carriers-deliveries has been updated. Status: Needs review = Approved For more details, see:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-v7-port-base_delivery_carrier_files_document-addon_rde into lp:carriers-deliveries

2014-03-31 Thread noreply
The proposal to merge lp:~camptocamp/carriers-deliveries/7.0-v7-port-base_delivery_carrier_files_document-addon_rde into lp:carriers-deliveries has been updated. Status: Approved = Merged For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-fix-1296678 into lp:carriers-deliveries

2014-03-31 Thread Romain Deheele - Camptocamp
Review: Approve code review LGTM, Romain -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-fix-1296678/+merge/212396 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

Re: [Openerp-community-reviewer] [Merge] lp:~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink into lp:ocb-addons

2014-03-31 Thread Holger Brunn (Therp)
Review: Approve code review -- https://code.launchpad.net/~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink/+merge/213086 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

[Openerp-community-reviewer] [Merge] lp:~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink into lp:ocb-addons

2014-03-31 Thread Holger Brunn (Therp)
The proposal to merge lp:~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink into lp:ocb-addons has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink/+merge/213086 --

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1275659-crm-my-items-filters into lp:ocb-addons/6.1

2014-03-31 Thread Holger Brunn (Therp)
Review: Approve given it's in 7.0, I don't think this needs its own module -- https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1275659-crm-my-items-filters/+merge/204498 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~0s/openerp-product-variant/openerp-product-variant into lp:openerp-product-variant

2014-03-31 Thread Mathieu Stumpf
Mathieu Stumpf has proposed merging lp:~0s/openerp-product-variant/openerp-product-variant into lp:openerp-product-variant. Requested reviews: Product Core Editors (product-core-editors) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-move-date into lp:ocb-addons

2014-03-31 Thread Holger Brunn (Therp)
Review: Approve code review also verified that this is roughly the same as trunk-wms does -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-move-date/+merge/213301 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/server-env-tools/7.0-auth_from_http_basic into lp:server-env-tools

2014-03-31 Thread Holger Brunn (Therp)
thanks for insisting, this was wrong in my addon template for months now -- https://code.launchpad.net/~therp-nl/server-env-tools/7.0-auth_from_http_basic/+merge/202316 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde into lp:carriers-deliveries

2014-03-31 Thread Romain Deheele - Camptocamp
Romain Deheele - Camptocamp has proposed merging lp:~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde into lp:carriers-deliveries. Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors) For more details, see:

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/branch_pep8 into lp:lp-community-utils

2014-03-31 Thread Holger Brunn (Therp)
Review: Approve code review I think it's okay to ignore ocb-addons -- https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/branch_pep8/+merge/205260 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/checkout-pep8 into lp:lp-community-utils

2014-03-31 Thread Holger Brunn (Therp)
The proposal to merge lp:~savoirfairelinux-openerp/lp-community-utils/checkout-pep8 into lp:lp-community-utils has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/checkout-pep8/+merge/211098 --

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/checkout-pep8 into lp:lp-community-utils

2014-03-31 Thread Holger Brunn (Therp)
Review: Approve code review -- https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/checkout-pep8/+merge/211098 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-move-date into lp:ocb-addons

2014-03-31 Thread Lionel Sausin - Numérigraphe
The proposal to merge lp:~numerigraphe-team/ocb-addons/7.0-inventory-move-date into lp:ocb-addons has been updated. Description changed to: This branch fixes the date of stock moves for inventory adjustments. It uses the inventory's date instead of today, which makes it consistent with the way

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/branch_pep8 into lp:lp-community-utils

2014-03-31 Thread Guewen Baconnier @ Camptocamp
Review: Disapprove Hi, It checks pep8 on the entire modified file, which is very likely to print way too many errors/warnings: the projects currently are far to be pep8-errors-prone and we don't expect for a merge proposal to fix all the pep8 errors in the modified files. Considering that, I

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/lp754339 into lp:ocb-addons

2014-03-31 Thread Lionel Sausin - Numérigraphe
Review: Abstain Thanks for making this clear, I see your point. I'll let the OCA team decide this on a strategic level. -- https://code.launchpad.net/~therp-nl/ocb-addons/lp754339/+merge/189107 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/server-env-tools/7.0-auth_from_http_basic into lp:server-env-tools

2014-03-31 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Approve -- https://code.launchpad.net/~therp-nl/server-env-tools/7.0-auth_from_http_basic/+merge/202316 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde into lp:carriers-deliveries

2014-03-31 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde/+merge/213427 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey into lp:server-env-tools

2014-03-31 Thread Sylvain LE GAL (GRAP)
Hi Holger, Thanks for your review. In order of your remarks: - typo changed; - About 'literal_eval' import, I just copied / pasted some of the code written in the file ./addons/auth_signup/res_users.py. But OK, I changed it. - About 'email.template'. At the beginning, I just not wanted to

Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey into lp:server-env-tools

2014-03-31 Thread Holger Brunn (Therp)
How about my only substantial point about swapping #451 and #454? Concerning the templates: You indeed need a persistent model for that, but in this case, res.users would be just fine I think -- https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/+merge/211338 Your

Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey into lp:server-env-tools

2014-03-31 Thread Sylvain LE GAL (GRAP)
Hum : 1/ About the swap : Sorry, I did it. rev75 : http://bazaar.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/revision/75 2/ About the template, The code sends an email like that : Admin user used his passkey to login with {login}. Technicals informations belows : -

Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey into lp:server-env-tools

2014-03-31 Thread Holger Brunn (Therp)
...nevermind, I saw you did that already -- https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/+merge/211338 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh into lp:contract-management

2014-03-31 Thread Matthieu Dietrich @ camptocamp
Hello, actually, the goal is, on the contrary, to have all products set to False after install. Only a very small subset of products are to be considered for the hours block. Setting all products to True would be the most iso-prod, given that the behaviour after upgrade would be identical to

[Openerp-community-reviewer] [Bug 1049653] Re: --unaccent option does not work

2014-03-31 Thread Christophe Simonis (OpenERP)
Fixed in 7.0 via revid 5268 c...@openerp.com-20140331123012-dq3hsw2bc368zvgq ** Changed in: openobject-server Milestone: 6.1 = 7.0 ** Changed in: openobject-server Status: Confirmed = Fix Released -- You received this bug notification because you are a member of OpenERP Community