Review: Approve code review, test
LGTM
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list:
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/lp-community-utils/nag-nameerror-1312682/+merge/217216
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:lp-community-utils.
--
Mailing list:
The proposal to merge
lp:~camptocamp/openerp-product-attributes/7.0-partner-attributes-lep into
lp:openerp-product-attributes has been updated.
Description changed to:
add module partner_custom_attributes
For more details, see:
Review: Approve code review, no test
--
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix-store-fields-mdh/+merge/216849
Your team Account Core Editors is subscribed to branch lp:account-budgeting.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
following the comment by Alexis on 23/04/2014 I'm setting this MP as work in
progress
--
https://code.launchpad.net/~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup/+merge/215970
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list:
Review: Approve code review, no test
LGTM, code wise.
--
https://code.launchpad.net/~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls/+merge/217063
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list:
The proposal to merge lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup
into lp:openerp-rma has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup/+merge/215970
--
on this
--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94
Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com
___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp
Actually I had completely goofed the branches (uploaded my ocb branch to
openobject-addons and proposed to merge there, hence the changes related to ocb
present in the old MP).
Should be fixed now. Thanks for the heads up, Yannick.
--
Review: Approve code review, no test
--
https://code.launchpad.net/~camptocamp/openerp-rma/7.0-fix-1282584/+merge/207450
Your team OpenERP RMA is subscribed to branch lp:openerp-rma.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/ocb-addons/6.1-fix_1311004_account_move_line_index-afe into
lp:ocb-addons/6.1.
Requested reviews:
OpenERP Core Team (openerp)
Guewen Baconnier @ Camptocamp (gbaconnier-c2c): code review
Yannick Vaucher @ Camptocamp
Review: Needs Fixing code review, no test
Your SQL request maybe works but it is not written in an efficient way (2
DISTINCT, 1 subquery). This should be written with EXISTS.
And, each time you bypass the ORM to write raw SQL, $DEITY kills a kitten.
$DEITY also maims a puppy if you don't
** Also affects: ocb-web
Importance: Undecided
Status: New
** Also affects: ocb-web/7.0
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/ocb-web/7.0-fix_1190236_opw-595981-msh into lp:ocb-web.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1190236 in OpenERP Community Backports (Web): Kanban view doesn't show
constraint error
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/ocb-addons/ocb-7.0-fix_1311004_account_move_line_index-afe into
lp:ocb-addons.
Requested reviews:
Guewen Baconnier @ Camptocamp (gbaconnier-c2c): code review
Related bugs:
Bug #1311004 in OpenERP Community Backports (Addons
Review: Approve code review, test
LGTM
--
https://code.launchpad.net/~camptocamp/purchase-report/purchase_print_button/+merge/216024
Your team Purchase Core Editors is subscribed to branch lp:purchase-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review, no test
--
https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/ocb-addons/fix-1308364-nbi/+merge/216023
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
** Also affects: ocb-addons
Importance: Undecided
Status: New
** Also affects: ocb-addons/7.0
Importance: Undecided
Status: New
** Changed in: ocb-addons/7.0
Status: New = Fix Committed
** Changed in: openobject-addons
Status: New = Fix Committed
** Changed
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/ocb-server/7.0-fix_1281290-afe into lp:ocb-server.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1281290 in OpenERP Community Backports (Server): Wrong currency code -
Poland
https
** Also affects: openobject-server
Importance: Undecided
Status: New
** Also affects: ocb-server
Importance: Undecided
Status: New
** Also affects: ocb-addons
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of
** Also affects: ocb-addons/7.0
Importance: Undecided
Status: New
** Changed in: ocb-addons/7.0
Assignee: (unassigned) = Alexandre Fayolle - camptocamp
(alexandre-fayolle-c2c)
--
You received this bug notification because you are a member of OpenERP
Community Backports Team
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/ocb-addons/7.0-fix_1281290-afe into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1281290 in OpenERP Community Backports (Addons): Wrong currency code -
Poland
https
with the
database from pgadmin.
--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94
Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com
___
Mailing list: https://launchpad.net/~openerp-community
The proposal to merge lp:~camptocamp/ocb-server/7.0-fix_1305872-afe into
lp:ocb-server has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305872-afe/+merge/215176
--
Thanks for the reviews. I updated both this MP and the original one by using
orm.browse_null() instead of None.
--
https://code.launchpad.net/~camptocamp/ocb-server/ocb-7.0-fix_1204920-afe/+merge/208390
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-server.
--
Review: Approve
Merged in 7.0 official
--
https://code.launchpad.net/~credativ/ocb-server/7.0-lp1210177/+merge/197190
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-server.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge lp:~credativ/ocb-server/7.0-lp1210177 into lp:ocb-server
has been updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~credativ/ocb-server/7.0-lp1210177/+merge/197190
--
Review: Needs Fixing code review, no test
Needs fixing:
* convert the description in __openerp__.py to Restructured Text
* please add a test
* I'm concerned the SQL query may bypass the multicompany security rules
* NEVER DO SQL PARAMETER SUBSTITUTION WITH THE % OPERATOR
--
The proposal to merge lp:~camptocamp/ocb-server/7.0-leaner-bzrignore-lep into
lp:ocb-server has been updated.
Status: Needs review = Rejected
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-server/7.0-leaner-bzrignore-lep/+merge/211290
--
Review: Needs Fixing
LGTM, but the corresponding MP on official addons is missing.
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-filter-zero-inventory-analysis/+merge/210216
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list:
/python2.7/logging/__init__.py, line 328, in getMessage
msg = msg % self.args
TypeError: not enough arguments for format string
** Affects: ocb-server
Importance: Undecided
Assignee: Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)
Status: Fix Committed
** Affects: ocb
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/ocb-server/7.0-fix_1305653-afe into lp:ocb-server.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1305653 in OpenERP Community Backports (Server): [7.0] missing
arguments to logging statement
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools.
Requested reviews:
Server Environment And Tools Core Editors (server-env-tools-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/server-env
Question #246689 on OpenERP POS addons changed:
https://answers.launchpad.net/openerp-pos/+question/246689
Status: Open = Answered
Alexandre Fayolle - camptocamp proposed the following answer:
There is a link: pos sale orders are linked to customers. To specify the
customer for a pos order
Hello,
Thanks for the module, it is really a valuable tool.
Some comments below:
Some PEP8 error in manifest
fixed
728+ name = '%s.%s' % (cls.__module__, cls.__name__)
There is a logical risk that cls is not initialized if it is not an old/new
style class.
fixed
729 +
** Also affects: ocb-server
Importance: Undecided
Status: New
** Also affects: ocb-server/7.0
Importance: Undecided
Status: New
** Changed in: openobject-server
Status: New = Fix Committed
** Changed in: ocb-server/7.0
Status: New = Fix Committed
--
You
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/ocb-server/7.0-fix_1305872-afe into lp:ocb-server.
Requested reviews:
Leonardo Pistone - camptocamp (lpistone)
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1305872 in OpenERP Community Backports (Server): [7.0
Review: Approve code review, no test
Given the scenario, the patch looks safe.
--
https://code.launchpad.net/~acsone-openerp/ocb-server/7.0-bug-1274997-cron/+merge/204298
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-server.
--
Mailing list:
) branch as a basis.
--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94
Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com
___
Mailing list: https://launchpad.net/~openerp-community
Post
when an error is detected, when I thought that
someone maybe had coded this and made the code available. Do you know of
a module which would help dealing with this?
If nothing comes along and people think it's worth it, we will
contribute an addon
Regards,
--
Alexandre Fayolle
Chef de Projet
8017/27/37
Skype: elico.corp
eric.cau...@elico-corp.com
http://www.elico-corp.com
On 04/07/2014 06:24 PM, Alexandre Fayolle wrote:
Hello,
I have a customer who uses stock.pickings and backorders to represent
shipping goods in multiple parcels. The problem
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde into
lp:ocb-addons.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1302630 in OpenERP Community Backports (Addons): [trunk/7.0
://launchpad.net/~openerp-community
More help : https://help.launchpad.net/ListHelp
People will have to change their grepping habits, and it means a
significant change in coding style between OCA addons and the official
addons.
-0 for me
--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26
This being said, and with the move pointed out by Stefan in mind, I
change my previous vote to +1 for changing this in OCA addons.
--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94
Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com
On 04/04/2014 13:22, Francesco Apruzzese wrote:
+1 for jeff.wang
That's not how voting is done. If you are against the proposal, you say
-1.
--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94
Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/better-age/+merge/211083
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:lp-community-utils.
--
Mailing list:
Review: Needs Fixing
There are lots of sv.po files in the MP which I think don't belong there.
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-tests-backport/+merge/214234
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list:
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde/+merge/213883
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries/6.1.
--
Mailing list:
Review: Approve code review, no test
OK.
I'd still like to see tests in the near future for this one.
--
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm/+merge/213673
Your team Partner and Contact Core Editors is subscribed to branch
Review: Needs Fixing code review, no test
missing i18n/analytic_hours_block.pot
--
https://code.launchpad.net/~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh/+merge/204957
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:contract-management.
Review: Needs Fixing code review, no test
I fail to see how the addon name crm_firstname relates to the described
functionality. Please copy the description provided in the MP in __openerp__.py
: this is what people looking at the module will see.
__openerp__.py : s/demo_xml/demo/ and then
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/project-reporting/blank_invoice_vre/+merge/213842
Your team Project Core Editors is subscribed to branch lp:project-reporting.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Needs Fixing code review, no test
42 + 'account.hours.block': (lambda self, cr, uid, ids, c=None:
43 + ids, ['invoice_id'], 10),
this is a very bad line split, please keep the 'ids' on the same line as the
lambda
missing i18n update
--
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-stock-picking-duplication-fix-regression-from-v7port-and-add-a-test_rde/+merge/212878
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
You have been requested to review the proposed merge of
lp:~camptocamp/carriers-deliveries/7.0-stock-picking-duplication-fix-regression-from-v7port-and-add-a-test_rde
into lp:carriers-deliveries.
For more details, see:
Review: Approve code review, no test
--
https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:contract-management.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help : https://help.launchpad.net/ListHelp
--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94
Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde/+merge/213427
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-l10n_fr_siret-view+company/+merge/212920
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
I share Stefan's concerns on this, but I like the feature. Can I convince you
to submit this as an addon in OCA? (https://launchpad.net/web-addons would be a
good place)
--
https://code.launchpad.net/~numerigraphe-team/ocb-web/7.0-hide-oe_read_only/+merge/213016
Your team OpenERP Community
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-v7-port-base_delivery_carrier_files_document-addon_rde/+merge/213083
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-state-field-to-avoid-js-error-on-wizard-launch_rde/+merge/213019
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
The proposal to merge
lp:~camptocamp/carriers-deliveries/7.0-add-state-field-to-avoid-js-error-on-wizard-launch_rde
into lp:carriers-deliveries has been updated.
Status: Needs review = Approved
For more details, see:
You have been requested to review the proposed merge of
lp:~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink into lp:ocb-addons.
For more details, see:
https://code.launchpad.net/~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink/+merge/213086
Port to OCB of the following fix:
[FIX]
Review: Approve code review, no test
This change is touchy, as it modifies the underlying database schema. Probably
not OK for standard addons.
I'd be OK for having this in OCB, though.
Having an automated test showing the bug is fixed would be sooo nice.
--
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~akretion-team/ocb-addons/trunk-lp1292587/+merge/211095
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge lp:~camptocamp/account-financial-tools/fix_bug_1297369
into lp:account-financial-tools has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~camptocamp/account-financial-tools/fix_bug_1297369/+merge/212648
--
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~sylvain-legal/web-addons/web_field_float_compute/+merge/207006
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-needed_changes_to_fit_with_stock_picking_v7_changes-rde/+merge/211056
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list:
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/account-financial-tools/fix_bug_1297369/+merge/212648
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/openerp-product-attributes/7.0-fix_1296605-afe into
lp:openerp-product-attributes.
Requested reviews:
Graeme Gellatly (gdgellatly)
Product Core Editors (product-core-editors)
Related bugs:
Bug #1296605 in OpenERP Product
Review: Approve lgtm
ok setup problem on my test instance.
--
https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list:
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/margin-analysis/7.0-fix_1296778-afe into lp:margin-analysis.
Requested reviews:
Margin Analysis Core Editors (margin-analysis-core-editors)
Related bugs:
Bug #1296778 in Financial controlling and costing
Review: Approve code review, test
LGTM
--
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-price-in-future-1295114/+merge/211954
Your team Margin Analysis Core Editors is subscribed to branch
lp:margin-analysis.
--
Mailing list:
Review: Approve code review, test
LGTM
--
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354
Your team Margin Analysis Core Editors is subscribed to branch
lp:margin-analysis.
--
Mailing list:
Review: Approve code review, no test
Indeed, thanks for the fix.
LGTM
--
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-fix_1295706-rde/+merge/212175
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
You have been requested to review the proposed merge of
lp:~camptocamp/sale-wkfl/7.0-fix_1295706-rde into lp:sale-wkfl.
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-fix_1295706-rde/+merge/212175
Hi,
It fixes https://bugs.launchpad.net/sale-wkfl/+bug/1295706
It
for the status notice (and the great work on the recipe).
- --
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94
Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux
file, and then trying to get that
change merged in server trunk
* other ideas ?
Thanks for your feedback.
--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94
Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com
Review: Needs Fixing tried to install
I get an error when I try to install import_odbc:
2014-03-20 13:55:00,065 32374 ERROR test_ocb_oca70
openerp.tools.view_validation: Invalid XML: A `string` attribute must be on a
`form` node.
2014-03-20 13:55:00,078 32374 ERROR test_ocb_oca70
with
an awkward situation.
I'm interested to know it OpenERP SA's position has evolved since
Raphael's rejection of the MP.
--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94
Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com
ok my bad. I generally run the OCA tests on the official branch...
Still with the OCB branch, the test requires some specific setup:
here: http://code.google.com/p/wkhtmltopdf/downloads/list and set the path in
the ir.config_parameter with the webkit_path key.Minimal version is 0.9.9')
quite a lot a code, and no test... :-(
Remarks:
* line 353 (in compute_delay_from_partial_rec): it would be nicer to move
reference_line = line in the else clause of the if / elif statement (makes it
clear that reference_line has avalue in all cases)
* line 381 and 383 (in get_compute_method)
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-1287072/+merge/209183
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-credit-control-scenarios-nbi/+merge/209050
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Needs Fixing
the tests are red here
TEST test_70 openerp.tools.yaml_import: In order to test the PDF General
Ledger webkit wizard I will print report with default setting
ERROR test_70 openerp.tools.yaml_import: (u'No period found', '')
2014-03-18 16:14:12,556 23281 ERROR test_70
much easier :-)
Regards
--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94
Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com
___
Mailing list: https://launchpad.net/~openerp-community
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe into
lp:ocb-addons.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1192115 in OpenERP Community Backports (Addons): [trunk/7.0] carrier
Review: Needs Fixing code review, test
Hello,
Thanks for this contribution, the functionality is great and I'd love to see it
in OCA. And thanks for including tests.
A few minor changes are needed to bring the module to the coding standards
* use orm.Model / orm.TransientModel as base
Review: Approve code review, test
LGTM
--
https://code.launchpad.net/~camptocamp/lp-community-utils/nag-user-specific-info/+merge/209665
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:lp-community-utils.
--
Mailing list:
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/product-kitting/6.1-fix_1293524-afe into lp:product-kitting/6.1.
Requested reviews:
Product Core Editors (product-core-editors)
Related bugs:
Bug #1293524 in Product - Kitting Management: sale_bom_split
I also updated the module to 7.0 standards
--
https://code.launchpad.net/~camptocamp/product-kitting/7.0-fix_1293524-afe/+merge/211311
Your team Product Core Editors is requested to review the proposed merge of
lp:~camptocamp/product-kitting/7.0-fix_1293524-afe into lp:product-kitting.
--
Review: Approve code review, no test
LGTM
Thanks for the patch Augustin. In the future, it's better to file a bug report
for such an issue as people facing this will find the bug report more easily
than the MP.
--
Review: Needs Information code review, no test
are we all aware that this MP is not going to be accepted in the official
stable branch, because it changes the database schema definition?
I personally have nothing against merging in OCB.
--
Public bug reported:
The fix for https://bugs.launchpad.net/openobject-addons/+bug/1083077
merge in ocb-addons at http://bazaar.launchpad.net/~ocb/ocb-
addons/7.0/revision/9733 has an issue : the field which is added in the
changeset is defined in mrp, which is not a dependency of sale_stock.
As
LGTM
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit/+merge/210599
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review, no test
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit/+merge/210599
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list:
my most sincere apologies to Pedro and the rest of the community.
I could see no objection myself, the MP was old and I felt the information had
been provided, but I may have been to quick indeed. My intent was not to hijack
the process.
--
101 - 200 of 371 matches
Mail list logo
