Review: Needs Fixing
Ciao Nico
you should remove mrp_webkit/.DS_Store
and run a PEP8 validator
When importing Python modules from the same addon, use explicit relative import
rather than absolute import, example in __init__.py, do not use:
import sale
But
from . import sale
line
Thank you Pedro, that's very kind of you.
I think both module have very simple code. I just checked, it seems that they
have no function in common so in theory you shall be able to just take all my
code and put it in sale_order_partial_invoice.
My module works as follow, it alter the
I'm really sorry guys, I took so long for answering even if you answered right
away... I guess I missed the notice email.
1) It was a oversight, I copy/paste another file of my own module, I corrected
line 10 but forgot line 68. I didn't planned to add my name on this module, but
you're right
The proposal to merge
lp:~camptocamp/stock-logistic-report/7.0-button-print-delivery-order into
lp:stock-logistic-report has been updated.
Status: Needs review = Approved
For more details, see:
The proposal to merge
lp:~camptocamp/stock-logistic-report/7.0-button-print-delivery-order into
lp:stock-logistic-report has been updated.
Status: Approved = Merged
For more details, see:
Review: Approve code review, no tests
--
https://code.launchpad.net/~camptocamp/stock-logistic-report/7.0-button-print-delivery-order/+merge/199952
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-report.
--
Mailing list:
Review: Approve code review, no tests
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1267495-afe/+merge/201023
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
The proposal to merge lp:~camptocamp/ocb-addons/ocb-7.0-fix_1267495-afe into
lp:ocb-addons has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1267495-afe/+merge/201023
--
Romain Deheele - Camptocamp has proposed merging
lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl.
Requested reviews:
Sale Core Editors (sale-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/207638
Hello,
Review: Approve code review, no tests
LGTM
--
https://code.launchpad.net/~camptocamp/purchase-report/purchase_report_port_date_planned_fix_vre/+merge/202640
Your team Purchase Core Editors is subscribed to branch lp:purchase-report.
--
Mailing list:
The proposal to merge
lp:~camptocamp/purchase-report/purchase_report_port_date_planned_fix_vre into
lp:purchase-report has been updated.
Status: Needs review = Approved
For more details, see:
The proposal to merge
lp:~camptocamp/purchase-report/purchase_report_port_date_planned_fix_vre into
lp:purchase-report has been updated.
Status: Approved = Merged
For more details, see:
I added the last 4 commits after an internal functional review.
It is just a little fix + translations added + view tweaks, so your reviews are
not wasted!
thanks
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-add-account_move_batch_validate-lep/+merge/201187
Your team
Review: Needs Fixing code review, no tests
Hello El Hadji Dem
Thanks for your contrib.
At line 952-956 of this MP
footer attrs={'invisible': [('partner_id','=',False)]}
Discard button is not available if invisible partner_id field is not set?
Could you explain why you need to add a create
Review: Approve code review and test
Thank you very much for the changes.
Regards.
--
https://code.launchpad.net/~sylvain-legal/web-addons/web_field_float_compute/+merge/207006
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list:
Review: Approve code review, no tests
LGTM Thanks !
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-add-account_move_batch_validate-lep/+merge/201187
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
The proposal to merge
lp:~camptocamp/account-financial-tools/7.0-add-account_move_batch_validate-lep
into lp:account-financial-tools has been updated.
Status: Needs review = Approved
For more details, see:
The proposal to merge
lp:~camptocamp/account-financial-tools/7.0-add-account_move_batch_validate-lep
into lp:account-financial-tools has been updated.
Status: Approved = Merged
For more details, see:
Roberto Onnis has proposed merging lp:~onnis-roberto/web-addons/6.1 into
lp:web-addons/6.1.
Requested reviews:
Lorenzo Battistini - Agile BG (elbati)
For more details, see:
https://code.launchpad.net/~onnis-roberto/web-addons/6.1/+merge/207662
[web_export_view]: enables export of boolean
Review: Needs Fixing code review
Hi, Roberto, thank you very much for your contribution. I see these little
things to fix:
- You must enclose in different 'if' some conditions to avoid possible False:
if(data_id.find('input').get(0) != undefined) {
if(data_id.find('input').get(0).type ==
Romain Deheele - Camptocamp has proposed merging
lp:~camptocamp/openerp-humanitarian-ngo/change-button-to-send-email-in-draftpo
into lp:openerp-humanitarian-ngo/purchase-wkfl.
Requested reviews:
OpenERP for Humanitarian Core Editors (humanitarian-core-editors)
For more details, see:
Review: Needs Fixing code review
Romain,
it looks like the two button have the same string. Maybe we could change a bit
one of the two?
thanks!
--
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/change-button-to-send-email-in-draftpo/+merge/207675
Your team OpenERP for
Good idea,
I've just changed it to avoid confusion.
Romain
--
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/change-button-to-send-email-in-draftpo/+merge/207675
Your team OpenERP for Humanitarian Core Editors is requested to review the
proposed merge of
Review: Approve code review
thanks!
--
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/change-button-to-send-email-in-draftpo/+merge/207675
Your team OpenERP for Humanitarian Core Editors is requested to review the
proposed merge of
The proposal to merge
lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix
into lp:account-financial-report has been updated.
Status: Needs review = Work in progress
For more details, see:
Hello,
As there was no activity on this MP I'll set it as Work in progress.
Feel free to set it back to Need reviews
Cheers
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-GL-fix/+merge/193709
Your team Account Report Core Editors is
The proposal to merge
lp:~yann-papouin/ocb-addons/6.1-bug-1091268-purchase-merge-no-origin-duplicates
into lp:ocb-addons/6.1 has been updated.
Status: Needs review = Approved
For more details, see:
The proposal to merge lp:~camptocamp/ocb-addons/ocb-7.0-fix_1267495-afe into
lp:ocb-addons has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1267495-afe/+merge/201023
--
The proposal to merge
lp:~yann-papouin/ocb-addons/6.1-bug-1091268-purchase-merge-no-origin-duplicates
into lp:ocb-addons/6.1 has been updated.
Status: Approved = Merged
For more details, see:
Review: Approve code review, no tests
--
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1091268-purchase-merge-no-origin-duplicates/+merge/205175
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons/6.1.
--
Mailing list:
** Also affects: ocb-addons/6.1
Importance: Undecided
Status: New
** Also affects: ocb-addons/7.0
Importance: Undecided
Status: New
** Changed in: ocb-addons/6.1
Status: New = Fix Released
--
You received this bug notification because you are a member of OpenERP
MP rejected as this is abandoned as stated in
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add-stock_recompute_availability_on_force-afe/+merge/187772/comments/456640
--
Review: Approve code review, no tests
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/update-account_journal_report_xls/+merge/202223
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list:
The proposal to merge
lp:~luc-demeyer/account-financial-report/update-account_journal_report_xls into
lp:account-financial-report has been updated.
Status: Needs review = Approved
For more details, see:
Review: Needs Information
I'll approve it under the condition this will be splited.
You should already create an other MP which has this one as prerequisite.
Will you split that added feature of serial number in a module as well ?
Otherwise thanks for the code cleaning.
Cheers
--
The proposal to merge
lp:~luc-demeyer/account-financial-report/update-account_journal_report_xls into
lp:account-financial-report has been updated.
Status: Approved = Merged
For more details, see:
@Yannick:
As I said, this MP is a first step towards a split ; as you can see, it
introduce 2 new modules : product_serial_sale_stock and
product_serial_purchase. I am about to do an MP on lp:openerp-manufacturing for
product_serial_mrp.
BUT I didn't say that i'll do all the work for the
Review: Needs Fixing code review, no tests
Please add contributors name in __openerp__.py under Contributors
And I think you can remove the All Rights Reserved.
http://www.iusmentis.com/copyright/allrightsreserved/
PEP8 to fix
trailing white space
blank lines with white space
l.22 + l.28 +
38 matches
Mail list logo
